82221 2012-03-26 10:42:46 -0700 Add rounding to Plugin creation in SubframeLoader 2012-04-02 03:48:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric japhet jchaffraix webkit.review.bot oldest_to_newest 587878 0 leviw 2012-03-26 10:42:46 -0700 Widgets are always positioned at pixel boundaries, so we're safe to round the sizes. We need to do so in SubframeLoader when we create plugins. 587882 1 leviw 2012-03-26 10:44:24 -0700 This depends on the patch to 82196 because it uses LayoutRect::pixelSnappedSize(). 588822 2 leviw 2012-03-27 06:26:24 -0700 On second look, we only need rounding, not pixel snapping. Patch forthcoming. 588835 3 134046 leviw 2012-03-27 06:48:02 -0700 Created attachment 134046 Patch 589139 4 134046 eric 2012-03-27 12:29:28 -0700 Comment on attachment 134046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134046&action=review > Source/WebCore/loader/SubframeLoader.cpp:363 > + IntSize contentSize = roundedIntSize(LayoutSize(renderer->contentWidth(), renderer->contentHeight())); Really? No contentSize()? 589256 5 leviw 2012-03-27 14:07:21 -0700 (In reply to comment #4) > (From update of attachment 134046 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134046&action=review > > > Source/WebCore/loader/SubframeLoader.cpp:363 > > + IntSize contentSize = roundedIntSize(LayoutSize(renderer->contentWidth(), renderer->contentHeight())); > > Really? No contentSize()? I thought the same thing initially, but then declined to implement it to prevent misuse. This should only be rounded when dealing with Widgets. Otherwise, it should be pixel snapped, which requires more work (but in the case of Widgets, would yield the same value... perhaps this is premature optimization?). 593317 6 134046 webkit.review.bot 2012-04-02 03:47:55 -0700 Comment on attachment 134046 Patch Clearing flags on attachment: 134046 Committed r112852: <http://trac.webkit.org/changeset/112852> 593318 7 webkit.review.bot 2012-04-02 03:48:05 -0700 All reviewed patches have been landed. Closing bug. 134046 2012-03-27 06:48:02 -0700 2012-04-02 03:47:55 -0700 Patch bug-82221-20120327144800.patch text/plain 2770 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTI3ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgcm91bmRpbmcgdG8g UGx1Z2luIGNyZWF0aW9uIGluIFN1YmZyYW1lTG9hZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjIyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGluZyByb3VuZGluZyB0byB0aGUgTGF5b3V0U2l6 ZSB1c2VkIHRvIGNvbnN0cnVjdCBQbHVnaW5zIGluIFN1YmZyYW1lTG9hZGVyLiBQbHVnaW5zLCB3 aGljaAorICAgICAgICBhcmUgd2lkZ2V0cywgYXJlIGFsd2F5cyBwbGFjZWQgb24gaW50ZWdlciBi b3VuZGFyaWVzLCB3aGljaCBtZWFucyB0aGVpciBzaXplcyBjYW4gYmUgcm91bmRlZAorICAgICAg ICB3aXRob3V0IGNvbnNpZGVyaW5nIHRoZWlyIGxvY2F0aW9uLiBTZWUgaHR0cHM6Ly90cmFjLndl YmtpdC5vcmcvd2lraS9MYXlvdXRVbml0IGZvciBkZXRhaWxzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogbG9hZGVyL1N1YmZyYW1l TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN1YmZyYW1lTG9hZGVyOjpsb2FkTWVkaWFQ bGF5ZXJQcm94eVBsdWdpbik6CisgICAgICAgIChXZWJDb3JlOjpTdWJmcmFtZUxvYWRlcjo6Y3Jl YXRlSmF2YUFwcGxldFdpZGdldCk6CisgICAgICAgIChXZWJDb3JlOjpTdWJmcmFtZUxvYWRlcjo6 bG9hZFBsdWdpbik6CisKIDIwMTItMDMtMjcgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBEb2N1bWVudDo6bWFwcGVkRWxlbWVudFNoZWV0KCkgCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3ViZnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDEx MjI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE3MSw3ICsxNzEsNyBAQCBQYXNzUmVmUHRyPFdpZGdldD4gU3ViZnJhbWVM b2FkZXI6OmxvYWRNCiAgICAgSW50U2l6ZSBzaXplOwogCiAgICAgaWYgKHJlbmRlcmVyKQotICAg ICAgICBzaXplID0gSW50U2l6ZShyZW5kZXJlci0+Y29udGVudFdpZHRoKCksIHJlbmRlcmVyLT5j b250ZW50SGVpZ2h0KCkpOworICAgICAgICBzaXplID0gcm91bmRlZEludFNpemUoTGF5b3V0U2l6 ZShyZW5kZXJlci0+Y29udGVudFdpZHRoKCksIHJlbmRlcmVyLT5jb250ZW50SGVpZ2h0KCkpKTsK ICAgICBlbHNlIGlmIChtZWRpYUVsZW1lbnQtPmlzVmlkZW8oKSkKICAgICAgICAgc2l6ZSA9IFJl bmRlclZpZGVvOjpkZWZhdWx0U2l6ZSgpOwogCkBAIC0yMjQsNyArMjI0LDcgQEAgUGFzc1JlZlB0 cjxXaWRnZXQ+IFN1YmZyYW1lTG9hZGVyOjpjcmVhdAogCiAgICAgUmVmUHRyPFdpZGdldD4gd2lk Z2V0OwogICAgIGlmIChhbGxvd1BsdWdpbnMoQWJvdXRUb0luc3RhbnRpYXRlUGx1Z2luKSkKLSAg ICAgICAgd2lkZ2V0ID0gbV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpLT5jcmVhdGVKYXZhQXBw bGV0V2lkZ2V0KHNpemUsIGVsZW1lbnQsIGJhc2VVUkwsIHBhcmFtTmFtZXMsIHBhcmFtVmFsdWVz KTsKKyAgICAgICAgd2lkZ2V0ID0gbV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpLT5jcmVhdGVK YXZhQXBwbGV0V2lkZ2V0KHJvdW5kZWRJbnRTaXplKHNpemUpLCBlbGVtZW50LCBiYXNlVVJMLCBw YXJhbU5hbWVzLCBwYXJhbVZhbHVlcyk7CiAgICAgaWYgKCF3aWRnZXQpCiAgICAgICAgIHJldHVy biAwOwogCkBAIC0zNjAsNyArMzYwLDcgQEAgYm9vbCBTdWJmcmFtZUxvYWRlcjo6bG9hZFBsdWdp bihIVE1MUGx1ZwogICAgIGlmICghZnJhbWVMb2FkZXItPmNoZWNrSWZSdW5JbnNlY3VyZUNvbnRl bnQoZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKSwgdXJsKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCi0gICAgSW50U2l6ZSBjb250ZW50U2l6ZShyZW5kZXJlci0+Y29udGVudFdpZHRoKCks IHJlbmRlcmVyLT5jb250ZW50SGVpZ2h0KCkpOworICAgIEludFNpemUgY29udGVudFNpemUgPSBy b3VuZGVkSW50U2l6ZShMYXlvdXRTaXplKHJlbmRlcmVyLT5jb250ZW50V2lkdGgoKSwgcmVuZGVy ZXItPmNvbnRlbnRIZWlnaHQoKSkpOwogICAgIGJvb2wgbG9hZE1hbnVhbGx5ID0gZG9jdW1lbnQo KS0+aXNQbHVnaW5Eb2N1bWVudCgpICYmICFtX2NvbnRhaW5zUGx1Z2lucyAmJiB0b1BsdWdpbkRv Y3VtZW50KGRvY3VtZW50KCkpLT5zaG91bGRMb2FkUGx1Z2luTWFudWFsbHkoKTsKICAgICBSZWZQ dHI8V2lkZ2V0PiB3aWRnZXQgPSBmcmFtZUxvYWRlci0+Y2xpZW50KCktPmNyZWF0ZVBsdWdpbihj b250ZW50U2l6ZSwKICAgICAgICAgcGx1Z2luRWxlbWVudCwgdXJsLCBwYXJhbU5hbWVzLCBwYXJh bVZhbHVlcywgbWltZVR5cGUsIGxvYWRNYW51YWxseSk7Cg==