82219 2012-03-26 09:35:46 -0700 Update LayoutUnit usage in ContainerNode, Element, and ElementRareData 2012-03-26 16:35:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 587830 0 leviw 2012-03-26 09:35:46 -0700 Correcting some minor misuse of LayoutUnits in these classes, and avoiding overflow when we switch to sub-pixel units by not using INT_MAX. 587844 1 133837 leviw 2012-03-26 09:49:16 -0700 Created attachment 133837 Patch 588290 2 133837 webkit.review.bot 2012-03-26 16:35:25 -0700 Comment on attachment 133837 Patch Clearing flags on attachment: 133837 Committed r112170: <http://trac.webkit.org/changeset/112170> 588291 3 webkit.review.bot 2012-03-26 16:35:29 -0700 All reviewed patches have been landed. Closing bug. 133837 2012-03-26 09:49:16 -0700 2012-03-26 16:35:24 -0700 Patch bug-82219-20120326174914.patch text/plain 3903 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjExMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAzLTI2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgTGF5b3V0VW5p dCB1c2FnZSBpbiBDb250YWluZXJOb2RlLCBFbGVtZW50LCBhbmQgRWxlbWVudFJhcmVEYXRhCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjIxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFpbmVyTm9kZTo6Z2V0TG93ZXJSaWdodENvcm5l cik6IGxpbmVzQm91bmRpbmdCb3ggcmV0dXJucyB0aGUgZW5jbG9zaW5nIEludFJlY3QKKyAgICAg ICAgb2YgdGhlIGNvbnRhaW5lZCBsaW5lcy4gSW5saW5lJ3MgYXJlbid0IGJvdW5kZWQgaW4gTGF5 b3V0VW5pdHMgbm9yIHBpeGVsIHNuYXBwZWQuCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6Ym91bmRzSW5Sb290Vmlld1NwYWNlKTogQ29vcmRp bmF0ZXMgaW4gcm9vdCB2aWV3IHNwYWNlIGFyZSBha2luIHRvIGFic29sdXRlCisgICAgICAgIGNv b3JkaW5hdGVzLCB3aGljaCBhcmUgYWx3YXlzIGV4cHJlc3NlZCBpbiBpbnRlZ2Vycy4KKyAgICAg ICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoRWxlbWVudCk6CisgICAgICAgICogZG9tL0Vs ZW1lbnRSYXJlRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6ZGVmYXVsdE1pbmltdW1TaXplRm9y UmVzaXppbmcpOiBVc2luZyBudW1lcmljX2xpbWl0czxMYXlvdXRVbml0Pjo6bWF4IGluc3RlYWQg b2YKKyAgICAgICAgSU5UX01BWCB0byBhdm9pZCBvdmVyZmxvd2luZyB3aGVuIExheW91dFVuaXRz IGFyZSBzdWItcGl4ZWwuCisKIDIwMTItMDMtMjYgIFJvYmluIENhbyAgPHJvYmluLmNhb0B0b3Jj aG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFVwc3RyZWFtIExheWVyQ29t cG9zaXRpbmdUaHJlYWQue2gsIGNwcH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWlu ZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9k ZS5jcHAJKHJldmlzaW9uIDExMjA2MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJO b2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMyLDcgKzkzMiw3IEBAIGJvb2wgQ29udGFpbmVy Tm9kZTo6Z2V0TG93ZXJSaWdodENvcm5lcigKICAgICAgICAgICAgIHBvaW50ID0gRmxvYXRQb2lu dCgpOwogICAgICAgICAgICAgaWYgKG8tPmlzVGV4dCgpKSB7CiAgICAgICAgICAgICAgICAgUmVu ZGVyVGV4dCogdGV4dCA9IHRvUmVuZGVyVGV4dChvKTsKLSAgICAgICAgICAgICAgICBMYXlvdXRS ZWN0IGxpbmVzQm94ID0gdGV4dC0+bGluZXNCb3VuZGluZ0JveCgpOworICAgICAgICAgICAgICAg IEludFJlY3QgbGluZXNCb3ggPSB0ZXh0LT5saW5lc0JvdW5kaW5nQm94KCk7CiAgICAgICAgICAg ICAgICAgaWYgKCFsaW5lc0JveC5tYXhYKCkgJiYgIWxpbmVzQm94Lm1heFkoKSkKICAgICAgICAg ICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgcG9pbnQubW92ZUJ5KGxpbmVz Qm94Lm1heFhNYXhZQ29ybmVyKCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNp b24gMTEyMDYyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00NzUsMTMgKzQ3NSwxMyBAQCBpbnQgRWxlbWVudDo6c2Nyb2xsSGVpZ2h0KCkKICAg ICByZXR1cm4gMDsKIH0KIAotTGF5b3V0UmVjdCBFbGVtZW50Ojpib3VuZHNJblJvb3RWaWV3U3Bh Y2UoKQorSW50UmVjdCBFbGVtZW50Ojpib3VuZHNJblJvb3RWaWV3U3BhY2UoKQogewogICAgIGRv Y3VtZW50KCktPnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOwogCiAgICAg RnJhbWVWaWV3KiB2aWV3ID0gZG9jdW1lbnQoKS0+dmlldygpOwogICAgIGlmICghdmlldykKLSAg ICAgICAgcmV0dXJuIExheW91dFJlY3QoKTsKKyAgICAgICAgcmV0dXJuIEludFJlY3QoKTsKIAog ICAgIFZlY3RvcjxGbG9hdFF1YWQ+IHF1YWRzOwogI2lmIEVOQUJMRShTVkcpCkBAIC01MDAsOSAr NTAwLDkgQEAgTGF5b3V0UmVjdCBFbGVtZW50Ojpib3VuZHNJblJvb3RWaWV3U3BhYwogICAgIH0K IAogICAgIGlmIChxdWFkcy5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiBMYXlvdXRSZWN0KCk7 CisgICAgICAgIHJldHVybiBJbnRSZWN0KCk7CiAKLSAgICBMYXlvdXRSZWN0IHJlc3VsdCA9IHF1 YWRzWzBdLmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7CisgICAgSW50UmVjdCByZXN1bHQgPSBxdWFk c1swXS5lbmNsb3NpbmdCb3VuZGluZ0JveCgpOwogICAgIGZvciAoc2l6ZV90IGkgPSAxOyBpIDwg cXVhZHMuc2l6ZSgpOyArK2kpCiAgICAgICAgIHJlc3VsdC51bml0ZShxdWFkc1tpXS5lbmNsb3Np bmdCb3VuZGluZ0JveCgpKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCShyZXZpc2lvbiAxMTIw NjIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0x ODYsNyArMTg2LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgaW50IHNjcm9sbFdpZHRoKCk7CiAg ICAgdmlydHVhbCBpbnQgc2Nyb2xsSGVpZ2h0KCk7CiAKLSAgICBMYXlvdXRSZWN0IGJvdW5kc0lu Um9vdFZpZXdTcGFjZSgpOworICAgIEludFJlY3QgYm91bmRzSW5Sb290Vmlld1NwYWNlKCk7CiAK ICAgICBQYXNzUmVmUHRyPENsaWVudFJlY3RMaXN0PiBnZXRDbGllbnRSZWN0cygpOwogICAgIFBh c3NSZWZQdHI8Q2xpZW50UmVjdD4gZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudFJhcmVEYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnRSYXJlRGF0YS5oCShyZXZpc2lvbiAxMTIwNjIpCisrKyBTb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudFJhcmVEYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTgxLDcgKzgx LDcgQEAgcHVibGljOgogCiBpbmxpbmUgSW50U2l6ZSBkZWZhdWx0TWluaW11bVNpemVGb3JSZXNp emluZygpCiB7Ci0gICAgcmV0dXJuIEludFNpemUoSU5UX01BWCwgSU5UX01BWCk7CisgICAgcmV0 dXJuIEludFNpemUoc3RkOjpudW1lcmljX2xpbWl0czxMYXlvdXRVbml0Pjo6bWF4KCksIHN0ZDo6 bnVtZXJpY19saW1pdHM8TGF5b3V0VW5pdD46Om1heCgpKTsKIH0KIAogaW5saW5lIEVsZW1lbnRS YXJlRGF0YTo6RWxlbWVudFJhcmVEYXRhKCkK