82213 2012-03-26 08:24:18 -0700 Convert RenderSelectionInfo::rect to LayoutUnits 2012-03-27 03:54:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix oldest_to_newest 587764 0 leviw 2012-03-26 08:24:18 -0700 RenderSelectionInfoBase stores a cached repaint rect in local coordinates, and therefor should store it in LayoutUnits. 587769 1 133818 leviw 2012-03-26 08:26:59 -0700 Created attachment 133818 Patch 588213 2 133818 eric 2012-03-26 15:42:49 -0700 Comment on attachment 133818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133818&action=review > Source/WebCore/ChangeLog:9 > + RenderSelectionInfoBase stores a cached repaint rect in local coordinates. Coordinates local to > + renderers should be stored in LayoutUnits. I think these sorts of changelogs might link to the wiki. Ending in "As described in LayoutUnit: http://trac.webkit.org/wiki/LayoutUnit" 588214 3 133818 eric 2012-03-26 15:43:11 -0700 Comment on attachment 133818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133818&action=review >> Source/WebCore/ChangeLog:9 >> + renderers should be stored in LayoutUnits. > > I think these sorts of changelogs might link to the wiki. > > Ending in "As described in LayoutUnit: http://trac.webkit.org/wiki/LayoutUnit" Obviously this means that then the wiki would need to make sure to include this sort of rational. :) 588729 4 leviw 2012-03-27 03:53:03 -0700 Committed r112248: <http://trac.webkit.org/changeset/112248> 588731 5 133818 leviw 2012-03-27 03:54:45 -0700 Comment on attachment 133818 Patch Clearing flags. 133818 2012-03-26 08:26:59 -0700 2012-03-27 03:54:45 -0700 Patch bug-82213-20120326162657.patch text/plain 1492 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjEwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTI2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb252ZXJ0IFJlbmRlclNl bGVjdGlvbkluZm86OnJlY3QgdG8gTGF5b3V0VW5pdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyU2VsZWN0aW9uSW5mb0Jhc2Ugc3RvcmVzIGEg Y2FjaGVkIHJlcGFpbnQgcmVjdCBpbiBsb2NhbCBjb29yZGluYXRlcy4gQ29vcmRpbmF0ZXMgbG9j YWwgdG8KKyAgICAgICAgcmVuZGVyZXJzIHNob3VsZCBiZSBzdG9yZWQgaW4gTGF5b3V0VW5pdHMu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyU2VsZWN0aW9uSW5mby5oOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyU2VsZWN0aW9uSW5mbzo6cmVjdCk6CisgICAgICAgIChSZW5kZXJTZWxlY3Rpb25JbmZv KToKKwogMjAxMi0wMy0yNiAgTWloYWkgQmFsYW4gIDxtaWJhbGFuQGFkb2JlLmNvbT4KIAogICAg ICAgICBbQ1NTIFJlZ2lvbnNdIEluIHJlZ2lvbiBzdHlsaW5nIChALXdlYmtpdC1yZWdpb24pIHRo ZSBwb3NpdGlvbiBmb3IgQ1NTIHJ1bGVzIGlzIGluY29ycmVjdGx5IGNvbXB1dGVkCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2VsZWN0aW9uSW5mby5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTZWxlY3Rpb25JbmZvLmgJKHJldmlz aW9uIDExMjA2MikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTZWxlY3Rpb25J bmZvLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDEwICs3MSwxMCBAQCBwdWJsaWM6CiAgICAgICAg IG1fb2JqZWN0LT5yZXBhaW50VXNpbmdDb250YWluZXIobV9yZXBhaW50Q29udGFpbmVyLCBtX3Jl Y3QpOwogICAgIH0KIAotICAgIEludFJlY3QgcmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVjdDsg fQorICAgIExheW91dFJlY3QgcmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVjdDsgfQogCiBwcml2 YXRlOgotICAgIEludFJlY3QgbV9yZWN0OyAvLyByZWxhdGl2ZSB0byByZXBhaW50IGNvbnRhaW5l cgorICAgIExheW91dFJlY3QgbV9yZWN0OyAvLyByZWxhdGl2ZSB0byByZXBhaW50IGNvbnRhaW5l cgogfTsKIAogCg==