82210 2012-03-26 08:14:41 -0700 Switch ColumnInfo::addForcedBreak to LayoutUnits 2012-03-26 16:38:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 587751 0 leviw 2012-03-26 08:14:41 -0700 This is an incredibly simple patch that converts the addForcedBreak function to use LayoutUnits. The member variables are already correct. 587759 1 133816 leviw 2012-03-26 08:19:40 -0700 Created attachment 133816 Patch 588295 2 133816 webkit.review.bot 2012-03-26 16:38:02 -0700 Comment on attachment 133816 Patch Clearing flags on attachment: 133816 Committed r112172: <http://trac.webkit.org/changeset/112172> 588296 3 webkit.review.bot 2012-03-26 16:38:06 -0700 All reviewed patches have been landed. Closing bug. 133816 2012-03-26 08:19:40 -0700 2012-03-26 16:38:02 -0700 Patch bug-82210-20120326161939.patch text/plain 1491 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjA5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBTd2l0Y2ggQ29sdW1uSW5m bzo6YWRkRm9yY2VkQnJlYWsgdG8gTGF5b3V0VW5pdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yY2VkIGJyZWFrcyBhcmUgYWRkZWQgYnkgbG9jYWwg b2Zmc2V0cywgd2hpY2ggc2hvdWxkIGJlIGluIExheW91dFVuaXRzLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcmVuZGVyaW5nL0Nv bHVtbkluZm8uaDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbHVtbkluZm86OmFkZEZvcmNlZEJyZWFr KToKKwogMjAxMi0wMy0yNiAgUGllcnJlIFJvc3NpICA8cGllcnJlLnJvc3NpQG5va2lhLmNvbT4K IAogICAgICAgICBbUXRdIERpc2FibGUgZm9jdXMgcmluZyBpbiB0aGUgbW9iaWxlIHRoZW1lLgpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0NvbHVtbkluZm8uaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQ29sdW1uSW5mby5oCShyZXZpc2lvbiAxMTIwNjIp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQ29sdW1uSW5mby5oCSh3b3JraW5nIGNvcHkp CkBAIC04MywxMCArODMsMTAgQEAgcHVibGljOgogICAgICAgICBtX21heGltdW1EaXN0YW5jZUJl dHdlZW5Gb3JjZWRCcmVha3MgPSAwOwogICAgICAgICBtX2ZvcmNlZEJyZWFrT2Zmc2V0ID0gMDsK ICAgICB9Ci0gICAgdm9pZCBhZGRGb3JjZWRCcmVhayhpbnQgb2Zmc2V0RnJvbUZpcnN0UGFnZSkK KyAgICB2b2lkIGFkZEZvcmNlZEJyZWFrKExheW91dFVuaXQgb2Zmc2V0RnJvbUZpcnN0UGFnZSkK ICAgICB7IAogICAgICAgICBBU1NFUlQoIW1fY29sdW1uSGVpZ2h0KTsKLSAgICAgICAgaW50IGRp c3RhbmNlRnJvbUxhc3RCcmVhayA9IG9mZnNldEZyb21GaXJzdFBhZ2UgLSBtX2ZvcmNlZEJyZWFr T2Zmc2V0OworICAgICAgICBMYXlvdXRVbml0IGRpc3RhbmNlRnJvbUxhc3RCcmVhayA9IG9mZnNl dEZyb21GaXJzdFBhZ2UgLSBtX2ZvcmNlZEJyZWFrT2Zmc2V0OwogICAgICAgICBpZiAoIWRpc3Rh bmNlRnJvbUxhc3RCcmVhaykKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgbV9mb3JjZWRC cmVha3MrKzsK