82182 2012-03-26 03:12:33 -0700 Revert linesBoundingBox to integers 2019-05-02 16:25:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw ap eae eric jchaffraix vivekjkumar266 webkit.review.bot oldest_to_newest 587571 0 leviw 2012-03-26 03:12:33 -0700 Moving linesBoundingBox back to integers. We don't pixel snap values from the inline box tree, we enclose them. Keeping linesBoundingBox as integers doesn't change its accuracy, and prevents misuse. 587576 1 133763 leviw 2012-03-26 03:22:56 -0700 Created attachment 133763 Patch 588203 2 133763 eric 2012-03-26 15:38:08 -0700 Comment on attachment 133763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133763&action=review > Source/WebCore/ChangeLog:12 > + LayoutRects are intended to be pixel snapped to determine the ultimate screen > + coordinates, but the Inline Box tree is laid out using floats, and pixel snapping > + the resulting box from linesBoundingBox would produce a potentially incorrect > + rectangle. Keeping this using enclosingIntRect retains the previous accuracy and > + prevents misuse. Clearly you've learned a lot as youv'e gone. I hope that we've documented this learning for others. To help make it obvious where LayoutPoint vs. IntPoitn vs. FloatPoint should be used. It's still not always 100% obvious to me. :( 588692 3 133763 leviw 2012-03-27 02:40:30 -0700 Comment on attachment 133763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133763&action=review >> Source/WebCore/ChangeLog:12 >> + prevents misuse. > > Clearly you've learned a lot as youv'e gone. I hope that we've documented this learning for others. To help make it obvious where LayoutPoint vs. IntPoitn vs. FloatPoint should be used. It's still not always 100% obvious to me. :( Looks like I've got a few things to clear up on the Wiki. I'll give it some more love today. I appreciate the feedback. 588707 4 133763 webkit.review.bot 2012-03-27 03:07:07 -0700 Comment on attachment 133763 Patch Clearing flags on attachment: 133763 Committed r112237: <http://trac.webkit.org/changeset/112237> 588708 5 webkit.review.bot 2012-03-27 03:07:12 -0700 All reviewed patches have been landed. Closing bug. 133763 2012-03-26 03:22:56 -0700 2012-03-27 03:07:07 -0700 Patch bug-82182-20120326112254.patch text/plain 6206 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjA3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTAzLTI2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZlcnQgbGluZXNCb3Vu ZGluZ0JveCB0byBpbnRlZ2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODIxODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBMYXlvdXRSZWN0cyBhcmUgaW50ZW5kZWQgdG8gYmUgcGl4ZWwgc25hcHBlZCB0 byBkZXRlcm1pbmUgdGhlIHVsdGltYXRlIHNjcmVlbgorICAgICAgICBjb29yZGluYXRlcywgYnV0 IHRoZSBJbmxpbmUgQm94IHRyZWUgaXMgbGFpZCBvdXQgdXNpbmcgZmxvYXRzLCBhbmQgcGl4ZWwg c25hcHBpbmcKKyAgICAgICAgdGhlIHJlc3VsdGluZyBib3ggZnJvbSBsaW5lc0JvdW5kaW5nQm94 IHdvdWxkIHByb2R1Y2UgYSBwb3RlbnRpYWxseSBpbmNvcnJlY3QKKyAgICAgICAgcmVjdGFuZ2xl LiBLZWVwaW5nIHRoaXMgdXNpbmcgZW5jbG9zaW5nSW50UmVjdCByZXRhaW5zIHRoZSBwcmV2aW91 cyBhY2N1cmFjeSBhbmQKKyAgICAgICAgcHJldmVudHMgbWlzdXNlLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlcklubGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6OmxpbmVzQm91 bmRpbmdCb3gpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbmxpbmUuaDoKKyAgICAgICAg KFJlbmRlcklubGluZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uKToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU ZXh0OjpsaW5lc0JvdW5kaW5nQm94KToKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNW R0lubGluZVRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHSW5saW5lVGV4dDo6 bGluZXNCb3VuZGluZ0JveCk6CisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbmxp bmVUZXh0Lmg6CisgICAgICAgIChSZW5kZXJTVkdJbmxpbmVUZXh0KToKKwogMjAxMi0wMy0yMiAg WXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBzcGxpdCBub2RlcyBhbmQgY29udGFpbm1lbnQgZWRnZXMgaW50byB0d28gZGlmZmVy ZW50IGFycmF5cwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5j cHAJKHJldmlzaW9uIDExMjA2MikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJ bmxpbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODUsMTQgKzc4NSwxNCBAQCBWaXNpYmxlUG9z aXRpb24gUmVuZGVySW5saW5lOjpwb3NpdGlvbkZvCiAgICAgcmV0dXJuIFJlbmRlckJveE1vZGVs T2JqZWN0Ojpwb3NpdGlvbkZvclBvaW50KHBvaW50KTsKIH0KIAotTGF5b3V0UmVjdCBSZW5kZXJJ bmxpbmU6OmxpbmVzQm91bmRpbmdCb3goKSBjb25zdAorSW50UmVjdCBSZW5kZXJJbmxpbmU6Omxp bmVzQm91bmRpbmdCb3goKSBjb25zdAogewogICAgIGlmICghYWx3YXlzQ3JlYXRlTGluZUJveGVz KCkpIHsKICAgICAgICAgQVNTRVJUKCFmaXJzdExpbmVCb3goKSk7Ci0gICAgICAgIHJldHVybiBl bmNsb3NpbmdMYXlvdXRSZWN0KGN1bGxlZElubGluZUJvdW5kaW5nQm94KHRoaXMpKTsKKyAgICAg ICAgcmV0dXJuIGVuY2xvc2luZ0ludFJlY3QoY3VsbGVkSW5saW5lQm91bmRpbmdCb3godGhpcykp OwogICAgIH0KIAotICAgIExheW91dFJlY3QgcmVzdWx0OworICAgIEludFJlY3QgcmVzdWx0Owog ICAgIAogICAgIC8vIFNlZSA8cmRhcjovL3Byb2JsZW0vNTI4OTcyMT4sIGZvciBhbiB1bmtub3du IHJlYXNvbiB0aGUgbGlua2VkIGxpc3QgaGVyZSBpcyBzb21ldGltZXMgaW5jb25zaXN0ZW50LCBm aXJzdCBpcyBub24temVybyBhbmQgbGFzdCBpcyB6ZXJvLiAgV2UgaGF2ZSBiZWVuCiAgICAgLy8g dW5hYmxlIHRvIHJlcHJvZHVjZSB0aGlzIGF0IGFsbCAoYW5kIGNvbnNlcXVlbnRseSB1bmFibGUg dG8gZmlndXJlIG90IHdoeSB0aGlzIGlzIGhhcHBlbmluZykuICBUaGUgYXNzZXJ0IHdpbGwgaG9w ZWZ1bGx5IGNhdGNoIHRoZSBwcm9ibGVtIGluIGRlYnVnCkBAIC04MTUsNyArODE1LDcgQEAgTGF5 b3V0UmVjdCBSZW5kZXJJbmxpbmU6OmxpbmVzQm91bmRpbmdCbwogICAgICAgICBmbG9hdCB5ID0g aXNIb3Jpem9udGFsID8gZmlyc3RMaW5lQm94KCktPnkoKSA6IGxvZ2ljYWxMZWZ0U2lkZTsKICAg ICAgICAgZmxvYXQgd2lkdGggPSBpc0hvcml6b250YWwgPyBsb2dpY2FsUmlnaHRTaWRlIC0gbG9n aWNhbExlZnRTaWRlIDogbGFzdExpbmVCb3goKS0+bG9naWNhbEJvdHRvbSgpIC0geDsKICAgICAg ICAgZmxvYXQgaGVpZ2h0ID0gaXNIb3Jpem9udGFsID8gbGFzdExpbmVCb3goKS0+bG9naWNhbEJv dHRvbSgpIC0geSA6IGxvZ2ljYWxSaWdodFNpZGUgLSBsb2dpY2FsTGVmdFNpZGU7Ci0gICAgICAg IHJlc3VsdCA9IGVuY2xvc2luZ0xheW91dFJlY3QoRmxvYXRSZWN0KHgsIHksIHdpZHRoLCBoZWln aHQpKTsKKyAgICAgICAgcmVzdWx0ID0gZW5jbG9zaW5nSW50UmVjdChGbG9hdFJlY3QoeCwgeSwg d2lkdGgsIGhlaWdodCkpOwogICAgIH0KIAogICAgIHJldHVybiByZXN1bHQ7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5oCShyZXZpc2lvbiAxMTIwNjIpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmgJKHdvcmtpbmcgY29weSkKQEAg LTUxLDcgKzUxLDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBMYXlvdXRTaXplIG9mZnNldEZy b21Db250YWluZXIoUmVuZGVyT2JqZWN0KiwgY29uc3QgTGF5b3V0UG9pbnQmKSBjb25zdDsKIAot ICAgIExheW91dFJlY3QgbGluZXNCb3VuZGluZ0JveCgpIGNvbnN0OworICAgIEludFJlY3QgbGlu ZXNCb3VuZGluZ0JveCgpIGNvbnN0OwogICAgIExheW91dFJlY3QgbGluZXNWaXN1YWxPdmVyZmxv d0JvdW5kaW5nQm94KCkgY29uc3Q7CiAKICAgICBJbmxpbmVGbG93Qm94KiBjcmVhdGVBbmRBcHBl bmRJbmxpbmVGbG93Qm94KCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAJKHJldmlzaW9uIDExMjA2MikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTczOSw3ICs3MzksNyBAQCB2b2lkIFJl bmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uKCkKICAgICBMYXlvdXRTaXplIGlubGluZUJv dW5kaW5nQm94T2Zmc2V0OyAvLyBXZSBkb24ndCBwdXQgdGhpcyBpbnRvIHRoZSBSZW5kZXJMYXll ciB4L3kgZm9yIGlubGluZXMsIHNvIHdlIG5lZWQgdG8gc3VidHJhY3QgaXQgb3V0IHdoZW4gZG9u ZS4KICAgICBpZiAocmVuZGVyZXIoKS0+aXNSZW5kZXJJbmxpbmUoKSkgewogICAgICAgICBSZW5k ZXJJbmxpbmUqIGlubGluZUZsb3cgPSB0b1JlbmRlcklubGluZShyZW5kZXJlcigpKTsKLSAgICAg ICAgTGF5b3V0UmVjdCBsaW5lQm94ID0gaW5saW5lRmxvdy0+bGluZXNCb3VuZGluZ0JveCgpOwor ICAgICAgICBJbnRSZWN0IGxpbmVCb3ggPSBpbmxpbmVGbG93LT5saW5lc0JvdW5kaW5nQm94KCk7 CiAgICAgICAgIHNldFNpemUobGluZUJveC5zaXplKCkpOwogICAgICAgICBpbmxpbmVCb3VuZGlu Z0JveE9mZnNldCA9IHRvU2l6ZShsaW5lQm94LmxvY2F0aW9uKCkpOwogICAgICAgICBsb2NhbFBv aW50ICs9IGlubGluZUJvdW5kaW5nQm94T2Zmc2V0OwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUZXh0LmNwcAkocmV2aXNpb24gMTEyMDYyKQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDY5LDkgKzE0Njks OSBAQCBmbG9hdCBSZW5kZXJUZXh0Ojp3aWR0aCh1bnNpZ25lZCBmcm9tLCB1CiAgICAgcmV0dXJu IHc7CiB9CiAKLUxheW91dFJlY3QgUmVuZGVyVGV4dDo6bGluZXNCb3VuZGluZ0JveCgpIGNvbnN0 CitJbnRSZWN0IFJlbmRlclRleHQ6OmxpbmVzQm91bmRpbmdCb3goKSBjb25zdAogewotICAgIExh eW91dFJlY3QgcmVzdWx0OworICAgIEludFJlY3QgcmVzdWx0OwogICAgIAogICAgIEFTU0VSVCgh Zmlyc3RUZXh0Qm94KCkgPT0gIWxhc3RUZXh0Qm94KCkpOyAgLy8gRWl0aGVyIGJvdGggYXJlIG51 bGwgb3IgYm90aCBleGlzdC4KICAgICBpZiAoZmlyc3RUZXh0Qm94KCkgJiYgbGFzdFRleHRCb3go KSkgewpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbmxpbmVU ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRl clNWR0lubGluZVRleHQuY3BwCShyZXZpc2lvbiAxMTIwNjIpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lubGluZVRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NjUsNyArMTY1LDcgQEAgRmxvYXRSZWN0IFJlbmRlclNWR0lubGluZVRleHQ6OmZsb2F0TGluZQog ICAgIHJldHVybiBib3VuZGluZ0JveDsKIH0KIAotTGF5b3V0UmVjdCBSZW5kZXJTVkdJbmxpbmVU ZXh0OjpsaW5lc0JvdW5kaW5nQm94KCkgY29uc3QKK0ludFJlY3QgUmVuZGVyU1ZHSW5saW5lVGV4 dDo6bGluZXNCb3VuZGluZ0JveCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGVuY2xvc2luZ0ludFJl Y3QoZmxvYXRMaW5lc0JvdW5kaW5nQm94KCkpOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbmxpbmVUZXh0LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbmxpbmVUZXh0LmgJKHJldmlzaW9uIDExMjA2 MikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHSW5saW5lVGV4dC5o CSh3b3JraW5nIGNvcHkpCkBAIC01OSw3ICs1OSw3IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFs IFZpc2libGVQb3NpdGlvbiBwb3NpdGlvbkZvclBvaW50KGNvbnN0IExheW91dFBvaW50Jik7CiAg ICAgdmlydHVhbCBMYXlvdXRSZWN0IGxvY2FsQ2FyZXRSZWN0KElubGluZUJveCosIGludCBjYXJl dE9mZnNldCwgTGF5b3V0VW5pdCogZXh0cmFXaWR0aFRvRW5kT2ZMaW5lID0gMCk7Ci0gICAgdmly dHVhbCBMYXlvdXRSZWN0IGxpbmVzQm91bmRpbmdCb3goKSBjb25zdDsKKyAgICB2aXJ0dWFsIElu dFJlY3QgbGluZXNCb3VuZGluZ0JveCgpIGNvbnN0OwogICAgIHZpcnR1YWwgSW5saW5lVGV4dEJv eCogY3JlYXRlVGV4dEJveCgpOwogCiAgICAgZmxvYXQgbV9zY2FsaW5nRmFjdG9yOwo=