82179 2012-03-26 02:43:13 -0700 Correct LayoutUnit usage in RenderFieldSet and RenderMenuItem 2012-03-26 15:41:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix tkent webkit.review.bot oldest_to_newest 587557 0 leviw 2012-03-26 02:43:13 -0700 Adding some simple build fixes, correcting a mismatch between h/cpp for padding functions (int vs LayoutUnit), and adding some necessary pixel snapping. 587564 1 133757 leviw 2012-03-26 03:01:27 -0700 Created attachment 133757 Patch 588025 2 133757 jchaffraix 2012-03-26 12:56:20 -0700 Comment on attachment 133757 Patch Pretty mechanical change, r=me. 588181 3 133757 leviw 2012-03-26 15:13:34 -0700 Comment on attachment 133757 Patch Thanks Julien! 588210 4 133757 webkit.review.bot 2012-03-26 15:41:45 -0700 Comment on attachment 133757 Patch Clearing flags on attachment: 133757 Committed r112158: <http://trac.webkit.org/changeset/112158> 588211 5 webkit.review.bot 2012-03-26 15:41:50 -0700 All reviewed patches have been landed. Closing bug. 133757 2012-03-26 03:01:27 -0700 2012-03-26 15:41:45 -0700 Patch bug-82179-20120326030126.patch text/plain 5140 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjA2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTI2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVu aXQgdXNhZ2UgaW4gUmVuZGVyRmllbGRTZXQgYW5kIFJlbmRlck1lbnVJdGVtCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjE3OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3Rpbmcgc21hbGwgbWlz dXNlcyBvZiBpbnRzIHZzIExheW91dFVuaXRzIGluIFJlbmRlckZpZWxkU2V0IGFuZCBSZW5kZXJN ZW51SXRlbS4gQWxzbworICAgICAgICBhZGRpbmcgemVyb0xheW91dFVuaXQgd2hlcmUgbmVjZXNz YXJ5IHRvIGZpeCB0aGUgc3ViLXBpeGVsIGJ1aWxkLiBTZWUgYmVsb3cgZm9yIGRldGFpbHMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRmllbGRzZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy RmllbGRzZXQ6OnBhaW50Qm94RGVjb3JhdGlvbnMpOiBDbGlwIHJlY3RzIG5lZWQgdG8gYmUgcGl4 ZWwgc25hcHBlZCB0byBtaXJyb3IKKyAgICAgICAgdGhlIGFjdHVhbCBjb29yZGluYXRlcyB3ZSBw YWludC4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZpZWxkc2V0OjpwYWludE1hc2spOiBVc2lu ZyB6ZXJvTGF5b3V0VW5pdCBmb3IgdGVybmFyeSBvcGVyYXRpb24gdG8gZml4IHRoZQorICAgICAg ICBzdWItcGl4ZWwgYnVpbGQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1lbnVMaXN0OjpzaG93UG9wdXApOiBDb3JyZWN0 bHkgdXNpbmcgYW4gSW50UmVjdCBmb3IgYWJzb2x1dGVCb3VuZGluZ0JveFJlY3QuCisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJNZW51TGlzdDo6Y2xpZW50UGFkZGluZ0xlZnQpOiBDb3JyZWN0aW5n IG1pc21hdGNoZWQgcmV0dXJuIHR5cGUgd2l0aCBoZWFkZXIuCisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJNZW51TGlzdDo6Y2xpZW50UGFkZGluZ1JpZ2h0KTogRGl0dG8uCisKIDIwMTItMDMtMjYg IElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IHJlcGxhY2UgaW5kZXhPZignYSB0ZXh0JykgPT09IDAgd2l0aCBSZWdFeHAgYmVj YXVzZSBpdCBpcyBtdWNoIGZhc3Rlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGaWVsZHNldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZpZWxkc2V0LmNwcAkocmV2aXNpb24gMTExNjY4KQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckZpZWxkc2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU5LDExICsx NTksMTEgQEAgdm9pZCBSZW5kZXJGaWVsZHNldDo6cGFpbnRCb3hEZWNvcmF0aW9ucwogICAgIGlm IChzdHlsZSgpLT5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSB7CiAgICAgICAgIExheW91dFVu aXQgY2xpcFRvcCA9IHBhaW50UmVjdC55KCk7CiAgICAgICAgIExheW91dFVuaXQgY2xpcEhlaWdo dCA9IG1heChzdGF0aWNfY2FzdDxMYXlvdXRVbml0PihzdHlsZSgpLT5ib3JkZXJUb3BXaWR0aCgp KSwgbGVnZW5kLT5oZWlnaHQoKSAtICgobGVnZW5kLT5oZWlnaHQoKSAtIGJvcmRlclRvcCgpKSAv IDIpKTsKLSAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5jbGlwT3V0KExheW91dFJlY3QocGFpbnRS ZWN0LngoKSArIGxlZ2VuZC0+eCgpLCBjbGlwVG9wLCBsZWdlbmQtPndpZHRoKCksIGNsaXBIZWln aHQpKTsKKyAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5jbGlwT3V0KHBpeGVsU25hcHBlZEludFJl Y3QocGFpbnRSZWN0LngoKSArIGxlZ2VuZC0+eCgpLCBjbGlwVG9wLCBsZWdlbmQtPndpZHRoKCks IGNsaXBIZWlnaHQpKTsKICAgICB9IGVsc2UgewogICAgICAgICBMYXlvdXRVbml0IGNsaXBMZWZ0 ID0gcGFpbnRSZWN0LngoKTsKICAgICAgICAgTGF5b3V0VW5pdCBjbGlwV2lkdGggPSBtYXgoc3Rh dGljX2Nhc3Q8TGF5b3V0VW5pdD4oc3R5bGUoKS0+Ym9yZGVyTGVmdFdpZHRoKCkpLCBsZWdlbmQt PndpZHRoKCkpOwotICAgICAgICBncmFwaGljc0NvbnRleHQtPmNsaXBPdXQoTGF5b3V0UmVjdChj bGlwTGVmdCwgcGFpbnRSZWN0LnkoKSArIGxlZ2VuZC0+eSgpLCBjbGlwV2lkdGgsIGxlZ2VuZC0+ aGVpZ2h0KCkpKTsKKyAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5jbGlwT3V0KHBpeGVsU25hcHBl ZEludFJlY3QoY2xpcExlZnQsIHBhaW50UmVjdC55KCkgKyBsZWdlbmQtPnkoKSwgY2xpcFdpZHRo LCBsZWdlbmQtPmhlaWdodCgpKSk7CiAgICAgfQogCiAgICAgcGFpbnRCb3JkZXIocGFpbnRJbmZv LCBwYWludFJlY3QsIHN0eWxlKCkpOwpAQCAtMTgzLDExICsxODMsMTEgQEAgdm9pZCBSZW5kZXJG aWVsZHNldDo6cGFpbnRNYXNrKFBhaW50SW5mbwogICAgIC8vIGNhc2VzIHRoZSBsZWdlbmQgaXMg ZW1iZWRkZWQgaW4gdGhlIHJpZ2h0IGFuZCBib3R0b20gYm9yZGVycyByZXNwZWN0aXZlbHkuCiAg ICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MjM2CiAgICAg aWYgKHN0eWxlKCktPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpIHsKLSAgICAgICAgTGF5b3V0 VW5pdCB5T2ZmID0gKGxlZ2VuZC0+eSgpID4gMCkgPyAwIDogKGxlZ2VuZC0+aGVpZ2h0KCkgLSBi b3JkZXJUb3AoKSkgLyAyOworICAgICAgICBMYXlvdXRVbml0IHlPZmYgPSAobGVnZW5kLT55KCkg PiAwKSA/IHplcm9MYXlvdXRVbml0IDogKGxlZ2VuZC0+aGVpZ2h0KCkgLSBib3JkZXJUb3AoKSkg LyAyOwogICAgICAgICBwYWludFJlY3QuZXhwYW5kKDAsIC15T2ZmKTsKICAgICAgICAgcGFpbnRS ZWN0Lm1vdmUoMCwgeU9mZik7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgTGF5b3V0VW5pdCB4T2Zm ID0gKGxlZ2VuZC0+eCgpID4gMCkgPyAwIDogKGxlZ2VuZC0+d2lkdGgoKSAtIGJvcmRlckxlZnQo KSkgLyAyOworICAgICAgICBMYXlvdXRVbml0IHhPZmYgPSAobGVnZW5kLT54KCkgPiAwKSA/IHpl cm9MYXlvdXRVbml0IDogKGxlZ2VuZC0+d2lkdGgoKSAtIGJvcmRlckxlZnQoKSkgLyAyOwogICAg ICAgICBwYWludFJlY3QuZXhwYW5kKC14T2ZmLCAwKTsKICAgICAgICAgcGFpbnRSZWN0Lm1vdmUo eE9mZiwgMCk7CiAgICAgfQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1l bnVMaXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TWVudUxpc3QuY3BwCShyZXZpc2lvbiAxMTE2NjgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTWVudUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDgsMTEgKzMwOCwxMSBA QCB2b2lkIFJlbmRlck1lbnVMaXN0OjpzaG93UG9wdXAoKQogICAgIC8vIENvbXB1dGUgdGhlIHRv cCBsZWZ0IHRha2luZyB0cmFuc2Zvcm1zIGludG8gYWNjb3VudCwgYnV0IHVzZQogICAgIC8vIHRo ZSBhY3R1YWwgd2lkdGggb2YgdGhlIGVsZW1lbnQgdG8gc2l6ZSB0aGUgcG9wdXAuCiAgICAgRmxv YXRQb2ludCBhYnNUb3BMZWZ0ID0gbG9jYWxUb0Fic29sdXRlKEZsb2F0UG9pbnQoKSwgZmFsc2Us IHRydWUpOwotICAgIExheW91dFJlY3QgYWJzQm91bmRzID0gYWJzb2x1dGVCb3VuZGluZ0JveFJl Y3RJZ25vcmluZ1RyYW5zZm9ybXMoKTsKKyAgICBJbnRSZWN0IGFic0JvdW5kcyA9IGFic29sdXRl Qm91bmRpbmdCb3hSZWN0SWdub3JpbmdUcmFuc2Zvcm1zKCk7CiAgICAgaW50IHNjYWxlID0gZG9j dW1lbnQoKS0+cGFnZSgpLT5zZXR0aW5ncygpLT5kZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3IoKTsK ICAgICBpZiAoc2NhbGUgJiYgc2NhbGUgIT0gMSkKICAgICAgICAgYWJzQm91bmRzLnNjYWxlKHNj YWxlKTsKLSAgICBhYnNCb3VuZHMuc2V0TG9jYXRpb24ocm91bmRlZExheW91dFBvaW50KGFic1Rv cExlZnQpKTsKKyAgICBhYnNCb3VuZHMuc2V0TG9jYXRpb24ocm91bmRlZEludFBvaW50KGFic1Rv cExlZnQpKTsKICAgICBIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0ID0gdG9IVE1MU2VsZWN0RWxl bWVudChub2RlKCkpOwogICAgIG1fcG9wdXAtPnNob3coYWJzQm91bmRzLCBkb2N1bWVudCgpLT52 aWV3KCksIHNlbGVjdC0+b3B0aW9uVG9MaXN0SW5kZXgoc2VsZWN0LT5zZWxlY3RlZEluZGV4KCkp KTsKIH0KQEAgLTUxMSwxMyArNTExLDEzIEBAIGludCBSZW5kZXJNZW51TGlzdDo6Y2xpZW50SW5z ZXRSaWdodCgpIGMKICAgICByZXR1cm4gMDsKIH0KIAotaW50IFJlbmRlck1lbnVMaXN0OjpjbGll bnRQYWRkaW5nTGVmdCgpIGNvbnN0CitMYXlvdXRVbml0IFJlbmRlck1lbnVMaXN0OjpjbGllbnRQ YWRkaW5nTGVmdCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIHBhZGRpbmdMZWZ0KCkgKyBtX2lubmVy QmxvY2stPnBhZGRpbmdMZWZ0KCk7CiB9CiAKIGNvbnN0IGludCBlbmRPZkxpbmVQYWRkaW5nID0g MjsKLWludCBSZW5kZXJNZW51TGlzdDo6Y2xpZW50UGFkZGluZ1JpZ2h0KCkgY29uc3QKK0xheW91 dFVuaXQgUmVuZGVyTWVudUxpc3Q6OmNsaWVudFBhZGRpbmdSaWdodCgpIGNvbnN0CiB7CiAgICAg aWYgKHN0eWxlKCktPmFwcGVhcmFuY2UoKSA9PSBNZW51bGlzdFBhcnQgfHwgc3R5bGUoKS0+YXBw ZWFyYW5jZSgpID09IE1lbnVsaXN0QnV0dG9uUGFydCkgewogICAgICAgICAvLyBGb3IgdGhlc2Ug YXBwZWFyYW5jZSB2YWx1ZXMsIHRoZSB0aGVtZSBhcHBsaWVzIHBhZGRpbmcgdG8gbGVhdmUgcm9v bSBmb3IgdGhlCg==