82045 2012-03-23 04:23:18 -0700 The JSC code generator can't handle boolean arguments for Callbacks 2012-03-23 06:01:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 81657 1 tommyw tommyw abarth haraken japhet ojan webkit.review.bot oldest_to_newest 586218 0 tommyw 2012-03-23 04:23:18 -0700 CodeGeneratorJS.pm only handles DOMStrings and objects as arguments for a Callback, so I added support for boolean values as well. 586227 1 133459 tommyw 2012-03-23 04:36:54 -0700 Created attachment 133459 Patch 586231 2 133459 haraken 2012-03-23 04:41:58 -0700 Comment on attachment 133459 Patch OK! 586232 3 133459 haraken 2012-03-23 04:42:40 -0700 Comment on attachment 133459 Patch Oops, would you please add run-bindings-tests? https://trac.webkit.org/wiki/WebKitIDL#RunBindingsTests 586240 4 133463 tommyw 2012-03-23 05:10:28 -0700 Created attachment 133463 Patch 586244 5 133463 haraken 2012-03-23 05:18:20 -0700 Comment on attachment 133463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review > Source/WebCore/bindings/scripts/test/TestCallback.idl:42 > + boolean callbackWithBoolean(in boolean boolParam); Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. 586247 6 133463 tommyw 2012-03-23 05:25:46 -0700 Comment on attachment 133463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review >> Source/WebCore/bindings/scripts/test/TestCallback.idl:42 >> + boolean callbackWithBoolean(in boolean boolParam); > > Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. This IS in TestCallback.idl... 586250 7 133463 haraken 2012-03-23 05:27:23 -0700 Comment on attachment 133463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review >>> Source/WebCore/bindings/scripts/test/TestCallback.idl:42 >>> + boolean callbackWithBoolean(in boolean boolParam); >> >> Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. > > This IS in TestCallback.idl... Sorry for the repeated confusion:) 586260 8 133463 webkit.review.bot 2012-03-23 06:01:51 -0700 Comment on attachment 133463 Patch Clearing flags on attachment: 133463 Committed r111853: <http://trac.webkit.org/changeset/111853> 586261 9 webkit.review.bot 2012-03-23 06:01:56 -0700 All reviewed patches have been landed. Closing bug. 133459 2012-03-23 04:36:54 -0700 2012-03-23 05:10:22 -0700 Patch bug-82045-20120323123652.patch text/plain 1706 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU4NTE3MTI5MGRkZmEx ZGRlZTA3ZWE2MWEyYjMzMDY1MmJhNGIwZi4uM2Y1NjM0OTFiNWJmNjhkYzBiMTUzNjk4YzNjNjgz MThmZjE1MTY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTIzICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIFRoZSBKU0MgY29k ZSBnZW5lcmF0b3IgY2FuJ3QgaGFuZGxlIGJvb2xlYW4gYXJndW1lbnRzIGZvciBDYWxsYmFja3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDQ1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29kZUdlbmVy YXRvckpTLnBtIG9ubHkgaGFuZGxlcyBET01TdHJpbmdzIGFuZCBvYmplY3RzIGFzIGFyZ3VtZW50 cworICAgICAgICBmb3IgYSBDYWxsYmFjaywgc28gSSBhZGRlZCBzdXBwb3J0IGZvciBib29sZWFu IHZhbHVlcyBhcyB3ZWxsLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUNhbGxiYWNrSW1wbGVtZW50YXRpb24pOgorCiAy MDEyLTAzLTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIGNz c1RleHQgc2hvdWxkIHVzZSBTdHJpbmdCdWlsZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IGIwYmY2N2FiNjBkOWIyNmNl OGFlNjEyY2JkMGEwZGMzZmI5ZDllMzMuLjQ2NTkxNWJkNjBmMTUyNjExMTcyMGMyN2ZlZTA5ZDNl YjQ5ZmRlOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCkBAIC0yNzE1LDYgKzI3MTUsOCBAQCBzdWIgR2VuZXJhdGVDYWxsYmFj a0ltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAgICAgbXkgJHBhcmFtTmFtZSA9ICRwYXJhbS0+ bmFtZTsKICAgICAgICAgICAgICAgICBpZiAoJHBhcmFtLT50eXBlIGVxICJET01TdHJpbmciKSB7 CiAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGFyZ3MuYXBwZW5k KGpzU3RyaW5nKGV4ZWMsICR7cGFyYW1OYW1lfSkpO1xuIik7CisgICAgICAgICAgICAgICAgfSBl bHNpZiAoJHBhcmFtLT50eXBlIGVxICJib29sZWFuIikgeworICAgICAgICAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICBhcmdzLmFwcGVuZChqc0Jvb2xlYW4oJHtwYXJhbU5hbWV9 KSk7XG4iKTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICBhcmdzLmFwcGVuZCh0b0pTKGV4ZWMsIG1fZGF0YS0+Z2xv YmFsT2JqZWN0KCksICR7cGFyYW1OYW1lfSkpO1xuIik7CiAgICAgICAgICAgICAgICAgfQo= 133463 2012-03-23 05:10:28 -0700 2012-03-23 06:01:51 -0700 Patch bug-82045-20120323131027.patch text/plain 12076 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmE0YzNjNzk2MzdhYmY4 NTk0NTYwY2U2OWFjOTM4YzdmMzA5Mjg1Ni4uZTI5YTg3NTQyYzE5N2NmNGNkNjRlOGY5NGE4ZTg5 YzI1Zjg1NWNjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDEyLTAzLTIzICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIFRoZSBKU0MgY29k ZSBnZW5lcmF0b3IgY2FuJ3QgaGFuZGxlIGJvb2xlYW4gYXJndW1lbnRzIGZvciBDYWxsYmFja3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDQ1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29kZUdlbmVy YXRvckpTLnBtIG9ubHkgaGFuZGxlcyBET01TdHJpbmdzIGFuZCBvYmplY3RzIGFzIGFyZ3VtZW50 cworICAgICAgICBmb3IgYSBDYWxsYmFjaywgc28gSSBhZGRlZCBzdXBwb3J0IGZvciBib29sZWFu IHZhbHVlcyBhcyB3ZWxsLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUNhbGxiYWNrSW1wbGVtZW50YXRpb24pOgorICAg ICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdENhbGxiYWNrLmNwcDoK KyAgICAgICAgKFdlYkRPTVRlc3RDYWxsYmFjazo6Y2FsbGJhY2tXaXRoQm9vbGVhbik6CisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suaDoKKyAg ICAgICAgKFdlYkRPTVRlc3RDYWxsYmFjayk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdENhbGxiYWNrLmNwcDoKKyAgICAgICAgKHdlYmtpdF9k b21fdGVzdF9jYWxsYmFja19jYWxsYmFja193aXRoX2Jvb2xlYW4pOgorICAgICAgICAqIGJpbmRp bmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RDYWxsYmFjay5oOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5jcHA6CisgICAgICAg IChXZWJDb3JlOjpKU1Rlc3RDYWxsYmFjazo6Y2FsbGJhY2tXaXRoQm9vbGVhbik6CisgICAgICAg IChXZWJDb3JlKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2Fs bGJhY2suaDoKKyAgICAgICAgKEpTVGVzdENhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJhY2suaDoKKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJhY2subW06CisgICAgICAgICgtW0RPTVRlc3RD YWxsYmFjayBjYWxsYmFja1dpdGhCb29sZWFuOl0pOgorICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvdGVzdC9UZXN0Q2FsbGJhY2suaWRsOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVz dC9WOC9WOFRlc3RDYWxsYmFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFRlc3RDYWxsYmFj azo6Y2FsbGJhY2tXaXRoQm9vbGVhbik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBi aW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0Q2FsbGJhY2suaDoKKyAgICAgICAgKFY4VGVz dENhbGxiYWNrKToKKwogMjAxMi0wMy0yMyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmViYXNlbGluZWQgcnVuLWJpbmRpbmdzLXRl c3RzIHJlc3VsdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCmluZGV4IGIwYmY2N2FiNjBkOWIyNmNlOGFlNjEyY2JkMGEwZGMzZmI5 ZDllMzMuLjQ2NTkxNWJkNjBmMTUyNjExMTcyMGMyN2ZlZTA5ZDNlYjQ5ZmRlOGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBA IC0yNzE1LDYgKzI3MTUsOCBAQCBzdWIgR2VuZXJhdGVDYWxsYmFja0ltcGxlbWVudGF0aW9uCiAg ICAgICAgICAgICAgICAgbXkgJHBhcmFtTmFtZSA9ICRwYXJhbS0+bmFtZTsKICAgICAgICAgICAg ICAgICBpZiAoJHBhcmFtLT50eXBlIGVxICJET01TdHJpbmciKSB7CiAgICAgICAgICAgICAgICAg ICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGFyZ3MuYXBwZW5kKGpzU3RyaW5nKGV4ZWMsICR7 cGFyYW1OYW1lfSkpO1xuIik7CisgICAgICAgICAgICAgICAgfSBlbHNpZiAoJHBhcmFtLT50eXBl IGVxICJib29sZWFuIikgeworICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwg IiAgICBhcmdzLmFwcGVuZChqc0Jvb2xlYW4oJHtwYXJhbU5hbWV9KSk7XG4iKTsKICAgICAgICAg ICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwg IiAgICBhcmdzLmFwcGVuZCh0b0pTKGV4ZWMsIG1fZGF0YS0+Z2xvYmFsT2JqZWN0KCksICR7cGFy YW1OYW1lfSkpO1xuIik7CiAgICAgICAgICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJh Y2suY3BwCmluZGV4IGEwODJjNGFkMzk3MTc1MzNmYjk2ZjRkZjQ2ODgxOTQ4YmI1ZDhiOTYuLmEz MzQwMTk2MmZhMWE2YzU4MDEwNGNhOTk1YTQzNWIyNjM3YzEyYjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdENhbGxiYWNrLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRl c3RDYWxsYmFjay5jcHAKQEAgLTEyNSw2ICsxMjUsMTQgQEAgYm9vbCBXZWJET01UZXN0Q2FsbGJh Y2s6OmNhbGxiYWNrV2l0aFN0cmluZ0xpc3QoY29uc3QgV2ViRE9NRE9NU3RyaW5nTGlzdCYgbGlz dFAKICAgICByZXR1cm4gaW1wbCgpLT5jYWxsYmFja1dpdGhTdHJpbmdMaXN0KHRvV2ViQ29yZShs aXN0UGFyYW0pKTsKIH0KIAorYm9vbCBXZWJET01UZXN0Q2FsbGJhY2s6OmNhbGxiYWNrV2l0aEJv b2xlYW4oYm9vbCBib29sUGFyYW0pCit7CisgICAgaWYgKCFpbXBsKCkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKworICAgIHJldHVybiBpbXBsKCktPmNhbGxiYWNrV2l0aEJvb2xlYW4oYm9vbFBh cmFtKTsKK30KKwogV2ViQ29yZTo6VGVzdENhbGxiYWNrKiB0b1dlYkNvcmUoY29uc3QgV2ViRE9N VGVzdENhbGxiYWNrJiB3cmFwcGVyKQogewogICAgIHJldHVybiB3cmFwcGVyLmltcGwoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9N VGVzdENhbGxiYWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQ L1dlYkRPTVRlc3RDYWxsYmFjay5oCmluZGV4IGNlYzhiNmMzYzgyMWY3YjIyNTRiYTk1NDI3NmM2 YjQwNWUxMTdkNTguLjEyYmJmNzc0NTU3ZGM0MDYwMDkyZmM0OWRhNjA2NGUwNjYwMzJhMTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9N VGVzdENhbGxiYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suaApAQCAtNTAsNiArNTAsNyBAQCBwdWJsaWM6CiAgICAg Ym9vbCBjYWxsYmFja1dpdGhDbGFzczJQYXJhbShjb25zdCBXZWJET01DbGFzczImIGNsYXNzMlBh cmFtLCBjb25zdCBXZWJET01TdHJpbmcmIHN0ckFyZyk7CiAgICAgaW50IGNhbGxiYWNrV2l0aE5v bkJvb2xSZXR1cm5UeXBlKGNvbnN0IFdlYkRPTUNsYXNzMyYgY2xhc3MzUGFyYW0pOwogICAgIGJv b2wgY2FsbGJhY2tXaXRoU3RyaW5nTGlzdChjb25zdCBXZWJET01ET01TdHJpbmdMaXN0JiBsaXN0 UGFyYW0pOworICAgIGJvb2wgY2FsbGJhY2tXaXRoQm9vbGVhbihib29sIGJvb2xQYXJhbSk7CiAK ICAgICBXZWJDb3JlOjpUZXN0Q2FsbGJhY2sqIGltcGwoKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVz dENhbGxiYWNrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2Jq ZWN0L1dlYktpdERPTVRlc3RDYWxsYmFjay5jcHAKaW5kZXggNzI0MTJmNmY3NGE1NDU0NGU0OTFi NjNlYWM5YTNkNjFiZTgxMTVmNC4uZGI3YmM1ZGJjYzAxZjAwNzYwNTVkNDhjZDQ5ZDIyNTYzZWUw YzFkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dP YmplY3QvV2ViS2l0RE9NVGVzdENhbGxiYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0Q2FsbGJhY2suY3BwCkBAIC0x MzUsNiArMTM1LDE2IEBAIHdlYmtpdF9kb21fdGVzdF9jYWxsYmFja19jYWxsYmFja193aXRoX3N0 cmluZ19saXN0KFdlYktpdERPTVRlc3RDYWxsYmFjayogc2VsZiwKICAgICByZXR1cm4gcmVzOwog fQogCitnYm9vbGVhbgord2Via2l0X2RvbV90ZXN0X2NhbGxiYWNrX2NhbGxiYWNrX3dpdGhfYm9v bGVhbihXZWJLaXRET01UZXN0Q2FsbGJhY2sqIHNlbGYsIGdib29sZWFuIGJvb2xfcGFyYW0pCit7 CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoc2VsZiwgMCk7CisgICAgV2ViQ29yZTo6SlNNYWlu VGhyZWFkTnVsbFN0YXRlIHN0YXRlOworICAgIFdlYkNvcmU6OlRlc3RDYWxsYmFjayAqIGl0ZW0g PSBXZWJLaXQ6OmNvcmUoc2VsZik7CisgICAgZ2Jvb2xlYW4gcmVzID0gaXRlbS0+Y2FsbGJhY2tX aXRoQm9vbGVhbihib29sX3BhcmFtKTsKKyAgICByZXR1cm4gcmVzOworfQorCiAKIEdfREVGSU5F X1RZUEUoV2ViS2l0RE9NVGVzdENhbGxiYWNrLCB3ZWJraXRfZG9tX3Rlc3RfY2FsbGJhY2ssIFdF QktJVF9UWVBFX0RPTV9PQkpFQ1QpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RDYWxsYmFjay5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdENhbGxi YWNrLmgKaW5kZXggM2MwMWZhMjJmNWNlM2NmMjA1NmQ0NDg2ZmU2ODhlNjdmODRhNWQzYy4uYzBk NzQzNGQ4YzFmNGViZmJmNjYxYjU2MzgyMTNhMGU3MjIzMGU2NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdENhbGxi YWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3Qv V2ViS2l0RE9NVGVzdENhbGxiYWNrLmgKQEAgLTEwMSw2ICsxMDEsMTcgQEAgd2Via2l0X2RvbV90 ZXN0X2NhbGxiYWNrX2NhbGxiYWNrX3dpdGhfbm9uX2Jvb2xfcmV0dXJuX3R5cGUoV2ViS2l0RE9N VGVzdENhbGxiYWMKIFdFQktJVF9BUEkgZ2Jvb2xlYW4KIHdlYmtpdF9kb21fdGVzdF9jYWxsYmFj a19jYWxsYmFja193aXRoX3N0cmluZ19saXN0KFdlYktpdERPTVRlc3RDYWxsYmFjayogc2VsZiwg V2ViS2l0RE9NRE9NU3RyaW5nTGlzdCogbGlzdF9wYXJhbSk7CiAKKy8qKgorICogd2Via2l0X2Rv bV90ZXN0X2NhbGxiYWNrX2NhbGxiYWNrX3dpdGhfYm9vbGVhbjoKKyAqIEBzZWxmOiBBICNXZWJL aXRET01UZXN0Q2FsbGJhY2sKKyAqIEBib29sX3BhcmFtOiBBICNnYm9vbGVhbgorICoKKyAqIFJl dHVybnM6CisgKgorKiovCitXRUJLSVRfQVBJIGdib29sZWFuCit3ZWJraXRfZG9tX3Rlc3RfY2Fs bGJhY2tfY2FsbGJhY2tfd2l0aF9ib29sZWFuKFdlYktpdERPTVRlc3RDYWxsYmFjayogc2VsZiwg Z2Jvb2xlYW4gYm9vbF9wYXJhbSk7CisKIEdfRU5EX0RFQ0xTCiAKICNlbmRpZiAvKiBXZWJLaXRE T01UZXN0Q2FsbGJhY2tfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0pTL0pTVGVzdENhbGxiYWNrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5jcHAKaW5kZXggZmMxNDYxYmRkOTM1 MTk5MWNlYTdlY2M5YzU5OGQ4Mzk1MDg2MjFjNS4uNzBiZTliNjE5MTRmMWRlMGQyZjUxYWZiOTNl MTgwNWI2OWNiNzBjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdENhbGxiYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suY3BwCkBAIC0xMjgsNiArMTI4LDI0IEBA IGJvb2wgSlNUZXN0Q2FsbGJhY2s6OmNhbGxiYWNrV2l0aFN0cmluZ0xpc3QoRE9NU3RyaW5nTGlz dCogbGlzdFBhcmFtKQogICAgIHJldHVybiAhcmFpc2VkRXhjZXB0aW9uOwogfQogCitib29sIEpT VGVzdENhbGxiYWNrOjpjYWxsYmFja1dpdGhCb29sZWFuKGJvb2wgYm9vbFBhcmFtKQoreworICAg IGlmICghY2FuSW52b2tlQ2FsbGJhY2soKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBS ZWZQdHI8SlNUZXN0Q2FsbGJhY2s+IHByb3RlY3QodGhpcyk7CisKKyAgICBKU0xvY2sgbG9jayhT aWxlbmNlQXNzZXJ0aW9uc09ubHkpOworCisgICAgRXhlY1N0YXRlKiBleGVjID0gbV9kYXRhLT5n bG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpOworICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyIGFy Z3M7CisgICAgYXJncy5hcHBlbmQoanNCb29sZWFuKGJvb2xQYXJhbSkpOworCisgICAgYm9vbCBy YWlzZWRFeGNlcHRpb24gPSBmYWxzZTsKKyAgICBtX2RhdGEtPmludm9rZUNhbGxiYWNrKGFyZ3Ms ICZyYWlzZWRFeGNlcHRpb24pOworICAgIHJldHVybiAhcmFpc2VkRXhjZXB0aW9uOworfQorCiB9 CiAKICNlbmRpZiAvLyBFTkFCTEUoU1FMX0RBVEFCQVNFKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdENhbGxiYWNrLmggYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suaAppbmRleCBh NmYzY2NlMWUwNDk3OGY2MGY1NGRkOGVkNTE2ZmJhMTE0NWFiMjhhLi5kYzM4NjliOTVhZDdkOTI1 N2NkMWRkNDhkNjllMzQ3MTVhNDdlMGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suaApAQCAtNDYsNiArNDYs NyBAQCBwdWJsaWM6CiAgICAgQ09NUElMRV9BU1NFUlQoZmFsc2UpICAgIHZpcnR1YWwgaW50IGNh bGxiYWNrV2l0aE5vbkJvb2xSZXR1cm5UeXBlKENsYXNzMyogY2xhc3MzUGFyYW0pOwogICAgIHZp cnR1YWwgaW50IGN1c3RvbUNhbGxiYWNrKENsYXNzNSogY2xhc3M1UGFyYW0sIENsYXNzNiogY2xh c3M2UGFyYW0pOwogICAgIHZpcnR1YWwgYm9vbCBjYWxsYmFja1dpdGhTdHJpbmdMaXN0KERPTVN0 cmluZ0xpc3QqIGxpc3RQYXJhbSk7CisgICAgdmlydHVhbCBib29sIGNhbGxiYWNrV2l0aEJvb2xl YW4oYm9vbCBib29sUGFyYW0pOwogCiBwcml2YXRlOgogICAgIEpTVGVzdENhbGxiYWNrKEpTQzo6 SlNPYmplY3QqIGNhbGxiYWNrLCBKU0RPTUdsb2JhbE9iamVjdCopOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L09iakMvRE9NVGVzdENhbGxiYWNrLmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJh Y2suaAppbmRleCAzZDZmN2JkOTMwOTJhNzk5NTYxOTUxNTM2ZDQxOWFhNjhjNDZiZTY1Li5kM2Rm MTAwMDExZDc5Y2JlYTdkMjYzYzgxZDc2ZDhkY2EyYWY3YzM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJhY2suaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJh Y2suaApAQCAtNDMsNiArNDMsNyBAQAogLSAoaW50KWNhbGxiYWNrV2l0aE5vbkJvb2xSZXR1cm5U eXBlOihET01DbGFzczMgKiljbGFzczNQYXJhbTsKIC0gKGludCljdXN0b21DYWxsYmFjazooRE9N Q2xhc3M1ICopY2xhc3M1UGFyYW0gY2xhc3M2UGFyYW06KERPTUNsYXNzNiAqKWNsYXNzNlBhcmFt OwogLSAoQk9PTCljYWxsYmFja1dpdGhTdHJpbmdMaXN0OihET01ET01TdHJpbmdMaXN0ICopbGlz dFBhcmFtOworLSAoQk9PTCljYWxsYmFja1dpdGhCb29sZWFuOihCT09MKWJvb2xQYXJhbTsKIEBl bmQKIAogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJhY2subW0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvT2JqQy9ET01UZXN0Q2FsbGJhY2subW0KaW5kZXggOWIwODY2YzlhNDgxODMy M2M5ODM3ZGViODlhMGJhOTFjMjRjNzMyZC4uNGIwMGE0NzU5ZjE3NmNjZjFkNThkZWFhZjRjNmYy Njk1NGFmNDYyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L09iakMvRE9NVGVzdENhbGxiYWNrLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9PYmpDL0RPTVRlc3RDYWxsYmFjay5tbQpAQCAtMTE3LDYgKzExNywxMiBA QAogICAgIHJldHVybiBJTVBMLT5jYWxsYmFja1dpdGhTdHJpbmdMaXN0KGNvcmUobGlzdFBhcmFt KSk7CiB9CiAKKy0gKEJPT0wpY2FsbGJhY2tXaXRoQm9vbGVhbjooQk9PTClib29sUGFyYW0KK3sK KyAgICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7CisgICAgcmV0dXJuIElN UEwtPmNhbGxiYWNrV2l0aEJvb2xlYW4oYm9vbFBhcmFtKTsKK30KKwogQGVuZAogCiBXZWJDb3Jl OjpUZXN0Q2FsbGJhY2sqIGNvcmUoRE9NVGVzdENhbGxiYWNrICp3cmFwcGVyKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RDYWxsYmFjay5pZGwg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdENhbGxiYWNrLmlkbApp bmRleCA5ZTFmMDZlNDBjNjZlNDczMTBjZDJiYTIwMDVkYjU4ZDMxMzA5OGU5Li5iYjE4ZjRlNzRl MjU0YmVlMTFiMGQyNWNiMGM2Zjg1MmY2YWQ5OTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdENhbGxiYWNrLmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdENhbGxiYWNrLmlkbApAQCAtMzksNSArMzks NiBAQCBtb2R1bGUgdGVzdCB7CiAgICAgICBsb25nIGNhbGxiYWNrV2l0aE5vbkJvb2xSZXR1cm5U eXBlKGluIENsYXNzMyBjbGFzczNQYXJhbSk7CiAgICAgICBbQ3VzdG9tXSBsb25nIGN1c3RvbUNh bGxiYWNrKGluIENsYXNzNSBjbGFzczVQYXJhbSwgaW4gQ2xhc3M2IGNsYXNzNlBhcmFtKTsKICAg ICAgIGJvb2xlYW4gY2FsbGJhY2tXaXRoU3RyaW5nTGlzdChpbiBET01TdHJpbmdMaXN0IGxpc3RQ YXJhbSk7CisgICAgICBib29sZWFuIGNhbGxiYWNrV2l0aEJvb2xlYW4oaW4gYm9vbGVhbiBib29s UGFyYW0pOwogICAgIH07CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvVjgvVjhUZXN0Q2FsbGJhY2suY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdENhbGxiYWNrLmNwcAppbmRleCAzYTE3ZjdhM2JkMWYy MzUyZTUxMDE4MmI3NmUyOWM0NGM4ZmIzZGRkLi41ZWUxYjE0ZjI2MmYzZGM0NGMzYjU2MzU2NDk5 NDg0YmQ0ZDU4NDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVjgvVjhUZXN0Q2FsbGJhY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RDYWxsYmFjay5jcHAKQEAgLTE2Myw2ICsxNjMsMzQgQEAg Ym9vbCBWOFRlc3RDYWxsYmFjazo6Y2FsbGJhY2tXaXRoU3RyaW5nTGlzdChSZWZQdHI8RE9NU3Ry aW5nTGlzdD4gbGlzdFBhcmFtKQogICAgIHJldHVybiAhaW52b2tlQ2FsbGJhY2sobV9jYWxsYmFj aywgMSwgYXJndiwgY2FsbGJhY2tSZXR1cm5WYWx1ZSwgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp KTsKIH0KIAorYm9vbCBWOFRlc3RDYWxsYmFjazo6Y2FsbGJhY2tXaXRoQm9vbGVhbihib29sIGJv b2xQYXJhbSkKK3sKKyAgICBpZiAoIWNhbkludm9rZUNhbGxiYWNrKCkpCisgICAgICAgIHJldHVy biB0cnVlOworCisgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOworCisgICAgdjg6Okhh bmRsZTx2ODo6Q29udGV4dD4gdjhDb250ZXh0ID0gdG9WOENvbnRleHQoc2NyaXB0RXhlY3V0aW9u Q29udGV4dCgpLCBtX3dvcmxkQ29udGV4dCk7CisgICAgaWYgKHY4Q29udGV4dC5Jc0VtcHR5KCkp CisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKHY4 Q29udGV4dCk7CisKKyAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gYm9vbFBhcmFtSGFuZGxlID0g djhCb29sZWFuKGJvb2xQYXJhbSk7CisgICAgaWYgKGJvb2xQYXJhbUhhbmRsZS5Jc0VtcHR5KCkp IHsKKyAgICAgICAgaWYgKCFpc1NjcmlwdENvbnRyb2xsZXJUZXJtaW5hdGluZygpKQorICAgICAg ICAgICAgQ1JBU0goKTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorCisgICAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IGFyZ3ZbXSA9IHsKKyAgICAgICAgYm9vbFBhcmFtSGFuZGxlCisgICAg fTsKKworICAgIGJvb2wgY2FsbGJhY2tSZXR1cm5WYWx1ZSA9IGZhbHNlOworICAgIHJldHVybiAh aW52b2tlQ2FsbGJhY2sobV9jYWxsYmFjaywgMSwgYXJndiwgY2FsbGJhY2tSZXR1cm5WYWx1ZSwg c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQog CiAjZW5kaWYgLy8gRU5BQkxFKFNRTF9EQVRBQkFTRSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RDYWxsYmFjay5oIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdENhbGxiYWNrLmgKaW5kZXggNzI5 ODBmMmNlODFiNDcxOGQ5NjVhMWU3MDI2YTY1MzgzM2YwZGM3NS4uZTFhMjNlMDM0NmIwNTZjNzk1 NmJmM2M1ODVjZTEwY2EzODlmNDRkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdENhbGxiYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdENhbGxiYWNrLmgKQEAgLTUxLDYgKzUxLDcg QEAgcHVibGljOgogICAgIENPTVBJTEVfQVNTRVJUKGZhbHNlKSAgICB2aXJ0dWFsIGludCBjYWxs YmFja1dpdGhOb25Cb29sUmV0dXJuVHlwZShDbGFzczMqIGNsYXNzM1BhcmFtKTsKICAgICB2aXJ0 dWFsIGludCBjdXN0b21DYWxsYmFjayhDbGFzczUqIGNsYXNzNVBhcmFtLCBDbGFzczYqIGNsYXNz NlBhcmFtKTsKICAgICB2aXJ0dWFsIGJvb2wgY2FsbGJhY2tXaXRoU3RyaW5nTGlzdChSZWZQdHI8 RE9NU3RyaW5nTGlzdD4gbGlzdFBhcmFtKTsKKyAgICB2aXJ0dWFsIGJvb2wgY2FsbGJhY2tXaXRo Qm9vbGVhbihib29sIGJvb2xQYXJhbSk7CiAKIHByaXZhdGU6CiAgICAgVjhUZXN0Q2FsbGJhY2so djg6OkxvY2FsPHY4OjpPYmplY3Q+LCBTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7Cg==