81964 2012-03-22 14:15:48 -0700 Improve soft hyphen testing 2012-03-23 09:12:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dtharp dtharp bdakin ossy rniwa tomz webkit.review.bot oldest_to_newest 585685 0 dtharp 2012-03-22 14:15:48 -0700 As part of a webkit patch (bug 76932) to fix the QT 4.8.0 soft hyphen problem, I created a layout test to expose the failure. The actual code patch was rejected (the team doesn't want a hack in webkit, they want a proper fix in QT), but the test itself adds value. This bug is for adding only the test. 585688 1 133342 dtharp 2012-03-22 14:18:30 -0700 Created attachment 133342 Patch 585808 2 133342 webkit.review.bot 2012-03-22 15:51:06 -0700 Comment on attachment 133342 Patch Rejecting attachment 133342 from commit-queue. dtharp@codeaurora.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 585937 3 133342 webkit.review.bot 2012-03-22 18:04:21 -0700 Comment on attachment 133342 Patch Clearing flags on attachment: 133342 Committed r111801: <http://trac.webkit.org/changeset/111801> 585938 4 webkit.review.bot 2012-03-22 18:04:25 -0700 All reviewed patches have been landed. Closing bug. 586153 5 rniwa 2012-03-23 00:50:34 -0700 The test added by this patch is failing on Qt bots :( http://build.webkit.org/results/Qt%20Linux%20Release/r111801%20(44828)/results.html 586154 6 rniwa 2012-03-23 00:51:50 -0700 +ossy. He can decide what to do with fast/text/soft-hyphen-5.html here. 586382 7 dtharp 2012-03-23 09:08:24 -0700 (In reply to comment #5) > The test added by this patch is failing on Qt bots :( > > http://build.webkit.org/results/Qt%20Linux%20Release/r111801%20(44828)/results.html What version of QT are the build bots using? It is possible that soft-hyphen is not yet supported in QTextBoundaryFinder in the version used by the build bots. It is likely this test is catching a real issue. See bug 76932. 586385 8 ossy 2012-03-23 09:12:34 -0700 It fails with Qt 4.8.0, so I skipped it - http://trac.webkit.org/changeset/111842/trunk/LayoutTests/platform/qt-4.8/Skipped 133342 2012-03-22 14:18:30 -0700 2012-03-22 18:04:21 -0700 Patch bug-81964-20120322141740.patch text/plain 2607 dtharp U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNzMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTQwOWEzMDc1M2E4MzFkNmY5Yjk0 OGJjYmJmZjhiOTY4N2Q1OTlmZi4uOWFmMGNjMGFkZjJjMjk1NjkxODA5ZDNkOGI4ZmYyNzJhNWQz YjczOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIyICBEYXZlIFRoYXJwICA8ZHRo YXJwQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFFUIDQuOCBzb2Z0IGh5cGhlbiBidWcgaGFz IG5vIGZhaWxpbmcgdGVzdCBjYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MTk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGluZyB0ZXN0IHRvIGV4cG9zZSBzb2Z0IGh5cGhlbiBwcm9ibGVtIGlu IFFUIDQuOC4wCisKKyAgICAgICAgKiBmYXN0L3RleHQvc29mdC1oeXBoZW4tNS1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9zb2Z0LWh5cGhlbi01Lmh0bWw6IEFkZGVk LgorCiAyMDEyLTAzLTIyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkZWQgZmFzdC9ldmVudHMvZHJhZy1saW5rLmh0bWwgdG8gdGhlIE1hYyBXZWJLaXQyIHNr aXAgbGlzdCwgYmVjYXVzZSBydW5uaW5nIGl0IGhhcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L3NvZnQtaHlwaGVuLTUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L3NvZnQtaHlwaGVuLTUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk0MzdkY2I5ODQzY2E2 YmNkYWQ2ZjgxMjIxNmVhNDRlOWQ0YjE0NDUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3RleHQvc29mdC1oeXBoZW4tNS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMCBAQAor U29mdCBIeXBoZW4gVGVzdAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitQQVNTIHRydWUgaXMg dHJ1ZQorYW50acKtZGlzwq1lc3TCrWFiwq1saXNowq1tZW50wq1hcmlhbsKtaXNtLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NvZnQtaHlwaGVuLTUuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvdGV4dC9zb2Z0LWh5cGhlbi01Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmI1OWY3ZDQxNzg1 OGIxNWRkYTJjNDhlZTI5MDdkMTU0YjAzNTc5ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvdGV4dC9zb2Z0LWh5cGhlbi01Lmh0bWwKQEAgLTAsMCArMSwyOSBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPG1ldGEgY2hhcnNldD0idXRmLTgiPgorPHNjcmlw dCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKTsiPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGRlc2Ny aXB0aW9uKCJTb2Z0IEh5cGhlbiBUZXN0Iik7CisKKyAgICAgICAgZnVuY3Rpb24gcnVuVGVzdCgp IHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAg ICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAg ICAvLyA1NiBpcyA0ICogdGhlIGZvbnQgc2l6ZSAoMTQpLiBXZSdyZSBleHBlY3RpbmcgdGhlIHRl eHQgdG8gYnJlYWsgdXAgaW50byA0IGxpbmVzLgorICAgICAgICAgICAgLy8gNCBsaW5lcyArIHRo ZSBwYWRkaW5nIGdpdmVzIGEgZGl2IGhlaWdodCBvZiA5MiBpbiB3ZWJraXQgYW5kIEZGLCA4OCBp biBjaHJvbWUuCisgICAgICAgICAgICAvLyBTbyBhbnl0aGluZyBsZXNzIHRoYW4gNTYgaXMgYSBG QUlMLgorICAgICAgICAgICAgdmFyIGRvZXNJdFBhc3MgPSBCb29sZWFuKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCd0ZXh0MScpLm9mZnNldEhlaWdodCA+IDU2KSA7CisgICAgICAgICAgICBzaG91 bGRCZVRydWUoU3RyaW5nKGRvZXNJdFBhc3MpKSA7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4K KworICAgIDxkaXYgaWQ9InRleHQxIiBzdHlsZT0id2lkdGg6MTUwcHg7IGZvbnQtZmFtaWx5OkFo ZW07IGZvbnQtc2l6ZToxNHB4OyBib3JkZXI6MnB4IHNvbGlkIHJlZCI+CisgICAgICAgIDxwPmFu dGkmc2h5O2RpcyZzaHk7ZXN0JnNoeTthYiZzaHk7bGlzaCZzaHk7bWVudCZzaHk7YXJpYW4mc2h5 O2lzbS48L3A+CisgICAgPC9kaXY+CisKKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K