81802 2012-03-21 10:39:56 -0700 REGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute 2012-03-26 09:52:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://trac.webkit.org/export/111546/trunk/LayoutTests/fast/forms/placeholder-set-attribute.html InRadar, LayoutTestFailure, Regression P1 Normal --- 1 mitz jchaffraix adele jchaffraix jonlee tkent webkit-bug-importer webkit.review.bot oldest_to_newest 584316 0 mitz 2012-03-21 10:39:56 -0700 To reproduce, open fast/forms/placeholder-set-attribute.html in Safari. Reload a few times. Occasionally, the placeholder is missing. Forcing a repaint makes it appear in those cases. This is causing intermittent pixel failures. 584318 1 webkit-bug-importer 2012-03-21 10:40:38 -0700 <rdar://problem/11091412> 584322 2 mitz 2012-03-21 10:42:43 -0700 This is a regression. It doesn’t happen in Safari 5.1.4. 584324 3 mitz 2012-03-21 10:43:48 -0700 Added this test to the Mac skipped list in <http://trac.webkit.org/r111571>. 584337 4 mitz 2012-03-21 10:50:44 -0700 This regression occurred between r110065 and r110080. It was most likely caused by <http://trac.webkit.org/r110072>, the fix for bug 75568. 586471 5 adele 2012-03-23 10:41:27 -0700 Julien, can you take a look at this? 586483 6 jchaffraix 2012-03-23 10:55:56 -0700 (In reply to comment #5) > Julien, can you take a look at this? Sure, sorry I am not as responsive as I would like on those regressions. I should have some time next week to investigate this bug. 586546 7 adele 2012-03-23 11:41:22 -0700 Thanks!! 587324 8 133687 jchaffraix 2012-03-25 12:36:14 -0700 Created attachment 133687 Proposed fix. Unfortunately no new test. 587343 9 133687 mitz 2012-03-25 13:52:27 -0700 Comment on attachment 133687 Proposed fix. Unfortunately no new test. View in context: https://bugs.webkit.org/attachment.cgi?id=133687&action=review r=me if you correct the style > Source/WebCore/ChangeLog:11 > + REGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute > + https://bugs.webkit.org/show_bug.cgi?id=81802 > + > + Reviewed by NOBODY (OOPS!). > + > + Covered by fast/forms/placeholder-set-attribute.html which should be less flaky. > + > + Unfortunately no new test case as this bug requires a very specific set of conditions that I couldn't reproduce deterministically. > + Can you explain how the change (presumably r110072) caused this regression? > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:297 > + if (!placeholderBoxHadLayout && placeholderBox->checkForRepaintDuringLayout()) > + // This assumes a shadow tree without floats. If floats are added, the > + // logic should be shared with RenderBlock::layoutBlockChild. > + placeholderBox->repaint(); This multi-line clause needs to be in braces. 587351 10 133687 jchaffraix 2012-03-25 14:20:27 -0700 Comment on attachment 133687 Proposed fix. Unfortunately no new test. View in context: https://bugs.webkit.org/attachment.cgi?id=133687&action=review >> Source/WebCore/ChangeLog:11 >> + > > Can you explain how the change (presumably r110072) caused this regression? Sure, currently repainting goes through different means and one of them is RenderLayer. In this case, the placeholder has overflow: hidden set and was implicitly relying on the layer to properly repaint the first time. r110072 removed the layer, removing also the first repaint. I will add this information in the ChangeLog. 587807 11 133826 jchaffraix 2012-03-26 09:10:19 -0700 Created attachment 133826 Patch for landing 587847 12 133826 webkit.review.bot 2012-03-26 09:52:17 -0700 Comment on attachment 133826 Patch for landing Clearing flags on attachment: 133826 Committed r112114: <http://trac.webkit.org/changeset/112114> 587848 13 webkit.review.bot 2012-03-26 09:52:23 -0700 All reviewed patches have been landed. Closing bug. 133687 2012-03-25 12:36:14 -0700 2012-03-26 09:10:15 -0700 Proposed fix. Unfortunately no new test. bug-81802-20120325123613.patch text/plain 4662 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTExOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI0MWYxOGYwMjFmY2Jm N2ZjNjM3ZTZkM2ZmNTZkNzA3YzhmMTVkOS4uOTU1ZWE4YjBkYzE3ZWE1ZmYwNzFlZWJkM2E0YmFl ZjhlN2RjZTRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTI1ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIxMTAwNjUtcjExMDA4MCk6IGZhc3QvZm9ybXMvcGxhY2Vob2xkZXItc2V0LWF0dHJpYnV0 ZS5odG1sIGlzIGZhaWxpbmcgaW50ZXJtaXR0ZW50bHkgYmVjYXVzZSBXZWJLaXQgZmFpbHMgdG8g cmVwYWludCBhZnRlciBzZXR0aW5nIHRoZSBwbGFjZWhvbGRlciBhdHRyaWJ1dGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxODAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2Zv cm1zL3BsYWNlaG9sZGVyLXNldC1hdHRyaWJ1dGUuaHRtbCB3aGljaCBzaG91bGQgYmUgbGVzcyBm bGFreS4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5IG5vIG5ldyB0ZXN0IGNhc2UgYXMgdGhpcyBi dWcgcmVxdWlyZXMgYSB2ZXJ5IHNwZWNpZmljIHNldCBvZiBjb25kaXRpb25zIHRoYXQgSSBjb3Vs ZG4ndCByZXByb2R1Y2UgZGV0ZXJtaW5pc3RpY2FsbHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clRleHRDb250cm9sU2luZ2xlTGluZTo6bGF5b3V0KToKKyAgICAgICAgRm9yIG91ciBmaXJzdCBs YXlvdXQsIHdlIG5lZWQgdG8gbWFrZSBzdXJlIG91ciBwbGFjZWhvbGRlciBpcyBwYWludGVkLiBs YXlvdXRCbG9ja0NoaWxkIGhhcyBhIHZlcnkgc2ltaWxhciBsb2dpYyB0byBmb3JjZSByZXBhaW50 CisgICAgICAgIG9uIGEgZmlyc3QgbGF5b3V0LiBXZSBkb24ndCBoaXQgdGhpcyBsb2dpYyBhcyB0 aGUgcGxhY2Vob2xkZXIgaXMgZXhwbGljaXRseSBza2lwcGVkIGluIFJlbmRlclRleHRDb250cm9s OjpsYXlvdXRTcGVjaWFsRXhjbHVkZWRDaGlsZC4KKwogMjAxMi0wMy0yMyAgVy4gSmFtZXMgTWFj TGVhbiAgPHdqbWFjbGVhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBDQ0xh eWVyVHJlZUhvc3RJbXBsOjpzY3JvbGxCZWdpbigpIHNob3VsZCByZXR1cm4gU2Nyb2xsRmFpbGVk IGZvciBDQ0lucHV0SGFuZGxlckNsaWVudDo6R2VzdHVyZSB0eXBlIHdoZW4gd2hlZWwgaGFuZGxl cnMgZm91bmQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU ZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwCmluZGV4IDNmZWNlZGFkMjMzOWJkMjllYTUwMGMwNDE1 MWZkMWVkNjY1YjhkMGQuLmEzNGVmZGYwNDFhYTY0Mjg0YzEwNDQyYjBhNWI0NjA1YThhMDMyMGEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNp bmdsZUxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29u dHJvbFNpbmdsZUxpbmUuY3BwCkBAIC0yODIsNiArMjgyLDcgQEAgdm9pZCBSZW5kZXJUZXh0Q29u dHJvbFNpbmdsZUxpbmU6OmxheW91dCgpCiAgICAgaWYgKFJlbmRlckJveCogcGxhY2Vob2xkZXJC b3ggPSBwbGFjZWhvbGRlckVsZW1lbnQgPyBwbGFjZWhvbGRlckVsZW1lbnQtPnJlbmRlckJveCgp IDogMCkgewogICAgICAgICBwbGFjZWhvbGRlckJveC0+c3R5bGUoKS0+c2V0V2lkdGgoTGVuZ3Ro KGlubmVyVGV4dFJlbmRlcmVyLT53aWR0aCgpIC0gcGxhY2Vob2xkZXJCb3gtPmJvcmRlckFuZFBh ZGRpbmdXaWR0aCgpLCBGaXhlZCkpOwogICAgICAgICBwbGFjZWhvbGRlckJveC0+c3R5bGUoKS0+ c2V0SGVpZ2h0KExlbmd0aChpbm5lclRleHRSZW5kZXJlci0+aGVpZ2h0KCkgLSBwbGFjZWhvbGRl ckJveC0+Ym9yZGVyQW5kUGFkZGluZ0hlaWdodCgpLCBGaXhlZCkpOworICAgICAgICBib29sIHBs YWNlaG9sZGVyQm94SGFkTGF5b3V0ID0gcGxhY2Vob2xkZXJCb3gtPmV2ZXJIYWRMYXlvdXQoKTsK ICAgICAgICAgcGxhY2Vob2xkZXJCb3gtPmxheW91dElmTmVlZGVkKCk7CiAgICAgICAgIExheW91 dFBvaW50IHRleHRPZmZzZXQgPSBpbm5lclRleHRSZW5kZXJlci0+bG9jYXRpb24oKTsKICAgICAg ICAgaWYgKGlubmVyQmxvY2tFbGVtZW50KCkgJiYgaW5uZXJCbG9ja0VsZW1lbnQoKS0+cmVuZGVy Qm94KCkpCkBAIC0yODksNiArMjkwLDExIEBAIHZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVM aW5lOjpsYXlvdXQoKQogICAgICAgICBpZiAoY29udGFpbmVyUmVuZGVyZXIpCiAgICAgICAgICAg ICB0ZXh0T2Zmc2V0ICs9IHRvTGF5b3V0U2l6ZShjb250YWluZXJSZW5kZXJlci0+bG9jYXRpb24o KSk7CiAgICAgICAgIHBsYWNlaG9sZGVyQm94LT5zZXRMb2NhdGlvbih0ZXh0T2Zmc2V0KTsKKwor ICAgICAgICBpZiAoIXBsYWNlaG9sZGVyQm94SGFkTGF5b3V0ICYmIHBsYWNlaG9sZGVyQm94LT5j aGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSkKKyAgICAgICAgICAgIC8vIFRoaXMgYXNzdW1l cyBhIHNoYWRvdyB0cmVlIHdpdGhvdXQgZmxvYXRzLiBJZiBmbG9hdHMgYXJlIGFkZGVkLCB0aGUK KyAgICAgICAgICAgIC8vIGxvZ2ljIHNob3VsZCBiZSBzaGFyZWQgd2l0aCBSZW5kZXJCbG9jazo6 bGF5b3V0QmxvY2tDaGlsZC4KKyAgICAgICAgICAgIHBsYWNlaG9sZGVyQm94LT5yZXBhaW50KCk7 CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGE1NzM5MWNlZWU1ODlkODEyMmY3NzM2NzcxZWE2NmNhMmMw NGQ3YS4uNDk1NzY0N2I5YWRkMzRlZjI5NTcwZGVkNjQ0ZDNlYWVkYjRiNDE5ZiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDEyLTAzLTI1ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3 ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMTAwNjUtcjExMDA4MCk6IGZhc3Qv Zm9ybXMvcGxhY2Vob2xkZXItc2V0LWF0dHJpYnV0ZS5odG1sIGlzIGZhaWxpbmcgaW50ZXJtaXR0 ZW50bHkgYmVjYXVzZSBXZWJLaXQgZmFpbHMgdG8gcmVwYWludCBhZnRlciBzZXR0aW5nIHRoZSBw bGFjZWhvbGRlciBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgxODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDogVW5za2lwIHRoZSB0ZXN0IG9uIE1h Yy4gVGhlIG90aGVyIHBsYXRmb3JtcyBhcmUgZWl0aGVyCisgICAgICAgIHNraXBwaW5nIGl0IGZv ciBvdGhlciByZWFzb25zIG9yIGRpZCBub3QgaGF2ZSBhIHNwZWNpZmljIGVudHJ5IGZvciB0aGUg Zmxha2luZXNzLgorCiAyMDEyLTAzLTIyICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgRml4IG1vcmUgQ2hyb21pdW0gMTAuNi8xMC41IHRlc3RzIHRoYXQgYnJva2Ug d2l0aCByMTExOTE3LiBUaGVyZSdzIGEgYnVnCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCmluZGV4 IDkxNDMzZTI4OGE1ZjFmMDM2NmY0ODAzN2ZkYWQyMjlkZjI4NWQwNjYuLmIwYjViNjIxNGQ4ZDQy MDgyZmM0MmQwYjgzNDQwMDVmNGRmNjFlNDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCkBA IC02MDgsMTAgKzYwOCw2IEBAIGZhc3Qvd29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNl LWluLXBhZ2UtYW5kLXdvcmtlcnMuaHRtbAogIyBBbGxvd2VkIHRvIHJlZ3Jlc3MgdG8gZml4IGEg Y3Jhc2guIAogZmFzdC9pbmxpbmUvY29udGludWF0aW9uLW91dGxpbmVzLXdpdGgtbGF5ZXJzLmh0 bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE4MDIgcmRh cjovL3Byb2JsZW0vMTEwOTE0MTIKLSMgZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1zZXQtYXR0cmli dXRlLmh0bWwgaXMgZmFpbGluZyBpbnRlcm1pdHRlbnRseSBiZWNhdXNlIFdlYktpdCBmYWlscyB0 byByZXBhaW50IGFmdGVyIHNldHRpbmcgdGhlIHBsYWNlaG9sZGVyIGF0dHJpYnV0ZQotZmFzdC9m b3Jtcy9wbGFjZWhvbGRlci1zZXQtYXR0cmlidXRlLmh0bWwKLQogIyBOb3QgcG9zc2libGUgdG8g c2V0IFVBIHN0cmluZyBmb3IgbWVkaWEgcmVxdWVzdHMgd2l0aCBhbGwgTWFjIG1lZGlhIGVuZ2lu ZXMuCiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXVzZXJhZ2VudC5odG1sCiAK 133826 2012-03-26 09:10:19 -0700 2012-03-26 09:52:17 -0700 Patch for landing bug-81802-20120326091018.patch text/plain 4860 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGEyNTYxZWE3MzY5OTNj ZTQ1MmZiYmQ0NzJhZmUwZTc3M2EzMjhhYy4uODBjZmZmOGExZjYxMzUwYjk2N2RhYjJkYWY0MmZh MzFjNmZjZjMxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTI2ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIxMTAwNjUtcjExMDA4MCk6IGZhc3QvZm9ybXMvcGxhY2Vob2xkZXItc2V0LWF0dHJpYnV0 ZS5odG1sIGlzIGZhaWxpbmcgaW50ZXJtaXR0ZW50bHkgYmVjYXVzZSBXZWJLaXQgZmFpbHMgdG8g cmVwYWludCBhZnRlciBzZXR0aW5nIHRoZSBwbGFjZWhvbGRlciBhdHRyaWJ1dGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxODAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KKworICAgICAgICBDb3ZlcmVkIGJ5IGZhc3QvZm9y bXMvcGxhY2Vob2xkZXItc2V0LWF0dHJpYnV0ZS5odG1sIHdoaWNoIHNob3VsZCBiZSBsZXNzIGZs YWt5LgorCisgICAgICAgIFVuZm9ydHVuYXRlbHkgbm8gbmV3IHRlc3QgY2FzZSBhcyB0aGlzIGJ1 ZyByZXF1aXJlcyBhIHZlcnkgc3BlY2lmaWMgc2V0IG9mIGNvbmRpdGlvbnMgdGhhdCBJIGNvdWxk bid0IHJlcHJvZHVjZSBkZXRlcm1pbmlzdGljYWxseS4KKworICAgICAgICBUaGlzIGlzIGEgcmVn cmVzc2lvbiBmcm9tIHIxMTAwNzI6IFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZSB3b3VsZCBy ZWx5IG9uIHRoZSBwbGFjZWhvbGRlcidzIFJlbmRlckxheWVyIHRvIHByb3Blcmx5IHJlcGFpbnQg ZHVyaW5nCisgICAgICAgIHRoZSBmaXJzdCBsYXlvdXQgYXMgdGhlIHBsYWNlaG9sZGVyIGhhcyBv dmVyZmxvdzogaGlkZGVuIHNldC4gcjExMDA3MiByZW1vdmVkIHRoZSBsYXllciBpbiB0aGlzIGNh c2UgYW5kIHRodXMgd2UgbWlzcyBhIHJlcGFpbnQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRl eHRDb250cm9sU2luZ2xlTGluZTo6bGF5b3V0KToKKyAgICAgICAgRm9yIG91ciBmaXJzdCBsYXlv dXQsIHdlIG5lZWQgdG8gbWFrZSBzdXJlIG91ciBwbGFjZWhvbGRlciBpcyBwYWludGVkLiBsYXlv dXRCbG9ja0NoaWxkIGhhcyBhIHZlcnkgc2ltaWxhciBsb2dpYyB0byBmb3JjZSByZXBhaW50Cisg ICAgICAgIG9uIGEgZmlyc3QgbGF5b3V0LiBXZSBkb24ndCBoaXQgdGhpcyBsb2dpYyBhcyB0aGUg cGxhY2Vob2xkZXIgaXMgZXhwbGljaXRseSBza2lwcGVkIGluIFJlbmRlclRleHRDb250cm9sOjps YXlvdXRTcGVjaWFsRXhjbHVkZWRDaGlsZC4KKwogMjAxMi0wMy0yNiAgTGVvIFlhbmcgIDxsZW8u eWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFNrZWxldG9u IGNvZGUgb2YgQXN5bmNGaWxlU3lzdGVtQmxhY2tCZXJyeS5jcHAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKaW5k ZXggM2ZlY2VkYWQyMzM5YmQyOWVhNTAwYzA0MTUxZmQxZWQ2NjViOGQwZC4uZTAwNTk4NzM2MDY1 YmFhYzBjY2QxZGViMDU0ZmI1Yzk5ZjdlNzk0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKQEAgLTI4Miw2 ICsyODIsNyBAQCB2b2lkIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6bGF5b3V0KCkKICAg ICBpZiAoUmVuZGVyQm94KiBwbGFjZWhvbGRlckJveCA9IHBsYWNlaG9sZGVyRWxlbWVudCA/IHBs YWNlaG9sZGVyRWxlbWVudC0+cmVuZGVyQm94KCkgOiAwKSB7CiAgICAgICAgIHBsYWNlaG9sZGVy Qm94LT5zdHlsZSgpLT5zZXRXaWR0aChMZW5ndGgoaW5uZXJUZXh0UmVuZGVyZXItPndpZHRoKCkg LSBwbGFjZWhvbGRlckJveC0+Ym9yZGVyQW5kUGFkZGluZ1dpZHRoKCksIEZpeGVkKSk7CiAgICAg ICAgIHBsYWNlaG9sZGVyQm94LT5zdHlsZSgpLT5zZXRIZWlnaHQoTGVuZ3RoKGlubmVyVGV4dFJl bmRlcmVyLT5oZWlnaHQoKSAtIHBsYWNlaG9sZGVyQm94LT5ib3JkZXJBbmRQYWRkaW5nSGVpZ2h0 KCksIEZpeGVkKSk7CisgICAgICAgIGJvb2wgcGxhY2Vob2xkZXJCb3hIYWRMYXlvdXQgPSBwbGFj ZWhvbGRlckJveC0+ZXZlckhhZExheW91dCgpOwogICAgICAgICBwbGFjZWhvbGRlckJveC0+bGF5 b3V0SWZOZWVkZWQoKTsKICAgICAgICAgTGF5b3V0UG9pbnQgdGV4dE9mZnNldCA9IGlubmVyVGV4 dFJlbmRlcmVyLT5sb2NhdGlvbigpOwogICAgICAgICBpZiAoaW5uZXJCbG9ja0VsZW1lbnQoKSAm JiBpbm5lckJsb2NrRWxlbWVudCgpLT5yZW5kZXJCb3goKSkKQEAgLTI4OSw2ICsyOTAsMTIgQEAg dm9pZCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OmxheW91dCgpCiAgICAgICAgIGlmIChj b250YWluZXJSZW5kZXJlcikKICAgICAgICAgICAgIHRleHRPZmZzZXQgKz0gdG9MYXlvdXRTaXpl KGNvbnRhaW5lclJlbmRlcmVyLT5sb2NhdGlvbigpKTsKICAgICAgICAgcGxhY2Vob2xkZXJCb3gt PnNldExvY2F0aW9uKHRleHRPZmZzZXQpOworCisgICAgICAgIGlmICghcGxhY2Vob2xkZXJCb3hI YWRMYXlvdXQgJiYgcGxhY2Vob2xkZXJCb3gtPmNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgp KSB7CisgICAgICAgICAgICAvLyBUaGlzIGFzc3VtZXMgYSBzaGFkb3cgdHJlZSB3aXRob3V0IGZs b2F0cy4gSWYgZmxvYXRzIGFyZSBhZGRlZCwgdGhlCisgICAgICAgICAgICAvLyBsb2dpYyBzaG91 bGQgYmUgc2hhcmVkIHdpdGggUmVuZGVyQmxvY2s6OmxheW91dEJsb2NrQ2hpbGQuCisgICAgICAg ICAgICBwbGFjZWhvbGRlckJveC0+cmVwYWludCgpOworICAgICAgICB9CiAgICAgfQogfQogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggMTNkYjg3N2UzM2Y5MjQ2YWFmYWU2ODk3NGQyNzhjZjY5NTg1ZGZhMC4uODFiYjVlZDFm YjM4M2Q5OWY4ZWY4OTdmNjcwZmY4OWUxZDA4NTc1NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDEyLTAzLTI2ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisg ICAgICAgIFJFR1JFU1NJT04gKHIxMTAwNjUtcjExMDA4MCk6IGZhc3QvZm9ybXMvcGxhY2Vob2xk ZXItc2V0LWF0dHJpYnV0ZS5odG1sIGlzIGZhaWxpbmcgaW50ZXJtaXR0ZW50bHkgYmVjYXVzZSBX ZWJLaXQgZmFpbHMgdG8gcmVwYWludCBhZnRlciBzZXR0aW5nIHRoZSBwbGFjZWhvbGRlciBhdHRy aWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgx ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KKworICAgICAgICAqIHBs YXRmb3JtL21hYy9Ta2lwcGVkOiBVbnNraXAgdGhlIHRlc3Qgb24gTWFjLiBUaGUgb3RoZXIgcGxh dGZvcm1zIGFyZSBlaXRoZXIKKyAgICAgICAgc2tpcHBpbmcgaXQgZm9yIG90aGVyIHJlYXNvbnMg b3IgZGlkIG5vdCBoYXZlIGEgc3BlY2lmaWMgZW50cnkgZm9yIHRoZSBmbGFraW5lc3MuCisKIDIw MTItMDMtMjYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBbUXRdW01hY10gU2tpcCBmYWlsaW5nIHRlc3RzIHRvIHBhaW50IHRoZSBib3QgZ3JlZW4uCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9Ta2lwcGVkCmluZGV4IDkxNDMzZTI4OGE1ZjFmMDM2NmY0ODAzN2ZkYWQy MjlkZjI4NWQwNjYuLmIwYjViNjIxNGQ4ZDQyMDgyZmM0MmQwYjgzNDQwMDVmNGRmNjFlNDggMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCkBAIC02MDgsMTAgKzYwOCw2IEBAIGZhc3Qvd29ya2Vy cy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFiYXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMuaHRtbAogIyBB bGxvd2VkIHRvIHJlZ3Jlc3MgdG8gZml4IGEgY3Jhc2guIAogZmFzdC9pbmxpbmUvY29udGludWF0 aW9uLW91dGxpbmVzLXdpdGgtbGF5ZXJzLmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODE4MDIgcmRhcjovL3Byb2JsZW0vMTEwOTE0MTIKLSMgZmFzdC9m b3Jtcy9wbGFjZWhvbGRlci1zZXQtYXR0cmlidXRlLmh0bWwgaXMgZmFpbGluZyBpbnRlcm1pdHRl bnRseSBiZWNhdXNlIFdlYktpdCBmYWlscyB0byByZXBhaW50IGFmdGVyIHNldHRpbmcgdGhlIHBs YWNlaG9sZGVyIGF0dHJpYnV0ZQotZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1zZXQtYXR0cmlidXRl Lmh0bWwKLQogIyBOb3QgcG9zc2libGUgdG8gc2V0IFVBIHN0cmluZyBmb3IgbWVkaWEgcmVxdWVz dHMgd2l0aCBhbGwgTWFjIG1lZGlhIGVuZ2luZXMuCiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXVz ZXJhZ2VudC5odG1sCiAK