81775 2012-03-21 06:29:19 -0700 Correct LayoutUnit usage in VisiblePosition.cpp 2012-03-21 15:42:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric webkit.review.bot oldest_to_newest 584073 0 leviw 2012-03-21 06:29:19 -0700 There's currently a mismatched function definition, and we assign localCaretRect to an IntRect, when local coordinates should be LayoutUnits. 584089 1 133035 leviw 2012-03-21 06:46:04 -0700 Created attachment 133035 Patch 584383 2 133035 eric 2012-03-21 11:15:07 -0700 Comment on attachment 133035 Patch OK. Caret rects will be sub-pixel precise? 584699 3 133035 leviw 2012-03-21 15:32:37 -0700 Comment on attachment 133035 Patch Thanks Eric :) 584710 4 133035 webkit.review.bot 2012-03-21 15:42:42 -0700 Comment on attachment 133035 Patch Clearing flags on attachment: 133035 Committed r111613: <http://trac.webkit.org/changeset/111613> 584711 5 webkit.review.bot 2012-03-21 15:42:46 -0700 All reviewed patches have been landed. Closing bug. 133035 2012-03-21 06:46:04 -0700 2012-03-21 15:42:42 -0700 Patch bug-81775-20120321064603.patch text/plain 2562 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTUzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTIxICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVu aXQgdXNhZ2UgaW4gVmlzaWJsZVBvc2l0aW9uLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0aW5nIGEgbWlzbWF0Y2ggYmV0d2VlbiB0aGUg LmggYW5kIC5jcHAgZm9yIHRoZSBkZWZpbml0aW9uIG9mIGxvY2FsQ2FyZXRSZWN0LAorICAgICAg ICBhbmQgcHJvcGVybHkgdXNpbmcgTGF5b3V0VW5pdHMgZm9yIGxvY2FsIGNvb3JkaW5hdGVzLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAg ICogZWRpdGluZy9WaXNpYmxlUG9zaXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VmlzaWJs ZVBvc2l0aW9uOjpsb2NhbENhcmV0UmVjdCk6IFN3aXRjaGluZyB0byByZXR1cm4gYSBMYXlvdXRS ZWN0LCBhcyBpbiB0aGUKKyAgICAgICAgaGVhZGVyLiBMb2NhbCBjb29yZGluYXRlcyBhcmUgaW4g TGF5b3V0VW5pdHMuCisgICAgICAgIChXZWJDb3JlOjpWaXNpYmxlUG9zaXRpb246OmFic29sdXRl Q2FyZXRCb3VuZHMpOiBVc2luZyBMYXlvdXRSZWN0IGZvciB0aGUgbG9jYWxDYXJldFJlY3QuCisg ICAgICAgIChXZWJDb3JlOjpWaXNpYmxlUG9zaXRpb246OmxpbmVEaXJlY3Rpb25Qb2ludEZvckJs b2NrRGlyZWN0aW9uTmF2aWdhdGlvbik6IERpdHRvLgorCiAyMDEyLTAzLTIxICBBbmRyZXkgS29z eWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZXhw b3NlIGdldEV2ZW50TGlzdGVuZXJzKCkgdG8gY29uc29sZSBjb21tYW5kIGxpbmUgQVBJCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVQb3NpdGlvbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlUG9zaXRpb24uY3BwCShyZXZpc2lvbiAx MTE1MTgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVQb3NpdGlvbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU5NSw3ICs1OTUsNyBAQCBVQ2hhcjMyIFZpc2libGVQb3NpdGlvbjo6 Y2hhcmFjdGVyQWZ0ZXIoCiAgICAgcmV0dXJuIGNoOwogfQogCi1JbnRSZWN0IFZpc2libGVQb3Np dGlvbjo6bG9jYWxDYXJldFJlY3QoUmVuZGVyT2JqZWN0KiYgcmVuZGVyZXIpIGNvbnN0CitMYXlv dXRSZWN0IFZpc2libGVQb3NpdGlvbjo6bG9jYWxDYXJldFJlY3QoUmVuZGVyT2JqZWN0KiYgcmVu ZGVyZXIpIGNvbnN0CiB7CiAgICAgaWYgKG1fZGVlcFBvc2l0aW9uLmlzTnVsbCgpKSB7CiAgICAg ICAgIHJlbmRlcmVyID0gMDsKQEAgLTYwNSw3ICs2MDUsNyBAQCBJbnRSZWN0IFZpc2libGVQb3Np dGlvbjo6bG9jYWxDYXJldFJlY3QoCiAgICAgCiAgICAgcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJl cigpOwogICAgIGlmICghcmVuZGVyZXIpCi0gICAgICAgIHJldHVybiBJbnRSZWN0KCk7CisgICAg ICAgIHJldHVybiBMYXlvdXRSZWN0KCk7CiAKICAgICBJbmxpbmVCb3gqIGlubGluZUJveDsKICAg ICBpbnQgY2FyZXRPZmZzZXQ7CkBAIC02MjAsNyArNjIwLDcgQEAgSW50UmVjdCBWaXNpYmxlUG9z aXRpb246OmxvY2FsQ2FyZXRSZWN0KAogSW50UmVjdCBWaXNpYmxlUG9zaXRpb246OmFic29sdXRl Q2FyZXRCb3VuZHMoKSBjb25zdAogewogICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXI7Ci0gICAg SW50UmVjdCBsb2NhbFJlY3QgPSBsb2NhbENhcmV0UmVjdChyZW5kZXJlcik7CisgICAgTGF5b3V0 UmVjdCBsb2NhbFJlY3QgPSBsb2NhbENhcmV0UmVjdChyZW5kZXJlcik7CiAgICAgaWYgKGxvY2Fs UmVjdC5pc0VtcHR5KCkgfHwgIXJlbmRlcmVyKQogICAgICAgICByZXR1cm4gSW50UmVjdCgpOwog CkBAIC02MzAsNyArNjMwLDcgQEAgSW50UmVjdCBWaXNpYmxlUG9zaXRpb246OmFic29sdXRlQ2Fy ZXRCbwogaW50IFZpc2libGVQb3NpdGlvbjo6bGluZURpcmVjdGlvblBvaW50Rm9yQmxvY2tEaXJl Y3Rpb25OYXZpZ2F0aW9uKCkgY29uc3QKIHsKICAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyOwot ICAgIEludFJlY3QgbG9jYWxSZWN0ID0gbG9jYWxDYXJldFJlY3QocmVuZGVyZXIpOworICAgIExh eW91dFJlY3QgbG9jYWxSZWN0ID0gbG9jYWxDYXJldFJlY3QocmVuZGVyZXIpOwogICAgIGlmIChs b2NhbFJlY3QuaXNFbXB0eSgpIHx8ICFyZW5kZXJlcikKICAgICAgICAgcmV0dXJuIDA7CiAK