81312 2012-03-15 23:07:30 -0700 [BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h 2012-03-19 09:23:43 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 580167 0 leo.yang 2012-03-15 23:07:30 -0700 BlackBerry specific change to keyboard event. 580201 1 132214 leo.yang 2012-03-15 23:56:19 -0700 Created attachment 132214 Patch 580212 2 132214 buildbot 2012-03-16 00:11:10 -0700 Comment on attachment 132214 Patch Attachment 132214 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11964047 580224 3 leo.yang 2012-03-16 00:21:40 -0700 (In reply to comment #2) > (From update of attachment 132214 [details]) > Attachment 132214 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/11964047 Seems not related to this patch. 580354 4 132214 rwlbuis 2012-03-16 04:13:32 -0700 Comment on attachment 132214 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review > Source/WebCore/platform/PlatformKeyboardEvent.h:195 > + unsigned short m_unmodifiedCharacter; How is m_unmodifiedCharacter used? It seems to be set to zero and then? 581575 5 leo.yang 2012-03-18 19:55:00 -0700 (In reply to comment #4) > (From update of attachment 132214 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review > > > Source/WebCore/platform/PlatformKeyboardEvent.h:195 > > + unsigned short m_unmodifiedCharacter; > > How is m_unmodifiedCharacter used? It seems to be set to zero and then? It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp. 581749 6 132214 rwlbuis 2012-03-19 07:05:44 -0700 Comment on attachment 132214 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review LGTM. >>> Source/WebCore/platform/PlatformKeyboardEvent.h:195 >>> + unsigned short m_unmodifiedCharacter; >> >> It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp. > > How is m_unmodifiedCharacter used? It seems to be set to zero and then? Ah, this was not visible from the context, I saw it just now in the source file, thanks. 581859 7 132214 webkit.review.bot 2012-03-19 09:23:37 -0700 Comment on attachment 132214 Patch Clearing flags on attachment: 132214 Committed r111191: <http://trac.webkit.org/changeset/111191> 581860 8 webkit.review.bot 2012-03-19 09:23:43 -0700 All reviewed patches have been landed. Closing bug. 132214 2012-03-15 23:56:19 -0700 2012-03-19 09:23:37 -0700 Patch 0001-BlackBerry-Upstream-the-BlackBerry-change-to-platfor.patch text/plain 4858 leo.yang RnJvbSAxYWU0MjU1ODg2MjNiNjZjZWQ0NTFmNjRmOTQyMGQ4ODRjNjZjYzE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBGcmksIDE2IE1hciAyMDEyIDE0OjU1OjE2ICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIFVwc3RyZWFtIHRoZSBCbGFja0JlcnJ5IGNoYW5nZSB0bwogcGxhdGZvcm0v UGxhdGZvcm1LZXlib2FyZEV2ZW50LmgKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MTMxMgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIHBsYXRmb3JtL1Bs YXRmb3JtS2V5Ym9hcmRFdmVudC5oOgooUGxhdGZvcm0pOgooV2ViQ29yZTo6UGxhdGZvcm1LZXli b2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQpOgooUGxhdGZvcm1LZXlib2FyZEV2ZW50 KToKKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6dW5tb2RpZmllZENoYXJhY3Rlcik6 CkFkZCBCbGFja0JlcnJ5IHNwZWNpZmljIGNvbnN0cnVjdG9yIGFuZCBtZW1iZXIgZmllbGRzLgoq IHBsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHA6 CihXZWJDb3JlOjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudCk6 CkNoYW5nZSB0aGUgcGFyYW1ldGVyIHR5cGUgdG8gY29uc3QgcmVmZXJlbmNlIHR5cGUgdG8gYWRh cHQgdG8gdGhlIGRlY2xhcmF0aW9uLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKwogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vUGxhdGZvcm1LZXlib2FyZEV2ZW50LmggICAgfCAgIDIzICsrKysrKysrKysr KysrKysrKysrCiAuLi4vYmxhY2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5 LmNwcCB8ICAgIDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk3NWUzOS4uNTdjOTEzZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIwIEBACisyMDEyLTAzLTE1ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxl LmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0gdGhlIEJsYWNrQmVycnkg Y2hhbmdlIHRvIHBsYXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5oCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMxMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vUGxhdGZvcm1LZXli b2FyZEV2ZW50Lmg6CisgICAgICAgIChQbGF0Zm9ybSk6CisgICAgICAgIChXZWJDb3JlOjpQbGF0 Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudCk6CisgICAgICAgIChQbGF0 Zm9ybUtleWJvYXJkRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2 ZW50Ojp1bm1vZGlmaWVkQ2hhcmFjdGVyKToKKyAgICAgICAgQWRkIEJsYWNrQmVycnkgc3BlY2lm aWMgY29uc3RydWN0b3IgYW5kIG1lbWJlciBmaWVsZHMuCisgICAgICAgICogcGxhdGZvcm0vYmxh Y2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KToKKyAg ICAgICAgQ2hhbmdlIHRoZSBwYXJhbWV0ZXIgdHlwZSB0byBjb25zdCByZWZlcmVuY2UgdHlwZSB0 byBhZGFwdCB0byB0aGUgZGVjbGFyYXRpb24uCisKIDIwMTItMDMtMTUgIFNoaW55YSBLYXdhbmFr YSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDcmFzaF0gQWRkaW5nIDxjb250 ZW50PiBpbnRvIGEgU2hhZG93Um9vdCBjYXVzZXMgY3Jhc2guCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybUtleWJvYXJkRXZlbnQuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5oCmluZGV4IDU5OTAwOTguLjFjMWRlNjUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVu dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5o CkBAIC01NSw2ICs1NSwxNCBAQCBRVF9FTkRfTkFNRVNQQUNFCiBjbGFzcyB3eEtleUV2ZW50Owog I2VuZGlmCiAKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKQorbmFtZXNwYWNlIEJsYWNrQmVycnkg eworbmFtZXNwYWNlIFBsYXRmb3JtIHsKK2NsYXNzIEtleWJvYXJkRXZlbnQ7Cit9Cit9CisjZW5k aWYKKwogI2lmIFBMQVRGT1JNKEVGTCkKIHR5cGVkZWYgc3RydWN0IF9FdmFzX0V2ZW50X0tleV9E b3duIEV2YXNfRXZlbnRfS2V5X0Rvd247CiB0eXBlZGVmIHN0cnVjdCBfRXZhc19FdmVudF9LZXlf VXAgRXZhc19FdmVudF9LZXlfVXA7CkBAIC03Miw2ICs4MCw5IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgICAgICwgbV9hdXRvUmVwZWF0KGZhbHNlKQogICAgICAgICAgICAgLCBtX2lz S2V5cGFkKGZhbHNlKQogICAgICAgICAgICAgLCBtX2lzU3lzdGVtS2V5KGZhbHNlKQorI2lmIFBM QVRGT1JNKEJMQUNLQkVSUlkpCisgICAgICAgICAgICAsIG1fdW5tb2RpZmllZENoYXJhY3Rlcigw KQorI2VuZGlmCiAjaWYgUExBVEZPUk0oR1RLKQogICAgICAgICAgICAgLCBtX2dka0V2ZW50S2V5 KDApCiAjZW5kaWYKQEAgLTEyNyw2ICsxMzgsMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICBzdGF0aWMgYm9vbCBjdXJyZW50Q2Fwc0xvY2tTdGF0ZSgpOwogICAgICAgICBzdGF0aWMg dm9pZCBnZXRDdXJyZW50TW9kaWZpZXJTdGF0ZShib29sJiBzaGlmdEtleSwgYm9vbCYgY3RybEtl eSwgYm9vbCYgYWx0S2V5LCBib29sJiBtZXRhS2V5KTsKIAorI2lmIFBMQVRGT1JNKEJMQUNLQkVS UlkpCisgICAgICAgIHVuc2lnbmVkIHNob3J0IHVubW9kaWZpZWRDaGFyYWN0ZXIoKSBjb25zdCB7 IHJldHVybiBtX3VubW9kaWZpZWRDaGFyYWN0ZXI7IH0KKyNlbmRpZgorCiAjaWYgUExBVEZPUk0o TUFDKQogICAgICAgICBOU0V2ZW50KiBtYWNFdmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fbWFjRXZl bnQuZ2V0KCk7IH0KICNlbmRpZgpAQCAtMTU2LDYgKzE3MSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudCh3eEtleUV2ZW50Jik7CiAjZW5kaWYK IAorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVu dChjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6S2V5Ym9hcmRFdmVudCYpOworI2VuZGlmCisK ICNpZiBQTEFURk9STShFRkwpCiAgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudChjb25zdCBF dmFzX0V2ZW50X0tleV9Eb3duKik7CiAgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudChjb25z dCBFdmFzX0V2ZW50X0tleV9VcCopOwpAQCAtMTcyLDYgKzE5MSwxMCBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgICAgIGJvb2wgbV9pc0tleXBhZDsKICAgICAgICAgYm9vbCBtX2lzU3lzdGVt S2V5OwogCisjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKKyAgICAgICAgdW5zaWduZWQgc2hvcnQg bV91bm1vZGlmaWVkQ2hhcmFjdGVyOworI2VuZGlmCisKICNpZiBQTEFURk9STShNQUMpCiAgICAg ICAgIFJldGFpblB0cjxOU0V2ZW50PiBtX21hY0V2ZW50OwogI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJs YWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9y bUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNwcAppbmRleCA2MDcxMjZiLi41ZGQ4NWJjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BsYXRmb3JtS2V5Ym9h cmRFdmVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvUGxhdGZvcm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAKQEAgLTQzNiw3ICs0MzYs NyBAQCBzdGF0aWMgaW5saW5lIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6VHlwZSB0b1dlYkNvcmVQ bGF0Zm9ybUtleWJvYXJkRXZlbnRUeXBlKGNvbgogICAgIH0KIH0KIAotUGxhdGZvcm1LZXlib2Fy ZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQoQmxhY2tCZXJyeTo6UGxhdGZvcm06OktleWJv YXJkRXZlbnQgZXZlbnQpCitQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRF dmVudChjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6S2V5Ym9hcmRFdmVudCYgZXZlbnQpCiAg ICAgOiBQbGF0Zm9ybUV2ZW50KHRvV2ViQ29yZVBsYXRmb3JtS2V5Ym9hcmRFdmVudFR5cGUoZXZl bnQudHlwZSgpKSwgZXZlbnQuc2hpZnRBY3RpdmUoKSB8fCAoZXZlbnQuY2hhcmFjdGVyKCkgPT0g S0VZQ09ERV9CQUNLX1RBQiksIGV2ZW50LmN0cmxBY3RpdmUoKSwgZXZlbnQuYWx0QWN0aXZlKCks IGZhbHNlKQogICAgICwgbV9rZXlJZGVudGlmaWVyKGtleUlkZW50aWZpZXJGb3JCbGFja0JlcnJ5 Q2hhcmFjdGVyKGV2ZW50LmNoYXJhY3RlcigpKSkKICAgICAsIG1fYXV0b1JlcGVhdChmYWxzZSkK LS0gCjEuNy41LjQKCg==