81297 2012-03-15 18:47:00 -0700 [BlackBerry] Crash when going back from an xhtml document containing <img> 2012-03-16 03:40:13 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei logingx rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 580022 0 leo.yang 2012-03-15 18:47:00 -0700 This is a regression of multipart image change. Internal PR: #144060. 580026 1 132175 leo.yang 2012-03-15 18:52:20 -0700 Created attachment 132175 Patch 580034 2 132175 rwlbuis 2012-03-15 19:13:23 -0700 Comment on attachment 132175 Patch LGTM. I assume you will use the same bug to redo the patch but without the crash? 580039 3 leo.yang 2012-03-15 19:20:46 -0700 (In reply to comment #2) > (From update of attachment 132175 [details]) > LGTM. I assume you will use the same bug to redo the patch but without the crash? Thanks for your review. Internal PR #105163 has been re-opened. It's not a high priority pr. I think we should file another upstreaming bug when the fix for it is ready. 580040 4 leo.yang 2012-03-15 19:22:06 -0700 Looping Chris Guan ... 580043 5 132175 leo.yang 2012-03-15 19:32:09 -0700 Comment on attachment 132175 Patch Sending to the cq ... 580338 6 132175 webkit.review.bot 2012-03-16 03:40:08 -0700 Comment on attachment 132175 Patch Clearing flags on attachment: 132175 Committed r110982: <http://trac.webkit.org/changeset/110982> 580339 7 webkit.review.bot 2012-03-16 03:40:13 -0700 All reviewed patches have been landed. Closing bug. 132175 2012-03-15 18:52:20 -0700 2012-03-16 03:40:08 -0700 Patch 0001-BlackBerry-Crash-when-going-back-from-an-xhtml-docum.patch text/plain 3063 leo.yang RnJvbSBhYTU3YzU0NmFkNjY1NDIxNjI3ZGIxOWY0YzZhNGZlOTQxMTI0YzVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBGcmksIDE2IE1hciAyMDEyIDA5OjUxOjE4ICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIENyYXNoIHdoZW4gZ29pbmcgYmFjayBmcm9tIGFuIHhodG1sIGRvY3VtZW50 CiBjb250YWluaW5nIDxpbWc+CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODEyOTcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVGhpcyBpcyBtYW51YWxseSBy ZXZlcnRpbmcgdGhlIG9mZmVuZGluZyBpbnRlcm5hbCBjb21taXQgd2hpY2ggY2hlY2tlZC1pbiBi ZWZvcmUgdXBzdHJlYW1pbmcuCgoqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeS5jcHA6CihXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNhbkNh Y2hlUGFnZSk6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAgfCAgIDExIC0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDEyIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCmluZGV4IDExNWI1ZGEuLmQ3ZDJhMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE1ICBMZW8gWWFuZyAgPGxlby55YW5n QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ3Jhc2ggd2hlbiBn b2luZyBiYWNrIGZyb20gYW4geGh0bWwgZG9jdW1lbnQgY29udGFpbmluZyA8aW1nPgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEyOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIG1hbnVhbGx5 IHJldmVydGluZyB0aGUgb2ZmZW5kaW5nIGludGVybmFsIGNvbW1pdCB3aGljaCBjaGVja2VkLWlu IGJlZm9yZSB1cHN0cmVhbWluZy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNs aWVudEJsYWNrQmVycnk6OmNhbkNhY2hlUGFnZSk6CisKIDIwMTItMDMtMTQgIEFydmlkIE5pbHNz b24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBNYWtlIHN1cmUg V2ViUGFnZSBhbmQgQmFja2luZ1N0b3JlIGRvbid0IGNyYXNoIHdpdGhvdXQgYSBXaW5kb3cKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggMGVlZjFmMy4u ZTZmNmVkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAK QEAgLTI0LDcgKzI0LDYgQEAKICNpbmNsdWRlICJCYWNraW5nU3RvcmVDbGllbnQuaCIKICNpbmNs dWRlICJCYWNraW5nU3RvcmVfcC5oIgogI2luY2x1ZGUgIkJhc2U2NC5oIgotI2luY2x1ZGUgIkNh Y2hlZEltYWdlLmgiCiAjaW5jbHVkZSAiQ2hyb21lLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50 QmxhY2tCZXJyeS5oIgogI2luY2x1ZGUgIkNsaWVudEV4dGVuc2lvbi5oIgpAQCAtMzQsNyArMzMs NiBAQAogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUgIkhUTUxGb3JtRWxlbWVudC5o IgogI2luY2x1ZGUgIkhUTUxIZWFkRWxlbWVudC5oIgotI2luY2x1ZGUgIkhUTUxJbWFnZUVsZW1l bnQuaCIKICNpbmNsdWRlICJIVE1MTGlua0VsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MTWVkaWFF bGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTE1ldGFFbGVtZW50LmgiCkBAIC0xMjA3LDE1ICsxMjA1 LDYgQEAgYm9vbCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNhbkNhY2hlUGFnZSgpIGNv bnN0CiAgICAgaWYgKG5vZGVMaXN0LmdldCgpLT5sZW5ndGgoKSA+IDApCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAotICAgIC8vIFRoZSBtdWx0aXBhcnQgb2YgIm11bHRpcGFydC94LW1peGVkLXJl cGxhY2UiIG9ubHkgc3VwcG9ydHMgaW1hZ2UsIGNvcnJlY3Q/Ci0gICAgLy8gRklYTUU6IERvIHdl IGhhdmUgYSBiZXR0ZXIgcGxhY2UgdG8gaGFuZGxlIHRoaXMgY2FzZT8KLSAgICBub2RlTGlzdCA9 IG1fZnJhbWUtPmRvY3VtZW50KCktPmdldEVsZW1lbnRzQnlUYWdOYW1lKEhUTUxOYW1lczo6aW1n VGFnLmxvY2FsTmFtZSgpKTsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbm9kZUxpc3Qu Z2V0KCktPmxlbmd0aCgpOyArK2kpIHsKLSAgICAgICAgSFRNTEltYWdlRWxlbWVudCogbm9kZSA9 IHN0YXRpY19jYXN0PEhUTUxJbWFnZUVsZW1lbnQqPihub2RlTGlzdC5nZXQoKS0+aXRlbShpKSk7 Ci0gICAgICAgIENhY2hlZEltYWdlKiBjYWNoZWRpbWFnZSA9IG5vZGUgPyBub2RlLT5jYWNoZWRJ bWFnZSgpIDogMDsKLSAgICAgICAgaWYgKGNhY2hlZGltYWdlICYmIGNhY2hlZGltYWdlLT5yZXNw b25zZSgpLmlzTXVsdGlwYXJ0UGF5bG9hZCgpKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgIH0KICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotLSAKMS43LjUuNAoK