81164 2012-03-14 15:32:49 -0700 [Qt][WK2] QtWebKit2 should support Page Visibility API 2012-04-04 06:35:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 81154 1 jesus jesus allan.jensen menard ostap73 vestbo webkit.review.bot zoltan oldest_to_newest 578859 0 jesus 2012-03-14 15:32:49 -0700 We should implement the Page Visibility API support in QQuickWebView as soon as WebKit2 and WKTR have what is needed to it. 593029 1 allan.jensen 2012-04-01 06:01:13 -0700 It should be noted that parts of the visibility spec is nonsense in a modern desktop sense. A user-agent that has been minimized is NOT hidden, it is still rendered for previews and other composition effects. This is the same reason there is no support in Qt to get an event when the top-window is minimized. 594451 2 jesus 2012-04-03 07:04:17 -0700 (In reply to comment #1) > It should be noted that parts of the visibility spec is nonsense in a modern desktop sense. > > A user-agent that has been minimized is NOT hidden, it is still rendered for previews and other composition effects. This is the same reason there is no support in Qt to get an event when the top-window is minimized. With that in mind QWindow::isExposed and the whole new set of exposed events are being cooked, right? Plus, why can't you use QQuickCanvas::windowStateChanged and check for Qt::WindowMinimized, for instance? (QQuickCanvas inherits QWindow). cheers! 594482 3 allan.jensen 2012-04-03 07:55:10 -0700 (In reply to comment #2) > (In reply to comment #1) > > It should be noted that parts of the visibility spec is nonsense in a modern desktop sense. > > > > A user-agent that has been minimized is NOT hidden, it is still rendered for previews and other composition effects. This is the same reason there is no support in Qt to get an event when the top-window is minimized. > > With that in mind QWindow::isExposed and the whole new set of exposed events are being cooked, right? > > Plus, why can't you use QQuickCanvas::windowStateChanged and check for Qt::WindowMinimized, for instance? (QQuickCanvas inherits QWindow). > > QWindow doesn't have a windowStateChange. WindowState needs to be made into a property, or maybe that has already been done? 594527 4 135336 jesus 2012-04-03 08:49:32 -0700 Created attachment 135336 Patch 594536 5 135336 menard 2012-04-03 09:01:09 -0700 Comment on attachment 135336 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135336&action=review > Source/WebKit2/UIProcess/qt/QtPageClient.cpp:275 > + if (m_webView->canvas() && m_webView->canvas()->windowState() == Qt::WindowMinimized) Question is : when the isExposed will be ready? If it's a matter of little time, no need to check the workaround in no? 594567 6 135336 webkit-ews 2012-04-03 09:44:38 -0700 Comment on attachment 135336 Patch Attachment 135336 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12324125 594636 7 135363 jesus 2012-04-03 10:49:24 -0700 Created attachment 135363 Patch 595488 8 135363 webkit.review.bot 2012-04-04 06:35:49 -0700 Comment on attachment 135363 Patch Clearing flags on attachment: 135363 Committed r113183: <http://trac.webkit.org/changeset/113183> 595489 9 webkit.review.bot 2012-04-04 06:35:54 -0700 All reviewed patches have been landed. Closing bug. 135336 2012-04-03 08:49:32 -0700 2012-04-03 10:49:16 -0700 Patch bug-81164-20120403124857.patch text/plain 3189 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWViNjRiZTNhOGNmMzYz ZGU1ZWMwOWNhNDg4ZTU3OWQ3NDY5MDdjMi4uMmJmZjUyMmE2MzUwZDNhYjljNWIwMDkxOGMxZjcx MmU0OGU0OTQ4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA0LTAzICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAorICAg ICAgICBbUXRdW1dLMl0gUXRXZWJLaXQyIHNob3VsZCBzdXBwb3J0IFBhZ2UgVmlzaWJpbGl0eSBB UEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMTY0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVt ZW50aW5nIHRoZSBsYXN0IGJpdHMgbmVlZGVkIGZvciBnZXR0aW5nIHRoZSBleHBlY3RlZAorICAg ICAgICBiZWhhdmlvciBmb3IgUGFnZSBWaXNpYmlsaXR5IEFQSSwgYWNjb3JkaW5nIHRvIGl0cyBz cGVjLgorICAgICAgICBUaGUgb25seSBtaXNzaW5nIHBhcnQgaW4gUXQgd2FzIGEgd2F5IHRvIGNo ZWNrIHdoZXRoZXIKKyAgICAgICAgdGhlIHZpZXcgd2FzIGV4cG9zZWQgb3Igbm90LgorCisgICAg ICAgICogVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHA6CisgICAgICAgIChRdFBhZ2VDbGll bnQ6OmlzVmlld1Zpc2libGUpOgorCisyMDEyLTA0LTAzICBKZXN1cyBTYW5jaGV6LVBhbGVuY2lh ICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKwogICAgICAgICBbV0syXSBBZGQgUGFn ZSBWaXNpYmlsaXR5IEFQSSBzdXBwb3J0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MTE1NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRQYWdlQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFBhZ2VDbGllbnQuY3BwCmluZGV4IGQ3MDQ5Y2IzYjYyMDg1OWFmOTM2YWU0ZjZiNmU4YzRmMDEw NTdlYWUuLjc2ZmRjMGM1ODQ0YjA3YmQ1ZDM1ZTZmZDRkODgzMTU3ZmFkZTZmNzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCkBAIC0yNzAsNiArMjcw LDExIEBAIGJvb2wgUXRQYWdlQ2xpZW50Ojppc1ZpZXdWaXNpYmxlKCkKIHsKICAgICBpZiAoIW1f d2ViVmlldykKICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gRklYTUU6IHRoaXMgaXMg YSB3b3JrYXJvdW5kIHdoaWxlIFFXaW5kb3c6OmlzRXhwb3NlZCgpIGlzIG5vdCByZWFkeS4KKyAg ICBpZiAobV93ZWJWaWV3LT5jYW52YXMoKSAmJiBtX3dlYlZpZXctPmNhbnZhcygpLT53aW5kb3dT dGF0ZSgpID09IFF0OjpXaW5kb3dNaW5pbWl6ZWQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwog ICAgIHJldHVybiBtX3dlYlZpZXctPmlzVmlzaWJsZSgpICYmIG1fd2ViVmlldy0+cGFnZSgpLT5p c1Zpc2libGUoKTsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IDE2ZTAxZmNhZTk0NDQxYTZkNTQ0MDc3ZGY3MWI5ZWE4MGNiOTM0ZDIuLmIy ZTQ4MTFiZWFhMmY4MzRjZjVjMWIzZjI3ZDE4YzE1NTU1NjYyODEgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0w NC0wMyAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgW1F0XVtXSzJdIFF0V2ViS2l0MiBzaG91bGQgc3VwcG9ydCBQYWdlIFZp c2liaWxpdHkgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MTE2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEVuYWJsaW5nIFBhZ2UgVmlzaWJsaXR5IEFQSSBmb3IgUXQgV2ViS2l0Mi4KKworICAgICAg ICAqIHFtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmOgorCiAyMDEyLTA0LTAyICBK b2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAgICAgICAg RW5hYmxlIGFuZCBjb25uZWN0IHRoZSBXZWJJbnNwZWN0b3JTZXJ2ZXIgd2l0aCBXZWJLaXQyIHBh Z2VzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5w cmYgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByZgppbmRleCAyZWMw N2UwZGI5OWE5NjgxYzc3ZDJlMDU3ZTU1YWU1NGZmNjU5YWY5Li5mN2Y2MjU5ZTg4N2U5ZmNhZjEw Y2ZmOWQzMjE0Y2Y4YWY5NjlkMzE1IDEwMDY0NAotLS0gYS9Ub29scy9xbWFrZS9ta3NwZWNzL2Zl YXR1cmVzL2ZlYXR1cmVzLnByZgorKysgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2Zl YXR1cmVzLnByZgpAQCAtOTEsNiArOTEsNyBAQCBoYXZlUXQoNSkgewogIWNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9BTklNQVRJT05fQVBJPS4pOiBERUZJTkVTICs9IEVOQUJMRV9BTklNQVRJT05f QVBJPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfVE9VQ0hfQURKVVNUTUVOVD0uKTogREVG SU5FUyArPSBFTkFCTEVfVE9VQ0hfQURKVVNUTUVOVD0xCiAhY29udGFpbnMoREVGSU5FUywgRU5B QkxFX0ZBU1RfTU9CSUxFX1NDUk9MTElORz0uKTogREVGSU5FUyArPSBFTkFCTEVfRkFTVF9NT0JJ TEVfU0NST0xMSU5HPTEKKyFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfUEFHRV9WSVNJQklMSVRZ X0FQST0uKTogREVGSU5FUyArPSBFTkFCTEVfUEFHRV9WSVNJQklMSVRZX0FQST0xCiAKICMgUG9s aWN5IGRlY2lzaW9uczogZm9yIHVzaW5nIGEgcGFydGljdWxhciB0aGlyZC1wYXJ0eSBsaWJyYXJ5 IG9yIG9wdGlvbmFsIE9TIHNlcnZpY2UKICFjb250YWlucyhERUZJTkVTLCBXVEZfVVNFX1FUX0lN QUdFX0RFQ09ERVI9Lik6IERFRklORVMgKz0gV1RGX1VTRV9RVF9JTUFHRV9ERUNPREVSPTEK 135363 2012-04-03 10:49:24 -0700 2012-04-04 06:35:49 -0700 Patch bug-81164-20120403144849.patch text/plain 3396 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmEyYzgzMTgxYjhlMjNm YWE2ZWM2YzE5MDBkN2IxZWE0NTQzM2ExOC4uMTQwM2UwMDdhYzNkNTFjMWU4ODI4NzFkNjdmOGJh MjQwODc2OTY4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA0LTAzICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAorICAg ICAgICBbUXRdW1dLMl0gUXRXZWJLaXQyIHNob3VsZCBzdXBwb3J0IFBhZ2UgVmlzaWJpbGl0eSBB UEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMTY0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVt ZW50aW5nIHRoZSBsYXN0IGJpdHMgbmVlZGVkIGZvciBnZXR0aW5nIHRoZSBleHBlY3RlZAorICAg ICAgICBiZWhhdmlvciBmb3IgUGFnZSBWaXNpYmlsaXR5IEFQSSwgYWNjb3JkaW5nIHRvIGl0cyBz cGVjLgorICAgICAgICBUaGUgb25seSBtaXNzaW5nIHBhcnQgaW4gUXQgd2FzIGEgd2F5IHRvIGNo ZWNrIHdoZXRoZXIKKyAgICAgICAgdGhlIHZpZXcgd2FzIGV4cG9zZWQgb3Igbm90LgorCisgICAg ICAgICogVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHA6CisgICAgICAgIChRdFBhZ2VDbGll bnQ6OmlzVmlld1Zpc2libGUpOgorCisyMDEyLTA0LTAzICBKZXN1cyBTYW5jaGV6LVBhbGVuY2lh ICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKwogICAgICAgICBbV0syXSBBZGQgUGFn ZSBWaXNpYmlsaXR5IEFQSSBzdXBwb3J0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MTE1NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRQYWdlQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFBhZ2VDbGllbnQuY3BwCmluZGV4IGQ3MDQ5Y2IzYjYyMDg1OWFmOTM2YWU0ZjZiNmU4YzRmMDEw NTdlYWUuLmQyYzNlNGEzMDg3OGI0ZWM1YmY0M2M3MDhiNjYzYWE5MmE0YmZmZmYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCkBAIC0yOSw2ICsyOSw3 IEBACiAjaW5jbHVkZSAicXF1aWNrd2Vidmlld19wLmgiCiAjaW5jbHVkZSAicXF1aWNrd2Vidmll d19wX3AuaCIKICNpbmNsdWRlIDxRR3VpQXBwbGljYXRpb24+CisjaW5jbHVkZSA8UVF1aWNrQ2Fu dmFzPgogI2luY2x1ZGUgPFdlYkNvcmUvQ3Vyc29yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9EcmFn RGF0YS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRSZWN0Lmg+CkBAIC0yNzAsNiArMjcxLDEx IEBAIGJvb2wgUXRQYWdlQ2xpZW50Ojppc1ZpZXdWaXNpYmxlKCkKIHsKICAgICBpZiAoIW1fd2Vi VmlldykKICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gRklYTUU6IHRoaXMgaXMgYSB3 b3JrYXJvdW5kIHdoaWxlIFFXaW5kb3c6OmlzRXhwb3NlZCgpIGlzIG5vdCByZWFkeS4KKyAgICBp ZiAobV93ZWJWaWV3LT5jYW52YXMoKSAmJiBtX3dlYlZpZXctPmNhbnZhcygpLT53aW5kb3dTdGF0 ZSgpID09IFF0OjpXaW5kb3dNaW5pbWl6ZWQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg IHJldHVybiBtX3dlYlZpZXctPmlzVmlzaWJsZSgpICYmIG1fd2ViVmlldy0+cGFnZSgpLT5pc1Zp c2libGUoKTsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDdiMzI4ZTk5YWQ0MDk4OWE2MjkxOWVkN2M5NjdlYWYwNjk3ZmMwZDEuLmQ1ZTNl NTk4MjllMDkyNTY5MjAxZTA2NzQzNGI2NTFmMTFmYzVhNGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNC0w MyAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgW1F0XVtXSzJdIFF0V2ViS2l0MiBzaG91bGQgc3VwcG9ydCBQYWdlIFZpc2li aWxpdHkgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04MTE2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEVuYWJsaW5nIFBhZ2UgVmlzaWJsaXR5IEFQSSBmb3IgUXQgV2ViS2l0Mi4KKworICAgICAgICAq IHFtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmOgorCiAyMDEyLTA0LTAzICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCB0ZXN0LXdlYmtpdHB5IGJ1aWxkIGZpeCBhZnRlciByMTEzMDM3LgpkaWZmIC0tZ2l0IGEvVG9v bHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYgYi9Ub29scy9xbWFrZS9ta3Nw ZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByZgppbmRleCAyZWMwN2UwZGI5OWE5NjgxYzc3ZDJlMDU3 ZTU1YWU1NGZmNjU5YWY5Li5mN2Y2MjU5ZTg4N2U5ZmNhZjEwY2ZmOWQzMjE0Y2Y4YWY5NjlkMzE1 IDEwMDY0NAotLS0gYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByZgor KysgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByZgpAQCAtOTEsNiAr OTEsNyBAQCBoYXZlUXQoNSkgewogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9BTklNQVRJT05f QVBJPS4pOiBERUZJTkVTICs9IEVOQUJMRV9BTklNQVRJT05fQVBJPTAKICFjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfVE9VQ0hfQURKVVNUTUVOVD0uKTogREVGSU5FUyArPSBFTkFCTEVfVE9VQ0hf QURKVVNUTUVOVD0xCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0ZBU1RfTU9CSUxFX1NDUk9M TElORz0uKTogREVGSU5FUyArPSBFTkFCTEVfRkFTVF9NT0JJTEVfU0NST0xMSU5HPTEKKyFjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfUEFHRV9WSVNJQklMSVRZX0FQST0uKTogREVGSU5FUyArPSBF TkFCTEVfUEFHRV9WSVNJQklMSVRZX0FQST0xCiAKICMgUG9saWN5IGRlY2lzaW9uczogZm9yIHVz aW5nIGEgcGFydGljdWxhciB0aGlyZC1wYXJ0eSBsaWJyYXJ5IG9yIG9wdGlvbmFsIE9TIHNlcnZp Y2UKICFjb250YWlucyhERUZJTkVTLCBXVEZfVVNFX1FUX0lNQUdFX0RFQ09ERVI9Lik6IERFRklO RVMgKz0gV1RGX1VTRV9RVF9JTUFHRV9ERUNPREVSPTEK