81143 2012-03-14 12:34:00 -0700 [Qt][WK2] Implement PageClient::isViewWindowActive() 2014-02-03 03:20:22 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID Qt, QtTriaged P2 Normal --- 82053 82167 82184 83887 70236 1 jesus jesus hausmann kenneth menard ossy webkit.review.bot zoltan oldest_to_newest 578653 0 jesus 2012-03-14 12:34:00 -0700 Since now QQuickCanvas provides API for telling us whether it is active or not, we can implement PageClient::isViewWindowActive. 578863 1 131942 jesus 2012-03-14 15:41:53 -0700 Created attachment 131942 Patch 578869 2 jesus 2012-03-14 15:45:29 -0700 (In reply to comment #1) > Created an attachment (id=131942) [details] > Patch This patch has a small workaround due to a segfault in Qt that happens everytime we try QQuickCanvas::isActive() on focusOutEvents. The issue was already reported and a fix for it is being reviewed. After it lands on Qt I can fix this and remove the //FIXME. 579235 3 131942 kenneth 2012-03-15 02:55:09 -0700 Comment on attachment 131942 Patch why no url to the Qt bug? 579317 4 jesus 2012-03-15 06:28:55 -0700 (In reply to comment #3) > (From update of attachment 131942 [details]) > why no url to the Qt bug? http://codereview.qt-project.org/#change,20129 Sorry :) 579325 5 kenneth 2012-03-15 06:38:53 -0700 In the code with the FIXME 579333 6 jesus 2012-03-15 06:45:03 -0700 (In reply to comment #5) > In the code with the FIXME I can fix when landing. Anything else? 579503 7 131942 jesus 2012-03-15 10:43:51 -0700 Comment on attachment 131942 Patch I will upload a new version now that the Qt Bug has been fixed. As soon as it goes through CI and we pick the new hash, I will land it. (after the r+ of course... :) 579544 8 132081 jesus 2012-03-15 11:18:15 -0700 Created attachment 132081 Patch 579691 9 132081 hausmann 2012-03-15 13:38:22 -0700 Comment on attachment 132081 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132081&action=review > Source/WebKit2/UIProcess/qt/QtPageClient.cpp:259 > + return m_webView->canvas()->isActive(); What does it mean for web content if the view window is active? Should this perhaps be tied to the QQuickItem instead of the window? 579712 10 jesus 2012-03-15 14:04:12 -0700 (In reply to comment #9) > (From update of attachment 132081 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132081&action=review > > > Source/WebKit2/UIProcess/qt/QtPageClient.cpp:259 > > + return m_webView->canvas()->isActive(); > > What does it mean for web content if the view window is active? Should this perhaps be tied to the QQuickItem instead of the window? The PageClient API seems to have been thought for returning the Window state (PageClient::isViewWindowActive) for WebPageProxy (see WebPageProxy::viewStateDidChange). I can see this being tied to the Page Visibility Spec (http://www.w3.org/TR/page-visibility/), for example, in which there are states related to the state of the window itself (QQuickCanvas, in our case) and not directly to the view one. For instance, let's say we have multiple tabs (webviews) but only one is in foreground and, therefore, has focus. This one will considered active while the others will be considered not active even if their top level window (canvas()) still is. I believe that is why we differentiate these states in WebPageProxy as ViewIsFocused and ViewWindowIsActive (besides ViewIsVisible and ViewIsInWindow). 579714 11 jesus 2012-03-15 14:05:15 -0700 (In reply to comment #10) > The PageClient API seems to have been thought for returning the Window state (PageClient::isViewWindowActive) for WebPageProxy (see WebPageProxy::viewStateDidChange). I can see this being tied to the Page Visibility Spec (http://www.w3.org/TR/page-visibility/), for example, in which there are states related to the state of the window itself (QQuickCanvas, in our case) and not directly to the view one. By the way, such work is being tracked by: https://bugs.webkit.org/show_bug.cgi?id=81154 https://bugs.webkit.org/show_bug.cgi?id=81164 and https://bugs.webkit.org/show_bug.cgi?id=69554 583484 12 132903 jesus 2012-03-20 14:53:12 -0700 Created attachment 132903 Patch 583493 13 jesus 2012-03-20 14:55:46 -0700 (In reply to comment #12) > Created an attachment (id=132903) [details] > Patch Updated the patch due to a check that was missing. 586276 14 132903 webkit.review.bot 2012-03-23 06:27:22 -0700 Comment on attachment 132903 Patch Clearing flags on attachment: 132903 Committed r111855: <http://trac.webkit.org/changeset/111855> 586277 15 webkit.review.bot 2012-03-23 06:27:28 -0700 All reviewed patches have been landed. Closing bug. 586307 16 ossy 2012-03-23 07:10:32 -0700 Reopen, because it broke 30+ tests - http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r111856%20%2821981%29/results.html 586724 17 jesus 2012-03-23 14:10:57 -0700 (In reply to comment #16) > Reopen, because it broke 30+ tests - http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r111856%20%2821981%29/results.html I've found what caused the crashes and I'm now looking for a way to tweak the WebKitTestRunner and its WrapperWindow in our favor. I believe the problem is not with the patch itself but with some missing pieces in our PlatformWebView. I will update this bug as soon as I find out the root cause. 586837 18 133579 jesus 2012-03-23 16:03:05 -0700 Created attachment 133579 Patch 587095 19 133579 jesus 2012-03-24 08:17:30 -0700 Comment on attachment 133579 Patch Let's give it a try... 587097 20 133579 webkit.review.bot 2012-03-24 08:24:10 -0700 Comment on attachment 133579 Patch Clearing flags on attachment: 133579 Committed r111993: <http://trac.webkit.org/changeset/111993> 587098 21 webkit.review.bot 2012-03-24 08:24:16 -0700 All reviewed patches have been landed. Closing bug. 587448 22 ossy 2012-03-25 22:23:35 -0700 Reopen, because it broke many tests, see https://bugs.webkit.org/show_bug.cgi?id=82167 for details. 587595 23 ossy 2012-03-26 04:08:14 -0700 Rollout landed in http://trac.webkit.org/changeset/112073 (rs=darktears) 587646 24 133579 jesus 2012-03-26 05:54:27 -0700 Comment on attachment 133579 Patch We need to wait the next round of Qt5 updates on the bots before landing this. 599237 25 133579 kenneth 2012-04-10 07:03:14 -0700 Comment on attachment 133579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133579&action=review > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:83 > + // QWindow does not create the underlying platform > + // specific bits unless QWindow::setVisible() or QWindow::show() are called, > + // and without it QWindow::isActive() will always return false. > + // For these cases QWindow::create() is provided. // QWindow delays creating of the underlying platform specific bits until ::setVisible() // or ::show() are called. This makes ::isActive() always return false. In order to force // the creation ::create() exists, so we use it here. 599240 26 133579 jesus 2012-04-10 07:07:32 -0700 Comment on attachment 133579 Patch CQ has issues, I will land it manually. 599279 27 jesus 2012-04-10 08:15:40 -0700 Committed r113714: <http://trac.webkit.org/changeset/113714> 599314 28 ossy 2012-04-10 08:55:12 -0700 Reopen, because it broke API tests: FAIL! : qmltests::DesktopWebViewLinkHovered::test_linkHovered() 'wait for signal linkHovered' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml(49)] FAIL! : qmltests::DesktopWebViewLinkHovered::test_linkHoveredDoesntEmitRepeated() 'wait for signal linkHovered' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml(68)] FAIL! : qmltests::DesktopWebViewLoadHtml::test_baseUrlAfterLoadHtml() 'wait for signal linkHovered' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml(48)] Could you check and fix it please? 599319 29 ossy 2012-04-10 09:05:22 -0700 Additionally it broke a layout test: --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/events/mouseout-on-window-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/events/mouseout-on-window-actual.txt @@ -1,2 +1,2 @@ This test ensures that mouse out events are sent to the window. -PASS: Received mouseout event. +FAIL: No mouseout was sent. 599329 30 ossy 2012-04-10 09:18:39 -0700 And it made 24 new flakey test :( 599397 31 jesus 2012-04-10 10:39:38 -0700 Wow! Ok, I will have a look at it now. I will roll it out if I need more time, Ossy. Thanks! 599475 32 jesus 2012-04-10 12:13:28 -0700 (In reply to comment #28) > Reopen, because it broke API tests: > > Could you check and fix it please? So, Ossy, I was debugging it with Alexis and we realized that the problem is happening because we run the tests in parallel. If you run "run-qtwebkit-tests -j1" you will see that the tests doesn't fail. Our belief is that running tests in parallel that depend on their window state is a potential mistake, which has now been flagged because this is exactly what this patch fixes. (In reply to comment #29) > Additionally it broke a layout test: This I can't reproduce this locally. =/ 599547 33 ossy 2012-04-10 12:55:48 -0700 (In reply to comment #32) > So, Ossy, I was debugging it with Alexis and we realized that the problem is happening because we run the tests in parallel. If you run "run-qtwebkit-tests -j1" you will see that the tests doesn't fail. > > Our belief is that running tests in parallel that depend on their window state is a potential mistake, which has now been flagged because this is exactly what this patch fixes. I tried it locally, but I got same results as the bot results. Did you run the tests in XFVB as the bots do? xvfb-run -a --server-args="-screen 0 1024x768x24" python ./Tools/Scripts/run-qtwebkit-tests --output-file=qt-unit-tests.html --do-not-open-results --timeout=120 WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/ I got same results with -j1 and without -j1 ... > (In reply to comment #29) > > Additionally it broke a layout test: > > This I can't reproduce this locally. =/ It's hard to believe. :( Did you run all tests with Tools/Scripts/run-webkit-tests on the reference platform? (Ubuntu 11.10) If you do it, fast/events/mouseout-on-window fails and there are 24 new flakey tests after your patch. 599585 34 jesus 2012-04-10 13:43:17 -0700 (In reply to comment #33) > I tried it locally, but I got same results as the bot results. > Did you run the tests in XFVB as the bots do? Nope. > > > (In reply to comment #29) > > > Additionally it broke a layout test: > > > > This I can't reproduce this locally. =/ > > It's hard to believe. :( Did you run all tests with Tools/Scripts/run-webkit-tests on the reference platform? (Ubuntu 11.10) > If you do it, fast/events/mouseout-on-window fails and there are > 24 new flakey tests after your patch. Hard to believe?! It was tested on two different machines (api tests with -j1 and this layout test specifically) but none of them use Ubuntu. Plus, a fast/event test that is called "mouseout-on-window" shouldn't have any platform-specific issues, right? Anyway, I'm having a deeper look in order to find a workaround for it somehow. 599622 35 jesus 2012-04-10 14:11:51 -0700 (In reply to comment #34) > It was tested on two different machines (api tests with -j1 and this layout test specifically) but none of them use Ubuntu. Plus, a fast/event test that is called "mouseout-on-window" shouldn't have any platform-specific issues, right? By "platform-specific" here I meant "distro-specific". 600298 36 ossy 2012-04-11 08:54:04 -0700 Here is the new flakey tests after this patch: ----------------------------------------------- editing/pasteboard/copy-crash.html = TEXT PASS fast/block/positioning/absolute-appended-to-inline.html = TEXT PASS fast/css/hover-affects-child.html = TEXT PASS fast/css/pseudo-any.html = TEXT PASS fast/dom/shadow/shadow-boundary-crossing.html = TEXT PASS fast/dom/shadow/shadow-contents-event.html = TEXT PASS fast/events/dont-loose-last-event.html = TEXT PASS fast/events/event-sender-mouse-moved.html = TEXT PASS fast/events/iframe-onmousemove.html = TEXT PASS fast/events/mouse-moved-remove-frame-crash.html = TEXT PASS fast/events/mousemove-after-drag-over-scrollbar.html = TEXT PASS fast/events/mouseout-dead-node.html = TEXT PASS fast/events/mouseout-dead-subframe.html = TEXT PASS fast/events/mouseover-mouseout.html = TEXT PASS fast/events/mouseover-mouseout2.html = TEXT PASS fast/events/touch/touch-before-pressing-spin-button.html = TEXT PASS fast/forms/autofocus-input-css-style-change.html = TEXT PASS fast/forms/input-step-as-double.html = TEXT PASS fast/forms/number/spin-button-events.html = TEXT PASS fast/forms/number/spin-button-state.html = TEXT PASS fast/forms/number/spin-in-multi-column.html = TEXT PASS fast/forms/range/slider-mouse-events.html = TEXT PASS fast/frames/flattening/iframe-flattening-fixed-width.html = TEXT PASS fast/overflow/overflow-focus-ring.html = TEXT PASS fast/replaced/image-map-2.html = TEXT PASS scrollbars/overflow-custom-scrollbar-crash.html = TEXT PASS scrollbars/scrollbar-iframe-click-does-not-blur-content.html = TEXT PASS svg/custom/foreign-object-skew.svg = TEXT PASS svg/custom/js-update-container2.svg = TEXT PASS svg/custom/pointer-events-invalid-fill.svg = TEXT PASS svg/custom/use-instanceRoot-as-event-target.xhtml = TEXT PASS svg/zoom/page/zoom-foreignObject.svg = TEXT PASS svg/zoom/text/zoom-foreignObject.svg = TEXT PASS And the new failing test: -------------------------- fast/css/hover-update.html = TEXT fast/css/nested-layers-with-hover.html = TEXT fast/events/mouseout-on-window.html = TEXT 600299 37 ossy 2012-04-11 09:00:05 -0700 (In reply to comment #34) > > > This I can't reproduce this locally. =/ > > > > It's hard to believe. :( Did you run all tests with Tools/Scripts/run-webkit-tests on the reference platform? (Ubuntu 11.10) > > If you do it, fast/events/mouseout-on-window fails and there are > > 24 new flakey tests after your patch. > > Hard to believe?! > It was tested on two different machines (api tests with -j1 and this layout test specifically) but none of them use Ubuntu. Plus, a fast/event test that is called "mouseout-on-window" shouldn't have any platform-specific issues, right? I think it is the main problem. All developers should run tests on the _reference_ platform. And at least you should have at least one Ubuntu to be able reproduce QtWebKit bugs occured on the buildbots. > Anyway, I'm having a deeper look in order to find a workaround for it somehow. Thanks for taking care. To be clarify I won't roll out QtWebKit patches, obviously buggy patches, I don't wan't to be the grumpy bad guy who blocks the rapid developing. But in this case our Qt5-WK2 bots aren't in a good shape. And it's hard to catch new flakey and new failing tests until it is fixed. :-/ But if it's OK for you guys let's leave the bot in this bad shape. 600302 38 ossy 2012-04-11 09:02:45 -0700 I modified our master.cfg to run API tests with -j1. The runtime was increased from 0.5 minutes to 2.5 minutes, but tests still fail. It's strange, because it worked for me locally in the same environment. But layout tests might break something in the environment and it might break API tests ... I have no idea what happens ... 600382 39 jesus 2012-04-11 10:35:36 -0700 (In reply to comment #38) > I modified our master.cfg to run API tests with -j1. The runtime was > increased from 0.5 minutes to 2.5 minutes, but tests still fail. > It's strange, because it worked for me locally in the same environment. > But layout tests might break something in the environment and it might > break API tests ... I have no idea what happens ... I will be investigating the issues today and I will update the bug with new comments. Thanks! 600678 40 jesus 2012-04-11 16:10:27 -0700 (In reply to comment #39) > I will be investigating the issues today and I will update the bug with new comments. An issue with my xvfb version and nvidia driver is preventing to run this as the bots do. I will need a bit more time to investigate and fix this. =/ 601179 41 ossy 2012-04-12 06:47:16 -0700 (In reply to comment #38) > I modified our master.cfg to run API tests with -j1. The runtime was > increased from 0.5 minutes to 2.5 minutes, but tests still fail. > It's strange, because it worked for me locally in the same environment. > But layout tests might break something in the environment and it might > break API tests ... I have no idea what happens ... After -j1 we got very strange results on the 32 bit Qt5-WK2 bot: 31 passed, 3 failed, 0 skipped, 3 crashed http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/22770/steps/API%20tests/logs/stdio CRASHED: WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView CRASHED: WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview CRASHED: WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/publicapi/tst_publicapi Great! :( 601194 42 jesus 2012-04-12 07:05:46 -0700 (In reply to comment #41) > Great! :( So remove the -j1 for the time being. But don't you think that not running the tests in parallel shouldn't be causing crashes?!! As I said, Xvfb is not working properly with my nvidia card on arch linux. I'm fixing this and setting up a virtual machine with the "reference platform" so I can debug the issues. Before that there is nothing I can do. If the patch is causing too much trouble on the bots, just roll it out as well and it will come back later when we all have understand what is going on with it. I would do it myself if I had X running right now. (and I would try -j1 without this patch just to see how the bots would behave as well) Other than that, if you really want to help, try to understand what we have explained on irc and on this bug report and help us to debug it as well. There is something way too wrong and not only with the patch if even you said that you are getting different behavior on the bots and on your machine, which is running the "reference platform". thanks! 601249 43 ossy 2012-04-12 08:30:27 -0700 (In reply to comment #42) > (In reply to comment #41) > > Great! :( > > So remove the -j1 for the time being. But don't you think that not running the tests in parallel shouldn't be causing crashes?!! I removed -j1 and now the runtime is 27 sec again and there isn't any crashes. Very strange. > As I said, Xvfb is not working properly with my nvidia card on arch linux. I'm fixing this and setting up a virtual machine with the "reference platform" so I can debug the issues. Before that there is nothing I can do. If the patch is causing too much trouble on the bots, just roll it out as well and it will come back later when we all have understand what is going on with it. I would do it myself if I had X running right now. (and I would try -j1 without this patch just to see how the bots would behave as well) > > Other than that, if you really want to help, try to understand what we have explained on irc and on this bug report and help us to debug it as well. There is something way too wrong and not only with the patch if even you said that you are getting different behavior on the bots and on your machine, which is running the "reference platform". I'm terrible sorry, but I don't have too much free time for debugging when I'm filing bugs about new regressions, rebase expected files instead of authors, digging which patch broke what in 24/7. :( I agree, something is really wrong with run-qtwebkit-tests script near -j1 option ... I'll check it soon with and without your patch. 975421 44 jturcotte 2014-02-03 03:20:22 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 131942 2012-03-14 15:41:53 -0700 2012-03-15 10:43:51 -0700 Patch bug-81143-20120314194117.patch text/plain 4105 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjczNDJiZmUzYWFlYzgz OWYzOTQwZDUxMDAzY2UyNmEzNzczOGZmOC4uM2UyNWY2ZDQ1NmVmYzI5NGIyMWI5MjhjYzgwYzY2 NTQ0MzIwZTU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTE0ICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gSW1wbGVtZW50IFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggaW1wbGVtZW50cyBQYWdlQ2xpZW50Ojppc1ZpZXdXaW5kb3dBY3RpdmUoKQorICAgICAgICBu b3cgdGhhdCBRUXVpY2tDYW52YXM6OmlzQWN0aXZlKCkgaXMgYXZhaWxhYmxlIChmcm9tIFFXaW5k b3cpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAg ICAgICAgKFFRdWlja1dlYlZpZXc6OmZvY3VzSW5FdmVudCk6CisgICAgICAgIChRUXVpY2tXZWJW aWV3Ojpmb2N1c091dEV2ZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dl YnZpZXdfcF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZSk6CisgICAgICAgIChR UXVpY2tXZWJWaWV3UHJpdmF0ZTo6aXNXaW5kb3dBY3RpdmUpOgorICAgICAgICAqIFVJUHJvY2Vz cy9xdC9RdFBhZ2VDbGllbnQuY3BwOgorICAgICAgICAoUXRQYWdlQ2xpZW50Ojppc1ZpZXdXaW5k b3dBY3RpdmUpOgorCiAyMDEyLTAzLTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgRml4IFVJIHByb2Nlc3MgY3Jhc2ggd2hlbiBhIHBsdWctaW4gcHJv Y2VzcyBjcmFzaGVzIHdpdGggYSBtb2RhbCBkaWFsb2cgc2hvd2luZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggZWUxYWJmNDhj ZGM4YzBmZWQ4MjYzODAyZmNlODdiZjdiNTZmY2U1Ni4uYzU3ZGVkZWVkMDVhZWYxZWE1YjYxZTkz MmEwZDc2YzMxYzc2M2ZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0xMzYyLDEyICsxMzYyLDIwIEBAIHZvaWQgUVF1aWNr V2ViVmlldzo6aW5wdXRNZXRob2RFdmVudChRSW5wdXRNZXRob2RFdmVudCogZXZlbnQpCiB2b2lk IFFRdWlja1dlYlZpZXc6OmZvY3VzSW5FdmVudChRRm9jdXNFdmVudCogZXZlbnQpCiB7CiAgICAg UV9EKFFRdWlja1dlYlZpZXcpOworICAgIC8vIEZJWE1FOiB3ZSBzaG91bGRuJ3QgbmVlZCB0byBr ZWVwIGQtPmlzVmlld1dpbmRvd0FjdGl2ZQorICAgIC8vIGFuZCBjb3VsZCAgYmUgdXNpbmcgY2Fu dmFzKCktPmlzQWN0aXZlKCkgaW5zdGVhZAorICAgIC8vIGJ1dCBhIGJ1ZyBpbiBRdCBpcyBwcmV2 ZW50aW5nIHVzIGZyb20gZG9pbmcgdGhhdC4KKyAgICBkLT5pc1ZpZXdXaW5kb3dBY3RpdmUgPSBj YW52YXMoKSAmJiBjYW52YXMoKS0+aXNBY3RpdmUoKTsKICAgICBkLT5wYWdlVmlldy0+ZXZlbnRI YW5kbGVyKCktPmhhbmRsZUZvY3VzSW5FdmVudChldmVudCk7CiB9CiAKIHZvaWQgUVF1aWNrV2Vi Vmlldzo6Zm9jdXNPdXRFdmVudChRRm9jdXNFdmVudCogZXZlbnQpCiB7CiAgICAgUV9EKFFRdWlj a1dlYlZpZXcpOworICAgIC8vIEZJWE1FOiB3ZSBzaG91bGRuJ3QgbmVlZCB0byBrZWVwIGQtPmlz Vmlld1dpbmRvd0FjdGl2ZQorICAgIC8vIGFuZCBjb3VsZCAgYmUgdXNpbmcgY2FudmFzKCktPmlz QWN0aXZlKCkgaW5zdGVhZAorICAgIC8vIGJ1dCBhIGJ1ZyBpbiBRdCBpcyBwcmV2ZW50aW5nIHVz IGZyb20gZG9pbmcgdGhhdC4KKyAgICBkLT5pc1ZpZXdXaW5kb3dBY3RpdmUgPSBmYWxzZTsKICAg ICBkLT5wYWdlVmlldy0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZUZvY3VzT3V0RXZlbnQoZXZlbnQp OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXdfcF9wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dl YnZpZXdfcF9wLmgKaW5kZXggMzlhMTRhN2E2NzViYzVkMzY3YzIyNmIzZTQyZGE5OTk0NGVkYjA1 Mi4uOGRhMDliNGQ0MmU5ZjdmYmE4MjcxMDhlOTE2Yjg5ZWE1MmE3MDE0MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaApAQCAt MTMzLDYgKzEzMywxMSBAQCBwdWJsaWM6CiAgICAgUGFzc093blB0cjxEcmF3aW5nQXJlYVByb3h5 PiBjcmVhdGVEcmF3aW5nQXJlYVByb3h5KCk7CiAgICAgdm9pZCBoYW5kbGVEb3dubG9hZFJlcXVl c3QoRG93bmxvYWRQcm94eSopOwogCisgICAgLy8gRklYTUU6IHdlIHNob3VsZG4ndCBiZSBuZWVk aW5nIHRvIGtlZXAgaXNWaWV3V2luZG93QWN0aXZlCisgICAgLy8gYW5kIGNvdWxkICBiZSB1c2lu ZyBjYW52YXMoKS0+aXNBY3RpdmUoKSBkaXJlY3RseSBpbnN0ZWFkCisgICAgLy8gYnV0IGEgYnVn IGluIFF0IGlzIHByZXZlbnRpbmcgdXMgZnJvbSBkb2luZyB0aGF0LgorICAgIGJvb2wgaXNXaW5k b3dBY3RpdmUoKSBjb25zdCB7IHJldHVybiBpc1ZpZXdXaW5kb3dBY3RpdmU7IH0KKwogcHJvdGVj dGVkOgogICAgIFFRdWlja1dlYlZpZXdQcml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdwb3J0KTsK ICAgICBSZWZQdHI8UXRXZWJDb250ZXh0PiBjb250ZXh0OwpAQCAtMTY5LDYgKzE3NCw3IEBAIHBy b3RlY3RlZDoKICAgICBib29sIG1fcmVuZGVyVG9PZmZzY3JlZW5CdWZmZXI7CiAgICAgYm9vbCBt X2xvYWRTdGFydGVkU2lnbmFsU2VudDsKICAgICBib29sIG1fZGlhbG9nUnVubmVyQWN0aXZlOwor ICAgIGJvb2wgaXNWaWV3V2luZG93QWN0aXZlOwogICAgIFFVcmwgbV9pY29uVVJMOwogICAgIFFV cmwgbV9kZWZlcmVkVXJsVG9Mb2FkOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0 L1F0UGFnZUNsaWVudC5jcHAKaW5kZXggZDcwNDljYjNiNjIwODU5YWY5MzZhZTRmNmI2ZThjNGYw MTA1N2VhZS4uOGU0YmE1OThlYTBkYjk4NDFkZDFlNGQ1ZWEzNmI4YmE4NjAzYzdjYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHAKQEAgLTI1NSw4ICsy NTUsOSBAQCBXZWJDb3JlOjpJbnRTaXplIFF0UGFnZUNsaWVudDo6dmlld1NpemUoKQogCiBib29s IFF0UGFnZUNsaWVudDo6aXNWaWV3V2luZG93QWN0aXZlKCkKIHsKLSAgICAvLyBGSVhNRTogVGhl IHNjZW5lIGdyYXBoIGRvZXMgbm90IGhhdmUgdGhlIGNvbmNlcHQgb2YgYmVpbmcgYWN0aXZlIG9y IG5vdCB3aGVuIHRoaXMgd2FzIHdyaXR0ZW4uCi0gICAgcmV0dXJuIHRydWU7CisgICAgLy8gRklY TUU6IHdlIHNob3VsZCByZWFkIGl0IGRpcmVjdGx5IGZyb20gbV93ZWJWaWV3LT5jYW52YXMoKS0+ aXNBY3RpdmUoKQorICAgIC8vIGJ1dCBhIGJ1ZyBpbiBRdCBpcyBwcmV2ZW50aW5nIHVzIGZyb20g dGhhdC4KKyAgICByZXR1cm4gUVF1aWNrV2ViVmlld1ByaXZhdGU6OmdldChtX3dlYlZpZXcpLT5p c1dpbmRvd0FjdGl2ZSgpOwogfQogCiBib29sIFF0UGFnZUNsaWVudDo6aXNWaWV3Rm9jdXNlZCgp Cg== 132081 2012-03-15 11:18:15 -0700 2012-03-20 14:53:04 -0700 Patch bug-81143-20120315151739.patch text/plain 1708 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjczNDJiZmUzYWFlYzgz OWYzOTQwZDUxMDAzY2UyNmEzNzczOGZmOC4uMjhkYTNiY2Q4MmRjMmI5MTViNjNkNjhjOWNlZGJm ZGQzZjNlYzAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTE1ICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gSW1wbGVtZW50IFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggaW1wbGVtZW50cyBQYWdlQ2xpZW50Ojppc1ZpZXdXaW5kb3dBY3RpdmUoKQorICAgICAgICBu b3cgdGhhdCBRUXVpY2tDYW52YXM6OmlzQWN0aXZlKCkgaXMgYXZhaWxhYmxlIChmcm9tIFFXaW5k b3cpLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHA6CisgICAgICAg IChRdFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSk6CisKIDIwMTItMDMtMTQgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggVUkgcHJvY2Vz cyBjcmFzaCB3aGVuIGEgcGx1Zy1pbiBwcm9jZXNzIGNyYXNoZXMgd2l0aCBhIG1vZGFsIGRpYWxv ZyBzaG93aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQYWdl Q2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3Bw CmluZGV4IGQ3MDQ5Y2IzYjYyMDg1OWFmOTM2YWU0ZjZiNmU4YzRmMDEwNTdlYWUuLmJmYzdlZjQy YWM0YmExNWQ3ZDRhZDE3Y2VkYzhiNTY5MmMyODY5MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAi cXF1aWNrd2Vidmlld19wLmgiCiAjaW5jbHVkZSAicXF1aWNrd2Vidmlld19wX3AuaCIKICNpbmNs dWRlIDxRR3VpQXBwbGljYXRpb24+CisjaW5jbHVkZSA8UVF1aWNrQ2FudmFzPgogI2luY2x1ZGUg PFdlYkNvcmUvQ3Vyc29yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9EcmFnRGF0YS5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvRmxvYXRSZWN0Lmg+CkBAIC0yNTUsOCArMjU2LDcgQEAgV2ViQ29yZTo6SW50 U2l6ZSBRdFBhZ2VDbGllbnQ6OnZpZXdTaXplKCkKIAogYm9vbCBRdFBhZ2VDbGllbnQ6OmlzVmll d1dpbmRvd0FjdGl2ZSgpCiB7Ci0gICAgLy8gRklYTUU6IFRoZSBzY2VuZSBncmFwaCBkb2VzIG5v dCBoYXZlIHRoZSBjb25jZXB0IG9mIGJlaW5nIGFjdGl2ZSBvciBub3Qgd2hlbiB0aGlzIHdhcyB3 cml0dGVuLgotICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBtX3dlYlZpZXctPmNhbnZhcygp LT5pc0FjdGl2ZSgpOwogfQogCiBib29sIFF0UGFnZUNsaWVudDo6aXNWaWV3Rm9jdXNlZCgpCg== 132903 2012-03-20 14:53:12 -0700 2012-03-23 16:02:58 -0700 Patch bug-81143-20120320185238.patch text/plain 1751 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGM4NjdmMjFlZjJhMjA1 MGM4ZTM1ZTQ4NWJlNzM0NzA4MDQ3YjMyOC4uMGY5OWJlOTJmZDQ5YmE4ZDY4MWQ4NDVkMzFmNjc1 NjBlODM5MDYxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTIwICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gSW1wbGVtZW50IFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggaW1wbGVtZW50cyBQYWdlQ2xpZW50Ojppc1ZpZXdXaW5kb3dBY3RpdmUoKQorICAgICAgICBu b3cgdGhhdCBRUXVpY2tDYW52YXM6OmlzQWN0aXZlKCkgaXMgYXZhaWxhYmxlIChmcm9tIFFXaW5k b3cpLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHA6CisgICAgICAg IChRdFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSk6CisKIDIwMTItMDMtMTQgIEplc3Vz IFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAg ICAgIFtXSzJdIEFkZCBQYWdlIFZpc2liaWxpdHkgQVBJIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHAKaW5kZXggZDcwNDljYjNiNjIwODU5YWY5 MzZhZTRmNmI2ZThjNGYwMTA1N2VhZS4uYWYwNzk3YjkwOWI4MzIzNmNmNzk2MTFmYmViZTZhM2Fl NGY0NzQyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNs aWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5j cHAKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJxcXVpY2t3ZWJ2aWV3X3AuaCIKICNpbmNs dWRlICJxcXVpY2t3ZWJ2aWV3X3BfcC5oIgogI2luY2x1ZGUgPFFHdWlBcHBsaWNhdGlvbj4KKyNp bmNsdWRlIDxRUXVpY2tDYW52YXM+CiAjaW5jbHVkZSA8V2ViQ29yZS9DdXJzb3IuaD4KICNpbmNs dWRlIDxXZWJDb3JlL0RyYWdEYXRhLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GbG9hdFJlY3QuaD4K QEAgLTI1NSw4ICsyNTYsOSBAQCBXZWJDb3JlOjpJbnRTaXplIFF0UGFnZUNsaWVudDo6dmlld1Np emUoKQogCiBib29sIFF0UGFnZUNsaWVudDo6aXNWaWV3V2luZG93QWN0aXZlKCkKIHsKLSAgICAv LyBGSVhNRTogVGhlIHNjZW5lIGdyYXBoIGRvZXMgbm90IGhhdmUgdGhlIGNvbmNlcHQgb2YgYmVp bmcgYWN0aXZlIG9yIG5vdCB3aGVuIHRoaXMgd2FzIHdyaXR0ZW4uCi0gICAgcmV0dXJuIHRydWU7 CisgICAgaWYgKCFtX3dlYlZpZXcgfHwgIW1fd2ViVmlldy0+Y2FudmFzKCkpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICByZXR1cm4gbV93ZWJWaWV3LT5jYW52YXMoKS0+aXNBY3RpdmUoKTsK IH0KIAogYm9vbCBRdFBhZ2VDbGllbnQ6OmlzVmlld0ZvY3VzZWQoKQo= 133579 2012-03-23 16:03:05 -0700 2012-04-11 08:54:15 -0700 Patch bug-81143-20120323200232.patch text/plain 3471 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGFmNDJjMGQ3NjZiOGFl MTNiMmZkZTZkNGFhNmNjODhkMmJiMTIwNi4uMDg1MDRjYzFmNzg0ZTFhMWM4NDQwOTBiOWQxNmMw NmExZWU4YzI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTIzICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gSW1wbGVtZW50IFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggaW1wbGVtZW50cyBQYWdlQ2xpZW50Ojppc1ZpZXdXaW5kb3dBY3RpdmUoKQorICAgICAgICBu b3cgdGhhdCBRUXVpY2tDYW52YXM6OmlzQWN0aXZlKCkgaXMgYXZhaWxhYmxlIChmcm9tIFFXaW5k b3cpLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHA6CisgICAgICAg IChRdFBhZ2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSk6CisKIDIwMTItMDMtMjMgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxMTE4NTUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRQYWdlQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFBhZ2VDbGllbnQuY3BwCmluZGV4IGQ3MDQ5Y2IzYjYyMDg1OWFmOTM2YWU0ZjZiNmU4YzRmMDEw NTdlYWUuLmFmMDc5N2I5MDliODMyMzZjZjc5NjExZmJlYmU2YTNhZTRmNDc0MmIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCkBAIC0yOSw2ICsyOSw3 IEBACiAjaW5jbHVkZSAicXF1aWNrd2Vidmlld19wLmgiCiAjaW5jbHVkZSAicXF1aWNrd2Vidmll d19wX3AuaCIKICNpbmNsdWRlIDxRR3VpQXBwbGljYXRpb24+CisjaW5jbHVkZSA8UVF1aWNrQ2Fu dmFzPgogI2luY2x1ZGUgPFdlYkNvcmUvQ3Vyc29yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9EcmFn RGF0YS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRSZWN0Lmg+CkBAIC0yNTUsOCArMjU2LDkg QEAgV2ViQ29yZTo6SW50U2l6ZSBRdFBhZ2VDbGllbnQ6OnZpZXdTaXplKCkKIAogYm9vbCBRdFBh Z2VDbGllbnQ6OmlzVmlld1dpbmRvd0FjdGl2ZSgpCiB7Ci0gICAgLy8gRklYTUU6IFRoZSBzY2Vu ZSBncmFwaCBkb2VzIG5vdCBoYXZlIHRoZSBjb25jZXB0IG9mIGJlaW5nIGFjdGl2ZSBvciBub3Qg d2hlbiB0aGlzIHdhcyB3cml0dGVuLgotICAgIHJldHVybiB0cnVlOworICAgIGlmICghbV93ZWJW aWV3IHx8ICFtX3dlYlZpZXctPmNhbnZhcygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg cmV0dXJuIG1fd2ViVmlldy0+Y2FudmFzKCktPmlzQWN0aXZlKCk7CiB9CiAKIGJvb2wgUXRQYWdl Q2xpZW50Ojppc1ZpZXdGb2N1c2VkKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCBjOGI4OTc0ZTgwYmYyNjAwZWQyZDFmMmVhYjVjZDIzNTdlNDQ5 ZjkwLi44Njk4M2NlZDU5Yzc3NjBlYWZkM2E1ZmYwNWM1NTVjZjI0OTNiMjUzIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTItMDMtMjMgIEplc3VzIFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVu Ym9zc2Eub3JnPgorCisgICAgICAgIFtRdF1bV0syXSBJbXBsZW1lbnQgUGFnZUNsaWVudDo6aXNW aWV3V2luZG93QWN0aXZlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgxMTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IHRoZSBXcmFwcGVyV2luZG93IGZyb20gb3VyIFBsYXRmb3JtV2ViVmlldwor ICAgICAgICBzbyBpdCBjb3JyZWN0bHkgY3JlYXRlcyB0aGUgcGxhdGZvcm0gcmVsYXRlZAorICAg ICAgICBzdHVmZiBmb3IgUVdpbmRvdywgd2hpY2ggaXMgbm90IGNyZWF0ZWQgdW5sZXNzCisgICAg ICAgIFFXaW5kb3c6OnNldFZpc2libGUoKSBvciBRV2luZG93OjpzaG93KCkgYXJlIGNhbGxlZC4K KworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwOgor ICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyk6CisKIDIwMTIt MDMtMjMgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGRmaXggZm9yIHRoZSBDaHJvbWl1bSBBbmRyb2lkIGJ1aWxkZXIuCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcCBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCmluZGV4IDdm NTEyMzk5OTJhYjg4M2RjZGE3ZjA0MDFmODQ1MzhlMWZjNDNiZjYuLmYwZmE2NDA4OTljZjEzOTE4 MjNkMDNkYWVhNWY5YjI5ZDcyMmU3OTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv cXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCkBAIC03Niw2ICs3NiwxMiBAQCBQbGF0Zm9ybVdlYlZp ZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tQYWdlR3JvdXBS ZWYgcGFnZUdybwogewogICAgIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWwgZXhwZXJpbWVudGFs KG1fdmlldyk7CiAgICAgZXhwZXJpbWVudGFsLnNldFJlbmRlclRvT2Zmc2NyZWVuQnVmZmVyKHRy dWUpOworCisgICAgLy8gUVdpbmRvdyBkb2VzIG5vdCBjcmVhdGUgdGhlIHVuZGVybHlpbmcgcGxh dGZvcm0KKyAgICAvLyBzcGVjaWZpYyBiaXRzIHVubGVzcyBRV2luZG93OjpzZXRWaXNpYmxlKCkg b3IgUVdpbmRvdzo6c2hvdygpIGFyZSBjYWxsZWQsCisgICAgLy8gYW5kIHdpdGhvdXQgaXQgUVdp bmRvdzo6aXNBY3RpdmUoKSB3aWxsIGFsd2F5cyByZXR1cm4gZmFsc2UuCisgICAgLy8gRm9yIHRo ZXNlIGNhc2VzIFFXaW5kb3c6OmNyZWF0ZSgpIGlzIHByb3ZpZGVkLgorICAgIG1fd2luZG93LT5j cmVhdGUoKTsKIH0KIAogUGxhdGZvcm1XZWJWaWV3Ojp+UGxhdGZvcm1XZWJWaWV3KCkK