80974 2012-03-13 01:33:07 -0700 Dromaeo perf-tests results are wrong 2012-03-14 12:27:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 81142 1 haraken haraken abarth benjamin morrita rniwa webkit.review.bot oldest_to_newest 577159 0 haraken 2012-03-13 01:33:07 -0700 Regarding Dromaeo/dom-attr.html, the ./run-perf-test result is as follows: RESULT Dromaeo: dom-attr= 6270.733871 ms median= 0.0 ms, stdev= 38.4424019328 ms, min= 6203.83270023 ms, max= 6354.54507606 ms Finished: 30.665235 s When I manually change the loop count from 10240 to 1, the ./run-perf-test result becomes: RESULT Dromaeo: dom-attr= 21839544.4 ms median= 0.0 ms, stdev= 50594.7730808 ms, min= 21685174.0 ms, max= 21970762.0 ms Finished: 30.582642 s As you can see, the "ms" number does not make sense. The number should represent the execution time per iteration and thus should be "smaller is better". Also, "median" should not be "0.0 ms". 577187 1 131576 haraken 2012-03-13 02:32:50 -0700 Created attachment 131576 Patch 577192 2 131576 morrita 2012-03-13 02:42:53 -0700 Comment on attachment 131576 Patch Please consider to keep using "run/s" since it's stable. I tried ms. But making them resulted unexpected (and typically longer) running time, especially we cannot assume underlying environment. Also, I guess |runStyle| could be specified externally via URL query string. Please do it if possible. Since this Dromaeo source is copied from upstream. If there is any obvious errors there, I encourage you to upstream the fix. 577197 3 haraken 2012-03-13 02:52:44 -0700 (In reply to comment #2) > (From update of attachment 131576 [details]) > Please consider to keep using "run/s" since it's stable. > I tried ms. But making them resulted unexpected (and typically longer) running time, especially we cannot assume underlying environment. This is the reason why I removed 'if (runStyle === "runs/s")' part. Now the running time does not change between run/s and ms. > Also, I guess |runStyle| could be specified externally via URL query string. > Please do it if possible. Let me try it. > Since this Dromaeo source is copied from upstream. > If there is any obvious errors there, > I encourage you to upstream the fix. If the patch looks OK, I'll try it. But it will take time, and I would like to land the patch into WebKit first. The current Dromaeo results have been preventing me from evaluating performance optimization patches. 577208 4 131582 haraken 2012-03-13 03:21:24 -0700 Created attachment 131582 Patch 577257 5 131599 haraken 2012-03-13 06:22:44 -0700 Created attachment 131599 Patch 577260 6 131600 haraken 2012-03-13 06:29:16 -0700 Created attachment 131600 Patch 577280 7 131600 webkit.review.bot 2012-03-13 07:10:08 -0700 Comment on attachment 131600 Patch Clearing flags on attachment: 131600 Committed r110559: <http://trac.webkit.org/changeset/110559> 577281 8 webkit.review.bot 2012-03-13 07:10:14 -0700 All reviewed patches have been landed. Closing bug. 578633 9 benjamin 2012-03-14 12:18:43 -0700 I think this broke most of the Dromaeo tests on WebKit-perf: http://webkit-perf.appspot.com/ They all report a time of 0 now. 578637 10 131600 rniwa 2012-03-14 12:21:26 -0700 Comment on attachment 131600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131600&action=review > PerformanceTests/Dromaeo/resources/dromaeorunner.js:16 > + median += 1000 / item.median; This makes no sense. The sum of medians isn't the median of all samples. 578642 11 rniwa 2012-03-14 12:24:19 -0700 What we need to do is to fix https://bugs.webkit.org/show_bug.cgi?id=78303. We don't want to invent our own score for Dromaeo. 131576 2012-03-13 02:32:50 -0700 2012-03-13 03:21:18 -0700 Patch bug-80974-20120313183248.patch text/plain 4144 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTQ3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUxYjY5OTNjOWI2 MDBhN2I0OWZhMzhjMTUyNDZlYjAxMTgxOWE2M2IuLjg4NGI1MGFkMDBmMGJhYzYxZjk1YjIwNzhh MThlMjYxNDA1YTQwYWQgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMt MTMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERyb21h ZW8gcGVyZi10ZXN0cyByZXN1bHRzIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEcm9tYWVvIHBlcmYtdGVzdHMgaGF2ZSBiZWVuIG91dHB1 dGluZyBtZWFuaW5nbGVzcyByZXN1bHRzLgorICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGEgRHJv bWFlbyBwZXJmLXRlc3QgcnVubmVyIHNvIHRoYXQKKyAgICAgICAgaXQgb3V0cHV0cyB0aGUgZXhl Y3V0aW9uIHRpbWUgKG1zKSBwZXIgcnVuLgorCisgICAgICAgICogRHJvbWFlby9yZXNvdXJjZXMv ZHJvbWFlby93ZWIvd2VicnVubmVyLmpzOgorICAgICAgICAoLik6CisKIDIwMTItMDMtMTIgIEls eWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGNocm9taXVtOiBpbmNyZWFzZSBoZWFwIHNuYXBzaG90IHBlcmZvcm1hbmNlIGNvdmVy YWdlLgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL3Jlc291cmNlcy9kcm9t YWVvL3dlYi93ZWJydW5uZXIuanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2Vz L2Ryb21hZW8vd2ViL3dlYnJ1bm5lci5qcwppbmRleCAzMjQ0NDYxNjRhNjA2YjkwNGIyOWEwODIw ZDcyZmUxMjA2YWJhYTI2Li44Yzg0ZmIxNjZlZGYxMTdhYTI4NzJmNzRjMDBjZDU0NjlhMmJiZDkw IDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW8v d2ViL3dlYnJ1bm5lci5qcworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2Vz L2Ryb21hZW8vd2ViL3dlYnJ1bm5lci5qcwpAQCAtOCw3ICs4LDcgQEAKICAgICAgICAgdmFyIG51 bVRlc3RzID0gNTsKICAgICAgICAgCiAgICAgICAgIC8vIFRoZSB0eXBlIG9mIHJ1biB0aGF0IHdl J3JlIGRvaW5nIChvcHRpb25zIGFyZSAicnVucy9zIiBvciAibXMiKQotICAgICAgICB2YXIgcnVu U3R5bGUgPSAicnVucy9zIjsKKyAgICAgICAgdmFyIHJ1blN0eWxlID0gIm1zIjsKICAgICAgICAg CiAgICAgICAgIC8vIEEgcm91Z2ggZXN0aW1hdGUsIGluIHNlY29uZHMsIG9mIGhvdyBsb25nIGl0 J2xsIHRha2UgZWFjaCB0ZXN0CiAgICAgICAgIC8vIGl0ZXJhdGlvbiB0byBydW4KQEAgLTg5LDM0 ICs4OSwyOCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29ubmVjdFNoYXJrKCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzdGFydFNoYXJrKCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnQgPSAobmV3IERhdGUo KSkuZ2V0VGltZSgpOwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICggcnVuU3R5bGUgPT09 ICJydW5zL3MiICkgewotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdmFyIHJ1bnMgPSAwOwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjdXIgPSAobmV3IERhdGUoKSkuZ2V0VGltZSgpOwotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB3aGlsZSAoIChjdXIgLSBzdGFydCkgPCAxMDAwICkgewotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbigp OwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjdXIgPSAobmV3IERhdGUoKSkuZ2V0VGltZSgpOwotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBydW5zKys7Ci0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGZuKCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjdXIgPSAobmV3IERhdGUoKSkuZ2V0VGltZSgpOworCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFyIHJ1bnMgPSAwOworCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3VyID0gKG5ldyBEYXRlKCkpLmdldFRp bWUoKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3aGlsZSAoIChj dXIgLSBzdGFydCkgPCAxMDAwICkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBmbigpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjdXIgPSAobmV3IERhdGUoKSkuZ2V0VGltZSgpOworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBydW5zKys7CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaWYgKCBkb1NoYXJrKG5hbWUpICkgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc3RvcFNoYXJrKCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBkaXNjb25uZWN0U2hhcmsoKTsKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCisKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAv LyBGb3IgbWFraW5nIE1lZGlhbiBhbmQgVmFyaWFuY2UKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpZiAoIHJ1blN0eWxlID09PSAicnVucy9zIiApIHsKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRpbWVzLnB1c2goIChydW5z ICogMTAwMCkgLyAoY3VyIC0gc3RhcnQpICk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRpbWVzLnB1c2goIChydW5zICogMTAwMCkgLyAoY3VyIC0gc3RhcnQp ICk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRpbWVzLnB1c2go IGN1ciAtIHN0YXJ0ICk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHRpbWVzLnB1c2goIChjdXIgLSBzdGFydCkgLyBydW5zICk7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB9IGNhdGNoKCBlICkgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGFsZXJ0KCJGQUlMICIgKyBuYW1lICsgIiAiICsgbnVtICsgZSk7Cg== 131582 2012-03-13 03:21:24 -0700 2012-03-13 06:22:36 -0700 Patch bug-80974-20120313192123.patch text/plain 2443 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTQ3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUxYjY5OTNjOWI2 MDBhN2I0OWZhMzhjMTUyNDZlYjAxMTgxOWE2M2IuLjMzNzg5M2ZhYzFhMTMyOTNmMDc5NTE5MDEy MTZjMDAwYzExOTllODYgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDMt MTMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERyb21h ZW8gcGVyZi10ZXN0cyByZXN1bHRzIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEcm9tYWVvIHBlcmYtdGVzdHMgaGFkIHJlcG9ydGVkIHRo ZSBzdW0gb2YgcnVucy9zZWNvbmRzIGFzICJtcyIuCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMg dGhlbSB0byByZXBvcnQgdGhlIGV4ZWN1dGlvbiB0aW1lIHBlciBydW4uCisKKyAgICAgICAgQXQg cHJlc2VudCwgdGhleSByZXBvcnQgIjAuMG1zIiBmb3IgInN0ZGV2Ii4gVGhpcyBpcyBiZWNhdXNl CisgICAgICAgIGRyb21hZW9ydW5uZXIuanMgY2FuIGp1c3Qga25vdyBzdGRldiBvZiAicnVucy9z ZWNvbmRzIgorICAgICAgICBhbmQgY2Fubm90IGNhbGN1bGF0ZSBzdGRldiBvZiAibXMiIGZyb20g dGhhdC4gV2UgY2FuIGZpeCBpdCBsYXRlci4KKworICAgICAgICAqIERyb21hZW8vcmVzb3VyY2Vz L2Ryb21hZW9ydW5uZXIuanM6CisgICAgICAgICguKToKKwogMjAxMi0wMy0xMiAgSWx5YSBUaWto b25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog Y2hyb21pdW06IGluY3JlYXNlIGhlYXAgc25hcHNob3QgcGVyZm9ybWFuY2UgY292ZXJhZ2UuCmRp ZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5u ZXIuanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5uZXIu anMKaW5kZXggMTM2MDkzZThkZjQ1NTI3MzI5ZGI2NTgyYmM2ZjQ0MGQwNjc1YTJiZC4uYmFjYjhk OTY2YzFhNjQ5MzJlMmVjMzJhZDY2Mzc5NTFjMDJkMjZmOSAxMDA2NDQKLS0tIGEvUGVyZm9ybWFu Y2VUZXN0cy9Ecm9tYWVvL3Jlc291cmNlcy9kcm9tYWVvcnVubmVyLmpzCisrKyBiL1BlcmZvcm1h bmNlVGVzdHMvRHJvbWFlby9yZXNvdXJjZXMvZHJvbWFlb3J1bm5lci5qcwpAQCAtMywyMiArMywy MiBAQAogICAgICAgICAgYmFzZVVSTDogIi4vcmVzb3VyY2VzL2Ryb21hZW8vd2ViL2luZGV4Lmh0 bWwiLAogCiAgICAgICAgICBjb21wdXRlU2NvcmVzOiBmdW5jdGlvbiAocmVzdWx0cykgewotICAg ICAgICAgICAgIHZhciBtZWFuID0gMCwgbWluID0gMCwgbWF4ID0gMCwgc3RkZXYgPSAwLCB2YXJz dW0gPSAwOworICAgICAgICAgICAgIHZhciBtZWFuID0gMCwgbWluID0gMCwgbWF4ID0gMCwgbWVk aWFuID0gMDsKIAogICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVzdWx0cy5sZW5n dGg7ICsraSkgewogICAgICAgICAgICAgICAgICB2YXIgaXRlbSA9IHJlc3VsdHNbaV07Ci0gICAg ICAgICAgICAgICAgIG1lYW4gKz0gaXRlbS5tZWFuOwotICAgICAgICAgICAgICAgICBtaW4gKz0g aXRlbS5taW47Ci0gICAgICAgICAgICAgICAgIG1heCArPSBpdGVtLm1heDsKLSAgICAgICAgICAg ICAgICAgdmFyc3VtICs9IGl0ZW0uZGV2aWF0aW9uICogaXRlbS5kZXZpYXRpb247CisgICAgICAg ICAgICAgICAgIG1lYW4gKz0gMSAvIGl0ZW0ubWVhbjsKKyAgICAgICAgICAgICAgICAgbWluICs9 IDEgLyBpdGVtLm1heDsKKyAgICAgICAgICAgICAgICAgbWF4ICs9IDEgLyBpdGVtLm1pbjsKKyAg ICAgICAgICAgICAgICAgbWVkaWFuICs9IDEgLyBpdGVtLm1lZGlhbjsKICAgICAgICAgICAgICB9 CiAKICAgICAgICAgICAgICByZXR1cm4gewotICAgICAgICAgICAgICAgICBtZWRpYW46IDAsCi0g ICAgICAgICAgICAgICAgIG1lYW46IG1lYW4sCi0gICAgICAgICAgICAgICAgIG1pbjogbWluLAot ICAgICAgICAgICAgICAgICBtYXg6IG1heCwKLSAgICAgICAgICAgICAgICAgc3RkZXY6IE1hdGgu c3FydCh2YXJzdW0pCisgICAgICAgICAgICAgICAgIG1lZGlhbjogbWVkaWFuICogMTAwMCwKKyAg ICAgICAgICAgICAgICAgbWVhbjogbWVhbiAqIDEwMDAsCisgICAgICAgICAgICAgICAgIG1pbjog bWluICogMTAwMCwKKyAgICAgICAgICAgICAgICAgbWF4OiBtYXggKiAxMDAwLAorICAgICAgICAg ICAgICAgICBzdGRldjogMAogICAgICAgICAgICAgIH07CiAgICAgICAgICB9LAogCg== 131599 2012-03-13 06:22:44 -0700 2012-03-13 06:29:11 -0700 Patch bug-80974-20120313222243.patch text/plain 2573 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTQ3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUxYjY5OTNjOWI2 MDBhN2I0OWZhMzhjMTUyNDZlYjAxMTgxOWE2M2IuLjZiOTk0ZmMzZDhkNDE4MDBjMTgwNzYzODgx MmFlNmVhMmY4MDA5MjAgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDMt MTMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERyb21h ZW8gcGVyZi10ZXN0cyByZXN1bHRzIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEcm9tYWVvIHBlcmYtdGVzdHMgaGFkIHJlcG9ydGVkIHRo ZSBzdW0gb2YgcnVucy9zZWNvbmRzIGFzICJtcyIuCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMg dGhlbSB0byByZXBvcnQgdGhlIGV4ZWN1dGlvbiB0aW1lIHBlciBydW4uCisKKyAgICAgICAgQXQg cHJlc2VudCwgdGhleSByZXBvcnQgIjAuMG1zIiBmb3IgInN0ZGV2Ii4gVGhpcyBpcyBiZWNhdXNl CisgICAgICAgIGRyb21hZW9ydW5uZXIuanMgY2FuIGp1c3Qga25vdyBzdGRldiBvZiAicnVucy9z ZWNvbmRzIgorICAgICAgICBhbmQgY2Fubm90IGNhbGN1bGF0ZSBzdGRldiBvZiAibXMiIGZyb20g dGhhdC4gV2UgY2FuIGZpeCBpdCBsYXRlci4KKworICAgICAgICAqIERyb21hZW8vcmVzb3VyY2Vz L2Ryb21hZW9ydW5uZXIuanM6IElmIGl0ZW0ueHh4IGlzIDAsIHRoZW4gTmFOIHdpbGwgYmUKKyAg ICAgICAgb3V0cHV0IGZvciB4eHguIFRoaXMgaXMgYW4gaW50ZW5kZWQgYmVoYXZpb3IgKHNvIHRo YXQgd2UgY2FuIG5vdGljZSBzb21ldGhpbmcgd3JvbmcpLgorICAgICAgICAoLik6CisKIDIwMTIt MDMtMTIgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGNocm9taXVtOiBpbmNyZWFzZSBoZWFwIHNuYXBzaG90IHBlcmZvcm1h bmNlIGNvdmVyYWdlLgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL3Jlc291 cmNlcy9kcm9tYWVvcnVubmVyLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL3Jlc291cmNl cy9kcm9tYWVvcnVubmVyLmpzCmluZGV4IDEzNjA5M2U4ZGY0NTUyNzMyOWRiNjU4MmJjNmY0NDBk MDY3NWEyYmQuLmJhY2I4ZDk2NmMxYTY0OTMyZTJlYzMyYWQ2NjM3OTUxYzAyZDI2ZjkgMTAwNjQ0 Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvRHJvbWFlby9yZXNvdXJjZXMvZHJvbWFlb3J1bm5lci5q cworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5uZXIu anMKQEAgLTMsMjIgKzMsMjIgQEAKICAgICAgICAgIGJhc2VVUkw6ICIuL3Jlc291cmNlcy9kcm9t YWVvL3dlYi9pbmRleC5odG1sIiwKIAogICAgICAgICAgY29tcHV0ZVNjb3JlczogZnVuY3Rpb24g KHJlc3VsdHMpIHsKLSAgICAgICAgICAgICB2YXIgbWVhbiA9IDAsIG1pbiA9IDAsIG1heCA9IDAs IHN0ZGV2ID0gMCwgdmFyc3VtID0gMDsKKyAgICAgICAgICAgICB2YXIgbWVhbiA9IDAsIG1pbiA9 IDAsIG1heCA9IDAsIG1lZGlhbiA9IDA7CiAKICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsg aSA8IHJlc3VsdHMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgICAgICAgdmFyIGl0ZW0gPSBy ZXN1bHRzW2ldOwotICAgICAgICAgICAgICAgICBtZWFuICs9IGl0ZW0ubWVhbjsKLSAgICAgICAg ICAgICAgICAgbWluICs9IGl0ZW0ubWluOwotICAgICAgICAgICAgICAgICBtYXggKz0gaXRlbS5t YXg7Ci0gICAgICAgICAgICAgICAgIHZhcnN1bSArPSBpdGVtLmRldmlhdGlvbiAqIGl0ZW0uZGV2 aWF0aW9uOworICAgICAgICAgICAgICAgICBtZWFuICs9IDEgLyBpdGVtLm1lYW47CisgICAgICAg ICAgICAgICAgIG1pbiArPSAxIC8gaXRlbS5tYXg7CisgICAgICAgICAgICAgICAgIG1heCArPSAx IC8gaXRlbS5taW47CisgICAgICAgICAgICAgICAgIG1lZGlhbiArPSAxIC8gaXRlbS5tZWRpYW47 CiAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgcmV0dXJuIHsKLSAgICAgICAgICAgICAg ICAgbWVkaWFuOiAwLAotICAgICAgICAgICAgICAgICBtZWFuOiBtZWFuLAotICAgICAgICAgICAg ICAgICBtaW46IG1pbiwKLSAgICAgICAgICAgICAgICAgbWF4OiBtYXgsCi0gICAgICAgICAgICAg ICAgIHN0ZGV2OiBNYXRoLnNxcnQodmFyc3VtKQorICAgICAgICAgICAgICAgICBtZWRpYW46IG1l ZGlhbiAqIDEwMDAsCisgICAgICAgICAgICAgICAgIG1lYW46IG1lYW4gKiAxMDAwLAorICAgICAg ICAgICAgICAgICBtaW46IG1pbiAqIDEwMDAsCisgICAgICAgICAgICAgICAgIG1heDogbWF4ICog MTAwMCwKKyAgICAgICAgICAgICAgICAgc3RkZXY6IDAKICAgICAgICAgICAgICB9OwogICAgICAg ICAgfSwKIAo= 131600 2012-03-13 06:29:16 -0700 2012-03-14 12:21:26 -0700 Patch bug-80974-20120313222914.patch text/plain 2512 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTQ3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUxYjY5OTNjOWI2 MDBhN2I0OWZhMzhjMTUyNDZlYjAxMTgxOWE2M2IuLjMzNzg5M2ZhYzFhMTMyOTNmMDc5NTE5MDEy MTZjMDAwYzExOTllODYgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDMt MTMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERyb21h ZW8gcGVyZi10ZXN0cyByZXN1bHRzIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEcm9tYWVvIHBlcmYtdGVzdHMgaGFkIHJlcG9ydGVkIHRo ZSBzdW0gb2YgcnVucy9zZWNvbmRzIGFzICJtcyIuCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMg dGhlbSB0byByZXBvcnQgdGhlIGV4ZWN1dGlvbiB0aW1lIHBlciBydW4uCisKKyAgICAgICAgQXQg cHJlc2VudCwgdGhleSByZXBvcnQgIjAuMG1zIiBmb3IgInN0ZGV2Ii4gVGhpcyBpcyBiZWNhdXNl CisgICAgICAgIGRyb21hZW9ydW5uZXIuanMgY2FuIGp1c3Qga25vdyBzdGRldiBvZiAicnVucy9z ZWNvbmRzIgorICAgICAgICBhbmQgY2Fubm90IGNhbGN1bGF0ZSBzdGRldiBvZiAibXMiIGZyb20g dGhhdC4gV2UgY2FuIGZpeCBpdCBsYXRlci4KKworICAgICAgICAqIERyb21hZW8vcmVzb3VyY2Vz L2Ryb21hZW9ydW5uZXIuanM6CisgICAgICAgICguKToKKwogMjAxMi0wMy0xMiAgSWx5YSBUaWto b25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog Y2hyb21pdW06IGluY3JlYXNlIGhlYXAgc25hcHNob3QgcGVyZm9ybWFuY2UgY292ZXJhZ2UuCmRp ZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5u ZXIuanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5uZXIu anMKaW5kZXggMTM2MDkzZThkZjQ1NTI3MzI5ZGI2NTgyYmM2ZjQ0MGQwNjc1YTJiZC4uNDdjN2Yy OGNmN2NkYzhkMzE0ODQxYjE0MjIwZjg4OTdmN2MwZTQ4ZSAxMDA2NDQKLS0tIGEvUGVyZm9ybWFu Y2VUZXN0cy9Ecm9tYWVvL3Jlc291cmNlcy9kcm9tYWVvcnVubmVyLmpzCisrKyBiL1BlcmZvcm1h bmNlVGVzdHMvRHJvbWFlby9yZXNvdXJjZXMvZHJvbWFlb3J1bm5lci5qcwpAQCAtMywyMiArMywy NSBAQAogICAgICAgICAgYmFzZVVSTDogIi4vcmVzb3VyY2VzL2Ryb21hZW8vd2ViL2luZGV4Lmh0 bWwiLAogCiAgICAgICAgICBjb21wdXRlU2NvcmVzOiBmdW5jdGlvbiAocmVzdWx0cykgewotICAg ICAgICAgICAgIHZhciBtZWFuID0gMCwgbWluID0gMCwgbWF4ID0gMCwgc3RkZXYgPSAwLCB2YXJz dW0gPSAwOworICAgICAgICAgICAgIHZhciBtZWFuID0gMCwgbWluID0gMCwgbWF4ID0gMCwgbWVk aWFuID0gMDsKIAogICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVzdWx0cy5sZW5n dGg7ICsraSkgewogICAgICAgICAgICAgICAgICB2YXIgaXRlbSA9IHJlc3VsdHNbaV07Ci0gICAg ICAgICAgICAgICAgIG1lYW4gKz0gaXRlbS5tZWFuOwotICAgICAgICAgICAgICAgICBtaW4gKz0g aXRlbS5taW47Ci0gICAgICAgICAgICAgICAgIG1heCArPSBpdGVtLm1heDsKLSAgICAgICAgICAg ICAgICAgdmFyc3VtICs9IGl0ZW0uZGV2aWF0aW9uICogaXRlbS5kZXZpYXRpb247CisgICAgICAg ICAgICAgICAgIGlmIChpdGVtLm1lYW4gPT0gMCB8fCBpdGVtLm1heCA9PSAwIHx8IGl0ZW0ubWlu ID09IDAgfHwgaXRlbS5tZWRpYW4gPT0gMCkKKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiB7 bWVkaWFuOiAwLCBtZWFuOiAwLCBtaW46IDAsIG1heDogMCwgc3RkZXY6IDB9OworCisgICAgICAg ICAgICAgICAgIG1lYW4gKz0gMTAwMCAvIGl0ZW0ubWVhbjsKKyAgICAgICAgICAgICAgICAgbWlu ICs9IDEwMDAgLyBpdGVtLm1heDsKKyAgICAgICAgICAgICAgICAgbWF4ICs9IDEwMDAgLyBpdGVt Lm1pbjsKKyAgICAgICAgICAgICAgICAgbWVkaWFuICs9IDEwMDAgLyBpdGVtLm1lZGlhbjsKICAg ICAgICAgICAgICB9CiAKICAgICAgICAgICAgICByZXR1cm4gewotICAgICAgICAgICAgICAgICBt ZWRpYW46IDAsCisgICAgICAgICAgICAgICAgIG1lZGlhbjogbWVkaWFuLAogICAgICAgICAgICAg ICAgICBtZWFuOiBtZWFuLAogICAgICAgICAgICAgICAgICBtaW46IG1pbiwKICAgICAgICAgICAg ICAgICAgbWF4OiBtYXgsCi0gICAgICAgICAgICAgICAgIHN0ZGV2OiBNYXRoLnNxcnQodmFyc3Vt KQorICAgICAgICAgICAgICAgICBzdGRldjogMAogICAgICAgICAgICAgIH07CiAgICAgICAgICB9 LAogCg==