8085 2006-03-30 09:48:47 -0800 REGRESSION: Main menu positioned incorrectly on eia.org and fedex.com/us 2006-04-04 01:56:59 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 VERIFIED FIXED http://www.eia.org/ NeedsReduction, Regression P1 Normal --- 1 mitz webkit-unassigned bdakin daniele.metilli oldest_to_newest 37997 0 mitz 2006-03-30 09:48:47 -0800 The green menu bar on eia.org should be at the top, right below the blue site head. In TOT it appears in the middle of the page. 38185 1 mitz 2006-04-01 10:40:18 -0800 This bug seems to be caused at least in part by offsetTop() returning the wrong offset, for the same underlying reason as bug 8081. I tried skipping table rows in RenderObject::offsetTop() but it didn't fix the bug completely, only moved the menu up. 38273 2 mitz 2006-04-02 09:00:49 -0700 This bug is seen also in http://fedex.com/us/ . I also noticed that the EIA site behaves differently when I set the user agent to Netscape 7 (still off, but not by as much), so maybe they have Safari-specific code to work around the old behavior where table rows' offsetTop was 0, and the fix for this bug is really not to add table rows in RenderObject::offsetTop(). 38389 3 mitz 2006-04-03 08:44:52 -0700 *** Bug 8151 has been marked as a duplicate of this bug. *** 38413 4 7489 mitz 2006-04-03 13:01:53 -0700 Created attachment 7489 Fix table cells' offsetTop This patch fixes fedex.com and the site mentioned in bug 8151 but not eia.org. I think the latter either has Safari-specific code to accommodate the old behavior (of rows' offsetTop being 0) or there's a different bug affecting it. fast/dom seems like the wrong place for the layout test. Feel free to relocate it when-if landing. 7489 2006-04-03 13:01:53 -0700 2006-04-03 13:13:02 -0700 Fix table cells' offsetTop 8085_r1.patch text/plain 4191 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzNjUzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDQtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTgwODUKKyAgICAgICAgICBSRUdSRVNTSU9OOiBNYWluIG1l bnUgcG9zaXRpb25lZCBpbmNvcnJlY3RseSBvbiBlaWEub3JnIGFuZCBmZWRleC5jb20vdXMKKwor ICAgICAgICAqIGZhc3QvZG9tL0VsZW1lbnQvb2Zmc2V0VG9wLXRhYmxlLWNlbGwtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1j ZWxsLmh0bWw6IEFkZGVkLgorCiAyMDA2LTA0LTAzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBA bnlwb3AuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRUb3AtdGFibGUtY2VsbC1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRUb3AtdGFibGUt Y2VsbC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9F bGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSw2IEBACitUaGlzIGlzIGEgcmVncmVzc2lvbiB0ZXN0IGZvciBodHRwOi8vYnVnemls bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTgwODUgUkVHUkVTU0lPTjogTWFpbiBt ZW51IHBvc2l0aW9uZWQgaW5jb3JyZWN0bHkgb24gZWlhLm9yZyBhbmQgZmVkZXguY29tL3VzLgor CitSb3cgMiB0b3Agb2Zmc2V0OjUwCitDZWxsIDIgdG9wIG9mZnNldDo5MAorVGVzdCByZXN1bHQ6 IFBBU1MKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRUb3AtdGFi bGUtY2VsbC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1lbnQv b2Zmc2V0VG9wLXRhYmxlLWNlbGwuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvZG9tL0VsZW1lbnQvb2Zmc2V0VG9wLXRhYmxlLWNlbGwuaHRtbAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwzOCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+Cit0 ciNyb3cxIHRkIHsgaGVpZ2h0OiA1MHB4OyB9Cit0ZCB7IHdpZHRoOiA1MHB4OyB9Cit0ZCNjZWxs MSB7IGhlaWdodDogMTAwcHg7IH0KK3RkI2NlbGwyIGRpdiB7IGhlaWdodDogMjBweDsgfQorPC9z dHlsZT4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2lmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor CitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImNvbnNvbGUiKTsKKyAgICByb3dPZmZzZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi cm93MiIpLm9mZnNldFRvcDsKKyAgICBjZWxsT2Zmc2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImNlbGwyIikub2Zmc2V0VG9wOworICAgIGNvbnNvbGUuaW5uZXJUZXh0ICs9ICJSb3cgMiB0 b3Agb2Zmc2V0OiIgKyByb3dPZmZzZXQ7CisgICAgY29uc29sZS5pbm5lclRleHQgKz0gIlxuIjsK KyAgICBjb25zb2xlLmlubmVyVGV4dCArPSAiQ2VsbCAyIHRvcCBvZmZzZXQ6IiArIGNlbGxPZmZz ZXQ7CisgICAgY29uc29sZS5pbm5lclRleHQgKz0gIlxuIjsKKyAgICBjb25zb2xlLmlubmVyVGV4 dCArPSAiVGVzdCByZXN1bHQ6ICIKKyAgICBjb25zb2xlLmlubmVyVGV4dCArPSAocm93T2Zmc2V0 ID09IDUwICYmIGNlbGxPZmZzZXQgPT0gOTAgPyAiUEFTUyIgOiAiRkFJTCIpOworfQorPC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Cis8cD5UaGlzIGlzIGEgcmVncmVz c2lvbiB0ZXN0IGZvciA8aT48YSBocmVmPSJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcv c2hvd19idWcuY2dpP2lkPTgwODUiPmh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODA4NTwvYT4KK1JFR1JFU1NJT046IE1haW4gbWVudSBwb3NpdGlvbmVkIGlu Y29ycmVjdGx5IG9uIGVpYS5vcmcgYW5kIGZlZGV4LmNvbS91czwvaT4uCis8L3A+Cis8cHJlIGlk PSJjb25zb2xlIj4KKzwvcHJlPgorPHRhYmxlIGNlbGxzcGFjaW5nPSIwIiBjZWxscGFkZGluZz0i MCI+Cis8dHIgaWQ9InJvdzEiPjx0ZCBjb2xzcGFuPSIyIj48L3RkPjwvdHI+Cis8dHIgaWQ9InJv dzIiPjx0ZCBpZD0iY2VsbDEiPjwvdGQ+PHRkIGlkPSJjZWxsMiI+PGRpdj48L2Rpdj48L3RkPjwv dHI+Cis8L3RhYmxlPgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjUzKQorKysgV2Vi Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAwNi0wNC0j IyAgTWl0eiBQZXR0ZWwgIDxvcGVuZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeCBodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTgwODUKKyAgICAgICAgICBSRUdS RVNTSU9OOiBNYWluIG1lbnUgcG9zaXRpb25lZCBpbmNvcnJlY3RseSBvbiBlaWEub3JnIGFuZCBm ZWRleC5jb20vdXMKKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10 YWJsZS1jZWxsLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpvZmZzZXRUb3ApOiBTa2lwIHRhYmxlIHJv d3Mgd2hlbiBhZGRpbmcgdXAKKyAgICAgICAgdGhlIG9mZnNldHMsIHNpbmNlIGEgdGFibGUgY2Vs bCdzIHlQb3MoKSBpcyByZWxhdGl2ZSB0byB0aGUgdGFibGUKKyAgICAgICAgc2VjdGlvbiwgbm90 IHRoZSByb3cuCisKIDIwMDYtMDQtMDMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBvcC5j b20+CiAKICAgICAgICAgRml4ZWQgYSBjb21tZW50IChmb3Jnb3QgdG8gc2F2ZSB0aGUgZmlsZSBi ZWZvcmUgdGhlIHByZXZpb3VzIGNvbW1pdCkuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVj dC5jcHAJKHJldmlzaW9uIDEzNjQ4KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgwLDcgKzU4MCw4IEBAIGludCBSZW5kZXJPYmplY3Q6 Om9mZnNldFRvcCgpIGNvbnN0CiAgICAgICAgIFJlbmRlck9iamVjdCogb2Zmc2V0UGFyID0gb2Zm c2V0UGFyZW50KCk7CiAgICAgICAgIFJlbmRlck9iamVjdCogY3VyciA9IHBhcmVudCgpOwogICAg ICAgICB3aGlsZSAoY3VyciAmJiBjdXJyICE9IG9mZnNldFBhcikgewotICAgICAgICAgICAgeSAr PSBjdXJyLT55UG9zKCk7CisgICAgICAgICAgICBpZiAoIWN1cnItPmlzVGFibGVSb3coKSkKKyAg ICAgICAgICAgICAgICB5ICs9IGN1cnItPnlQb3MoKTsKICAgICAgICAgICAgIGN1cnIgPSBjdXJy LT5wYXJlbnQoKTsKICAgICAgICAgfQogICAgIH0K