80835 2012-03-12 07:26:16 -0700 Style checker complains about naming parameter with default values 2012-12-28 08:34:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 tonikitoo webkit-unassigned abarth ap zan oldest_to_newest 576111 0 tonikitoo 2012-03-12 07:26:16 -0700 It happened in https://bugs.webkit.org/show_bug.cgi?id=79611#c4 Code looks like this: - void calculateScrollbarModesForLayout(ScrollbarMode& hMode, ScrollbarMode& vMode); + void calculateScrollbarModesForLayout(ScrollbarMode& hMode, ScrollbarMode& vMode, ScrollbarModesCalculationStrategy strategy = AnyRule); and the code style checker complained that 'strategy' added not value: >> Source/WebCore/page/FrameView.h:283: The parameter name "strategy" adds no information, so it should be removed. [readability/parameter_name] [5] However it is needed, given the default value. 576210 1 ap 2012-03-12 10:04:33 -0700 Actually, this should work: + void calculateScrollbarModesForLayout(ScrollbarMode& hMode, ScrollbarMode& vMode, ScrollbarModesCalculationStrategy = AnyRule); 576237 2 tonikitoo 2012-03-12 10:24:39 -0700 (In reply to comment #1) > Actually, this should work: > > + void calculateScrollbarModesForLayout(ScrollbarMode& hMode, ScrollbarMode& vMode, ScrollbarModesCalculationStrategy = AnyRule); oh thanks, so this is INVALID. 797911 3 levin 2012-12-28 08:34:33 -0800 *** Bug 105831 has been marked as a duplicate of this bug. ***