80655 2012-03-08 16:27:14 -0800 Change calcRadiiFor to IntSize 2012-03-08 21:01:02 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric jchaffraix leviw simon.fraser webkit.review.bot oldest_to_newest 574368 0 eae 2012-03-08 16:27:14 -0800 Since borders and RoundedRect are both using integers it doesn't make sense for calcRadiiFor to use LayoutRects. It just adds unnecessary type conversions. 574371 1 130936 eae 2012-03-08 16:31:29 -0800 Created attachment 130936 Patch 574386 2 130936 eae 2012-03-08 16:41:45 -0800 Comment on attachment 130936 Patch Thanks Simon! 574568 3 130936 webkit.review.bot 2012-03-08 21:00:58 -0800 Comment on attachment 130936 Patch Clearing flags on attachment: 130936 Committed r110260: <http://trac.webkit.org/changeset/110260> 574569 4 webkit.review.bot 2012-03-08 21:01:02 -0800 All reviewed patches have been landed. Closing bug. 130936 2012-03-08 16:31:29 -0800 2012-03-08 21:00:58 -0800 Patch bug-80655-20120308163128.patch text/plain 2566 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDIyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTA4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2UgY2FsY1JhZGlpRm9y IHRvIEludFNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgwNjU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQm9yZGVycyBhbmQgUm91bmRlZFJlY3QgYXJlIGJvdGggcmVwcmVzZW50ZWQgd2l0aCBwaXhl bCBwcmVjaXNpb24uIEFzCisgICAgICAgIHN1Y2ggaXQgZG9lc24ndCBtYWtlIHNlbnNlIGZvciBj YWxjUmFkaWlGb3IgdG8gdXNlIHN1YnBpeGVsIHVuaXRzLCBpdAorICAgICAgICBqdXN0IGFkZHMg dW5uZWNlc3NhcnkgdHlwZSBjb252ZXJzaW9ucy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5v IG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0 eWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNhbGNSYWRpaUZvcik6CisKIDIwMTItMDMtMDgg IEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVc2UgYW4g ZXhwbGljaXQgYXR0cmlidXRlIHRvIHNpZ25hbCB0aGF0IGEgY29udGV4dCBwcmVmZXJzIHRvIHVz ZSBhIGRpc2NyZXRlIEdQVQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1Jl bmRlclN0eWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5 bGUvUmVuZGVyU3R5bGUuY3BwCShyZXZpc2lvbiAxMTAxNzYpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NDUsMTQg Kzg0NSwxNCBAQCB2b2lkIFJlbmRlclN0eWxlOjpzZXRCb3hTaGFkb3coUGFzc093blB0CiBzdGF0 aWMgUm91bmRlZFJlY3Q6OlJhZGlpIGNhbGNSYWRpaUZvcihjb25zdCBCb3JkZXJEYXRhJiBib3Jk ZXIsIExheW91dFNpemUgc2l6ZSkKIHsKICAgICByZXR1cm4gUm91bmRlZFJlY3Q6OlJhZGlpKAot ICAgICAgICBMYXlvdXRTaXplKGJvcmRlci50b3BMZWZ0KCkud2lkdGgoKS5jYWxjVmFsdWUoc2l6 ZS53aWR0aCgpKSwgCi0gICAgICAgICAgICAgICAgICAgYm9yZGVyLnRvcExlZnQoKS5oZWlnaHQo KS5jYWxjVmFsdWUoc2l6ZS5oZWlnaHQoKSkpLAotICAgICAgICBMYXlvdXRTaXplKGJvcmRlci50 b3BSaWdodCgpLndpZHRoKCkuY2FsY1ZhbHVlKHNpemUud2lkdGgoKSksCi0gICAgICAgICAgICAg ICAgICAgYm9yZGVyLnRvcFJpZ2h0KCkuaGVpZ2h0KCkuY2FsY1ZhbHVlKHNpemUuaGVpZ2h0KCkp KSwKLSAgICAgICAgTGF5b3V0U2l6ZShib3JkZXIuYm90dG9tTGVmdCgpLndpZHRoKCkuY2FsY1Zh bHVlKHNpemUud2lkdGgoKSksIAotICAgICAgICAgICAgICAgICAgIGJvcmRlci5ib3R0b21MZWZ0 KCkuaGVpZ2h0KCkuY2FsY1ZhbHVlKHNpemUuaGVpZ2h0KCkpKSwKLSAgICAgICAgTGF5b3V0U2l6 ZShib3JkZXIuYm90dG9tUmlnaHQoKS53aWR0aCgpLmNhbGNWYWx1ZShzaXplLndpZHRoKCkpLCAK LSAgICAgICAgICAgICAgICAgICBib3JkZXIuYm90dG9tUmlnaHQoKS5oZWlnaHQoKS5jYWxjVmFs dWUoc2l6ZS5oZWlnaHQoKSkpKTsKKyAgICAgICAgSW50U2l6ZShib3JkZXIudG9wTGVmdCgpLndp ZHRoKCkuY2FsY1ZhbHVlKHNpemUud2lkdGgoKSksIAorICAgICAgICAgICAgICAgIGJvcmRlci50 b3BMZWZ0KCkuaGVpZ2h0KCkuY2FsY1ZhbHVlKHNpemUuaGVpZ2h0KCkpKSwKKyAgICAgICAgSW50 U2l6ZShib3JkZXIudG9wUmlnaHQoKS53aWR0aCgpLmNhbGNWYWx1ZShzaXplLndpZHRoKCkpLAor ICAgICAgICAgICAgICAgIGJvcmRlci50b3BSaWdodCgpLmhlaWdodCgpLmNhbGNWYWx1ZShzaXpl LmhlaWdodCgpKSksCisgICAgICAgIEludFNpemUoYm9yZGVyLmJvdHRvbUxlZnQoKS53aWR0aCgp LmNhbGNWYWx1ZShzaXplLndpZHRoKCkpLCAKKyAgICAgICAgICAgICAgICBib3JkZXIuYm90dG9t TGVmdCgpLmhlaWdodCgpLmNhbGNWYWx1ZShzaXplLmhlaWdodCgpKSksCisgICAgICAgIEludFNp emUoYm9yZGVyLmJvdHRvbVJpZ2h0KCkud2lkdGgoKS5jYWxjVmFsdWUoc2l6ZS53aWR0aCgpKSwg CisgICAgICAgICAgICAgICAgYm9yZGVyLmJvdHRvbVJpZ2h0KCkuaGVpZ2h0KCkuY2FsY1ZhbHVl KHNpemUuaGVpZ2h0KCkpKSk7CiB9CiAKIHN0YXRpYyBmbG9hdCBjYWxjQ29uc3RyYWludFNjYWxl Rm9yKGNvbnN0IEludFJlY3QmIHJlY3QsIGNvbnN0IFJvdW5kZWRSZWN0OjpSYWRpaSYgcmFkaWkp Cg==