80564 2012-03-07 20:19:59 -0800 Do not refer to resutlsButtonElement and cancelButtonElement to compute paddings of search popups 2012-03-08 08:41:47 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80479 1 tkent tkent dglazkov haraken morrita oldest_to_newest 573537 0 tkent 2012-03-07 20:19:59 -0800 Do not refer to resutlsButtonElement and cancelButtonElement to compute paddings of search popups 573539 1 130757 tkent 2012-03-07 20:27:14 -0800 Created attachment 130757 Patch 573546 2 130757 haraken 2012-03-07 20:33:01 -0800 Comment on attachment 130757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130757&action=review The change looks OK, but I'll delegate the review to another reviewer since I am not familiar with the rendering text. > Source/WebCore/ChangeLog:11 > + No behavior change. Isn't there any existing test that _can_ be affected by this change, if the change were wrong? I wanted to see "Test: xxx.html (No change behavior)", to confirm that the change is correct. 573547 3 130757 tkent 2012-03-07 20:36:02 -0800 Comment on attachment 130757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130757&action=review >> Source/WebCore/ChangeLog:11 >> + No behavior change. > > Isn't there any existing test that _can_ be affected by this change, if the change were wrong? I wanted to see "Test: xxx.html (No change behavior)", to confirm that the change is correct. Unfortunately, none. We can't check the appearance of search popup menus because DRT can't capture them. 573548 4 130757 morrita 2012-03-07 20:41:43 -0800 Comment on attachment 130757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130757&action=review >>> Source/WebCore/ChangeLog:11 >>> + No behavior change. >> >> Isn't there any existing test that _can_ be affected by this change, if the change were wrong? I wanted to see "Test: xxx.html (No change behavior)", to confirm that the change is correct. > > Unfortunately, none. We can't check the appearance of search popup menus because DRT can't capture them. We could grab the shadow tree using internals.shadowRoot() and dump its RenderTree using internals.elementRenderTreeAsText() You can make a reference DOM tree and compare the render-tree of the shadow tree and the referende DOM. 573550 5 130757 tkent 2012-03-07 20:47:07 -0800 Comment on attachment 130757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130757&action=review >>>> Source/WebCore/ChangeLog:11 >>>> + No behavior change. >>> >>> Isn't there any existing test that _can_ be affected by this change, if the change were wrong? I wanted to see "Test: xxx.html (No change behavior)", to confirm that the change is correct. >> >> Unfortunately, none. We can't check the appearance of search popup menus because DRT can't capture them. > > We could grab the shadow tree using internals.shadowRoot() and dump its RenderTree using internals.elementRenderTreeAsText() > You can make a reference DOM tree and compare the render-tree of the shadow tree and the referende DOM. It is not related to this patch. This patch doesn't change any renderer metrics or any DOM values. RenderTextControlSingleLine::clientInsetRight() and clientInsetLeft() are passed to platform-specific popup-menu implementation via ChromeClient::createSearchPopupMenu(). DRT doesn't have a way to get these values. 573567 6 130757 morrita 2012-03-07 21:22:58 -0800 Comment on attachment 130757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130757&action=review >>>>> Source/WebCore/ChangeLog:11 >>>>> + No behavior change. >>>> >>>> Isn't there any existing test that _can_ be affected by this change, if the change were wrong? I wanted to see "Test: xxx.html (No change behavior)", to confirm that the change is correct. >>> >>> Unfortunately, none. We can't check the appearance of search popup menus because DRT can't capture them. >> >> We could grab the shadow tree using internals.shadowRoot() and dump its RenderTree using internals.elementRenderTreeAsText() >> You can make a reference DOM tree and compare the render-tree of the shadow tree and the referende DOM. > > It is not related to this patch. > This patch doesn't change any renderer metrics or any DOM values. RenderTextControlSingleLine::clientInsetRight() and clientInsetLeft() are passed to platform-specific popup-menu implementation via ChromeClient::createSearchPopupMenu(). DRT doesn't have a way to get these values. Ah, got it. It would be nice if we have a mock for ChromeClient. But it's a different story... 573576 7 tkent 2012-03-07 21:31:46 -0800 Committed r110145: <http://trac.webkit.org/changeset/110145> 573858 8 dglazkov 2012-03-08 08:41:47 -0800 This is cool. 130757 2012-03-07 20:27:14 -0800 2012-03-07 21:22:58 -0800 Patch bug-80564-20120308132712.patch text/plain 3029 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU5MTVlYzg0OTE3MzEx M2FlNWNhY2MwMDhkZmRiMDhiZDA3ZDgwNC4uZWZkYWM5M2ExNWY1MzMwOTU5NjRlMmVjODY1Njgw YWNkNTY0Zjg3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAzLTA3ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBEbyBub3QgcmVmZXIgdG8g cmVzdXRsc0J1dHRvbkVsZW1lbnQgYW5kIGNhbmNlbEJ1dHRvbkVsZW1lbnQgdG8gY29tcHV0ZSBw YWRkaW5ncyBvZiBzZWFyY2ggcG9wdXBzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MDU2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlJ2QgbGlrZSB0byByZWR1Y2UgZGVwZW5kZW5jeSBvZiByZXN1bHRz QnV0dG9uRWxlbWVudCBhbmQKKyAgICAgICAgY2FuY2VsQnV0dG9uRWxlbWVudCBmcm9tIFJlbmRl clRleHRDb250cm9sU2luZ2xlTGluZS4KKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6Y2xpZW50UGFkZGlu Z0xlZnQpOgorICAgICAgICBVc2UgdGhlIGxlZnQgcG9zaXRpb24gb2YgaW5uZXJCbG9ja0VsZW1l bnQsIGluc3RlYWQgb2YgdGhlIHdpZHRoIG9mIHJlc3VsdHNCdXR0b25FbGVtZW50LgorICAgICAg ICBUaGV5IGFyZSBlcXVpdmFsZW50LgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dENvbnRy b2xTaW5nbGVMaW5lOjpjbGllbnRQYWRkaW5nUmlnaHQpOgorICAgICAgICBVc2UgPHRoZSBjb250 YWluZXIgd2lkdGggLSByaWdodCBwb3NpdGlvbiBvZiBpbm5lckJsb2NrRWxlbWVudD4sCisgICAg ICAgIGluc3RlYWQgb2YgdGhlIHdpZHRoIG9mIHRoZSBjYW5jZWxCdXR0b25FbGVtZW50LiBUaGV5 IGFyZQorICAgICAgICBlcXVpdmFsZW50LgorCiAyMDEyLTAzLTA3ICBKZXNzaWUgQmVybGluICA8 amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gV2luZG93cyBidWlsZCBmYWlscyBh ZnRlciByMTEwMDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwCmluZGV4IDRlNjVmNDNhNzJiYWQwNzYwYWNkYjk5 MTNkNGY4YTc5NjU4YTI1ZGQuLmU4N2UxZDc0ZTRiZGFjMzQ0N2U4N2QxMDNmYjBlOTRlZjdiZTU1 YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJv bFNpbmdsZUxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0 Q29udHJvbFNpbmdsZUxpbmUuY3BwCkBAIC02MTMsMjIgKzYxMywxOCBAQCBpbnQgUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lOjpjbGllbnRJbnNldFJpZ2h0KCkgY29uc3QKIExheW91dFVuaXQg UmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpjbGllbnRQYWRkaW5nTGVmdCgpIGNvbnN0CiB7 CiAgICAgTGF5b3V0VW5pdCBwYWRkaW5nID0gcGFkZGluZ0xlZnQoKTsKLQotICAgIEhUTUxFbGVt ZW50KiByZXN1bHRzQnV0dG9uID0gcmVzdWx0c0J1dHRvbkVsZW1lbnQoKTsKLSAgICBpZiAoUmVu ZGVyQm94KiByZXN1bHRzUmVuZGVyZXIgPSByZXN1bHRzQnV0dG9uID8gcmVzdWx0c0J1dHRvbi0+ cmVuZGVyQm94KCkgOiAwKQotICAgICAgICBwYWRkaW5nICs9IHJlc3VsdHNSZW5kZXJlci0+d2lk dGgoKSArIHJlc3VsdHNSZW5kZXJlci0+bWFyZ2luTGVmdCgpICsgcmVzdWx0c1JlbmRlcmVyLT5w YWRkaW5nTGVmdCgpICsgcmVzdWx0c1JlbmRlcmVyLT5tYXJnaW5SaWdodCgpICsgcmVzdWx0c1Jl bmRlcmVyLT5wYWRkaW5nUmlnaHQoKTsKLQorICAgIGlmIChSZW5kZXJCb3gqIGJveCA9IGlubmVy QmxvY2tFbGVtZW50KCkgPyBpbm5lckJsb2NrRWxlbWVudCgpLT5yZW5kZXJCb3goKSA6IDApCisg ICAgICAgIHBhZGRpbmcgKz0gYm94LT54KCk7CiAgICAgcmV0dXJuIHBhZGRpbmc7CiB9CiAKIExh eW91dFVuaXQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpjbGllbnRQYWRkaW5nUmlnaHQo KSBjb25zdAogewogICAgIExheW91dFVuaXQgcGFkZGluZyA9IHBhZGRpbmdSaWdodCgpOwotCi0g ICAgSFRNTEVsZW1lbnQqIGNhbmNlbEJ1dHRvbiA9IGNhbmNlbEJ1dHRvbkVsZW1lbnQoKTsKLSAg ICBpZiAoUmVuZGVyQm94KiBjYW5jZWxSZW5kZXJlciA9IGNhbmNlbEJ1dHRvbiA/IGNhbmNlbEJ1 dHRvbi0+cmVuZGVyQm94KCkgOiAwKQotICAgICAgICBwYWRkaW5nICs9IGNhbmNlbFJlbmRlcmVy LT53aWR0aCgpICsgY2FuY2VsUmVuZGVyZXItPm1hcmdpbkxlZnQoKSArIGNhbmNlbFJlbmRlcmVy LT5wYWRkaW5nTGVmdCgpICsgY2FuY2VsUmVuZGVyZXItPm1hcmdpblJpZ2h0KCkgKyBjYW5jZWxS ZW5kZXJlci0+cGFkZGluZ1JpZ2h0KCk7Ci0KKyAgICBpZiAoUmVuZGVyQm94KiBjb250YWluZXJC b3ggPSBjb250YWluZXJFbGVtZW50KCkgPyBjb250YWluZXJFbGVtZW50KCktPnJlbmRlckJveCgp IDogMCkgeworICAgICAgICBpZiAoUmVuZGVyQm94KiBpbm5lckJsb2NrQm94ID0gaW5uZXJCbG9j a0VsZW1lbnQoKSA/IGlubmVyQmxvY2tFbGVtZW50KCktPnJlbmRlckJveCgpIDogMCkKKyAgICAg ICAgICAgIHBhZGRpbmcgKz0gY29udGFpbmVyQm94LT53aWR0aCgpIC0gKGlubmVyQmxvY2tCb3gt PngoKSArIGlubmVyQmxvY2tCb3gtPndpZHRoKCkpOworICAgIH0KICAgICByZXR1cm4gcGFkZGlu ZzsKIH0KIAo=