80404 2012-03-06 02:46:30 -0800 r109563 caused perf regression 2012-03-06 04:43:16 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rolandsteiner rolandsteiner abarth arv koivisto macpherson menard rniwa webkit.review.bot oldest_to_newest 571690 0 rolandsteiner 2012-03-06 02:46:30 -0800 The culprit is one line in CSSStyleSelector::pushParentElement(): changing from parentOrHostElement() to parentOrHostNode(), causing a 20% perf regression in Parser/html5-full-render.html. 571691 1 130346 rolandsteiner 2012-03-06 02:49:38 -0800 Created attachment 130346 Patch 571702 2 130348 rolandsteiner 2012-03-06 03:19:37 -0800 Created attachment 130348 Patch 571733 3 130348 webkit.review.bot 2012-03-06 04:43:11 -0800 Comment on attachment 130348 Patch Clearing flags on attachment: 130348 Committed r109906: <http://trac.webkit.org/changeset/109906> 571734 4 webkit.review.bot 2012-03-06 04:43:16 -0800 All reviewed patches have been landed. Closing bug. 130346 2012-03-06 02:49:38 -0800 2012-03-06 03:19:30 -0800 Patch bug-80404-20120306194936.patch text/plain 1837 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ1ZWUyNTE3ZWZjOTMx ZGU3ZjY4MjY5ODEwMTZjYmM3NTM2MmRhYy4uNzM0YzMwZmU4ZDk3NjFhOTg1YzM4YTg3ZGQ5Mjg5 ZjYyMjIyNmRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA2ICBSb2xh bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIHIxMDk1 NjMgY2F1c2VkIHBlcmYgcmVncmVzc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA0MDQKKworICAgICAgICBBZGQgdGVzdCBmb3IgRWxlbWVudCBv ciBTaGFkb3dSb290LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gKGZpeCkKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVj dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OnB1c2hQYXJlbnRF bGVtZW50KToKKwogMjAxMi0wMy0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgog CiAgICAgICAgIEF0dGVtcHQgdG8gZml4IGEgbnVtYmVyIG9mIEdUSyB0ZXN0cy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCBmMWFjODU4MDMwYTQzYjY3ODEzMTUx ZDgwMTFhZjU5YTM4NjUxOGQ1Li43NzA2NTIxMzhjODAyOGE5NzZkODFiNzA2MzM5MTA1OGFkOTYw NTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC01NTIsMTEg KzU1MiwxMiBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OnBvcFNjb3BlKGNvbnN0IENvbnRhaW5l ck5vZGUqIHNjb3BlKQogdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjpwdXNoUGFyZW50RWxlbWVudChF bGVtZW50KiBwYXJlbnQpCiB7CiAgICAgY29uc3QgQ29udGFpbmVyTm9kZSogcGFyZW50c1BhcmVu dCA9IHBhcmVudC0+cGFyZW50T3JIb3N0Tm9kZSgpOworCiAgICAgLy8gV2UgYXJlIG5vdCBhbHdh eXMgaW52b2tlZCBjb25zaXN0ZW50bHkuIEZvciBleGFtcGxlLCBzY3JpcHQgZXhlY3V0aW9uIGNh biBjYXVzZSB1cyB0byBlbnRlcgogICAgIC8vIHN0eWxlIHJlY2FsYyBpbiB0aGUgbWlkZGxlIG9m IHRyZWUgYnVpbGRpbmcuIFdlIG1heSBhbHNvIGJlIGludm9rZWQgZnJvbSBzb21ld2hlcmUgd2l0 aGluIHRoZSB0cmVlLgogICAgIC8vIFJlc2V0IHRoZSBzdGFjayBpbiB0aGlzIGNhc2UsIG9yIGlm IHdlIHNlZSBhIG5ldyByb290IGVsZW1lbnQuCiAgICAgLy8gT3RoZXJ3aXNlIGp1c3QgcHVzaCB0 aGUgbmV3IHBhcmVudC4KLSAgICBpZiAoIXBhcmVudHNQYXJlbnQgfHwgbV9jaGVja2VyLnBhcmVu dFN0YWNrSXNFbXB0eSgpKQorICAgIGlmICghcGFyZW50c1BhcmVudCB8fCAoIXBhcmVudHNQYXJl bnQtPmlzU2hhZG93Um9vdCgpICYmICFwYXJlbnRzUGFyZW50LT5pc0VsZW1lbnROb2RlKCkpIHx8 IG1fY2hlY2tlci5wYXJlbnRTdGFja0lzRW1wdHkoKSkKICAgICAgICAgbV9jaGVja2VyLnNldHVw UGFyZW50U3RhY2socGFyZW50KTsKICAgICBlbHNlCiAgICAgICAgIG1fY2hlY2tlci5wdXNoUGFy ZW50KHBhcmVudCk7Cg== 130348 2012-03-06 03:19:37 -0800 2012-03-06 04:43:11 -0800 Patch bug-80404-20120306201935.patch text/plain 1979 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ1ZWUyNTE3ZWZjOTMx ZGU3ZjY4MjY5ODEwMTZjYmM3NTM2MmRhYy4uNzM0YzMwZmU4ZDk3NjFhOTg1YzM4YTg3ZGQ5Mjg5 ZjYyMjIyNmRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA2ICBSb2xh bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIHIxMDk1 NjMgY2F1c2VkIHBlcmYgcmVncmVzc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA0MDQKKworICAgICAgICBBZGQgdGVzdCBmb3IgRWxlbWVudCBv ciBTaGFkb3dSb290LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gKGZpeCkKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVj dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OnB1c2hQYXJlbnRF bGVtZW50KToKKwogMjAxMi0wMy0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgog CiAgICAgICAgIEF0dGVtcHQgdG8gZml4IGEgbnVtYmVyIG9mIEdUSyB0ZXN0cy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCBmMWFjODU4MDMwYTQzYjY3ODEzMTUx ZDgwMTFhZjU5YTM4NjUxOGQ1Li5lYjllYTIxYWVhZTM3NzJiNzk4Y2UxMDU0MTBiYWE5MjcyMDBj YjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC01NTEsNyAr NTUxLDggQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjpwb3BTY29wZShjb25zdCBDb250YWluZXJO b2RlKiBzY29wZSkKIAogdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjpwdXNoUGFyZW50RWxlbWVudChF bGVtZW50KiBwYXJlbnQpCiB7Ci0gICAgY29uc3QgQ29udGFpbmVyTm9kZSogcGFyZW50c1BhcmVu dCA9IHBhcmVudC0+cGFyZW50T3JIb3N0Tm9kZSgpOworICAgIGNvbnN0IENvbnRhaW5lck5vZGUq IHBhcmVudHNQYXJlbnQgPSBwYXJlbnQtPnBhcmVudE9ySG9zdEVsZW1lbnQoKTsKKwogICAgIC8v IFdlIGFyZSBub3QgYWx3YXlzIGludm9rZWQgY29uc2lzdGVudGx5LiBGb3IgZXhhbXBsZSwgc2Ny aXB0IGV4ZWN1dGlvbiBjYW4gY2F1c2UgdXMgdG8gZW50ZXIKICAgICAvLyBzdHlsZSByZWNhbGMg aW4gdGhlIG1pZGRsZSBvZiB0cmVlIGJ1aWxkaW5nLiBXZSBtYXkgYWxzbyBiZSBpbnZva2VkIGZy b20gc29tZXdoZXJlIHdpdGhpbiB0aGUgdHJlZS4KICAgICAvLyBSZXNldCB0aGUgc3RhY2sgaW4g dGhpcyBjYXNlLCBvciBpZiB3ZSBzZWUgYSBuZXcgcm9vdCBlbGVtZW50LgpAQCAtNTYwLDcgKzU2 MSw5IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6cHVzaFBhcmVudEVsZW1lbnQoRWxlbWVudCog cGFyZW50KQogICAgICAgICBtX2NoZWNrZXIuc2V0dXBQYXJlbnRTdGFjayhwYXJlbnQpOwogICAg IGVsc2UKICAgICAgICAgbV9jaGVja2VyLnB1c2hQYXJlbnQocGFyZW50KTsKLSAgICBwdXNoU2Nv cGUocGFyZW50LCBwYXJlbnRzUGFyZW50KTsKKworICAgIC8vIE5vdGU6IFdlIG11c3RuJ3Qgc2tp cCBTaGFkb3dSb290IG5vZGVzIGZvciB0aGUgc2NvcGUgc3RhY2suCisgICAgcHVzaFNjb3BlKHBh cmVudCwgcGFyZW50LT5wYXJlbnRPckhvc3ROb2RlKCkpOwogfQogCiB2b2lkIENTU1N0eWxlU2Vs ZWN0b3I6OnBvcFBhcmVudEVsZW1lbnQoRWxlbWVudCogcGFyZW50KQo=