80188 2012-03-02 13:37:36 -0800 Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round 2012-03-02 14:59:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75069 1 cmarcelo cmarcelo oldest_to_newest 569894 0 cmarcelo 2012-03-02 13:37:36 -0800 Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round 569895 1 129951 cmarcelo 2012-03-02 13:41:09 -0800 Created attachment 129951 Patch 569932 2 129951 rniwa 2012-03-02 14:13:00 -0800 Comment on attachment 129951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129951&action=review > Source/WebCore/dom/NamedNodeMap.cpp:108 > + Attr* attr = static_cast<Attr*>(node); > + return m_element->setAttributeNode(attr, ec); Do we really need a local variable? 569968 3 cmarcelo 2012-03-02 14:59:59 -0800 Committed r109619: <http://trac.webkit.org/changeset/109619> 129951 2012-03-02 13:41:09 -0800 2012-03-02 14:13:00 -0800 Patch bug-80188-20120302184107.patch text/plain 5663 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA1ZDFiYjcwOTZhMThk YmQ4ZmUzMTkwNTcwMjgyMjExZmQ4ZThmYi4uMzk3OGZlOTExMzhhZDk4MWY5YjY0Y2FmNzdlMWFl ZmZmNzQ2ZGQ4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAzLTAyICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgSW1wbGVtZW50IE5hbWVkTm9kZU1hcDo6c2V0TmFtZWRJdGVtKCkgaW4gdGVy bXMgb2YgRWxlbWVudDo6c2V0QXR0cmlidXRlTm9kZSgpIGluc3RlYWQgb2YgdGhlIG90aGVyIHdh eSByb3VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODAxODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV c2luZyBzZXROYW1lZEl0ZW0oKSBpbiBzZXRBdHRyaWJ1dGVOb2RlKCkgaW1wbGVtZW50YXRpb24g bWFkZSB1cyBkbyB1bm5lY2Vzc2FyeQorICAgICAgICBjaGVja3MgbGlrZSB3aGV0aGVyIHRoZSBl bGVtZW50IGV4aXN0ZWQgb3Igd2hldGhlciB0aGUgZ2l2ZW4gbm9kZSB3YXMgYW4KKyAgICAgICAg YXR0cmlidXRlLiBTbyBub3cgc2V0QXR0cmlidXRlTm9kZSgpIGRvIGxlc3Mgd29yay4KKworICAg ICAgICBObyBuZXcgdGVzdHMgd2VyZSBhZGRlZCwgZnVuY3Rpb25hbGl0eSBzaG91bGQgYmUgdW5j aGFuZ2VkLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RWxlbWVudDo6c2V0QXR0cmlidXRlTm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpz ZXRBdHRyaWJ1dGVOb2RlTlMpOgorICAgICAgICAqIGRvbS9FbGVtZW50Lmg6CisgICAgICAgIChF bGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmF0dHJpYnV0ZXMpOiBXZSBnb3Qg cmlkIG9mIGVuc3VyZVVwZGF0ZWRBdHRyaWJ1dGVzKCksIG5leHQgaW4KKyAgICAgICAgbGluZSB3 aWxsIGJlIHVwZGF0ZWRBdHRyaWJ1dGVzKCkuCisgICAgICAgICogZG9tL05hbWVkTm9kZU1hcC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpOYW1lZE5vZGVNYXA6OnNldE5hbWVkSXRlbSk6CisKIDIw MTItMDItMTggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIFtBQ10gR2VuZXJhbGl6ZSBXaW5kb3dDb250ZXh0R0wKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcAppbmRleCBhZGQ2ZjQ2YjdiZjZhMzRmNzhjMTNhN2ZlODc3NWQ4MTQ4MTllNmNiLi41OGY5 OGVkZDg1NGIwYzVkYzhmMzViNTkzNTVjZGRjMjJiYmI0ODE2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQu Y3BwCkBAIC0xMzc0LDE2ICsxMzc0LDM0IEBAIFBhc3NSZWZQdHI8QXR0cj4gRWxlbWVudDo6c2V0 QXR0cmlidXRlTm9kZShBdHRyKiBhdHRyLCBFeGNlcHRpb25Db2RlJiBlYykKICAgICAgICAgZWMg PSBUWVBFX01JU01BVENIX0VSUjsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQotICAgIHJldHVy biBzdGF0aWNfcG9pbnRlcl9jYXN0PEF0dHI+KGVuc3VyZVVwZGF0ZWRBdHRyaWJ1dGVzKCktPnNl dE5hbWVkSXRlbShhdHRyLCBlYykpOworCisgICAgRWxlbWVudEF0dHJpYnV0ZURhdGEqIGF0dHJp YnV0ZURhdGEgPSBlbnN1cmVVcGRhdGVkQXR0cmlidXRlRGF0YSgpOworICAgIEF0dHJpYnV0ZSog YXR0cmlidXRlID0gYXR0ci0+YXR0cigpOworICAgIHNpemVfdCBpbmRleCA9IGF0dHJpYnV0ZURh dGEtPmdldEF0dHJpYnV0ZUl0ZW1JbmRleChhdHRyaWJ1dGUtPm5hbWUoKSk7CisgICAgQXR0cmli dXRlKiBvbGRBdHRyaWJ1dGUgPSBpbmRleCAhPSBub3RGb3VuZCA/IGF0dHJpYnV0ZURhdGEtPmF0 dHJpYnV0ZUl0ZW0oaW5kZXgpIDogMDsKKyAgICBpZiAob2xkQXR0cmlidXRlID09IGF0dHJpYnV0 ZSkKKyAgICAgICAgcmV0dXJuIGF0dHI7IC8vIHdlIGtub3cgYWJvdXQgaXQgYWxyZWFkeQorCisg ICAgLy8gSU5VU0VfQVRUUklCVVRFX0VSUjogUmFpc2VkIGlmIG5vZGUgaXMgYW4gQXR0ciB0aGF0 IGlzIGFscmVhZHkgYW4gYXR0cmlidXRlIG9mIGFub3RoZXIgRWxlbWVudCBvYmplY3QuCisgICAg Ly8gVGhlIERPTSB1c2VyIG11c3QgZXhwbGljaXRseSBjbG9uZSBBdHRyIG5vZGVzIHRvIHJlLXVz ZSB0aGVtIGluIG90aGVyIGVsZW1lbnRzLgorICAgIGlmIChhdHRyLT5vd25lckVsZW1lbnQoKSkg eworICAgICAgICBlYyA9IElOVVNFX0FUVFJJQlVURV9FUlI7CisgICAgICAgIHJldHVybiAwOwor ICAgIH0KKworICAgIFJlZlB0cjxBdHRyPiBvbGRBdHRyOworICAgIGlmIChvbGRBdHRyaWJ1dGUp IHsKKyAgICAgICAgb2xkQXR0ciA9IG9sZEF0dHJpYnV0ZS0+Y3JlYXRlQXR0cklmTmVlZGVkKHRo aXMpOworICAgICAgICBhdHRyaWJ1dGVEYXRhLT5yZXBsYWNlQXR0cmlidXRlKGluZGV4LCBhdHRy aWJ1dGUsIHRoaXMpOworICAgIH0gZWxzZQorICAgICAgICBhdHRyaWJ1dGVEYXRhLT5hZGRBdHRy aWJ1dGUoYXR0cmlidXRlLCB0aGlzKTsKKworICAgIHJldHVybiBvbGRBdHRyLnJlbGVhc2UoKTsK IH0KIAogUGFzc1JlZlB0cjxBdHRyPiBFbGVtZW50OjpzZXRBdHRyaWJ1dGVOb2RlTlMoQXR0ciog YXR0ciwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgaWYgKCFhdHRyKSB7Ci0gICAgICAgIGVj ID0gVFlQRV9NSVNNQVRDSF9FUlI7Ci0gICAgICAgIHJldHVybiAwOwotICAgIH0KLSAgICByZXR1 cm4gc3RhdGljX3BvaW50ZXJfY2FzdDxBdHRyPihlbnN1cmVVcGRhdGVkQXR0cmlidXRlcygpLT5z ZXROYW1lZEl0ZW0oYXR0ciwgZWMpKTsKKyAgICByZXR1cm4gc2V0QXR0cmlidXRlTm9kZShhdHRy LCBlYyk7CiB9CiAKIFBhc3NSZWZQdHI8QXR0cj4gRWxlbWVudDo6cmVtb3ZlQXR0cmlidXRlTm9k ZShBdHRyKiBhdHRyLCBFeGNlcHRpb25Db2RlJiBlYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCmluZGV4IDlk MjRiOTg5ZTUzM2ExZjA3YWJiNDU4MDQ2ZDMyNjQ3NWQwMjFiZjguLmQ5Y2ZjYThiMWJkMzVjZjQ2 MTc4ZjcwYzBhYzdiMTEzMTQzMTUzNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtMjI4LDkgKzIy OCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldEJvb2xlYW5BdHRyaWJ1dGUoY29uc3QgUXVhbGlm aWVkTmFtZSYgbmFtZSwgYm9vbCk7CiAKICAgICAvLyBGb3IgZXhwb3NpbmcgdG8gRE9NIG9ubHku Ci0gICAgTmFtZWROb2RlTWFwKiBhdHRyaWJ1dGVzKCkgY29uc3QgeyByZXR1cm4gZW5zdXJlVXBk YXRlZEF0dHJpYnV0ZXMoKTsgfQorICAgIE5hbWVkTm9kZU1hcCogYXR0cmlidXRlcygpIGNvbnN0 OwogCi0gICAgTmFtZWROb2RlTWFwKiBlbnN1cmVVcGRhdGVkQXR0cmlidXRlcygpIGNvbnN0Owog ICAgIE5hbWVkTm9kZU1hcCogdXBkYXRlZEF0dHJpYnV0ZXMoKSBjb25zdDsKIAogICAgIC8vIFRo aXMgbWV0aG9kIGlzIGNhbGxlZCB3aGVuZXZlciBhbiBhdHRyaWJ1dGUgaXMgYWRkZWQsIGNoYW5n ZWQgb3IgcmVtb3ZlZC4KQEAgLTUzMCw3ICs1MjksNyBAQCBpbmxpbmUgRWxlbWVudCogRWxlbWVu dDo6bmV4dEVsZW1lbnRTaWJsaW5nKCkgY29uc3QKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RWxl bWVudCo+KG4pOwogfQogCi1pbmxpbmUgTmFtZWROb2RlTWFwKiBFbGVtZW50OjplbnN1cmVVcGRh dGVkQXR0cmlidXRlcygpIGNvbnN0CitpbmxpbmUgTmFtZWROb2RlTWFwKiBFbGVtZW50OjphdHRy aWJ1dGVzKCkgY29uc3QKIHsKICAgICB1cGRhdGVJbnZhbGlkQXR0cmlidXRlcygpOwogICAgIGlm ICghbV9hdHRyaWJ1dGVNYXApCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTmFtZWRO b2RlTWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3BwCmluZGV4IGM3 YTgzZTVhMjBhOTRjOGU1M2EyZGEwNGNkN2JmYWEwMmUzODBmZWUuLmE0NTVkMTQzNzkzM2I5OTAy MDA0N2JjZjJkMTE1NGE1M2YxNzhjYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9O YW1lZE5vZGVNYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3Bw CkBAIC0xMDMsMjkgKzEwMyw5IEBAIFBhc3NSZWZQdHI8Tm9kZT4gTmFtZWROb2RlTWFwOjpzZXRO YW1lZEl0ZW0oTm9kZSogbm9kZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiAgICAgICAgIGVjID0gSElF UkFSQ0hZX1JFUVVFU1RfRVJSOwogICAgICAgICByZXR1cm4gMDsKICAgICB9Ci0gICAgQXR0ciog YXR0ciA9IHN0YXRpY19jYXN0PEF0dHIqPihub2RlKTsKLQotICAgIEF0dHJpYnV0ZSogYXR0cmli dXRlID0gYXR0ci0+YXR0cigpOwotICAgIHNpemVfdCBpbmRleCA9IG1fYXR0cmlidXRlRGF0YS5n ZXRBdHRyaWJ1dGVJdGVtSW5kZXgoYXR0cmlidXRlLT5uYW1lKCkpOwotICAgIEF0dHJpYnV0ZSog b2xkQXR0cmlidXRlID0gaW5kZXggIT0gbm90Rm91bmQgPyBtX2F0dHJpYnV0ZURhdGEuYXR0cmli dXRlSXRlbShpbmRleCkgOiAwOwotICAgIGlmIChvbGRBdHRyaWJ1dGUgPT0gYXR0cmlidXRlKQot ICAgICAgICByZXR1cm4gbm9kZTsgLy8gd2Uga25vdyBhYm91dCBpdCBhbHJlYWR5CiAKLSAgICAv LyBJTlVTRV9BVFRSSUJVVEVfRVJSOiBSYWlzZWQgaWYgbm9kZSBpcyBhbiBBdHRyIHRoYXQgaXMg YWxyZWFkeSBhbiBhdHRyaWJ1dGUgb2YgYW5vdGhlciBFbGVtZW50IG9iamVjdC4KLSAgICAvLyBU aGUgRE9NIHVzZXIgbXVzdCBleHBsaWNpdGx5IGNsb25lIEF0dHIgbm9kZXMgdG8gcmUtdXNlIHRo ZW0gaW4gb3RoZXIgZWxlbWVudHMuCi0gICAgaWYgKGF0dHItPm93bmVyRWxlbWVudCgpKSB7Ci0g ICAgICAgIGVjID0gSU5VU0VfQVRUUklCVVRFX0VSUjsKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAg fQotCi0gICAgUmVmUHRyPEF0dHI+IG9sZEF0dHI7Ci0gICAgaWYgKG9sZEF0dHJpYnV0ZSkgewot ICAgICAgICBvbGRBdHRyID0gb2xkQXR0cmlidXRlLT5jcmVhdGVBdHRySWZOZWVkZWQobV9lbGVt ZW50KTsKLSAgICAgICAgbV9hdHRyaWJ1dGVEYXRhLnJlcGxhY2VBdHRyaWJ1dGUoaW5kZXgsIGF0 dHJpYnV0ZSwgbV9lbGVtZW50KTsKLSAgICB9IGVsc2UKLSAgICAgICAgbV9hdHRyaWJ1dGVEYXRh LmFkZEF0dHJpYnV0ZShhdHRyaWJ1dGUsIG1fZWxlbWVudCk7Ci0KLSAgICByZXR1cm4gb2xkQXR0 ci5yZWxlYXNlKCk7CisgICAgQXR0ciogYXR0ciA9IHN0YXRpY19jYXN0PEF0dHIqPihub2RlKTsK KyAgICByZXR1cm4gbV9lbGVtZW50LT5zZXRBdHRyaWJ1dGVOb2RlKGF0dHIsIGVjKTsKIH0KIAog UGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6OnNldE5hbWVkSXRlbU5TKE5vZGUqIG5vZGUs IEV4Y2VwdGlvbkNvZGUmIGVjKQo=