80141 2012-03-02 03:55:16 -0800 [Qt] Compile WebCore without QtWidgets 2012-03-02 04:17:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78109 1 hausmann hausmann menard webkit.review.bot zoltan oldest_to_newest 569511 0 hausmann 2012-03-02 03:55:16 -0800 [Qt] Compile WebCore without QtWidgets 569515 1 129869 hausmann 2012-03-02 03:59:27 -0800 Created attachment 129869 Patch 569520 2 129869 kenneth 2012-03-02 04:04:02 -0800 Comment on attachment 129869 Patch Looks correct to me so rs=me but maybe someone else wants to have a look. 569522 3 129869 vestbo 2012-03-02 04:12:35 -0800 Comment on attachment 129869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129869&action=review > Source/WebCore/WebCore.pri:199 > + !haveQt(5): QT *= opengl haveQt(4) ? 569526 4 129869 hausmann 2012-03-02 04:15:18 -0800 Comment on attachment 129869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129869&action=review >> Source/WebCore/WebCore.pri:199 >> + !haveQt(5): QT *= opengl > > haveQt(4) ? Good catch. Will fix when landing. 569529 5 hausmann 2012-03-02 04:17:04 -0800 Committed r109552: <http://trac.webkit.org/changeset/109552> 129869 2012-03-02 03:59:27 -0800 2012-03-02 04:15:18 -0800 Patch bug-80141-20120302125944.patch text/plain 5590 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWYxMDU3ZTEwNzI5MGU4 YjUxODYyMTk1ZmJjNGZlMzIzMTU3NmI2OC4uOWVjOGFiYjQwMzZlYzQ1ZjAwOTYxZTY2M2FhMmM3 MWMzODhhZjNiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTAyICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIENv bXBpbGUgV2ViQ29yZSB3aXRob3V0IFF0V2lkZ2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAxNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAq IFRhcmdldC5wcmk6IERvbid0IGFkZCB3aWRnZXRzIHRvIFFULgorICAgICAgICAqIFdlYkNvcmUu cHJpOiBVc2UgUVQgKz0gb3BlbmdsIG9ubHkgd2l0aCBRdCA0LCBiZWNhdXNlIGl0IGhhcyBhbiBp bXBsaWNpdCBRdFdpZGdldHMKKyAgICAgICAgZGVwZW5kZW5jeS4gV2l0aCBRdCA1IGFsbCBuZWNl c3NhcnkgT3BlbkdMIEFQSSBpcyBwYXJ0IG9mIFF0R3VpICh3aXRoIGEgUU9wZW5HTCogcHJlZml4 KS4KKwogMjAxMi0wMy0wMiAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5v a2lhLmNvbT4KIAogICAgICAgICBTdXNwZW5kL1Jlc3VtZSBBUEkgZm9yIHBhdXNpbmcgdGltZXJz IGFuZCBhbmltYXRpb25zLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGY5Y2NkN2FlZTRkMWYyZTU0MTg5MDhhZmIw MGNlNDhlZjc3MGUxMjQuLmM1NTcyOTc2OTg0Mjc0NjNlZGUzZGY2MmY4ZjVkMDY4ZmY5N2U0MTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0wMiAgU2ltb24gSGF1c21hbm4g IDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBDb21waWxlIFdlYkNv cmUgd2l0aG91dCBRdFdpZGdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgwMTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTaGFyZWQvcXQvV2ViRXZlbnRGYWN0b3J5UXQuY3BwOiBSZW1vdmVkIHVu bmVjZXNzYXJ5IGluY2x1ZGUuCisgICAgICAgICogVGFyZ2V0LnByaTogUmVxdWlyZSB3aWRnZXRz IGZvciBXSzIgZm9yIHRoZSBtb21lbnQsIHVudGlsIGJ1ZyAjNzk0NTgKKyAgICAgICAgaXMgZml4 ZWQuCisKIDIwMTItMDMtMDIgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBu b2tpYS5jb20+CiAKICAgICAgICAgU3VzcGVuZC9SZXN1bWUgQVBJIGZvciBwYXVzaW5nIHRpbWVy cyBhbmQgYW5pbWF0aW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkg Yi9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCmluZGV4IGNkZTJjYTQxYzAzYTMyM2JhY2VlYWQ1 ZjQzZjQ4NGM1NDhkNDZkMDcuLjc2MjBhZDNmMWUzZDFlYzZlNDRhZTJhZTU4ODU0YWFhYTllZmM2 MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKKysrIGIvU291cmNlL1dl YkNvcmUvVGFyZ2V0LnByaQpAQCAtMTksNyArMTksNyBAQCBERUZJTkVTICs9IFFUX01BS0VETEwK IGhhdmVRdCg1KSB7CiAgICAgIyBBZGQgYSBRdFNjcmlwdCBkZXBlbmRlbmN5IGZvciB0aGUgdGlt ZSBiZWluZywgaW4gb3JkZXIgdG8gcHVsbCBpbiB0aGUgaW5jbHVkZQogICAgICMgcGF0aCBmb3Ig UXRTY3JpcHQgd2hlbiBpdCdzIGJ1aWx0IGFzIGEgc3RhbmRhbG9uZSBtb2R1bGUKLSAgICBRVCAr PSBzY3JpcHQgd2lkZ2V0cworICAgIFFUICs9IHNjcmlwdAogfSBlbHNlIHsKICAgICBJTkNMVURF UEFUSCArPSAkJFBXRC8uLi9KYXZhU2NyaXB0Q29yZS93dGYvcXQvY29tcGF0CiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaSBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu cHJpCmluZGV4IGU0MmE4ZTgwZWJlYTliMmRmNzhlYjQ4OGE5YmFhMzIxMDRkZmFjZTguLmU1Yzky YmZiNWUxOWM4YmIxZjA5MzllMDhjN2QyNzZkMWI3MWI4YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL1dlYkNvcmUucHJpCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCkBAIC0x ODQsMTggKzE4NCwyMSBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCR0w9MSkgewogICAg ICFjb250YWlucyhRVF9DT05GSUcsIG9wZW5nbCkgewogICAgICAgICBlcnJvciggIlRoaXMgY29u ZmlndXJhdGlvbiBuZWVkcyBhbiBPcGVuR0wgZW5hYmxlZCBRdC4gWW91ciBRdCBpcyBtaXNzaW5n IE9wZW5HTC4iKQogICAgIH0KLSAgICBRVCAqPSBvcGVuZ2wKIH0KIAogY29udGFpbnMoQ09ORklH LCB0ZXhtYXApIHsKICAgICBERUZJTkVTICs9IFdURl9VU0VfVEVYVFVSRV9NQVBQRVI9MQogICAg ICF3aW4zMi0qOmNvbnRhaW5zKFFUX0NPTkZJRywgb3BlbmdsKSB7Ci0gICAgICAgIERFRklORVMg Kz0gV1RGX1VTRV9URVhUVVJFX01BUFBFUl9HTAotICAgICAgICBRVCAqPSBvcGVuZ2wKKyAgICAg ICAgREVGSU5FUyArPSBXVEZfVVNFX1RFWFRVUkVfTUFQUEVSX0dMPTEKICAgICAgICAgY29udGFp bnMoUVRfQ09ORklHLCBvcGVuZ2xlczIpOiBMSUJTICs9IC1sRUdMCiAgICAgfQogfQogCitjb250 YWlucyhERUZJTkVTLCBXVEZfVVNFX1RFWFRVUkVfTUFQUEVSX0dMPTEpfGNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9XRUJHTD0xKSB7CisgICAgIyBPbmx5IFF0IDQgbmVlZHMgdGhlIG9wZW5nbCBt b2R1bGUsIGZvciBRdCA1IGV2ZXJ5dGhpbmcgd2UgbmVlZCBpcyBwYXJ0IG9mIFF0R3VpLgorICAg ICFoYXZlUXQoNSk6IFFUICo9IG9wZW5nbAorfQorCiAhc3lzdGVtLXNxbGl0ZTpleGlzdHMoICQk e1NRTElURTNTUkNESVJ9L3NxbGl0ZTMuYyApIHsKICAgICBJTkNMVURFUEFUSCArPSAkJHtTUUxJ VEUzU1JDRElSfQogICAgIERFRklORVMgKz0gU1FMSVRFX0NPUkUgU1FMSVRFX09NSVRfTE9BRF9F WFRFTlNJT04gU1FMSVRFX09NSVRfQ09NUExFVEUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9xdC9XZWJFdmVudEZhY3RvcnlRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv cXQvV2ViRXZlbnRGYWN0b3J5UXQuY3BwCmluZGV4IDRlYWZmMmM3ZWRhZWU5ZTMzNGM0YzZhYmY1 N2MzNzg0YmY3MjBlOTguLjQ4MTI2MDJmOWY1YWVmNmRmMzc1MDFlOTkwNDVhZmYyZGVjNWIxMjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9XZWJFdmVudEZhY3RvcnlRdC5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkV2ZW50RmFjdG9yeVF0LmNwcApA QCAtMjYsNyArMjYsNiBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViRXZl bnRGYWN0b3J5UXQuaCIKLSNpbmNsdWRlIDxxZ3JhcGhpY3NzY2VuZWV2ZW50Lmg+CiAjaW5jbHVk ZSA8UUFwcGxpY2F0aW9uPgogI2luY2x1ZGUgPFFLZXlFdmVudD4KICNpbmNsdWRlIDxRVHJhbnNm b3JtPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVGFyZ2V0LnByaSBiL1NvdXJjZS9XZWJL aXQyL1RhcmdldC5wcmkKaW5kZXggYmYxZTg3N2QyZjRiYzcxMmM0NTRiMWQyYjVlY2IyNGUxOTM1 ODBhMS4uNTViOWM4OTA0ZDdjNzcwMDIzMWI2ZGJiNjcyNmM5MzdmYjExZDA3MiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVGFyZ2V0LnByaQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9UYXJnZXQu cHJpCkBAIC0xMiw3ICsxMiw3IEBAIGxvYWQoZmVhdHVyZXMpCiBpbmNsdWRlKFdlYktpdDIucHJp KQogCiBXRUJLSVQgKz0gd3RmIGphdmFzY3JpcHRjb3JlIHdlYmNvcmUKLVFUICs9IGRlY2xhcmF0 aXZlIHF1aWNrIHF1aWNrLXByaXZhdGUKK1FUICs9IGRlY2xhcmF0aXZlIHF1aWNrIHF1aWNrLXBy aXZhdGUgd2lkZ2V0cwogCiBDT05GSUcgKz0gc3RhdGljbGliCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9hcGkucHJpIGIvU291cmNlL2FwaS5wcmkKaW5kZXggZTM1MzExMWI0MmEyNDFhMzBkYzQwMmEy NzA0ZWE5ODZkMGNhOGUwOS4uOTI5MjRmOWM1OGM4NTY4Njk4NTQ0OTZiNGY5NTBiYjk2NzgwMjU1 YyAxMDA2NDQKLS0tIGEvU291cmNlL2FwaS5wcmkKKysrIGIvU291cmNlL2FwaS5wcmkKQEAgLTMz LDkgKzMzLDEwIEBAIFdFQktJVCArPSB3ZWJjb3JlCiBRVCArPSBuZXR3b3JrCiBoYXZlUXQoNSk6 IFFUICs9IHdpZGdldHMgcHJpbnRzdXBwb3J0IHF1aWNrCiAKLXdpbjMyKjohd2luMzItbXN2Yyog eworY29udGFpbnMoREVGSU5FUywgV1RGX1VTRV9URVhUVVJFX01BUFBFUl9HTD0xKXxjb250YWlu cyhERUZJTkVTLCBFTkFCTEVfV0VCR0w9MSkgeworICAgIFFUICo9IG9wZW5nbAogICAgICMgTWFr ZSBzdXJlIE9wZW5HTCBsaWJzIGFyZSBhZnRlciB0aGUgd2ViY29yZSBsaWIgc28gTWluR1cgY2Fu IHJlc29sdmUgc3ltYm9scwotICAgIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9XRUJHTD0xKXxj b250YWlucyhDT05GSUcsIHRleG1hcCk6IExJQlMgKz0gJCRRTUFLRV9MSUJTX09QRU5HTAorICAg IHdpbjMyKjohd2luMzItbXN2Yyo6IExJQlMgKz0gJCRRTUFLRV9MSUJTX09QRU5HTAogfQogCiAh c3RhdGljOiBERUZJTkVTICs9IFFUX01BS0VETEwKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCAxMDQzZWU2NDI1ODUwZThkZmFiNDNmM2I0MDBjYjk5MTExMzE0MGMwLi42 M2M5OTQwOGZjZGM5NDVlOTIzZGUxMTVlMWQyMDEzODg4NmJhZGZhIDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDMtMDIgIFNpbW9u IEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCisgICAgICAgIFtRdF0gQ29t cGlsZSBXZWJDb3JlIHdpdGhvdXQgUXRXaWRnZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDE0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2FwaS5wcmk6IFVzZSBRVCArPSBvcGVuZ2wg Zm9yIHRoZSBXZWJLaXQxIGJpdHMsIHN1Y2ggYXMgdGhlIFFHTFdpZGdldAorICAgICAgICB1c2Fn ZSBpbiBQYWdlQ2xpZW50UXQuY3BwLiBQcmV2aW91c2x5IHRoaXMgZGVwZW5kZW5jeSBjYW1lIGlt cGxpY2l0bHkgdGhyb3VnaCBXZWJDb3JlLnByaS4KKwogMjAxMi0wMy0wMiAgQnl1bmd3b28gTGVl ICA8Ync4MC5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQnVpbGQgd2FybmluZyA6 IGNvbXBhcmlzb24gYmV0d2VlbiBzaWduZWQgYW5kIHVuc2lnbmVkIGludGVnZXIgZXhwcmVzc2lv bnMuCg==