80097 2012-03-01 22:10:05 -0800 [Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification 2012-03-02 05:24:56 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin abarth haraken ojan tkent webkit.review.bot oldest_to_newest 569247 0 yosin 2012-03-01 22:10:05 -0800 For ease of maintainability, attributes and methods declaration order should be as same as specification. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-select-element Similar work was done for input element: https://bugs.webkit.org/show_bug.cgi?id=79622 569260 1 129816 yosin 2012-03-01 22:17:26 -0800 Created attachment 129816 Patch 1 569266 2 129816 haraken 2012-03-01 22:20:28 -0800 Comment on attachment 129816 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129816&action=review > Source/WebCore/html/HTMLSelectElement.idl:-31 > - // Modified in DOM Level 2: Why did you remove this comment? > Source/WebCore/html/HTMLSelectElement.idl:-45 > - // Modified in DOM Level 2: Ditto > Source/WebCore/html/HTMLSelectElement.idl:-67 > - // These methods are not in DOM Level 2 IDL, but are mentioned in the standard: > - // "The contained options can be directly accessed through the select element as a collection." Ditto 569295 3 yosin 2012-03-01 22:45:21 -0800 Do we care about differences between DOM Level 2 and WHATWG specification? These comments doesn't provide useful information other than history. 569301 4 haraken 2012-03-01 22:48:12 -0800 (In reply to comment #3) > Do we care about differences between DOM Level 2 and WHATWG specification? These comments doesn't provide useful information other than history. tkent: WDYT? Such comments remain in other IDL files though. 569305 5 129816 tkent 2012-03-01 22:52:45 -0800 Comment on attachment 129816 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129816&action=review >> Source/WebCore/html/HTMLSelectElement.idl:-31 >> - // Modified in DOM Level 2: > > Why did you remove this comment? This comment explains why we have #if defined(LANGUAGE_OBJECTIVE_C)... So, we shouldn't remove it. >> Source/WebCore/html/HTMLSelectElement.idl:-45 >> - // Modified in DOM Level 2: > > Ditto This comment looks non-sense. ok to remove it. >> Source/WebCore/html/HTMLSelectElement.idl:-67 >> - // "The contained options can be directly accessed through the select element as a collection." > > Ditto It's ok to remove this comment because the WHATWG spec has them. 569311 6 129826 yosin 2012-03-01 23:11:01 -0800 Created attachment 129826 Patch 2 569312 7 yosin 2012-03-01 23:15:11 -0800 It seems author who wrote "// Modified in DOM Level 2:" that she simply copy and paste from DOM Level 2 specification. http://www.w3.org/TR/2003/REC-DOM-Level-2-HTML-20030109/html.html#ID-94282980 interface HTMLSelectElement : HTMLElement { readonly attribute DOMString type; attribute long selectedIndex; attribute DOMString value; // Modified in DOM Level 2: attribute unsigned long length; // raises(DOMException) on setting "// Modified in DOM Level 2" doesn't tell me reason of why there is #ifdef here. I put explanatory comment instead of just "Modified in DOM Level2." 569400 8 129826 tkent 2012-03-02 01:01:17 -0800 Comment on attachment 129826 Patch 2 ok 569583 9 129826 webkit.review.bot 2012-03-02 05:24:52 -0800 Comment on attachment 129826 Patch 2 Clearing flags on attachment: 129826 Committed r109562: <http://trac.webkit.org/changeset/109562> 569584 10 webkit.review.bot 2012-03-02 05:24:56 -0800 All reviewed patches have been landed. Closing bug. 129816 2012-03-01 22:17:26 -0800 2012-03-01 23:10:55 -0800 Patch 1 bug-80097-20120302151724.patch text/plain 4247 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uY2E0YWEwMDYzNmI2YmJmYjlkMzRiYWJmMDcwZGNl MTgzODQwZGVkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTFNlbGVjdEVsZW1lbnQuaWRsIGFzIHNh bWUgYXMgc3BlY2lmaWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODAwOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAg KiBodG1sL0hUTUxTZWxlY3RFbGVtZW50LmlkbDogUmVvcmRlciBhdHRyaWJ1dGUvbWV0aG9kIHBv c2l0aW9uLgorCiAyMDEyLTAzLTAxICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgSGFuZGxlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyRml0IGlu IENTU1N0eWxlQXBwbHlQcm9wZXJ0eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFNlbGVjdEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxl bWVudC5pZGwKaW5kZXggNGYwYjgyNjYyZjk5Y2M0NDE5MzRmMzg3NTIwMWQ4ZmQ2NzBhZTRhNC4u Y2Q3ZDM2ZGExZjAzOWIwYzM3NWU4Y2FiMWJmYjM4ODI4MWM5NjJiMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKQEAgLTI0LDM3ICsyNCwyNiBAQCBtb2R1bGUg aHRtbCB7CiAgICAgICAgIEluZGV4ZWRHZXR0ZXIsCiAgICAgICAgIEN1c3RvbUluZGV4ZWRTZXR0 ZXIKICAgICBdIEhUTUxTZWxlY3RFbGVtZW50IDogSFRNTEVsZW1lbnQgeworICAgICAgICBhdHRy aWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0b2ZvY3VzOworICAgICAgICBhdHRyaWJ1dGUgW1Jl ZmxlY3RdIGJvb2xlYW4gZGlzYWJsZWQ7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1M Rm9ybUVsZW1lbnQgZm9ybTsKKyAgICAgICAgYXR0cmlidXRlIGJvb2xlYW4gbXVsdGlwbGU7Cisg ICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIG5hbWU7 CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiByZXF1aXJlZDsKKyAgICAgICAg YXR0cmlidXRlIGxvbmcgc2l6ZTsKKwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry aW5nIHR5cGU7Ci0gICAgICAgIGF0dHJpYnV0ZSBsb25nIHNlbGVjdGVkSW5kZXg7Ci0gICAgICAg IGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIHZhbHVlOwotICAg ICAgICAKLSAgICAgICAgLy8gTW9kaWZpZWQgaW4gRE9NIExldmVsIDI6CisKKyAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIEhUTUxPcHRpb25zQ29sbGVjdGlvbiBvcHRpb25zOwogI2lmIGRlZmlu ZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DCiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nIGxlbmd0aDsKICNlbHNlCiAgICAgICAgIGF0dHJpYnV0 ZSB1bnNpZ25lZCBsb25nIGxlbmd0aCBzZXR0ZXIgcmFpc2VzIChET01FeGNlcHRpb24pOwogI2Vu ZGlmCi0KLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhUTUxGb3JtRWxlbWVudCBmb3JtOwot ICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRpdHlTdGF0ZSB2YWxpZGl0eTsKLSAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2lsbFZhbGlkYXRlOwotICAgICAgICByZWFk b25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlOwotICAgICAgICBib29s ZWFuIGNoZWNrVmFsaWRpdHkoKTsKLSAgICAgICAgdm9pZCBzZXRDdXN0b21WYWxpZGl0eShpbiBb VHJlYXROdWxsQXM9TnVsbFN0cmluZywgVHJlYXRVbmRlZmluZWRBcz1OdWxsU3RyaW5nXSBET01T dHJpbmcgZXJyb3IpOwotCi0gICAgICAgIC8vIE1vZGlmaWVkIGluIERPTSBMZXZlbCAyOgotICAg ICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTE9wdGlvbnNDb2xsZWN0aW9uIG9wdGlvbnM7Ci0K LSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIGRpc2FibGVkOwotICAgICAgICBh dHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0b2ZvY3VzOwotICAgICAgICBhdHRyaWJ1dGUg Ym9vbGVhbiBtdWx0aXBsZTsKLSAgICAgICAgYXR0cmlidXRlIFtUcmVhdE51bGxBcz1OdWxsU3Ry aW5nXSBET01TdHJpbmcgbmFtZTsKLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFu IHJlcXVpcmVkOwotICAgICAgICBhdHRyaWJ1dGUgbG9uZyBzaXplOwotICAgICAgICAKLSAgICAg ICAgW09iakNMZWdhY3lVbm5hbWVkUGFyYW1ldGVyc10gdm9pZCBhZGQoaW4gW09wdGlvbmFsPURl ZmF1bHRJc1VuZGVmaW5lZF0gSFRNTEVsZW1lbnQgZWxlbWVudCwgCisgICAgICAgIE5vZGUgaXRl bShpbiBbSXNJbmRleCxPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIHVuc2lnbmVkIGxvbmcg aW5kZXgpOworICAgICAgICBOb2RlIG5hbWVkSXRlbShpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5k ZWZpbmVkXSBET01TdHJpbmcgbmFtZSk7CisgICAgICAgIFtPYmpDTGVnYWN5VW5uYW1lZFBhcmFt ZXRlcnNdIHZvaWQgYWRkKGluIFtPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIEhUTUxFbGVt ZW50IGVsZW1lbnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25h bD1EZWZhdWx0SXNVbmRlZmluZWRdIEhUTUxFbGVtZW50IGJlZm9yZSkgcmFpc2VzKERPTUV4Y2Vw dGlvbik7Ci0KICNpZiBkZWZpbmVkKExBTkdVQUdFX0pBVkFTQ1JJUFQpICYmIExBTkdVQUdFX0pB VkFTQ1JJUFQKICAgICAgICAgLy8gSW4gSmF2YVNjcmlwdCwgd2Ugc3VwcG9ydCBib3RoIG9wdGlv biBpbmRleCBhbmQgb3B0aW9uIG9iamVjdCBwYXJhbWV0ZXJzLgogICAgICAgICAvLyBBcyBvZiB0 aGlzIHdyaXRpbmcgdGhpcyBjYW5ub3QgYmUgYXV0by1nZW5lcmF0ZWQuCkBAIC02MiwxMiArNTEs MTUgQEAgbW9kdWxlIGh0bWwgewogI2Vsc2UKICAgICAgICAgdm9pZCByZW1vdmUoaW4gbG9uZyBp bmRleCk7CiAjZW5kaWYKKyAgICAgICAgYXR0cmlidXRlIGxvbmcgc2VsZWN0ZWRJbmRleDsKKyAg ICAgICAgYXR0cmlidXRlIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgdmFsdWU7 CisKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2lsbFZhbGlkYXRlOworICAg ICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRpdHlTdGF0ZSB2YWxpZGl0eTsKKyAgICAgICAg cmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyB2YWxpZGF0aW9uTWVzc2FnZTsKKyAgICAgICAg Ym9vbGVhbiBjaGVja1ZhbGlkaXR5KCk7CisgICAgICAgIHZvaWQgc2V0Q3VzdG9tVmFsaWRpdHko aW4gW1RyZWF0TnVsbEFzPU51bGxTdHJpbmcsIFRyZWF0VW5kZWZpbmVkQXM9TnVsbFN0cmluZ10g RE9NU3RyaW5nIGVycm9yKTsKIAotICAgICAgICAvLyBUaGVzZSBtZXRob2RzIGFyZSBub3QgaW4g RE9NIExldmVsIDIgSURMLCBidXQgYXJlIG1lbnRpb25lZCBpbiB0aGUgc3RhbmRhcmQ6Ci0gICAg ICAgIC8vICJUaGUgY29udGFpbmVkIG9wdGlvbnMgY2FuIGJlIGRpcmVjdGx5IGFjY2Vzc2VkIHRo cm91Z2ggdGhlIHNlbGVjdCBlbGVtZW50IGFzIGEgY29sbGVjdGlvbi4iCi0gICAgICAgIE5vZGUg aXRlbShpbiBbSXNJbmRleCxPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIHVuc2lnbmVkIGxv bmcgaW5kZXgpOwotICAgICAgICBOb2RlIG5hbWVkSXRlbShpbiBbT3B0aW9uYWw9RGVmYXVsdElz VW5kZWZpbmVkXSBET01TdHJpbmcgbmFtZSk7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBO b2RlTGlzdCBsYWJlbHM7CiAgICAgfTsKLQogfQo= 129826 2012-03-01 23:11:01 -0800 2012-03-02 05:24:52 -0800 Patch 2 bug-80097-20120302161059.patch text/plain 4385 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVhMDVhNWVjNDcxNmZm OGNjNmFkN2YzNThkMzk5ZGRlMGI3Y2EzOC4uY2E0YWEwMDYzNmI2YmJmYjlkMzRiYWJmMDcwZGNl MTgzODQwZGVkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTFNlbGVjdEVsZW1lbnQuaWRsIGFzIHNh bWUgYXMgc3BlY2lmaWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODAwOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAg KiBodG1sL0hUTUxTZWxlY3RFbGVtZW50LmlkbDogUmVvcmRlciBhdHRyaWJ1dGUvbWV0aG9kIHBv c2l0aW9uLgorCiAyMDEyLTAzLTAxICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgSGFuZGxlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyRml0IGlu IENTU1N0eWxlQXBwbHlQcm9wZXJ0eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFNlbGVjdEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxl bWVudC5pZGwKaW5kZXggNGYwYjgyNjYyZjk5Y2M0NDE5MzRmMzg3NTIwMWQ4ZmQ2NzBhZTRhNC4u MTIwMTE3Y2M5ZTk2NTVjYTAwMGFiMjI5MWQzYjA1NTI1NzAyMTQ1OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGwKQEAgLTI0LDM3ICsyNCwyOCBAQCBtb2R1bGUg aHRtbCB7CiAgICAgICAgIEluZGV4ZWRHZXR0ZXIsCiAgICAgICAgIEN1c3RvbUluZGV4ZWRTZXR0 ZXIKICAgICBdIEhUTUxTZWxlY3RFbGVtZW50IDogSFRNTEVsZW1lbnQgeworICAgICAgICBhdHRy aWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0b2ZvY3VzOworICAgICAgICBhdHRyaWJ1dGUgW1Jl ZmxlY3RdIGJvb2xlYW4gZGlzYWJsZWQ7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1M Rm9ybUVsZW1lbnQgZm9ybTsKKyAgICAgICAgYXR0cmlidXRlIGJvb2xlYW4gbXVsdGlwbGU7Cisg ICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIG5hbWU7 CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiByZXF1aXJlZDsKKyAgICAgICAg YXR0cmlidXRlIGxvbmcgc2l6ZTsKKwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry aW5nIHR5cGU7Ci0gICAgICAgIGF0dHJpYnV0ZSBsb25nIHNlbGVjdGVkSW5kZXg7Ci0gICAgICAg IGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIHZhbHVlOwotICAg ICAgICAKLSAgICAgICAgLy8gTW9kaWZpZWQgaW4gRE9NIExldmVsIDI6CisKKyAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIEhUTUxPcHRpb25zQ29sbGVjdGlvbiBvcHRpb25zOwogI2lmIGRlZmlu ZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DCisgICAgICAg IC8vIERPTSBMZXZlbCAyIGNoYW5nZXMgdHlwZSBvZiBsZW5ndGggYXR0cmlidXRlIHRvIHVuc2ln bmVkIGxvbmcsIAorICAgICAgICAvLyBmb3IgY29tcGF0aWJpbGl0eSB3ZSBrZWVwIERPTSBMZXZl bCAxIGRlZmluaXRpb24uCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nIGxlbmd0aDsK ICNlbHNlCiAgICAgICAgIGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGxlbmd0aCBzZXR0ZXIgcmFp c2VzIChET01FeGNlcHRpb24pOwogI2VuZGlmCi0KLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IEhUTUxGb3JtRWxlbWVudCBmb3JtOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRp dHlTdGF0ZSB2YWxpZGl0eTsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2ls bFZhbGlkYXRlOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHZhbGlkYXRp b25NZXNzYWdlOwotICAgICAgICBib29sZWFuIGNoZWNrVmFsaWRpdHkoKTsKLSAgICAgICAgdm9p ZCBzZXRDdXN0b21WYWxpZGl0eShpbiBbVHJlYXROdWxsQXM9TnVsbFN0cmluZywgVHJlYXRVbmRl ZmluZWRBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgZXJyb3IpOwotCi0gICAgICAgIC8vIE1vZGlm aWVkIGluIERPTSBMZXZlbCAyOgotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTE9wdGlv bnNDb2xsZWN0aW9uIG9wdGlvbnM7Ci0KLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29s ZWFuIGRpc2FibGVkOwotICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gYXV0b2Zv Y3VzOwotICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiBtdWx0aXBsZTsKLSAgICAgICAgYXR0cmli dXRlIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgbmFtZTsKLSAgICAgICAgYXR0 cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIHJlcXVpcmVkOwotICAgICAgICBhdHRyaWJ1dGUgbG9u ZyBzaXplOwotICAgICAgICAKLSAgICAgICAgW09iakNMZWdhY3lVbm5hbWVkUGFyYW1ldGVyc10g dm9pZCBhZGQoaW4gW09wdGlvbmFsPURlZmF1bHRJc1VuZGVmaW5lZF0gSFRNTEVsZW1lbnQgZWxl bWVudCwgCisgICAgICAgIE5vZGUgaXRlbShpbiBbSXNJbmRleCxPcHRpb25hbD1EZWZhdWx0SXNV bmRlZmluZWRdIHVuc2lnbmVkIGxvbmcgaW5kZXgpOworICAgICAgICBOb2RlIG5hbWVkSXRlbShp biBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBET01TdHJpbmcgbmFtZSk7CisgICAgICAg IFtPYmpDTGVnYWN5VW5uYW1lZFBhcmFtZXRlcnNdIHZvaWQgYWRkKGluIFtPcHRpb25hbD1EZWZh dWx0SXNVbmRlZmluZWRdIEhUTUxFbGVtZW50IGVsZW1lbnQsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGluIFtPcHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIEhUTUxFbGVtZW50 IGJlZm9yZSkgcmFpc2VzKERPTUV4Y2VwdGlvbik7Ci0KICNpZiBkZWZpbmVkKExBTkdVQUdFX0pB VkFTQ1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKICAgICAgICAgLy8gSW4gSmF2YVNjcmlw dCwgd2Ugc3VwcG9ydCBib3RoIG9wdGlvbiBpbmRleCBhbmQgb3B0aW9uIG9iamVjdCBwYXJhbWV0 ZXJzLgogICAgICAgICAvLyBBcyBvZiB0aGlzIHdyaXRpbmcgdGhpcyBjYW5ub3QgYmUgYXV0by1n ZW5lcmF0ZWQuCkBAIC02MiwxMiArNTMsMTUgQEAgbW9kdWxlIGh0bWwgewogI2Vsc2UKICAgICAg ICAgdm9pZCByZW1vdmUoaW4gbG9uZyBpbmRleCk7CiAjZW5kaWYKKyAgICAgICAgYXR0cmlidXRl IGxvbmcgc2VsZWN0ZWRJbmRleDsKKyAgICAgICAgYXR0cmlidXRlIFtUcmVhdE51bGxBcz1OdWxs U3RyaW5nXSBET01TdHJpbmcgdmFsdWU7CisKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJv b2xlYW4gd2lsbFZhbGlkYXRlOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgVmFsaWRpdHlT dGF0ZSB2YWxpZGl0eTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyB2YWxp ZGF0aW9uTWVzc2FnZTsKKyAgICAgICAgYm9vbGVhbiBjaGVja1ZhbGlkaXR5KCk7CisgICAgICAg IHZvaWQgc2V0Q3VzdG9tVmFsaWRpdHkoaW4gW1RyZWF0TnVsbEFzPU51bGxTdHJpbmcsIFRyZWF0 VW5kZWZpbmVkQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIGVycm9yKTsKIAotICAgICAgICAvLyBU aGVzZSBtZXRob2RzIGFyZSBub3QgaW4gRE9NIExldmVsIDIgSURMLCBidXQgYXJlIG1lbnRpb25l ZCBpbiB0aGUgc3RhbmRhcmQ6Ci0gICAgICAgIC8vICJUaGUgY29udGFpbmVkIG9wdGlvbnMgY2Fu IGJlIGRpcmVjdGx5IGFjY2Vzc2VkIHRocm91Z2ggdGhlIHNlbGVjdCBlbGVtZW50IGFzIGEgY29s bGVjdGlvbi4iCi0gICAgICAgIE5vZGUgaXRlbShpbiBbSXNJbmRleCxPcHRpb25hbD1EZWZhdWx0 SXNVbmRlZmluZWRdIHVuc2lnbmVkIGxvbmcgaW5kZXgpOwotICAgICAgICBOb2RlIG5hbWVkSXRl bShpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVkXSBET01TdHJpbmcgbmFtZSk7CiAgICAg ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBOb2RlTGlzdCBsYWJlbHM7CiAgICAgfTsKLQogfQo=