80089 2012-03-01 20:16:53 -0800 [Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement 2012-03-05 17:39:19 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79764 1 yosin yosin abarth fishd tkent webkit.review.bot oldest_to_newest 569200 0 yosin 2012-03-01 20:16:53 -0800 According to specification, WebOptionElement isn't form associated control(FormControlElement is derived from FormAssociateElement) . To avoid having extra functionality and removing extra dependency, WebOptionElement should derive from WebElement rather than WebFormControlElement. 569218 1 129804 yosin 2012-03-01 21:13:30 -0800 Created attachment 129804 Patch 1 569221 2 webkit.review.bot 2012-03-01 21:18:00 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 569999 3 129804 fishd 2012-03-02 15:40:12 -0800 Comment on attachment 129804 Patch 1 Why? HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that. 570052 4 tkent 2012-03-02 17:20:13 -0800 (In reply to comment #3) > (From update of attachment 129804 [details]) > Why? HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that. HTMLOptionElement shouldn't inherit from HTMLFormControlElement. The current implementation of HTMLOptionElement wastes memory and time, and we have an actual performance bug reported by a user. yosin is going to change it. See Bug 79764. 571224 5 129804 fishd 2012-03-05 17:10:23 -0800 Comment on attachment 129804 Patch 1 OK! 571268 6 129804 webkit.review.bot 2012-03-05 17:39:12 -0800 Comment on attachment 129804 Patch 1 Clearing flags on attachment: 129804 Committed r109827: <http://trac.webkit.org/changeset/109827> 571269 7 webkit.review.bot 2012-03-05 17:39:19 -0800 All reviewed patches have been landed. Closing bug. 129804 2012-03-01 21:13:30 -0800 2012-03-05 17:39:12 -0800 Patch 1 bug-80089-20120302141329.patch text/plain 3197 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGMyYjFhMzk4OGIxMDFhMmRkM2JhNDc3ZDRjZDViZmY5MDgyOTI2N2EuLmRkNjViYTQ0NDNmMmEw MmZkNzY2MTE3YTE5YTRmMTVkMzFiMjMyNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDMtMDEgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYk9wdGlvbkVsZW1lbnQgc2hvdWxkIGlu aGVyaXQgV2ViRWxlbWVudCBpbnN0ZWFkIG9mIFdlYkZvcm1Db250cm9sRWxlbWVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAwODkKKworICAgICAg ICBDaGFuZ2UgY2xhc3MgaGllcmFyY2h5IG9mIFdlYk9wdGlvbkVsZW1lbnQgdG8gbWF0Y2ggd2l0 aCBzcGVjaWZpY2F0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcHVibGljL1dlYk9wdGlvbkVsZW1lbnQuaDogUmVwbGFjZSB0byBXZWJFbGVt ZW50IGZyb20gV2ViRm9ybUNvbnRyb2xFbGVtZW50IAorICAgICAgICAoV2ViS2l0OjpXZWJPcHRp b25FbGVtZW50OjpXZWJPcHRpb25FbGVtZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViT3B0aW9u RWxlbWVudDo6b3BlcmF0b3I9KToKKyAgICAgICAgKFdlYktpdDo6V2ViT3B0aW9uRWxlbWVudDo6 YXNzaWduKToKKyAgICAgICAgKiBzcmMvV2ViT3B0aW9uRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYk9wdGlvbkVsZW1lbnQ6OldlYk9wdGlvbkVsZW1lbnQpOgorCiAyMDEyLTAzLTAx ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9t aXVtXSBSZW5hbWUgTGF5ZXJDaHJvbWl1bTo6bmFtZSB0byBkZWJ1Z05hbWUgdG8gYmUgbW9yZSBj b25zaXN0ZW50IHdpdGggb3RoZXIgZGVidWcgcHJvcGVydGllcywgbWFrZSB0aHJlYWRzYWZlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJPcHRpb25FbGVtZW50 LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJPcHRpb25FbGVtZW50LmgKaW5k ZXggM2Q5MzkwYjcxOTdmMTliNzI0ZjdmNzMzN2VkNWYyMmIxNzVmOTczNS4uZDU4Y2NiNGUzY2Y1 NjQ1ZjM2Nzc0ZTg0ODE2MzNmMzAzODk5MzI5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViT3B0aW9uRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYk9wdGlvbkVsZW1lbnQuaApAQCAtMzEsNyArMzEsNyBAQAogI2lmbmRl ZiBXZWJPcHRpb25FbGVtZW50X2gKICNkZWZpbmUgV2ViT3B0aW9uRWxlbWVudF9oCiAKLSNpbmNs dWRlICJXZWJGb3JtQ29udHJvbEVsZW1lbnQuaCIKKyNpbmNsdWRlICJXZWJFbGVtZW50LmgiCiAj aW5jbHVkZSAicGxhdGZvcm0vV2ViVmVjdG9yLmgiCiAKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJ T04KQEAgLTQxLDE3ICs0MSwxNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7IGNsYXNzIEhUTUxPcHRp b25FbGVtZW50OyB9CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogLy8gUHJvdmlkZXMgcmVhZG9ubHkg YWNjZXNzIHRvIHNvbWUgcHJvcGVydGllcyBvZiBhIERPTSBvcHRpb24gZWxlbWVudCBub2RlLgot Y2xhc3MgV2ViT3B0aW9uRWxlbWVudCA6IHB1YmxpYyBXZWJGb3JtQ29udHJvbEVsZW1lbnQgewor Y2xhc3MgV2ViT3B0aW9uRWxlbWVudCA6IHB1YmxpYyBXZWJFbGVtZW50IHsKIHB1YmxpYzoKLSAg ICBXZWJPcHRpb25FbGVtZW50KCkgOiBXZWJGb3JtQ29udHJvbEVsZW1lbnQoKSB7IH0KLSAgICBX ZWJPcHRpb25FbGVtZW50KGNvbnN0IFdlYk9wdGlvbkVsZW1lbnQmIGVsZW1lbnQpIDogV2ViRm9y bUNvbnRyb2xFbGVtZW50KGVsZW1lbnQpIHsgfQorICAgIFdlYk9wdGlvbkVsZW1lbnQoKSA6IFdl YkVsZW1lbnQoKSB7IH0KKyAgICBXZWJPcHRpb25FbGVtZW50KGNvbnN0IFdlYk9wdGlvbkVsZW1l bnQmIGVsZW1lbnQpIDogV2ViRWxlbWVudChlbGVtZW50KSB7IH0KIAogICAgIFdlYk9wdGlvbkVs ZW1lbnQmIG9wZXJhdG9yPShjb25zdCBXZWJPcHRpb25FbGVtZW50JiBlbGVtZW50KQogICAgIHsK LSAgICAgICAgV2ViRm9ybUNvbnRyb2xFbGVtZW50Ojphc3NpZ24oZWxlbWVudCk7CisgICAgICAg IFdlYkVsZW1lbnQ6OmFzc2lnbihlbGVtZW50KTsKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAg IH0KLSAgICB2b2lkIGFzc2lnbihjb25zdCBXZWJPcHRpb25FbGVtZW50JiBlbGVtZW50KSB7IFdl YkZvcm1Db250cm9sRWxlbWVudDo6YXNzaWduKGVsZW1lbnQpOyB9CisgICAgdm9pZCBhc3NpZ24o Y29uc3QgV2ViT3B0aW9uRWxlbWVudCYgZWxlbWVudCkgeyBXZWJFbGVtZW50Ojphc3NpZ24oZWxl bWVudCk7IH0KIAogICAgIFdFQktJVF9FWFBPUlQgdm9pZCBzZXRWYWx1ZShjb25zdCBXZWJTdHJp bmcmKTsKICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyB2YWx1ZSgpIGNvbnN0OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViT3B0aW9uRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJPcHRpb25FbGVtZW50LmNwcAppbmRleCBkNDg0 OTI1OTRiYWU2N2E1Yjg0Yzk3YzI4MTQxYTE0ZjY4YzJjM2Y3Li5jNzFmN2I1NjU2ODZkZGM0MzFm Zjg0ODBmZTk1ZDMyYmNjYjg1ZTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJPcHRpb25FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJPcHRpb25FbGVtZW50LmNwcApAQCAtODMsNyArODMsNyBAQCBib29sIFdlYk9wdGlvbkVs ZW1lbnQ6OmlzRW5hYmxlZCgpIGNvbnN0CiB9CiAKIFdlYk9wdGlvbkVsZW1lbnQ6OldlYk9wdGlv bkVsZW1lbnQoY29uc3QgUGFzc1JlZlB0cjxIVE1MT3B0aW9uRWxlbWVudD4mIGVsZW0pCi0gICAg OiBXZWJGb3JtQ29udHJvbEVsZW1lbnQoZWxlbSkKKyAgICA6IFdlYkVsZW1lbnQoZWxlbSkKIHsK IH0KIAo=