80088 2012-03-01 20:11:30 -0800 [Forms][CSS] The option element should not match pseudo class :valid 2012-03-22 23:11:56 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://jsfiddle.net/YtJmt/ P2 Normal --- 79764 80381 1 yosin yosin tkent webkit.review.bot oldest_to_newest 569199 0 yosin 2012-03-01 20:11:30 -0800 Because of the class HTMLOptionElement inherits HTMLFormControlElement, the option element matches CSS pseudo class :valid. Sample URL shows this bug. List box should contain red color text instead of green color text. 571426 1 yosin 2012-03-05 20:34:40 -0800 Pseudo class :valid and :invalid are defined in http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#pseudo-classes 581643 2 yosin 2012-03-18 23:20:21 -0700 *** Bug 81487 has been marked as a duplicate of this bug. *** 581679 3 yosin 2012-03-19 00:47:41 -0700 The "option" elements match following CSS pseudo classes[1]: 1. enables 2. disabled 3. checked 4. default I'm not sure [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#pseudo-classes == Sample HTML == <head> <style type="text/css"> option:enabled { color: #0000ff; font-size: 30pt; } option:disabled { color: #808080; font-size: 20pt;} option:checked { background: #00ffff; } option:default{ font-style: italic; } </style> </head> <select size="10"> <option id="enabled">enabled #0000ff</option> <option id="disabled" disabled="disabled">disabled #cccccc</option> <option id="checcked">checked #00ffff</option> <option id="default" selected="selected">default #italic</option> </select> 586069 4 133425 yosin 2012-03-22 21:29:36 -0700 Created attachment 133425 Patch 1 586084 5 133425 tkent 2012-03-22 22:13:43 -0700 Comment on attachment 133425 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=133425&action=review > LayoutTests/fast/css/pseudo-valid-007.html:24 > +shouldBeNull('document.querySelector("option:valid")'); This should be added to pseudo-valid-unapplied.html. pseudo-valid-007.html is for <select>. 586085 6 133430 yosin 2012-03-22 22:21:36 -0700 Created attachment 133430 Patch 2 586089 7 133430 tkent 2012-03-22 22:41:07 -0700 Comment on attachment 133430 Patch 2 ok 586102 8 133430 webkit.review.bot 2012-03-22 23:11:52 -0700 Comment on attachment 133430 Patch 2 Clearing flags on attachment: 133430 Committed r111830: <http://trac.webkit.org/changeset/111830> 586103 9 webkit.review.bot 2012-03-22 23:11:56 -0700 All reviewed patches have been landed. Closing bug. 133425 2012-03-22 21:29:36 -0700 2012-03-22 22:21:32 -0700 Patch 1 bug-80088-20120323132935.patch text/plain 2342 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODAxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWE5NTM2N2YyNTc5M2JlMjQ0ODgz Y2EwNDgzMDM4NzA3ZDhlNTIyYS4uNGIwYjYwZjk3NDllMzMxYTRkNjc1YTcyMDM0ZWNlMjUwZDRl ZDVkZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTIyICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXVtDU1NdIFRoZSBvcHRpb24g ZWxlbWVudCBzaG91bGQgbm90IG1hdGNoIHBzZXVkbyBjbGFzcyA6dmFsaWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMDg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRlZCBhbiBh c3NlcnRpb24gZm9yIGNoZWNraW5nIHRoZSAib3B0aW9uIiBlbGVtZW50CisgICAgICAgIGRvZXNu J3QgbWF0Y2ggdG8gQ1NTIHBzZXVkbyBjbGFzcyAidmFsaWQiLiBUaGlzIGJlaGF2aW9yIHdhcyBm aXhlZAorICAgICAgICBieSByMTExNjU5LgorCisgICAgICAgICogZmFzdC9jc3MvcHNldWRvLXZh bGlkLTAwNy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jc3MvcHNldWRvLXZhbGlkLTAw Ny5odG1sOgorCiAyMDEyLTAzLTIyICBEYXZlIFRoYXJwICA8ZHRoYXJwQGNvZGVhdXJvcmEub3Jn PgogCiAgICAgICAgIFFUIDQuOCBzb2Z0IGh5cGhlbiBidWcgaGFzIG5vIGZhaWxpbmcgdGVzdCBj YXNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1ZG8tdmFsaWQtMDA3LWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby12YWxpZC0wMDctZXhwZWN0 ZWQudHh0CmluZGV4IDA3MTZjMGI3ZjkwOTFlOTE4NjgyZDU5NDgzYWUyZjMyMmUxNjYzYTMuLjBj ODI5NmI5YmNlNTE0OGQxZDhkM2Y2YTJiYzRlNzY5ZDM5ZGU2ZWYgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby12YWxpZC0wMDctZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby12YWxpZC0wMDctZXhwZWN0ZWQudHh0CkBAIC02LDYgKzYs NyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogIAogUEFTUyBkb2N1bWVudC5kZWZhdWx0Vmll dy5nZXRDb21wdXRlZFN0eWxlKHZbaV0sIG51bGwpLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91 bmQtY29sb3InKSBpcyAncmdiKDAsIDI1NSwgMCknCiBQQVNTIGRvY3VtZW50LmRlZmF1bHRWaWV3 LmdldENvbXB1dGVkU3R5bGUodltpXSwgbnVsbCkuZ2V0UHJvcGVydHlWYWx1ZSgnYmFja2dyb3Vu ZC1jb2xvcicpIGlzICdyZ2IoMCwgMjU1LCAwKScKK1BBU1MgZG9jdW1lbnQucXVlcnlTZWxlY3Rv cigib3B0aW9uOnZhbGlkIikgaXMgbnVsbAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1 ZG8tdmFsaWQtMDA3Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1ZG8tdmFsaWQtMDA3 Lmh0bWwKaW5kZXggMTdjMmExNWJmOWUyOTNmZTRiYmU2M2UwMTQ4YTQ1MDRhOTZkZDljZC4uY2Fh NzViZTEyMjNjYTY1MjJkM2JjYzkzYzVmZGZkYjU1NjZkMTkzMiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZmFzdC9jc3MvcHNldWRvLXZhbGlkLTAwNy5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL3BzZXVkby12YWxpZC0wMDcuaHRtbApAQCAtMjEsNiArMjEsNyBAQCBkZXNjcmlwdGlv bigiVGhpcyB0ZXN0IHBlcmZvcm1zIGEgY2hlY2sgZm9yIHRoZSA6dmFsaWQgQ1NTIHNlbGVjdG9y IG9uIGEgc2VsZWN0CiB2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeU5hbWUoInZpY3RpbSIpOwog Zm9yIChpID0gMDsgaSA8IHYubGVuZ3RoOyBpKyspCiAgICAgc2hvdWxkQmUoImRvY3VtZW50LmRl ZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUodltpXSwgbnVsbCkuZ2V0UHJvcGVydHlWYWx1ZSgn YmFja2dyb3VuZC1jb2xvcicpIiwgIidyZ2IoMCwgMjU1LCAwKSciKTsKK3Nob3VsZEJlTnVsbCgn ZG9jdW1lbnQucXVlcnlTZWxlY3Rvcigib3B0aW9uOnZhbGlkIiknKTsKIDwvc2NyaXB0PgogPHNj cmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgogPC9i b2R5Pgo= 133430 2012-03-22 22:21:36 -0700 2012-03-22 23:11:52 -0700 Patch 2 bug-80088-20120323142135.patch text/plain 2526 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODAxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWE5NTM2N2YyNTc5M2JlMjQ0ODgz Y2EwNDgzMDM4NzA3ZDhlNTIyYS4uM2Y3MDA1YThjZDdkYTcwZDVlN2ZjMTU4YTAzYmM2NzZmZjc3 Yzk0NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTIyICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXVtDU1NdIFRoZSBvcHRpb24g ZWxlbWVudCBzaG91bGQgbm90IG1hdGNoIHBzZXVkbyBjbGFzcyA6dmFsaWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMDg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRlZCBhbiBh c3NlcnRpb24gZm9yIGNoZWNraW5nIHRoZSAib3B0aW9uIiBlbGVtZW50CisgICAgICAgIGRvZXNu J3QgbWF0Y2ggdG8gQ1NTIHBzZXVkbyBjbGFzcyAidmFsaWQiLiBUaGlzIGJlaGF2aW9yIHdhcyBm aXhlZAorICAgICAgICBieSByMTExNjU5LgorCisgICAgICAgICogZmFzdC9jc3MvcHNldWRvLXZh bGlkLXVuYXBwbGllZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jc3MvcHNldWRvLXZh bGlkLXVuYXBwbGllZC5odG1sOgorCiAyMDEyLTAzLTIyICBEYXZlIFRoYXJwICA8ZHRoYXJwQGNv ZGVhdXJvcmEub3JnPgogCiAgICAgICAgIFFUIDQuOCBzb2Z0IGh5cGhlbiBidWcgaGFzIG5vIGZh aWxpbmcgdGVzdCBjYXNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1ZG8t dmFsaWQtdW5hcHBsaWVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVk by12YWxpZC11bmFwcGxpZWQtZXhwZWN0ZWQudHh0CmluZGV4IDBlNjU4ZTlkOWU4Y2E3OTFhOTNm OThlOGM3OTdhNWY2NzdiMjBiYmMuLmQ3NjA3NzRlMGY0N2RhMmJlNWU0MzVhZjNlMmVlM2QyNzcy NjI1MGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby12YWxpZC11bmFw cGxpZWQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby12YWxp ZC11bmFwcGxpZWQtZXhwZWN0ZWQudHh0CkBAIC0xNSw2ICsxNSw3IEBAIFBBU1MgZ2V0QmFja2dy b3VuZENvbG9yKCdidXR0b24tYnV0dG9uJykgaXMgbm9ybWFsQ29sb3IKIFBBU1MgZ2V0QmFja2dy b3VuZENvbG9yKCdidXR0b24tcmVzZXQnKSBpcyBub3JtYWxDb2xvcgogUEFTUyBnZXRCYWNrZ3Jv dW5kQ29sb3IoJ3Byb2dyZXNzJykgaXMgbm9ybWFsQ29sb3IKIFBBU1MgZ2V0QmFja2dyb3VuZENv bG9yKCdtZXRlcicpIGlzIG5vcm1hbENvbG9yCitQQVNTIGdldEJhY2tncm91bmRDb2xvcignb3B0 aW9uJykgaXMgbm9ybWFsQ29sb3IKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAog VEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcHNldWRvLXZh bGlkLXVuYXBwbGllZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcHNldWRvLXZhbGlkLXVu YXBwbGllZC5odG1sCmluZGV4IGMwZjFmOTQ4OWY5MDRiMTI0YjliMGI5YmY4NWM1YmI3NzEwMzE0 MTIuLjQxYzk1ZGZkZmRmODE3OWMzMTM3ODRjMTQ3ZTIwZjMzYTk1MDAxOTMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby12YWxpZC11bmFwcGxpZWQuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1ZG8tdmFsaWQtdW5hcHBsaWVkLmh0bWwKQEAgLTExLDYg KzExLDggQEAKICBidXR0b24geyBiYWNrZ3JvdW5kOiBsaW1lOyB9CiAgcHJvZ3Jlc3MgeyBiYWNr Z3JvdW5kOiBsaW1lOyB9CiAgbWV0ZXIgeyBiYWNrZ3JvdW5kOiBsaW1lOyB9Cisgb3B0aW9uIHsg YmFja2dyb3VuZDogbGltZTsgfQorIHNlbGVjdCB7IGJhY2tncm91bmQ6IGxpbWU7IH0KIDwvc3R5 bGU+CiA8L2hlYWQ+CiA8Ym9keT4KQEAgLTI4LDYgKzMwLDcgQEAKIDxidXR0b24gbmFtZT0iYnV0 dG9uLXJlc2V0IiB0eXBlPSJyZXNldCI+TG9yZW0gaXBzdW08L2J1dHRvbj4KIDxwcm9ncmVzcyBp ZD0icHJvZ3Jlc3MiIHZhbHVlPTUwIG1heD0xMDA+NTA8L3Byb2dyZXNzPgogPG1ldGVyIGlkPSJt ZXRlciIgdmFsdWU9NTAgbWF4PTEwMD41MDwvbWV0ZXI+Cis8c2VsZWN0IGlkPSJzZWxlY3QiIHJl cXVpcmVkPjxvcHRpb24gaWQ9Im9wdGlvbiIgdmFsdWU9IjEiPk9uZTwvb3B0aW9uPjwvc2VsZWN0 PgogPC9mb3JtPgogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiA8c2NyaXB0PgpAQCAtNTIsNiAr NTUsNyBAQCB2YXIgbmFtZXMgPSBbCiAgICAgImJ1dHRvbi1yZXNldCIsCiAgICAgInByb2dyZXNz IiwKICAgICAibWV0ZXIiLAorICAgICJvcHRpb24iLAogXTsKIAogdmFyIG5vcm1hbENvbG9yID0g InJnYigwLCAyNTUsIDApIjsK