79753 2012-02-27 23:46:34 -0800 RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled should not be inline 2012-02-28 02:19:45 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 rolandsteiner rolandsteiner dglazkov hayato morrita shinyak webkit.review.bot oldest_to_newest 566430 0 rolandsteiner 2012-02-27 23:46:34 -0800 It's referred in WebCore.exp.in if SHADOW_DOM is enabled, and creates a linker error if inline 566433 1 129199 rolandsteiner 2012-02-27 23:49:24 -0800 Created attachment 129199 Patch 566444 2 hayato 2012-02-28 00:07:26 -0800 Looks reasonable. Inline should be avoided here because it is used from DumpRenderTree. 566452 3 129199 morrita 2012-02-28 00:18:16 -0800 Comment on attachment 129199 Patch Basically we should inline runtime feature accessor for performance reason. But considering this flag will be removed shortly, this is OK for now. 566491 4 129199 webkit.review.bot 2012-02-28 01:24:00 -0800 Comment on attachment 129199 Patch Clearing flags on attachment: 129199 Committed r109089: <http://trac.webkit.org/changeset/109089> 566492 5 webkit.review.bot 2012-02-28 01:24:05 -0800 All reviewed patches have been landed. Closing bug. 566522 6 webkit.review.bot 2012-02-28 02:19:45 -0800 The commit-queue encountered the following flaky tests while processing attachment 129199: compositing/reflections/nested-reflection-transformed2.html bug 79743 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch. 129199 2012-02-27 23:49:24 -0800 2012-02-28 01:24:00 -0800 Patch bug-79753-20120228164922.patch text/plain 2499 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VjYzQ2MWQxNWRiMWM0 ZWY4MTNlZTBhMWNlNzVlNDU1N2U3MzE2ZS4uZjRkMDUwNzAxNmMxMWEzYmIwNjM0MDdjZWEzMDE0 MjBlZmM2MzZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTI3ICBSb2xh bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJ1bnRp bWVFbmFibGVkRmVhdHVyZXM6OnNldE11bHRpcGxlU2hhZG93U3VidHJlZXNFbmFibGVkIHNob3Vs ZCBub3QgYmUgaW5saW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03OTc1MworCisgICAgICAgIE1vdmVkIHRoZSBmdW5jdGlvbiBpbXBsZW1lbnRhdGlv biB0byB0aGUgLmNwcCBmaWxlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKG5vIGZ1bmN0aW9uYWwgY2hhbmdlKQorCisgICAg ICAgICogYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldE11bHRpcGxlU2hhZG93U3Vi dHJlZXNFbmFibGVkKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL2dl bmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgorICAgICAgICAoUnVudGltZUVuYWJsZWRG ZWF0dXJlcyk6CisKIDIwMTItMDItMjcgIFdlaSBKYW1lcyAgPGphbWVzLndlaUBpbnRlbC5jb20+ CiAKICAgICAgICAgTXVsdGktQ2hhbm5lbCBzdXBwb3J0IGluIEF1ZGlvQnVmZmVyU291cmNlTm9k ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5h YmxlZEZlYXR1cmVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGlt ZUVuYWJsZWRGZWF0dXJlcy5jcHAKaW5kZXggOGZhZDJjNWQ3MDJlMTI4ZTU2YTI5MDUxNmVjMjZl NDFjNWQzMzQxZC4uY2FkZDJjNDRkMTc0YmFkMWIwNmMzMjYxYmNjNzBlYzU5OWVkZmEwNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZl YXR1cmVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVF bmFibGVkRmVhdHVyZXMuY3BwCkBAIC0xODEsNiArMTgxLDExIEBAIGJvb2wgUnVudGltZUVuYWJs ZWRGZWF0dXJlczo6aXNNZWRpYVNvdXJjZUVuYWJsZWQgPSBmYWxzZTsKICNlbmRpZgogCiAjaWYg RU5BQkxFKFNIQURPV19ET00pCit2b2lkIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldE11bHRp cGxlU2hhZG93U3VidHJlZXNFbmFibGVkKGJvb2wgaXNFbmFibGVkKQoreworICAgIGlzTXVsdGlw bGVTaGFkb3dTdWJ0cmVlc0VuYWJsZWQgPSBpc0VuYWJsZWQ7Cit9CisKIGJvb2wgUnVudGltZUVu YWJsZWRGZWF0dXJlczo6aXNTaGFkb3dET01FbmFibGVkID0gZmFsc2U7CiBib29sIFJ1bnRpbWVF bmFibGVkRmVhdHVyZXM6OmlzTXVsdGlwbGVTaGFkb3dTdWJ0cmVlc0VuYWJsZWQgPSBmYWxzZTsK ICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1 bnRpbWVFbmFibGVkRmVhdHVyZXMuaAppbmRleCAzNjA2NWM4MmFkOGQwOGMyMDBiZWJlODlhMjBi NThmZjE4NjE2ZDAwLi4zMTlhNjNlNWFjMjUwMWUwYTZkMTNiZGUxNGI4NzdkZWNiZTkwMzlmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVk RmVhdHVyZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVF bmFibGVkRmVhdHVyZXMuaApAQCAtMTk2LDcgKzE5Niw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMg dm9pZCBzZXRTaGFkb3dET01FbmFibGVkKGJvb2wgaXNFbmFibGVkKSB7IGlzU2hhZG93RE9NRW5h YmxlZCA9IGlzRW5hYmxlZDsgfQogCiAgICAgc3RhdGljIGJvb2wgbXVsdGlwbGVTaGFkb3dTdWJ0 cmVlc0VuYWJsZWQoKSB7IHJldHVybiBpc011bHRpcGxlU2hhZG93U3VidHJlZXNFbmFibGVkOyB9 Ci0gICAgc3RhdGljIHZvaWQgc2V0TXVsdGlwbGVTaGFkb3dTdWJ0cmVlc0VuYWJsZWQoYm9vbCBp c0VuYWJsZWQpIHsgaXNNdWx0aXBsZVNoYWRvd1N1YnRyZWVzRW5hYmxlZCA9IGlzRW5hYmxlZDsg fQorICAgIHN0YXRpYyB2b2lkIHNldE11bHRpcGxlU2hhZG93U3VidHJlZXNFbmFibGVkKGJvb2wg aXNFbmFibGVkKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKFNUWUxFX1NDT1BFRCkK