79714 2012-02-27 16:31:53 -0800 [chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium 2012-03-01 14:25:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79428 1 jamesr jamesr aelias cc-bugs enne shawnsingh webkit.review.bot oldest_to_newest 566093 0 jamesr 2012-02-27 16:31:53 -0800 [chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium 566114 1 129129 jamesr 2012-02-27 16:44:25 -0800 Created attachment 129129 Patch 566398 2 aelias 2012-02-27 22:48:55 -0800 LGTM, seems reasonable. 568777 3 129129 enne 2012-03-01 11:08:54 -0800 Comment on attachment 129129 Patch Yay for pushing WebCore-only corner cases out of the compositor. 568848 4 129129 jamesr 2012-03-01 13:19:03 -0800 Comment on attachment 129129 Patch Thanks for the review! 568913 5 129129 webkit.review.bot 2012-03-01 14:25:08 -0800 Comment on attachment 129129 Patch Clearing flags on attachment: 129129 Committed r109424: <http://trac.webkit.org/changeset/109424> 568914 6 webkit.review.bot 2012-03-01 14:25:13 -0800 All reviewed patches have been landed. Closing bug. 129129 2012-02-27 16:44:25 -0800 2012-03-01 14:25:08 -0800 Patch bug-79714-20120227164424.patch text/plain 5918 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI0OTAzNmVkNDllZmQy OGE3ZjA1ZTA1MzY1NWEyYTZlYTEzYjg3MS4uNjgyMjdjNTBmZThmOTY5OTg0NWZjZTQwYmEyOWRl MmFlYTIwMGExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAyLTI3ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBN b3ZlIHBhZ2VTY2FsZURpcnR5IGxvZ2ljIGZyb20gTGF5ZXJDaHJvbWl1bSB0byBHcmFwaGljc0xh eWVyQ2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc5NzE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiB0aGUgcGFnZSBzY2FsZSBjaGFuZ2VzIG9uIGEgY29tcG9zaXRlZCBsYXllciB3ZSBu ZWVkIHRvIGludmFsaWRhdGUgYWxsIG9mIHRoZSBjb250ZW50cyBvbiB0aGUgbGF5ZXIgaW4KKyAg ICAgICAgb3JkZXIgdG8gcmVwYWludCB0aGVtIGF0IHRoZSBuZXcgc2NhbGUuIFRoZSBzZXF1ZW5j ZSBvZiBjYWxscyB3ZSBnZXQgbWFrZSB0aGlzIGEgYml0IHRyaWNreSwgc2luY2Ugd2UgZmlyc3QK KyAgICAgICAgcmVjZWl2ZSBhIHBhZ2Ugc2NhbGUgY2hhbmdlZCBub3RpZmljYXRpb24gYW5kIHRo ZW4gcmVjZWl2ZSB0aGUgbmV3IGxheWVyIGJvdW5kcy4gVGhlIHNvbHV0aW9uIGlzIHRvIGRlZmVy IHRoZQorICAgICAgICBpbnZhbGlkYXRpb24gdW50aWwgd2UgaGF2ZSB0aGUgbmV3IGxheWVyIGJv dW5kcywgd2hpY2ggbGFuZGVkIGluIHI5OTc3NC4KKworICAgICAgICBUaGlzIG1vdmVzIHRoYXQg bG9naWMgZnJvbSBMYXllckNocm9taXVtIGludG8gR3JhcGhpY3NMYXllckNocm9taXVtIHNpbmNl IElNTyB0aGlzIGlzIHByZXR0eSBwYXJ0aWN1bGFyIHRvIHRoZQorICAgICAgICB3YXkgV2ViQ29y ZSBpcyBwYXNzaW5nIHVzIGludmFsaWRhdGlvbnMgYW5kIG5vdCBzb21ldGhpbmcgZnVuZGFtZW50 YWwgdG8gdGhlIGNvbXBvc2l0b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhp Y3NMYXllckNocm9taXVtOjpHcmFwaGljc0xheWVyQ2hyb21pdW0pOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRTaXplKToKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzTGF5ZXJDaHJvbWl1bTo6ZGV2aWNlT3JQYWdlU2NhbGVGYWN0b3JDaGFuZ2VkKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0u aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyQ2hyb21pdW06OkxheWVyQ2hyb21pdW0pOgorICAg ICAgICAoV2ViQ29yZTo6TGF5ZXJDaHJvbWl1bTo6c2V0Qm91bmRzKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmg6CisgICAgICAgIChMYXllckNo cm9taXVtKToKKwogMjAxMi0wMi0yNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ3RybCtLIHNob3VsZCBub3Qgem9vbSBpbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3Jh cGhpY3NMYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggMmRiZDBhMzA0OWU3YWQy ZTBlMTM3NDYyZTk0OTdiMmZkODVkMDNhYS4uZjk2Nzc4MjdhZjQ1OTkzYzJiYmQyOWIwMzJjYWRm YTljNDA4YThiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCkBAIC03 OCw2ICs3OCw3IEBAIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6R3JhcGhpY3NMYXllckNocm9taXVt KEdyYXBoaWNzTGF5ZXJDbGllbnQqIGNsaWVudCkKICAgICAsIG1fY29udGVudHNMYXllclB1cnBv c2UoTm9Db250ZW50c0xheWVyKQogICAgICwgbV9jb250ZW50c0xheWVySGFzQmFja2dyb3VuZENv bG9yKGZhbHNlKQogICAgICwgbV9pblNldENoaWxkcmVuKGZhbHNlKQorICAgICwgbV9wYWdlU2Nh bGVDaGFuZ2VkKGZhbHNlKQogewogICAgIG1fbGF5ZXIgPSBDb250ZW50TGF5ZXJDaHJvbWl1bTo6 Y3JlYXRlKHRoaXMpOwogCkBAIC0yMDEsNiArMjAyLDEwIEBAIHZvaWQgR3JhcGhpY3NMYXllckNo cm9taXVtOjpzZXRTaXplKGNvbnN0IEZsb2F0U2l6ZSYgc2l6ZSkKIAogICAgIEdyYXBoaWNzTGF5 ZXI6OnNldFNpemUoY2xhbXBlZFNpemUpOwogICAgIHVwZGF0ZUxheWVyU2l6ZSgpOworCisgICAg aWYgKG1fcGFnZVNjYWxlQ2hhbmdlZCAmJiBtX2xheWVyKQorICAgICAgICBtX2xheWVyLT5zZXRO ZWVkc0Rpc3BsYXkoKTsKKyAgICBtX3BhZ2VTY2FsZUNoYW5nZWQgPSBmYWxzZTsKIH0KIAogdm9p ZCBHcmFwaGljc0xheWVyQ2hyb21pdW06OnNldFRyYW5zZm9ybShjb25zdCBUcmFuc2Zvcm1hdGlv bk1hdHJpeCYgdHJhbnNmb3JtKQpAQCAtNzIyLDggKzcyNywxMCBAQCBmbG9hdCBHcmFwaGljc0xh eWVyQ2hyb21pdW06OmNvbnRlbnRzU2NhbGUoKSBjb25zdAogdm9pZCBHcmFwaGljc0xheWVyQ2hy b21pdW06OmRldmljZU9yUGFnZVNjYWxlRmFjdG9yQ2hhbmdlZCgpCiB7CiAgICAgdXBkYXRlQ29u dGVudHNTY2FsZSgpOwotICAgIGlmIChtX2xheWVyKQotICAgICAgICBtX2xheWVyLT5wYWdlU2Nh bGVDaGFuZ2VkKCk7CisgICAgLy8gSW52YWxpZGF0aW9ucyBhcmUgY2xhbXBlZCB0byB0aGUgbGF5 ZXIncyBib3VuZHMgYnV0IHdlIHJlY2VpdmUgdGhlIHNjYWxlIGNoYW5nZWQgbm90aWZpY2F0aW9u IGJlZm9yZSByZWNlaXZpbmcKKyAgICAvLyB0aGUgbmV3IGxheWVyIGJvdW5kcy4gV2hlbiB0aGUg c2NhbGUgY2hhbmdlcywgd2UgcmVhbGx5IHdhbnQgdG8gaW52YWxpZGF0ZSB0aGUgcG9zdC1zY2Fs ZSBsYXllciBib3VuZHMsIHNvIHdlCisgICAgLy8gcmVtZW1iZXIgdGhhdCB0aGUgc2NhbGUgaGFz IGNoYW5nZWQgYW5kIHRoZW4gaW52YWxpZGF0ZSB0aGUgZnVsbCBsYXllciBib3VuZHMgd2hlbiB3 ZSByZWNlaXZlIHRoZSBuZXcgc2l6ZS4KKyAgICBtX3BhZ2VTY2FsZUNoYW5nZWQgPSB0cnVlOwog fQogCiB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6cGFpbnRDb250ZW50cyhHcmFwaGljc0Nv bnRleHQmIGNvbnRleHQsIGNvbnN0IEludFJlY3QmIGNsaXApCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0u aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5 ZXJDaHJvbWl1bS5oCmluZGV4IGRmMWJmMjZhYTdmNzE3YTc3NmY3ZWM5Y2RmNjc0OTlkMzUwMjBl YzIuLmFkY2U4Yjk1NDQ4MmY1M2U1NDllZWRkZDliZjZiMDlmZTQyM2U2NzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJD aHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5oCkBAIC0xNjUsNiArMTY1LDcgQEAgcHJpdmF0ZToKICAg ICBDb250ZW50c0xheWVyUHVycG9zZSBtX2NvbnRlbnRzTGF5ZXJQdXJwb3NlOwogICAgIGJvb2wg bV9jb250ZW50c0xheWVySGFzQmFja2dyb3VuZENvbG9yIDogMTsKICAgICBib29sIG1faW5TZXRD aGlsZHJlbjsKKyAgICBib29sIG1fcGFnZVNjYWxlQ2hhbmdlZDsKIAogICAgIEFuaW1hdGlvbklk TWFwIG1fYW5pbWF0aW9uSWRNYXA7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcAppbmRleCA5Mjli YmM3ZTE5MzZlZDU1YzU1MThiMTk0Y2UyZDIzZTE2ZjI0MzgwLi41OGZlYzg5ZmI5NTAwOGM5YTU0 N2UyNTQ5ZDBlNTM5YTY1YzgzYjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcApAQCAtODQsNyAr ODQsNiBAQCBMYXllckNocm9taXVtOjpMYXllckNocm9taXVtKCkKICAgICAsIG1fZHJhd09wYWNp dHkoMCkKICAgICAsIG1fdGFyZ2V0UmVuZGVyU3VyZmFjZSgwKQogICAgICwgbV9jb250ZW50c1Nj YWxlKDEuMCkKLSAgICAsIG1fcGFnZVNjYWxlRGlydHkoZmFsc2UpCiAgICAgLCBtX2xheWVyQW5p bWF0aW9uRGVsZWdhdGUoMCkKIHsKIH0KQEAgLTI3OCwxMiArMjc3LDEwIEBAIHZvaWQgTGF5ZXJD aHJvbWl1bTo6c2V0Qm91bmRzKGNvbnN0IEludFNpemUmIHNpemUpCiAKICAgICBtX2JvdW5kcyA9 IHNpemU7CiAKLSAgICBpZiAoZmlyc3RSZXNpemUgfHwgbV9wYWdlU2NhbGVEaXJ0eSkKKyAgICBp ZiAoZmlyc3RSZXNpemUpCiAgICAgICAgIHNldE5lZWRzRGlzcGxheSgpOwogICAgIGVsc2UKICAg ICAgICAgc2V0TmVlZHNDb21taXQoKTsKLQotICAgIG1fcGFnZVNjYWxlRGlydHkgPSBmYWxzZTsK IH0KIAogY29uc3QgTGF5ZXJDaHJvbWl1bSogTGF5ZXJDaHJvbWl1bTo6cm9vdExheWVyKCkgY29u c3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0xheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0xheWVyQ2hyb21pdW0uaAppbmRleCBlMzEyM2JmNzk3NjI5NTAyYmFjOTdkYWJmYTI1YzRk YWQ4OTJkMmZiLi5mYTFjMGYyZjQzZDYxNDVlZWU4MTM2ZjdmNjQ5MDM2NTk1NGQwOWY5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNo cm9taXVtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v TGF5ZXJDaHJvbWl1bS5oCkBAIC0xNjksNyArMTY5LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwg dm9pZCBzZXRJc01hc2soYm9vbCkgeyB9CiAgICAgdmlydHVhbCB2b2lkIHVucmVzZXJ2ZUNvbnRl bnRzVGV4dHVyZSgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBiaW5kQ29udGVudHNUZXh0dXJlKCkg eyB9Ci0gICAgdmlydHVhbCB2b2lkIHBhZ2VTY2FsZUNoYW5nZWQoKSB7IG1fcGFnZVNjYWxlRGly dHkgPSB0cnVlOyB9CiAgICAgdmlydHVhbCB2b2lkIHByb3RlY3RWaXNpYmxlVGlsZVRleHR1cmVz KCkgeyB9CiAgICAgdmlydHVhbCBib29sIG5lZWRzQ29udGVudHNTY2FsZSgpIGNvbnN0IHsgcmV0 dXJuIGZhbHNlOyB9CiAKQEAgLTMyNiw4ICszMjUsNiBAQCBwcml2YXRlOgogCiAgICAgU3RyaW5n IG1fbmFtZTsKIAotICAgIGJvb2wgbV9wYWdlU2NhbGVEaXJ0eTsKLQogICAgIENDTGF5ZXJBbmlt YXRpb25EZWxlZ2F0ZSogbV9sYXllckFuaW1hdGlvbkRlbGVnYXRlOwogfTsKIAo=