79623 2012-02-26 21:54:18 -0800 Add test case for ::selection:window-inactive 2012-02-29 01:09:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 79890 1 dbates dbates bdakin hyatt webkit.review.bot oldest_to_newest 565313 0 dbates 2012-02-26 21:54:18 -0800 We should add a test case to ensure that we don't regress inactive selection. Inactive selection was implemented in <http://trac.webkit.org/changeset/41094> (rdar://problem/6077775). 565317 1 128950 dbates 2012-02-26 22:07:17 -0800 Created attachment 128950 Layout test 565322 2 dbates 2012-02-26 22:08:51 -0800 Additional remarks: We blend the background-color property, call this b, for ::selection with white unless b specifies an alpha value < 1 (255) by <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderObject.cpp?rev=108719#L1612>, <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/Color.cpp?rev=94452#L328>, and <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/Color.h?rev=102740#L104>. 566157 3 128950 webkit.review.bot 2012-02-27 17:12:55 -0800 Comment on attachment 128950 Layout test Clearing flags on attachment: 128950 Committed r109045: <http://trac.webkit.org/changeset/109045> 566158 4 webkit.review.bot 2012-02-27 17:13:00 -0800 All reviewed patches have been landed. Closing bug. 128950 2012-02-26 22:07:17 -0800 2012-02-27 17:12:55 -0800 Layout test Bug79623.patch text/plain 2377 dbates SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwODk1NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTI2ICBEYW5pZWwgQmF0ZXMgIDxk YmF0ZXNAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgdGVzdCBjYXNlIGZvciA6OnNlbGVjdGlv bjp3aW5kb3ctaW5hY3RpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc5NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIHJlZnRlc3QgdG8gZW5zdXJlIHRoYXQgd2UgZG9uJ3QgcmVncmVzcyBpbmFj dGl2ZSBzZWxlY3Rpb24gY29sb3IuCisKKyAgICAgICAgRm9yIGNvbXBsZXRlbmVzcywgc3VwcG9y dCBmb3IgaW5hY3RpdmUgc2VsZWN0aW9uIGNvbG9yIHdhcyBhZGRlZCBpbgorICAgICAgICA8aHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNDEwOTQ+ICg8cmRhcjovL3Byb2JsZW0vNjA3 Nzc3NT4pLgorCisgICAgICAgICogZmFzdC9zZWxlY3RvcnMvc2VsZWN0aW9uLXdpbmRvdy1pbmFj dGl2ZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3NlbGVjdG9ycy9zZWxl Y3Rpb24td2luZG93LWluYWN0aXZlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTAyLTI2ICBZb3NoaWZ1 bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9udW1iZXIvaW5wdXQtbnVtYmVyLWV2ZW50cy5odG1sIGlzIGZhaWxpbmcgc2luY2Ug cjEwODIyOApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc2VsZWN0aW9uLXdpbmRv dy1pbmFjdGl2ZS1leHBlY3RlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv c2VsZWN0b3JzL3NlbGVjdGlvbi13aW5kb3ctaW5hY3RpdmUtZXhwZWN0ZWQuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qvc2VsZWN0b3JzL3NlbGVjdGlvbi13aW5kb3ctaW5h Y3RpdmUtZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw4IEBACis8IURPQ1RZ UEUgaHRtbD4KKzxzdHlsZT4KK3NwYW4geworICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoNjMs IDEyOCwgMzMsIDAuOTUpOworICAgIGNvbG9yOiBibGFjazsKK30KKzwvc3R5bGU+Cis8c3Bhbj5B bnkgdGV4dHVhbCBzZWxlY3Rpb24gaW4gdGhpcyBzZW50ZW5jZSBzaG91bGQgaGF2ZSBhIGdyZWVu IGJhY2tncm91bmQgd2hlbiB0aGUgd2luZG93IGlzIGluYWN0aXZlLjwvc3Bhbj4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3Qvc2VsZWN0b3JzL3NlbGVjdGlvbi13aW5kb3ctaW5hY3RpdmUuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NlbGVjdG9ycy9zZWxlY3Rpb24td2luZG93 LWluYWN0aXZlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NlbGVjdG9y cy9zZWxlY3Rpb24td2luZG93LWluYWN0aXZlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MTggQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorOjpzZWxlY3Rpb24geworICAgIGJhY2tn cm91bmQtY29sb3I6IGJsdWU7CisgICAgY29sb3I6IHllbGxvdzsKK30KKzo6c2VsZWN0aW9uOndp bmRvdy1pbmFjdGl2ZSB7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiYSg2MywgMTI4LCAzMywg MC45NSk7IC8qIGdyZWVuOyBhbHBoYSA8IDEgc28gdGhhdCB3ZSBkb24ndCBibGVuZCB0aGUgYmFj a2dyb3VuZCBjb2xvciB3aXRoIHdoaXRlLiAqLyAKKyAgICBjb2xvcjogYmxhY2s7Cit9Cis8L3N0 eWxlPgorPHNwYW4+QW55IHRleHR1YWwgc2VsZWN0aW9uIGluIHRoaXMgc2VudGVuY2Ugc2hvdWxk IGhhdmUgYSBncmVlbiBiYWNrZ3JvdW5kIHdoZW4gdGhlIHdpbmRvdyBpcyBpbmFjdGl2ZS48L3Nw YW4+Cis8c2NyaXB0PgordmFyIHNwYW4gPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJzcGFuIik7 Cit3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFuZEV4dGVudChzcGFuLCAwLCBzcGFuLCAx KTsKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIuc2V0V2luZG93SXNLZXkoZmFsc2UpOworPC9zY3JpcHQ+Cg==