79622 2012-02-26 21:39:06 -0800 [Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification 2012-02-27 20:17:52 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin abarth haraken ojan tkent webkit.review.bot oldest_to_newest 565310 0 yosin 2012-02-26 21:39:06 -0800 For ease of maintainability, attributes and methods declaration order should be as same as specification. See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html 566193 1 129148 yosin 2012-02-27 17:36:57 -0800 Created attachment 129148 Patch 1 566205 2 129148 abarth 2012-02-27 17:52:15 -0800 Comment on attachment 129148 Patch 1 Ok. We'll probably screw up the ordering again in the future though. 566208 3 yosin 2012-02-27 17:56:55 -0800 (In reply to comment #2) > (From update of attachment 129148 [details]) > Ok. We'll probably screw up the ordering again in the future though. Thanks for quick response. I wrote simple Perl script for re-ordering to reduce manual handling. Obsolete comments and Objective-C #ifdef prevent me to make my script fully automatically. 566318 4 129148 webkit.review.bot 2012-02-27 20:17:46 -0800 Comment on attachment 129148 Patch 1 Clearing flags on attachment: 129148 Committed r109067: <http://trac.webkit.org/changeset/109067> 566319 5 webkit.review.bot 2012-02-27 20:17:52 -0800 All reviewed patches have been landed. Closing bug. 129148 2012-02-27 17:36:57 -0800 2012-02-27 20:17:46 -0800 Patch 1 bug-79622-20120228103656.patch text/plain 7099 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y4MGQxZWVkNmRlMjA3 ZDM4NjBkZmYzMmM0YTljZWVjYzViNmQ2Yi4uYzk3OTM2MDc3ZGNhYWFjZDZjZGI0MTMxYmRhOWEw ZDM4OTc5ZjNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTI3ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNYWtl IG9yZGVyIG9mIGF0dHJpYnV0ZS9tZXRob2QgaW4gSFRNTElucHV0RWxlbWVudC5pZGwgYXMgc2Ft ZSBhcyBzcGVjaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03OTYyMgorCisgICAgICAgIEZvciBlYXNlIG9mIG1haW50YWluYWJpbGl0eSwg dGhpcyBwYXRjaCByZW9yZGVycyBhdHRyaWJ1dGVzIGFuZCBtZXRob2RzIGRlY2xhcmF0aW9uCisg ICAgICAgIG1hdGNoaW5nIHdpdGggc3BlY2lmaWNhdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9yIGNo YW5nZS4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5pZGw6IFJlb3JkZXIgYW5k IHJlbW92ZSBvYnNvbGV0ZSBjb21tZW50cy4KKwogMjAxMi0wMi0yNyAgSnVsaWVuIENoYWZmcmFp eCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBFeHRyYWN0IHRoZSBsb2dpYyBm b3IgY29tcHV0aW5nIHRoZSBkaXJ0eSByb3dzIC8gY29sdW1ucyBvdXQgb2YgUmVuZGVyVGFibGVT ZWN0aW9uOjpwYWludE9iamVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M SW5wdXRFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5p ZGwKaW5kZXggODRiZWI4YWM1MTJmZGM0ZGI4OGQ4ZGY4MmY5YWQzZmViNjc2MjhkOS4uYWQxYzMx NTRmZGRiYzY5Mjc1ZjNhY2UxYWZhZDFjMDg0ZGVlNDBhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuaWRsCkBAIC0yMSwzNiArMjEsMzMgQEAKIG1vZHVsZSBodG1sIHsK IAogICAgIGludGVyZmFjZSBIVE1MSW5wdXRFbGVtZW50IDogSFRNTEVsZW1lbnQgewotICAgICAg ICBhdHRyaWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBkZWZhdWx0VmFs dWU7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGFjY2VwdDsKKyAgICAg ICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYWx0OworICAgICAgICBhdHRyaWJ1dGUg W1JlZmxlY3RdIERPTVN0cmluZyBhdXRvY29tcGxldGU7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVm bGVjdF0gYm9vbGVhbiBhdXRvZm9jdXM7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdD1jaGVj a2VkXSBib29sZWFuIGRlZmF1bHRDaGVja2VkOworICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiBj aGVja2VkOwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBkaXJOYW1lOwor ICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gZGlzYWJsZWQ7CiAgICAgICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBIVE1MRm9ybUVsZW1lbnQgZm9ybTsKKyAgICAgICAgcmVhZG9ubHkg YXR0cmlidXRlIEZpbGVMaXN0IGZpbGVzOwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3QsIFVS TF0gRE9NU3RyaW5nIGZvcm1BY3Rpb247CiAgICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9 TnVsbFN0cmluZ10gRE9NU3RyaW5nIGZvcm1FbmN0eXBlOwogICAgICAgICBhdHRyaWJ1dGUgW1Ry ZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBmb3JtTWV0aG9kOwogICAgICAgICBhdHRy aWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gZm9ybU5vVmFsaWRhdGU7CiAgICAgICAgIGF0dHJpYnV0 ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGZvcm1UYXJnZXQ7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBWYWxpZGl0eVN0YXRlIHZhbGlkaXR5OwotICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3Rd IERPTVN0cmluZyBhY2NlcHQ7Ci0gICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5n IGFsaWduOwotICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBhbHQ7Ci0gICAg ICAgIGF0dHJpYnV0ZSBib29sZWFuIGNoZWNrZWQ7Ci0gICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVj dF0gYm9vbGVhbiBkaXNhYmxlZDsKLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFu IGF1dG9mb2N1czsKLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYXV0b2Nv bXBsZXRlOworICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiBpbmRldGVybWluYXRlOwogICAgICAg ICByZWFkb25seSBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPURBVEFMSVNUXSBIVE1MRWxlbWVudCBs aXN0OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBtYXg7CiAgICAgICAg IGF0dHJpYnV0ZSBsb25nIG1heExlbmd0aCBzZXR0ZXIgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAg ICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIG1pbjsKICAgICAgICAgYXR0cmli dXRlIFtSZWZsZWN0XSBib29sZWFuIG11bHRpcGxlOwotICAgICAgICBhdHRyaWJ1dGUgW0NvbmRp dGlvbmFsPURJUkVDVE9SWV9VUExPQUQsIFJlZmxlY3RdIGJvb2xlYW4gd2Via2l0ZGlyZWN0b3J5 OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBuYW1lOwogICAgICAgICBh dHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBwYXR0ZXJuOwogICAgICAgICBhdHRyaWJ1dGUg W1JlZmxlY3RdIERPTVN0cmluZyBwbGFjZWhvbGRlcjsKICAgICAgICAgYXR0cmlidXRlIFtSZWZs ZWN0XSBib29sZWFuIHJlYWRPbmx5OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xl YW4gcmVxdWlyZWQ7CiAjaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VB R0VfT0JKRUNUSVZFX0MKLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYWNj ZXNzS2V5OwogICAgICAgICBhdHRyaWJ1dGUgW09iakNJbXBsZW1lbnRlZEFzVW5zaWduZWRMb25n XSBET01TdHJpbmcgc2l6ZTsgLy8gRE9NIGxldmVsIDIgY2hhbmdlZCB0aGlzIHRvIGEgbG9uZywg YnV0IE9iakMgQVBJIGlzIGEgc3RyaW5nCiAjZWxzZQogICAgICAgICBhdHRyaWJ1dGUgdW5zaWdu ZWQgbG9uZyBzaXplOyAvLyBDaGFuZ2VkIHN0cmluZyAtPiBsb25nIC0+IHVuc2lnbmVkIGxvbmcK QEAgLTU4LDM5ICs1NSwyOCBAQCBtb2R1bGUgaHRtbCB7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVm bGVjdCwgVVJMXSBET01TdHJpbmcgc3JjOwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERP TVN0cmluZyBzdGVwOwogICAgICAgICBhdHRyaWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmdd IERPTVN0cmluZyB0eXBlOyAvLyByZWFkb25seSBkcm9wcGVkIGFzIHBhcnQgb2YgRE9NIGxldmVs IDIKLSAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgdXNlTWFwOworICAgICAg ICBhdHRyaWJ1dGUgW1RyZWF0TnVsbEFzPU51bGxTdHJpbmddIERPTVN0cmluZyBkZWZhdWx0VmFs dWU7CiAgICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5n IHZhbHVlOwogI2lmICFkZWZpbmVkKExBTkdVQUdFX0NQUCkgfHwgIUxBTkdVQUdFX0NQUAogICAg ICAgICBhdHRyaWJ1dGUgRGF0ZSB2YWx1ZUFzRGF0ZSBzZXR0ZXIgcmFpc2VzKERPTUV4Y2VwdGlv bik7CiAjZW5kaWYKICAgICAgICAgYXR0cmlidXRlIGRvdWJsZSB2YWx1ZUFzTnVtYmVyIHNldHRl ciByYWlzZXMoRE9NRXhjZXB0aW9uKTsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDb25k aXRpb25hbD1EQVRBTElTVF0gSFRNTE9wdGlvbkVsZW1lbnQgc2VsZWN0ZWRPcHRpb247Ci0gICAg ICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiBpbmNyZW1lbnRhbDsKIAogICAgICAgICB2 b2lkIHN0ZXBVcChpbiBbT3B0aW9uYWxdIGxvbmcgbikgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAg ICAgICAgIHZvaWQgc3RlcERvd24oaW4gW09wdGlvbmFsXSBsb25nIG4pIHJhaXNlcyhET01FeGNl cHRpb24pOwogCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIHdpbGxWYWxpZGF0 ZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFZhbGlkaXR5U3RhdGUgdmFsaWRpdHk7CiAg ICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdmFsaWRhdGlvbk1lc3NhZ2U7CiAg ICAgICAgIGJvb2xlYW4gY2hlY2tWYWxpZGl0eSgpOwogICAgICAgICB2b2lkIHNldEN1c3RvbVZh bGlkaXR5KGluIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nLCBUcmVhdFVuZGVmaW5lZEFzPU51bGxT dHJpbmddIERPTVN0cmluZyBlcnJvcik7Ci0gICAgICAgIHZvaWQgc2VsZWN0KCk7Ci0KLSNpZiBk ZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQwotICAg ICAgICB2b2lkIGNsaWNrKCk7Ci0jZW5kaWYKLQotI2lmICFkZWZpbmVkKExBTkdVQUdFX0pBVkFT Q1JJUFQpIHx8ICFMQU5HVUFHRV9KQVZBU0NSSVBUCi0gICAgICAgIHZvaWQgc2V0VmFsdWVGb3JV c2VyKGluIFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgdmFsdWUpOwotI2VuZGlm CiAKLSAgICAgICAgLy8gV2luSUUgZXh0ZW5zaW9uOgotICAgICAgICBhdHRyaWJ1dGUgYm9vbGVh biBpbmRldGVybWluYXRlOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgTm9kZUxpc3QgbGFi ZWxzOwogCisgICAgICAgIHZvaWQgc2VsZWN0KCk7CiAgICAgICAgIGF0dHJpYnV0ZSBbQ3VzdG9t XSBsb25nIHNlbGVjdGlvblN0YXJ0OwogICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbV0gbG9uZyBz ZWxlY3Rpb25FbmQ7CiAgICAgICAgIGF0dHJpYnV0ZSBbQ3VzdG9tXSBET01TdHJpbmcgc2VsZWN0 aW9uRGlyZWN0aW9uOwotCiAjaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFO R1VBR0VfT0JKRUNUSVZFX0MKICAgICAgICAgW0N1c3RvbV0gdm9pZCBzZXRTZWxlY3Rpb25SYW5n ZShpbiBsb25nIHN0YXJ0LCBpbiBsb25nIGVuZCk7CiAjZWxzZQpAQCAtOTksMTggKzg1LDMzIEBA IG1vZHVsZSBodG1sIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp biBbT3B0aW9uYWxdIERPTVN0cmluZyBkaXJlY3Rpb24pOwogI2VuZGlmCiAKLSNpZiBkZWZpbmVk KExBTkdVQUdFX09CSkVDVElWRV9DKQorICAgICAgICAvLyBOb24tc3RhbmRhcmQgYXR0cmlidXRl cworICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBhbGlnbjsKKyAgICAgICAg YXR0cmlidXRlIFtDb25kaXRpb25hbD1ESVJFQ1RPUllfVVBMT0FELCBSZWZsZWN0XSBib29sZWFu IHdlYmtpdGRpcmVjdG9yeTsKKyAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcg dXNlTWFwOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPURBVEFMSVNU XSBIVE1MT3B0aW9uRWxlbWVudCBzZWxlY3RlZE9wdGlvbjsKKyAgICAgICAgYXR0cmlidXRlIFtS ZWZsZWN0XSBib29sZWFuIGluY3JlbWVudGFsOworICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlv bmFsPUlOUFVUX1NQRUVDSCwgUmVmbGVjdCwgVjhFbmFibGVkQXRSdW50aW1lXSBib29sZWFuIHdl YmtpdFNwZWVjaDsKKyAgICAgICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD1JTlBVVF9TUEVFQ0gs IFJlZmxlY3QsIFY4RW5hYmxlZEF0UnVudGltZV0gYm9vbGVhbiB3ZWJraXRHcmFtbWFyOworICAg ICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPUlOUFVUX1NQRUVDSCwgTm90RW51bWVyYWJsZV0g RXZlbnRMaXN0ZW5lciBvbndlYmtpdHNwZWVjaGNoYW5nZTsKKworI2lmIGRlZmluZWQoTEFOR1VB R0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DCisgICAgICAgIGF0dHJpYnV0 ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGFjY2Vzc0tleTsKKyNlbmRpZgorCisjaWYgZGVmaW5lZChM QU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKKyAgICAgICAgdm9p ZCBjbGljaygpOworI2VuZGlmCisKKyNpZiAhZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBUKSB8 fCAhTEFOR1VBR0VfSkFWQVNDUklQVAorICAgICAgICB2b2lkIHNldFZhbHVlRm9yVXNlcihpbiBb VHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIHZhbHVlKTsKKyNlbmRpZgorCisjaWYg ZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKICAg ICAgICAgLy8gT2JqZWN0aXZlLUMgZXh0ZW5zaW9uOgogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgRE9NU3RyaW5nIGFsdERpc3BsYXlTdHJpbmc7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSBVUkwgYWJzb2x1dGVJbWFnZVVSTDsKICNlbmRpZgogCi0gICAgICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBGaWxlTGlzdCBmaWxlczsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE5vZGVMaXN0 IGxhYmVsczsKLQotICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPUlOUFVUX1NQRUVDSCwg UmVmbGVjdCwgVjhFbmFibGVkQXRSdW50aW1lXSBib29sZWFuIHdlYmtpdFNwZWVjaDsKLSAgICAg ICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD1JTlBVVF9TUEVFQ0gsIFJlZmxlY3QsIFY4RW5hYmxl ZEF0UnVudGltZV0gYm9vbGVhbiB3ZWJraXRHcmFtbWFyOwotICAgICAgICBhdHRyaWJ1dGUgW0Nv bmRpdGlvbmFsPUlOUFVUX1NQRUVDSCwgTm90RW51bWVyYWJsZV0gRXZlbnRMaXN0ZW5lciBvbndl YmtpdHNwZWVjaGNoYW5nZTsKICAgICB9OwotCiB9Cg==