79476 2012-02-24 04:57:27 -0800 Refactor EventHandler::handleGestureEvent 2012-02-24 07:03:08 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78801 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 564209 0 allan.jensen 2012-02-24 04:57:27 -0800 The handling of specific gesture events should be moved out of the switch statement in handleGestureEvent. Especially since they will become more complicated as the issues in them are resolved. Additionally the two gesture events tap and scrollupdate events could return better return-values even is the return value is not currently used. 564211 1 128711 allan.jensen 2012-02-24 05:00:07 -0800 Created attachment 128711 Patch 564302 2 webkit.review.bot 2012-02-24 07:00:58 -0800 The commit-queue encountered the following flaky tests while processing attachment 128711: storage/indexeddb/index-basics.html bug 79138 (authors: dgrogan@chromium.org and jsbell@chromium.org) The commit-queue is continuing to process your patch. 564303 3 128711 webkit.review.bot 2012-02-24 07:03:04 -0800 Comment on attachment 128711 Patch Clearing flags on attachment: 128711 Committed r108793: <http://trac.webkit.org/changeset/108793> 564304 4 webkit.review.bot 2012-02-24 07:03:08 -0800 All reviewed patches have been landed. Closing bug. 128711 2012-02-24 05:00:07 -0800 2012-02-24 07:03:03 -0800 Patch bug-79476-20120224140005.patch text/plain 6511 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg5NDNhNDY0ZWY3ODQ1 NTMyN2FjM2M0MGYyMWNkNzVhYTA0NGU4Ny4uYmVlNzA4N2U2OTUyOTgzMGM3NDU2OWQyNDMwMmQ5 MTFjOTY4OTU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTI0ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFJl ZmFjdG9yIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2ZW50LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk0NzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2ZW50KToKKyAgICAgICAgKFdlYkNv cmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVRhcCk6CisgICAgICAgIChXZWJDb3JlOjpF dmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVTY3JvbGxVcGRhdGUpOgorICAgICAgICAqIHBhZ2Uv RXZlbnRIYW5kbGVyLmg6CisKIDIwMTItMDItMjQgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1JlZ3Jlc3Npb25dIG5ldHdv cmsgd29ya2VyIHRlc3RzIGNyYXNoIG9uIHF0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCmluZGV4IDRmMGRkZWVlM2RiZGZlYmEyMmRjMzJiYzViZjZjMzQzMzFhMWRkODUuLjNjMTBi NzU0MGY2ZGQzZmYyMzJkMmMzMjM3NGExMjFkOGNiN2M4MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAKQEAgLTIzNDQsMjUgKzIzNDQsMTAgQEAgYm9vbCBFdmVudEhhbmRsZXI6 OmhhbmRsZUdlc3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2 ZW50KQogICAgIHN3aXRjaCAoZ2VzdHVyZUV2ZW50LnR5cGUoKSkgewogICAgIGNhc2UgUGxhdGZv cm1FdmVudDo6R2VzdHVyZVRhcERvd246CiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgUGxhdGZv cm1FdmVudDo6R2VzdHVyZVRhcDogewotICAgICAgICAvLyBGSVhNRTogUmVmYWN0b3IgdGhpcyBj b2RlIHRvIG5vdCBoaXQgdGVzdCBtdWx0aXBsZSB0aW1lcyBvbmNlIGhpdCB0ZXN0aW5nIGhhcyBi ZWVuIGNvcnJlY3RlZCBhcyBzdWdnZXN0ZWQgYWJvdmUuCi0gICAgICAgIFBsYXRmb3JtTW91c2VF dmVudCBmYWtlTW91c2VNb3ZlKGdlc3R1cmVFdmVudC5wb3NpdGlvbigpLCBnZXN0dXJlRXZlbnQu Z2xvYmFsUG9zaXRpb24oKSwgTm9CdXR0b24sIFBsYXRmb3JtRXZlbnQ6Ok1vdXNlTW92ZWQsIC8q IGNsaWNrQ291bnQgKi8gMSwgZ2VzdHVyZUV2ZW50LnNoaWZ0S2V5KCksIGdlc3R1cmVFdmVudC5j dHJsS2V5KCksIGdlc3R1cmVFdmVudC5hbHRLZXkoKSwgZ2VzdHVyZUV2ZW50Lm1ldGFLZXkoKSwg Z2VzdHVyZUV2ZW50LnRpbWVzdGFtcCgpKTsKLSAgICAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IGZh a2VNb3VzZURvd24oZ2VzdHVyZUV2ZW50LnBvc2l0aW9uKCksIGdlc3R1cmVFdmVudC5nbG9iYWxQ b3NpdGlvbigpLCBMZWZ0QnV0dG9uLCBQbGF0Zm9ybUV2ZW50OjpNb3VzZVByZXNzZWQsIC8qIGNs aWNrQ291bnQgKi8gMSwgZ2VzdHVyZUV2ZW50LnNoaWZ0S2V5KCksIGdlc3R1cmVFdmVudC5jdHJs S2V5KCksIGdlc3R1cmVFdmVudC5hbHRLZXkoKSwgZ2VzdHVyZUV2ZW50Lm1ldGFLZXkoKSwgZ2Vz dHVyZUV2ZW50LnRpbWVzdGFtcCgpKTsKLSAgICAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IGZha2VN b3VzZVVwKGdlc3R1cmVFdmVudC5wb3NpdGlvbigpLCBnZXN0dXJlRXZlbnQuZ2xvYmFsUG9zaXRp b24oKSwgTGVmdEJ1dHRvbiwgUGxhdGZvcm1FdmVudDo6TW91c2VSZWxlYXNlZCwgLyogY2xpY2tD b3VudCAqLyAxLCBnZXN0dXJlRXZlbnQuc2hpZnRLZXkoKSwgZ2VzdHVyZUV2ZW50LmN0cmxLZXko KSwgZ2VzdHVyZUV2ZW50LmFsdEtleSgpLCBnZXN0dXJlRXZlbnQubWV0YUtleSgpLCBnZXN0dXJl RXZlbnQudGltZXN0YW1wKCkpOwotICAgICAgICBtb3VzZU1vdmVkKGZha2VNb3VzZU1vdmUpOwot ICAgICAgICBoYW5kbGVNb3VzZVByZXNzRXZlbnQoZmFrZU1vdXNlRG93bik7Ci0gICAgICAgIGhh bmRsZU1vdXNlUmVsZWFzZUV2ZW50KGZha2VNb3VzZVVwKTsKLSAgICAgICAgcmV0dXJuIHRydWU7 Ci0gICAgfQotICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVNjcm9sbFVwZGF0ZTogewot ICAgICAgICBjb25zdCBmbG9hdCB0aWNrRGl2aXNvciA9IChmbG9hdClXaGVlbEV2ZW50Ojp0aWNr TXVsdGlwbGllcjsKLSAgICAgICAgLy8gRklYTUU6IFJlcGxhY2UgdGhpcyBpbnRlcmltIGltcGxl bWVudGF0aW9uIG9uY2UgdGhlIGFib3ZlIGZpeG1lIGhhcyBiZWVuIGFkZHJlc3NlZC4KLSAgICAg ICAgSW50UG9pbnQgcG9pbnQoZ2VzdHVyZUV2ZW50LnBvc2l0aW9uKCkueCgpLCBnZXN0dXJlRXZl bnQucG9zaXRpb24oKS55KCkpOwotICAgICAgICBJbnRQb2ludCBnbG9iYWxQb2ludChnZXN0dXJl RXZlbnQuZ2xvYmFsUG9zaXRpb24oKS54KCksIGdlc3R1cmVFdmVudC5nbG9iYWxQb3NpdGlvbigp LnkoKSk7Ci0gICAgICAgIFBsYXRmb3JtV2hlZWxFdmVudCBzeW50aGV0aWNXaGVlbEV2ZW50KHBv aW50LCBnbG9iYWxQb2ludCwgZ2VzdHVyZUV2ZW50LmRlbHRhWCgpLCBnZXN0dXJlRXZlbnQuZGVs dGFZKCksIGdlc3R1cmVFdmVudC5kZWx0YVgoKSAvIHRpY2tEaXZpc29yLCBnZXN0dXJlRXZlbnQu ZGVsdGFZKCkgLyB0aWNrRGl2aXNvciwgU2Nyb2xsQnlQaXhlbFdoZWVsRXZlbnQsIGdlc3R1cmVF dmVudC5zaGlmdEtleSgpLCBnZXN0dXJlRXZlbnQuY3RybEtleSgpLCBnZXN0dXJlRXZlbnQuYWx0 S2V5KCksIGdlc3R1cmVFdmVudC5tZXRhS2V5KCkpOwotICAgICAgICBoYW5kbGVXaGVlbEV2ZW50 KHN5bnRoZXRpY1doZWVsRXZlbnQpOwotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9CisgICAg Y2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwOgorICAgICAgICByZXR1cm4gaGFuZGxlR2Vz dHVyZVRhcChnZXN0dXJlRXZlbnQpOworICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVNj cm9sbFVwZGF0ZToKKyAgICAgICAgcmV0dXJuIGhhbmRsZUdlc3R1cmVTY3JvbGxVcGRhdGUoZ2Vz dHVyZUV2ZW50KTsKICAgICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVEb3VibGVUYXA6CiAg ICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlU2Nyb2xsQmVnaW46CiAgICAgY2FzZSBQbGF0 Zm9ybUV2ZW50OjpHZXN0dXJlU2Nyb2xsRW5kOgpAQCAtMjM3Miw2ICsyMzU3LDMyIEBAIGJvb2wg RXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZl bnQmIGdlc3R1cmVFdmVudCkKICAgICB9CiAgICAgcmV0dXJuIHRydWU7CiB9CisKK2Jvb2wgRXZl bnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlVGFwKGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50JiBn ZXN0dXJlRXZlbnQpCit7CisgICAgLy8gRklYTUU6IFJlZmFjdG9yIHRoaXMgY29kZSB0byBub3Qg aGl0IHRlc3QgbXVsdGlwbGUgdGltZXMgb25jZSBoaXQgdGVzdGluZworICAgIC8vIGhhcyBiZWVu IGNvcnJlY3RlZCBhcyBzdWdnZXN0ZWQgYWJvdmUgaW4gaGFuZGxlR2VzdHVyZUV2ZW50KCkuCisg ICAgYm9vbCBkZWZhdWx0UHJldmVudGVkID0gZmFsc2U7CisgICAgUGxhdGZvcm1Nb3VzZUV2ZW50 IGZha2VNb3VzZU1vdmUoZ2VzdHVyZUV2ZW50LnBvc2l0aW9uKCksIGdlc3R1cmVFdmVudC5nbG9i YWxQb3NpdGlvbigpLCBOb0J1dHRvbiwgUGxhdGZvcm1FdmVudDo6TW91c2VNb3ZlZCwgLyogY2xp Y2tDb3VudCAqLyAxLCBnZXN0dXJlRXZlbnQuc2hpZnRLZXkoKSwgZ2VzdHVyZUV2ZW50LmN0cmxL ZXkoKSwgZ2VzdHVyZUV2ZW50LmFsdEtleSgpLCBnZXN0dXJlRXZlbnQubWV0YUtleSgpLCBnZXN0 dXJlRXZlbnQudGltZXN0YW1wKCkpOworICAgIFBsYXRmb3JtTW91c2VFdmVudCBmYWtlTW91c2VE b3duKGdlc3R1cmVFdmVudC5wb3NpdGlvbigpLCBnZXN0dXJlRXZlbnQuZ2xvYmFsUG9zaXRpb24o KSwgTGVmdEJ1dHRvbiwgUGxhdGZvcm1FdmVudDo6TW91c2VQcmVzc2VkLCAvKiBjbGlja0NvdW50 ICovIDEsIGdlc3R1cmVFdmVudC5zaGlmdEtleSgpLCBnZXN0dXJlRXZlbnQuY3RybEtleSgpLCBn ZXN0dXJlRXZlbnQuYWx0S2V5KCksIGdlc3R1cmVFdmVudC5tZXRhS2V5KCksIGdlc3R1cmVFdmVu dC50aW1lc3RhbXAoKSk7CisgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IGZha2VNb3VzZVVwKGdlc3R1 cmVFdmVudC5wb3NpdGlvbigpLCBnZXN0dXJlRXZlbnQuZ2xvYmFsUG9zaXRpb24oKSwgTGVmdEJ1 dHRvbiwgUGxhdGZvcm1FdmVudDo6TW91c2VSZWxlYXNlZCwgLyogY2xpY2tDb3VudCAqLyAxLCBn ZXN0dXJlRXZlbnQuc2hpZnRLZXkoKSwgZ2VzdHVyZUV2ZW50LmN0cmxLZXkoKSwgZ2VzdHVyZUV2 ZW50LmFsdEtleSgpLCBnZXN0dXJlRXZlbnQubWV0YUtleSgpLCBnZXN0dXJlRXZlbnQudGltZXN0 YW1wKCkpOworICAgIG1vdXNlTW92ZWQoZmFrZU1vdXNlTW92ZSk7CisgICAgZGVmYXVsdFByZXZl bnRlZCB8PSBoYW5kbGVNb3VzZVByZXNzRXZlbnQoZmFrZU1vdXNlRG93bik7CisgICAgZGVmYXVs dFByZXZlbnRlZCB8PSBoYW5kbGVNb3VzZVJlbGVhc2VFdmVudChmYWtlTW91c2VVcCk7CisgICAg cmV0dXJuIGRlZmF1bHRQcmV2ZW50ZWQ7Cit9CisKK2Jvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVH ZXN0dXJlU2Nyb2xsVXBkYXRlKGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50JiBnZXN0dXJlRXZl bnQpCit7CisgICAgY29uc3QgZmxvYXQgdGlja0Rpdmlzb3IgPSAoZmxvYXQpV2hlZWxFdmVudDo6 dGlja011bHRpcGxpZXI7CisgICAgLy8gRklYTUU6IFJlcGxhY2UgdGhpcyBpbnRlcmltIGltcGxl bWVudGF0aW9uIG9uY2UgdGhlIGFib3ZlIGZpeG1lIGluIGhhbmRsZUdlc3R1cmVFdmVudCgpIGhh cyBiZWVuIGFkZHJlc3NlZC4KKyAgICBib29sIGRlZmF1bHRQcmV2ZW50ZWQgPSBmYWxzZTsKKyAg ICBJbnRQb2ludCBwb2ludChnZXN0dXJlRXZlbnQucG9zaXRpb24oKS54KCksIGdlc3R1cmVFdmVu dC5wb3NpdGlvbigpLnkoKSk7CisgICAgSW50UG9pbnQgZ2xvYmFsUG9pbnQoZ2VzdHVyZUV2ZW50 Lmdsb2JhbFBvc2l0aW9uKCkueCgpLCBnZXN0dXJlRXZlbnQuZ2xvYmFsUG9zaXRpb24oKS55KCkp OworICAgIFBsYXRmb3JtV2hlZWxFdmVudCBzeW50aGV0aWNXaGVlbEV2ZW50KHBvaW50LCBnbG9i YWxQb2ludCwgZ2VzdHVyZUV2ZW50LmRlbHRhWCgpLCBnZXN0dXJlRXZlbnQuZGVsdGFZKCksIGdl c3R1cmVFdmVudC5kZWx0YVgoKSAvIHRpY2tEaXZpc29yLCBnZXN0dXJlRXZlbnQuZGVsdGFZKCkg LyB0aWNrRGl2aXNvciwgU2Nyb2xsQnlQaXhlbFdoZWVsRXZlbnQsIGdlc3R1cmVFdmVudC5zaGlm dEtleSgpLCBnZXN0dXJlRXZlbnQuY3RybEtleSgpLCBnZXN0dXJlRXZlbnQuYWx0S2V5KCksIGdl c3R1cmVFdmVudC5tZXRhS2V5KCkpOworICAgIGRlZmF1bHRQcmV2ZW50ZWQgfD0gaGFuZGxlV2hl ZWxFdmVudChzeW50aGV0aWNXaGVlbEV2ZW50KTsKKyAgICByZXR1cm4gZGVmYXVsdFByZXZlbnRl ZDsKK30KICNlbmRpZgogCiAjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuaAppbmRleCA3NzMzYTBmNjUyNjQyYmU5Njk5Njk3NTYwMTQzYWViOTU5ODhm N2QyLi5hNWZmMzAzNGZlMmQ5MmQ5OGY2ZjE4OTg5NzhlMDc0YmQ5NGUxN2RjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmgKQEAgLTE2Miw2ICsxNjIsOCBAQCBwdWJsaWM6CiAKICNpZiBF TkFCTEUoR0VTVFVSRV9FVkVOVFMpCiAgICAgYm9vbCBoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3Qg UGxhdGZvcm1HZXN0dXJlRXZlbnQmKTsKKyAgICBib29sIGhhbmRsZUdlc3R1cmVUYXAoY29uc3Qg UGxhdGZvcm1HZXN0dXJlRXZlbnQmKTsKKyAgICBib29sIGhhbmRsZUdlc3R1cmVTY3JvbGxVcGRh dGUoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKENP TlRFWFRfTUVOVVMpCg==