79437 2012-02-23 21:18:56 -0800 Move FileSystem-related APIs from DOMWindow.idl to DOMWindowFileSystem.idl 2012-03-23 17:29:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79327 1 haraken haraken abarth arv commit-queue ericu eric ojan oldest_to_newest 563898 0 haraken 2012-02-23 21:18:56 -0800 For WebKit modularization, we can move FileSystem-related APIs from DOMWindow.idl to DOMWindowFileSystem.idl. 563900 1 128645 haraken 2012-02-23 21:22:47 -0800 Created attachment 128645 Patch 563991 2 128645 abarth 2012-02-23 23:34:13 -0800 Comment on attachment 128645 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128645&action=review > Source/WebCore/fileapi/DOMWindowFileSystem.idl:35 > + attribute FileConstructor File; > + attribute FileListConstructor FileList; > + attribute BlobConstructor Blob; > + attribute [Conditional=BLOB] FileErrorConstructor FileError; > + attribute [Conditional=BLOB] FileReaderConstructor FileReader; > + attribute [Conditional=BLOB] WebKitBlobBuilderConstructor WebKitBlobBuilder; > + attribute [Conditional=BLOB] DOMURLConstructor webkitURL; I'm not sure this is quite right. I'm slightly unclear which of these APIs are part of FileSystem versus Blob or FileReader / FileWriter: http://dev.w3.org/2006/webapi/FileAPI/ http://www.w3.org/TR/file-system-api/ We might need to ask EricU for some guidance. 565743 3 ericu 2012-02-27 09:42:24 -0800 > > + attribute FileConstructor File; > > + attribute FileListConstructor FileList; > > + attribute BlobConstructor Blob; > > + attribute [Conditional=BLOB] FileErrorConstructor FileError; > > + attribute [Conditional=BLOB] FileReaderConstructor FileReader; > > + attribute [Conditional=BLOB] WebKitBlobBuilderConstructor WebKitBlobBuilder; > > + attribute [Conditional=BLOB] DOMURLConstructor webkitURL; > > I'm not sure this is quite right. I'm slightly unclear which of these APIs are part of FileSystem versus Blob or FileReader / FileWriter: > > http://dev.w3.org/2006/webapi/FileAPI/ > http://www.w3.org/TR/file-system-api/ > > We might need to ask EricU for some guidance. None of those are from FileSystem. BlobBuilder is from FileWriter [http://www.w3.org/TR/file-writer-api/], and the rest are from the File API. They can all be moved out of DOMWIndow, but shouldn't go into anything with the name FileSystem on it. As for BlobBuilder, I'm not sure; it's going to go away at some point soon anyway, as it's to be replaced by a constructable Blob. So it can go wherever's convenient, and don't stress about it too much. 565835 4 128645 abarth 2012-02-27 11:12:41 -0800 Comment on attachment 128645 Patch The file-related APIs are spread out over a couple of different specs. We should figure out which APIs go with which specs and see if the code can be organized along those lines too. 586895 5 abarth 2012-03-23 17:29:36 -0700 Mark took care of these, I believe. 128645 2012-02-23 21:22:47 -0800 2012-02-27 11:12:41 -0800 Patch bug-79437-20120224142246.patch text/plain 3240 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTAwMGU4YjM3MTYwNGZl MmU5NDMwNTQ4NjZlNDc3NjFkYzkwYTUxMy4uZDRmZjRkNGVkMjNlNDk2NjhjYmJiMDM5MzA1MGNj ODAwNDlmNDQ4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTIzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBNb3ZlIEZpbGVTeXN0 ZW0tcmVsYXRlZCBBUElzIGZyb20gRE9NV2luZG93LmlkbCB0byBET01XaW5kb3dGaWxlU3lzdGVt LmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk0 MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3Ig V2ViS2l0IG1vZHVsYXJpemF0aW9uLCB0aGlzIHBhdGNoIG1vdmVzIEZpbGVTeXN0ZW0tcmVsYXRl ZCBBUElzCisgICAgICAgIGZyb20gRE9NV2luZG93LmlkbCB0byBET01XaW5kb3dGaWxlU3lzdGVt LmlkbC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAg ICAgICogZmlsZWFwaS9ET01XaW5kb3dGaWxlU3lzdGVtLmlkbDoKKyAgICAgICAgKiBwYWdlL0RP TVdpbmRvdy5pZGw6CisKIDIwMTItMDItMjMgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFN3aXRjaCBkcmF3TGluZUZvckJveFNpZGUgdG8gdXNlIGludGVn ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0RPTVdpbmRvd0ZpbGVTeXN0 ZW0uaWRsIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9ET01XaW5kb3dGaWxlU3lzdGVtLmlkbApp bmRleCA3OTk0N2NiZDdkYTNkZjJjMzNiODgzNWI5MTYwY2RjNWVkNzRjZGRkLi5kZDNmYTliNDUz YmQxOTY2YjNmM2MyMTkyNTk3ZTI1ZjI2ZjJkMTE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9maWxlYXBpL0RPTVdpbmRvd0ZpbGVTeXN0ZW0uaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Zp bGVhcGkvRE9NV2luZG93RmlsZVN5c3RlbS5pZGwKQEAgLTI2LDYgKzI2LDE0IEBAIG1vZHVsZSB3 aW5kb3cgewogICAgICAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBURU1QT1JBUlkgPSAwOwogICAg ICAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBQRVJTSVNURU5UID0gMTsKIAorICAgICAgICBhdHRy aWJ1dGUgRmlsZUNvbnN0cnVjdG9yIEZpbGU7CisgICAgICAgIGF0dHJpYnV0ZSBGaWxlTGlzdENv bnN0cnVjdG9yIEZpbGVMaXN0OworICAgICAgICBhdHRyaWJ1dGUgQmxvYkNvbnN0cnVjdG9yIEJs b2I7CisgICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9QkxPQl0gRmlsZUVycm9yQ29uc3Ry dWN0b3IgRmlsZUVycm9yOworICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPUJMT0JdIEZp bGVSZWFkZXJDb25zdHJ1Y3RvciBGaWxlUmVhZGVyOworICAgICAgICBhdHRyaWJ1dGUgW0NvbmRp dGlvbmFsPUJMT0JdIFdlYktpdEJsb2JCdWlsZGVyQ29uc3RydWN0b3IgV2ViS2l0QmxvYkJ1aWxk ZXI7CisgICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9QkxPQl0gRE9NVVJMQ29uc3RydWN0 b3Igd2Via2l0VVJMOworCiAgICAgICAgIFtWOEVuYWJsZWRBdFJ1bnRpbWU9RmlsZVN5c3RlbV0g dm9pZCB3ZWJraXRSZXF1ZXN0RmlsZVN5c3RlbShpbiB1bnNpZ25lZCBzaG9ydCB0eXBlLCBpbiBs b25nIGxvbmcgc2l6ZSwKICAgICAgICAgICAgICAgICBpbiBbQ2FsbGJhY2tdIEZpbGVTeXN0ZW1D YWxsYmFjayBzdWNjZXNzQ2FsbGJhY2ssIGluIFtDYWxsYmFjaywgT3B0aW9uYWxdIEVycm9yQ2Fs bGJhY2sgZXJyb3JDYWxsYmFjayk7CiAgICAgICAgIFtWOEVuYWJsZWRBdFJ1bnRpbWU9RmlsZVN5 c3RlbV0gdm9pZCB3ZWJraXRSZXNvbHZlTG9jYWxGaWxlU3lzdGVtVVJMKGluIERPTVN0cmluZyB1 cmwsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKaW5kZXggYjBmMjZlZjZlNWMzM2E5NGRjOWIw NTdjZjVkNzVlM2FkY2Q2ODAwYi4uZGFiNTk4MWE3OTg5ZWZkNmI4NzM3NzhjNTE4NGM3MzRiODQ3 NzQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbApAQCAtNDY1LDEwICs0NjUsNiBAQCBt b2R1bGUgd2luZG93IHsKIAogICAgICAgICBhdHRyaWJ1dGUgQ2xpcGJvYXJkQ29uc3RydWN0b3Ig Q2xpcGJvYXJkOwogCi0gICAgICAgIGF0dHJpYnV0ZSBGaWxlQ29uc3RydWN0b3IgRmlsZTsKLSAg ICAgICAgYXR0cmlidXRlIEZpbGVMaXN0Q29uc3RydWN0b3IgRmlsZUxpc3Q7Ci0gICAgICAgIGF0 dHJpYnV0ZSBCbG9iQ29uc3RydWN0b3IgQmxvYjsKLQogICAgICAgICBhdHRyaWJ1dGUgTm9kZUZp bHRlckNvbnN0cnVjdG9yIE5vZGVGaWx0ZXI7CiAgICAgICAgIGF0dHJpYnV0ZSBSYW5nZUNvbnN0 cnVjdG9yIFJhbmdlOwogICAgICAgICBhdHRyaWJ1dGUgUmFuZ2VFeGNlcHRpb25Db25zdHJ1Y3Rv ciBSYW5nZUV4Y2VwdGlvbjsKQEAgLTU0MSwxMyArNTM3LDYgQEAgbW9kdWxlIHdpbmRvdyB7CiAK ICAgICAgICAgYXR0cmlidXRlIERPTUZvcm1EYXRhQ29uc3RydWN0b3IgRm9ybURhdGE7CiAKLSAg ICAgICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD1CTE9CfEZJTEVfU1lTVEVNXSBGaWxlRXJyb3JD b25zdHJ1Y3RvciBGaWxlRXJyb3I7Ci0gICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9QkxP Ql0gRmlsZVJlYWRlckNvbnN0cnVjdG9yIEZpbGVSZWFkZXI7Ci0KLSAgICAgICAgYXR0cmlidXRl IFtDb25kaXRpb25hbD1CTE9CXSBXZWJLaXRCbG9iQnVpbGRlckNvbnN0cnVjdG9yIFdlYktpdEJs b2JCdWlsZGVyOwotCi0gICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9QkxPQl0gRE9NVVJM Q29uc3RydWN0b3Igd2Via2l0VVJMOwotCiAjaWYgZGVmaW5lZChFTkFCTEVfUVVPVEEpICYmIEVO QUJMRV9RVU9UQQogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW1Y4RW5hYmxlZEF0UnVudGlt ZT1RdW90YV0gU3RvcmFnZUluZm8gd2Via2l0U3RvcmFnZUluZm87CiAjZW5kaWYK