79315 2012-02-22 18:10:13 -0800 Add pixelSnapped methods to FractionalLayoutRect 2012-03-06 11:13:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae darin eric leviw rniwa simon.fraser oldest_to_newest 562658 0 eae 2012-02-22 18:10:13 -0800 This will make it easier to get the pixel snapped bottom/right edges as well as the size. 562661 1 128357 eae 2012-02-22 18:14:32 -0800 Created attachment 128357 Patch 562701 2 128357 eric 2012-02-22 19:08:46 -0800 Comment on attachment 128357 Patch Odd. Why not just use rect.pixelSnapped().width(), etc? 562704 3 eae 2012-02-22 19:13:10 -0800 (In reply to comment #2) > (From update of attachment 128357 [details]) > Odd. Why not just use rect.pixelSnapped().width(), etc? That would be pixelSnappedIntRect(rect).width(). The advantage of these methods is that it only computed the values that are needed. Might not be worth worrying about though. 572007 4 leviw 2012-03-06 11:13:14 -0800 These were added in http://trac.webkit.org/changeset/109835. 572008 5 128357 leviw 2012-03-06 11:13:42 -0800 Comment on attachment 128357 Patch Clearing flags. 128357 2012-02-22 18:14:32 -0800 2012-03-06 11:13:42 -0800 Patch bug-79315-20120222181431.patch text/plain 2256 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODU5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTIyICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgcGl4ZWxTbmFwcGVkIG1l dGhvZHMgdG8gRnJhY3Rpb25hbExheW91dFJlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIEFkZCBwaXhlbFNuYXBwZWRYL1kvTWF4WC9NYXhZL1dpZHRoL0hl aWdodCBtZXRob2RzIHRvIEZyYWN0aW9uYWxMYXlvdXRSZWN0CisgICAgICAgIHRvIGFpZCBpbiBn ZXR0aW5nIHRoZSBwaXhlbCBzbmFwcGVkIHZhbHVlcyBmb3IgYSBzdWJwaXhlbCByZWN0LgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZyYWN0 aW9uYWxMYXlvdXRSZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpGcmFjdGlvbmFsTGF5b3V0UmVj dDo6cGl4ZWxTbmFwcGVkWCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFjdGlvbmFsTGF5b3V0UmVj dDo6cGl4ZWxTbmFwcGVkWSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFjdGlvbmFsTGF5b3V0UmVj dDo6cGl4ZWxTbmFwcGVkV2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6RnJhY3Rpb25hbExheW91 dFJlY3Q6OnBpeGVsU25hcHBlZEhlaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFjdGlvbmFs TGF5b3V0UmVjdDo6cGl4ZWxTbmFwcGVkTWF4WCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFjdGlv bmFsTGF5b3V0UmVjdDo6cGl4ZWxTbmFwcGVkTWF4WSk6CisgICAgICAgIChGcmFjdGlvbmFsTGF5 b3V0UmVjdCk6CisKIDIwMTItMDItMjIgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBw bGUuY29tPgogCiAgICAgICAgIE1ha2UgcGFyc2luZyBjb2xvciBwcmVzZW50YXRpb24gYXR0cmli dXRlcyBkbyBsZXNzIHBvaW50bGVzcyB3b3JrLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvRnJhY3Rpb25hbExheW91dFJlY3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GcmFjdGlvbmFsTGF5b3V0UmVjdC5oCShyZXZpc2lv biAxMDg1NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GcmFjdGlvbmFs TGF5b3V0UmVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC02NSw2ICs2NSwxMyBAQCBwdWJsaWM6CiAg ICAgRnJhY3Rpb25hbExheW91dFVuaXQgd2lkdGgoKSBjb25zdCB7IHJldHVybiBtX3NpemUud2lk dGgoKTsgfQogICAgIEZyYWN0aW9uYWxMYXlvdXRVbml0IGhlaWdodCgpIGNvbnN0IHsgcmV0dXJu IG1fc2l6ZS5oZWlnaHQoKTsgfQogCisgICAgaW50IHBpeGVsU25hcHBlZFgoKSBjb25zdCB7IHJl dHVybiB4KCkucm91bmQoKTsgfQorICAgIGludCBwaXhlbFNuYXBwZWRZKCkgY29uc3QgeyByZXR1 cm4geSgpLnJvdW5kKCk7IH0KKyAgICBpbnQgcGl4ZWxTbmFwcGVkV2lkdGgoKSBjb25zdCB7IHJl dHVybiBzbmFwU2l6ZVRvUGl4ZWwod2lkdGgoKSwgeCgpKTsgfQorICAgIGludCBwaXhlbFNuYXBw ZWRIZWlnaHQoKSBjb25zdCB7IHJldHVybiBzbmFwU2l6ZVRvUGl4ZWwoaGVpZ2h0KCksIHkoKSk7 IH0KKyAgICBpbnQgcGl4ZWxTbmFwcGVkTWF4WCgpIGNvbnN0IHsgcmV0dXJuIHBpeGVsU25hcHBl ZFgoKSArIHBpeGVsU25hcHBlZFdpZHRoKCk7IH0KKyAgICBpbnQgcGl4ZWxTbmFwcGVkTWF4WSgp IGNvbnN0IHsgcmV0dXJuIHBpeGVsU25hcHBlZFkoKSArIHBpeGVsU25hcHBlZEhlaWdodCgpOyB9 CisKICAgICB2b2lkIHNldFgoRnJhY3Rpb25hbExheW91dFVuaXQgeCkgeyBtX2xvY2F0aW9uLnNl dFgoeCk7IH0KICAgICB2b2lkIHNldFkoRnJhY3Rpb25hbExheW91dFVuaXQgeSkgeyBtX2xvY2F0 aW9uLnNldFkoeSk7IH0KICAgICB2b2lkIHNldFdpZHRoKEZyYWN0aW9uYWxMYXlvdXRVbml0IHdp ZHRoKSB7IG1fc2l6ZS5zZXRXaWR0aCh3aWR0aCk7IH0K