78866 2012-02-16 18:53:18 -0800 webkit-patch is broken on SL with a new, clean checkout, using Python 2.6.1 2012-02-17 13:53:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth aroben eric ojan tony oldest_to_newest 558798 0 dpranke 2012-02-16 18:53:18 -0800 On my corp Mac Pro (running SL + Python 2.6.1), if I have a clean checkout (or remove my webkitpy.thirdparty.autoinstalled directory, then "webkit-patch help" fails trying to auto install irclib :( 558799 1 dpranke 2012-02-16 18:54:56 -0800 it works fine, however, on Lion with python 2.7.1 . 558800 2 dpranke 2012-02-16 18:57:45 -0800 I've confirmed this on two different machines running the same corp image, so I don't think it's just one machine. I will see if maybe it has something to do with this specific version of irc. The script keels over trying to decompress the zipfile into a temporary directory; for some reason it is creating the top-level directory python-irclib-0.4.8 as a file, not a directory, and then everything goes south. Traceback (most recent call last): File "/src/wk/Tools/Scripts/webkit-patch", line 44, in <module> from webkitpy.tool.main import WebKitPatch File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/tool/main.py", line 38, in <module> from webkitpy.common.net.irc import ircproxy File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/common/net/irc/ircproxy.py", line 31, in <module> from webkitpy.common.net.irc.ircbot import IRCBot File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py", line 32, in <module> from webkitpy.thirdparty.autoinstalled.irc import ircbot File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 80, in find_module self._install_irc() File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 123, in _install_irc url_subpath="irclib.py") File "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 445, in install raise Exception(message) Exception: Error auto-installing the irclib.py package to: "/Volumes/Source/src/wk/Tools/Scripts/webkitpy/thirdparty/autoinstalled/irc/irclib.py" --> Inner message: [Errno 20] Not a directory: '/var/folders/++/++3pXE++6+0++4RjPqRgNE+-RMo/-Tmp-/irclib.py_YZR9KZ/python-irclib-0.4.8/dccsend' 558801 3 eric 2012-02-16 18:58:16 -0800 I suspect it failed to download the package from Adam's server. :) 558808 4 dpranke 2012-02-16 19:08:04 -0800 (In reply to comment #3) > I suspect it failed to download the package from Adam's server. :) Nope, package is downloading fine. I actually changed the version to 0.4.6 to try that, and it failed w/ the same error. 559301 5 abarth 2012-02-17 10:32:33 -0800 Can you try reverting the recent change to the autoinstaller to remove 2.5 compat? 559303 6 abarth 2012-02-17 10:32:56 -0800 "to remove" => "that removed" 559486 7 dpranke 2012-02-17 13:37:21 -0800 (In reply to comment #5) > Can you try reverting the recent change to the autoinstaller to remove 2.5 compat? Oh, you mean, can I revert the change where we stopped using our working code and decided to use the broken system version? Yeah, that fixes the problem :). I've reopened bug 78173. 559500 8 abarth 2012-02-17 13:49:23 -0800 > > Can you try reverting the recent change to the autoinstaller to remove 2.5 compat? > > Oh, you mean, can I revert the change where we stopped using our working code and decided to use the broken system version? Yeah, that fixes the problem :). Yes. :) 559502 9 dpranke 2012-02-17 13:50:23 -0800 *** Bug 78931 has been marked as a duplicate of this bug. *** 559503 10 127648 dpranke 2012-02-17 13:50:50 -0800 Created attachment 127648 Patch 559504 11 127648 abarth 2012-02-17 13:52:10 -0800 Comment on attachment 127648 Patch Thanks for updating the comment. 559507 12 eric 2012-02-17 13:53:49 -0800 What an excellent example of why good "why" comments are important. :) Thanks Dirk! 559508 13 dpranke 2012-02-17 13:53:54 -0800 Committed r108118: <http://trac.webkit.org/changeset/108118> 127648 2012-02-17 13:50:50 -0800 2012-02-17 13:52:10 -0800 Patch bug-78866-20120217135048.patch text/plain 3351 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmQwYzBjYWUxY2UwYTk1ZmExNWJiNjhiZjQ0MGQ0Mzg5 OWVjYmNhYy4uMzUxNWNkNTYxOGZmMjAyMTM3NGRjMDU3NzA3NGRlYzZhODRiNmM2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTAyLTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHJldmVydCByMTA3MTQ3IC0gYnJlYWtzIHdlYmtpdC1wYXRjaCBvbiBNYWMgU0wKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4ODY2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgYXBwZWFycyB0 aGF0IHppcGZpbGUuRXh0cmFjdEFsbCBpcyBicm9rZW4gb24gUHl0aG9uIDIuNi4xLAorICAgICAg ICB3aGljaCBpcyB0aGUgdmVyc2lvbiB0aGF0IHNoaXBzIG9uIE1hYyBTTC4gUmV2ZXJ0aW5nIHRo aXMKKyAgICAgICAgY2hhbmdlIHVudGlsIHdlIG5vIGxvbmdlciBoYXZlIHRvIHdvcnJ5IGFib3V0 IHRoYXQgdmVyc2lvbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS9hdXRvaW5zdGFsbC5weToKKyAgICAgICAgKEF1dG9JbnN0YWxsZXIpOgorICAgICAgICAoQXV0 b0luc3RhbGxlci5fZXh0cmFjdF9hbGwpOiBBZGRlZCBhIGNvbW1lbnQgYWJvdXQgU0wuCisgICAg ICAgIChBdXRvSW5zdGFsbGVyLl91bnppcCk6CisKIDIwMTItMDItMTcgIE1paG5lYSBPdmlkZW5p ZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgQ1NTIHJlZ2lvbnMgZW5hYmxlZCBieSBk ZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v YXV0b2luc3RhbGwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0 b2luc3RhbGwucHkKaW5kZXggYTkyOGRiNjNhZTFkMDY1ZDg4YTIwYjhhYTY4MjgyZTBmYjBhMjAy NS4uZTViYzBiMmNiYTcxOGQ0NTBmNmZjYTdmMDEyY2Y0N2M3M2NiYjkzYiAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2F1dG9pbnN0YWxsLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weQpAQCAt MjU5LDYgKzI1OSw0NCBAQCBjbGFzcyBBdXRvSW5zdGFsbGVyKG9iamVjdCk6CiAKICAgICAgICAg cmV0dXJuIHRhcmdldF9wYXRoCiAKKyAgICAjIFRoaXMgaXMgYSByZXBsYWNlbWVudCBmb3IgWmlw RmlsZS5leHRyYWN0YWxsKCksIHdoaWNoIGlzCisgICAgIyBhdmFpbGFibGUgaW4gUHl0aG9uIDIu NiBidXQgbm90IGluIGVhcmxpZXIgdmVyc2lvbnMuCisgICAgIyBOT1RFOiBUaGUgdmVyc2lvbiBp biAyLjYuMSAod2hpY2ggc2hpcHBlZCBvbiBTbm93IExlb3BhcmQpIGlzIGJyb2tlbiEKKyAgICBk ZWYgX2V4dHJhY3RfYWxsKHNlbGYsIHppcF9maWxlLCB0YXJnZXRfZGlyKToKKyAgICAgICAgc2Vs Zi5fbG9nX3RyYW5zZmVyKCJFeHRyYWN0aW5nIHppcCBmaWxlLi4uIiwgemlwX2ZpbGUsIHRhcmdl dF9kaXIpCisKKyAgICAgICAgIyBUaGlzIGlzIGhlbHBmdWwgZm9yIGRlYnVnZ2luZyBwdXJwb3Nl cy4KKyAgICAgICAgX2xvZy5kZWJ1ZygiTGlzdGluZyB6aXAgZmlsZSBjb250ZW50cy4uLiIpCisg ICAgICAgIGZvciBuYW1lIGluIHppcF9maWxlLm5hbWVsaXN0KCk6CisgICAgICAgICAgICBfbG9n LmRlYnVnKCcgICAgKiAiJXMiJyAlIG5hbWUpCisKKyAgICAgICAgZm9yIG5hbWUgaW4gemlwX2Zp bGUubmFtZWxpc3QoKToKKyAgICAgICAgICAgIHBhdGggPSBvcy5wYXRoLmpvaW4odGFyZ2V0X2Rp ciwgbmFtZSkKKyAgICAgICAgICAgIHNlbGYuX2xvZ190cmFuc2ZlcigiRXh0cmFjdGluZy4uLiIs IG5hbWUsIHBhdGgpCisKKyAgICAgICAgICAgIGlmIG5vdCBvcy5wYXRoLmJhc2VuYW1lKHBhdGgp OgorICAgICAgICAgICAgICAgICMgVGhlbiB0aGUgcGF0aCBlbmRzIGluIGEgc2xhc2gsIHNvIGl0 IGlzIGEgZGlyZWN0b3J5LgorICAgICAgICAgICAgICAgIHNlbGYuX2NyZWF0ZV9kaXJlY3Rvcnko cGF0aCkKKyAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgIyBPdGhlcndpc2Us IGl0IGlzIGEgZmlsZS4KKworICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgICMgV2Ug b3BlbiB0aGlzIGZpbGUgdy9vIGVuY29kaW5nLCBhcyB3ZSdyZSByZWFkaW5nL3dyaXRpbmcKKyAg ICAgICAgICAgICAgICAjIHRoZSByYXcgYnl0ZS1zdHJlYW0gZnJvbSB0aGUgemlwIGZpbGUuCisg ICAgICAgICAgICAgICAgb3V0ZmlsZSA9IG9wZW4ocGF0aCwgJ3diJykKKyAgICAgICAgICAgIGV4 Y2VwdCBJT0Vycm9yLCBlcnI6CisgICAgICAgICAgICAgICAgIyBOb3QgYWxsIHppcCBmaWxlcyBz ZWVtIHRvIGxpc3QgdGhlIGRpcmVjdG9yaWVzIGV4cGxpY2l0bHksCisgICAgICAgICAgICAgICAg IyBzbyB0cnkgYWdhaW4gYWZ0ZXIgY3JlYXRpbmcgdGhlIGNvbnRhaW5pbmcgZGlyZWN0b3J5Lgor ICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoIkdvdCBJT0Vycm9yOiByZXRyeWluZyBhZnRlciBj cmVhdGluZyBkaXJlY3RvcnkuLi4iKQorICAgICAgICAgICAgICAgIGRpciA9IG9zLnBhdGguZGly bmFtZShwYXRoKQorICAgICAgICAgICAgICAgIHNlbGYuX2NyZWF0ZV9kaXJlY3RvcnkoZGlyKQor ICAgICAgICAgICAgICAgIG91dGZpbGUgPSBvcGVuKHBhdGgsICd3YicpCisKKyAgICAgICAgICAg IHRyeToKKyAgICAgICAgICAgICAgICBvdXRmaWxlLndyaXRlKHppcF9maWxlLnJlYWQobmFtZSkp CisgICAgICAgICAgICBmaW5hbGx5OgorICAgICAgICAgICAgICAgIG91dGZpbGUuY2xvc2UoKQor CiAgICAgZGVmIF91bnppcChzZWxmLCBwYXRoLCBzY3JhdGNoX2Rpcik6CiAgICAgICAgICMgemlw ZmlsZS5leHRyYWN0YWxsKCkgZXh0cmFjdHMgdG8gYSBwYXRoIHdpdGhvdXQgdGhlCiAgICAgICAg ICMgdHJhaWxpbmcgIi56aXAiLgpAQCAtMjc2LDcgKzMxNCw3IEBAIGNsYXNzIEF1dG9JbnN0YWxs ZXIob2JqZWN0KToKICAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbihtZXNzYWdlKQogCiAgICAg ICAgIHRyeToKLSAgICAgICAgICAgIHppcF9maWxlLmV4dHJhY3RhbGwoc2NyYXRjaF9kaXIpCisg ICAgICAgICAgICBzZWxmLl9leHRyYWN0X2FsbCh6aXBfZmlsZSwgc2NyYXRjaF9kaXIpCiAgICAg ICAgIGZpbmFsbHk6CiAgICAgICAgICAgICB6aXBfZmlsZS5jbG9zZSgpCiAK