78835 2012-02-16 13:22:32 -0800 Fix use of long long in FractionalLayoutUnit::setRawValue 2012-02-16 17:16:36 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76571 1 eae eae aroben eric leviw webkit.review.bot oldest_to_newest 558468 0 eae 2012-02-16 13:22:32 -0800 setRawValue(long long) which is called by the multiple operator has an assertion to verify that the resulting value is within the range of an int. This currently uses abs(long long) which isn't implemented on all platforms we support. 558476 1 127434 eae 2012-02-16 13:31:46 -0800 Created attachment 127434 Patch 558486 2 127434 eric 2012-02-16 13:44:24 -0800 Comment on attachment 127434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127434&action=review The rest looks fine. > Source/WebCore/platform/FractionalLayoutUnit.h:122 > + return value < static_cast<unsigned>(std::numeric_limits<int>::max()) / kFixedPointDenominator; Why is this necessary? 558487 3 127434 leviw 2012-02-16 13:46:15 -0800 Comment on attachment 127434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127434&action=review >> Source/WebCore/platform/FractionalLayoutUnit.h:122 >> + return value < static_cast<unsigned>(std::numeric_limits<int>::max()) / kFixedPointDenominator; > > Why is this necessary? Since value here is unsigned, you'll get a type warning when comparing them if you don't cast the int. 558488 4 127434 eric 2012-02-16 13:46:57 -0800 Comment on attachment 127434 Patch OK. 558723 5 127434 webkit.review.bot 2012-02-16 17:16:32 -0800 Comment on attachment 127434 Patch Clearing flags on attachment: 127434 Committed r108006: <http://trac.webkit.org/changeset/108006> 558724 6 webkit.review.bot 2012-02-16 17:16:36 -0800 All reviewed patches have been landed. Closing bug. 127434 2012-02-16 13:31:46 -0800 2012-02-16 17:16:32 -0800 Patch bug-78835-20120216133145.patch text/plain 3072 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNzk3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAyLTE2ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggdXNlIG9mIGxvbmcgbG9u ZyBpbiBGcmFjdGlvbmFsTGF5b3V0VW5pdDo6c2V0UmF3VmFsdWUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4ODM1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHNldFJhd1ZhbHVlKGxvbmcgbG9u ZykgdG8gY29tcGFyZSBhZ2FpbnN0IGludCBtaW4gYW5kIG1heCBpbnN0ZWFkCisgICAgICAgIG9m IHVzaW5nIGFicyBhcyBub3QgYWxsIHBsYXRmb3JtcyB3ZSBzdXBwb3J0IGltcGxlbWVudCBhIGxv bmcgbG9uZworICAgICAgICB2ZXJzaW9uIG9mIGFicyBvciBsbGFicy4KKworICAgICAgICBObyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9GcmFjdGlvbmFsTGF5b3V0VW5pdC5oOgor ICAgICAgICAoV2ViQ29yZTo6RnJhY3Rpb25hbExheW91dFVuaXQ6OnNldFJhd1ZhbHVlKToKKyAg ICAgICAgQ29tcGFyZSBhZ2FpbnN0IGludCBtaW4vbWF4IGluc3RlYWQgb2YganVzdCBtYXggd2l0 aCBhYnMuCisgICAgICAgIAorICAgICAgICAoV2ViQ29yZTo6RnJhY3Rpb25hbExheW91dFVuaXQ6 OmlzSW5Cb3VuZHMpOgorICAgICAgICBGaXggdHlwZSBtaXNtYXRjaCB3YXJuaW5nLgorICAgICAg ICAKKyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9yPT0pOgorICAgICAgICBGaXggdHlwby4KKyAg ICAgICAgCisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvciopOgorICAgICAgICBVc2UgbG9uZyBs b25nIHZlcnNpb24gb2Ygc2V0UmF3VmFsdWUuCisKIDIwMTItMDItMTYgIFNlcmdpbyBWaWxsYXIg U2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW3NvdXBdIE1vdmUgaW1wb3J0 YW50IFNvdXBTZXNzaW9uIGZlYXR1cmUgaW5pdGlhbGl6YXRpb24gdG8gV2ViQ29yZQpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRnJhY3Rpb25hbExheW91dFVuaXQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GcmFjdGlvbmFsTGF5b3V0VW5pdC5oCShyZXZp c2lvbiAxMDc5NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GcmFjdGlvbmFsTGF5b3V0 VW5pdC5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw3ICs2NCwxMSBAQCBwdWJsaWM6CiAKICAgICBp bmxpbmUgaW50IHJhd1ZhbHVlKCkgY29uc3QgeyByZXR1cm4gbV92YWx1ZTsgfQogICAgIGlubGlu ZSB2b2lkIHNldFJhd1ZhbHVlKGludCB2YWx1ZSkgeyBtX3ZhbHVlID0gdmFsdWU7IH0KLSAgICBp bmxpbmUgdm9pZCBzZXRSYXdWYWx1ZShsb25nIGxvbmcgdmFsdWUpIHsgQVNTRVJUKDo6YWJzKHZh bHVlKSA8IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCkpOyBtX3ZhbHVlID0gdmFsdWU7 IH0KKyAgICBpbmxpbmUgdm9pZCBzZXRSYXdWYWx1ZShsb25nIGxvbmcgdmFsdWUpCisgICAgewor ICAgICAgICBBU1NFUlQodmFsdWUgPiBzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1pbigpICYm IHZhbHVlIDwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptYXgoKSk7CisgICAgICAgIG1fdmFs dWUgPSB2YWx1ZTsKKyAgICB9CiAKICAgICBpbmxpbmUgRnJhY3Rpb25hbExheW91dFVuaXQgYWJz KCkKICAgICB7CkBAIC0xMTUsNyArMTE5LDcgQEAgcHJpdmF0ZToKICAgICB9CiAgICAgaW5saW5l IGJvb2wgaXNJbkJvdW5kcyh1bnNpZ25lZCB2YWx1ZSkKICAgICB7Ci0gICAgICAgIHJldHVybiB2 YWx1ZSA8IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCkgLyBrRml4ZWRQb2ludERlbm9t aW5hdG9yOworICAgICAgICByZXR1cm4gdmFsdWUgPCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oc3Rk OjpudW1lcmljX2xpbWl0czxpbnQ+OjptYXgoKSkgLyBrRml4ZWRQb2ludERlbm9taW5hdG9yOwog ICAgIH0KICAgICBpbmxpbmUgYm9vbCBpc0luQm91bmRzKGRvdWJsZSB2YWx1ZSkKICAgICB7CkBA IC0yNjIsMTIgKzI2NiwxMiBAQCBpbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEZyYWN0aW9u YWxMCiAKIGlubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgRnJhY3Rpb25hbExheW91dFVuaXQm IGEsIGludCBiKQogewotICAgIHJldHVybiBhID09IEZyYWN0aW9uTGF5b3V0VW5pdChiKTsKKyAg ICByZXR1cm4gYSA9PSBGcmFjdGlvbmFsTGF5b3V0VW5pdChiKTsKIH0KIAogaW5saW5lIGJvb2wg b3BlcmF0b3I9PShjb25zdCBpbnQgYSwgY29uc3QgRnJhY3Rpb25hbExheW91dFVuaXQmIGIpCiB7 Ci0gICAgcmV0dXJuIEZyYWN0aW9uTGF5b3V0VW5pdChhKSA9PSBiOworICAgIHJldHVybiBGcmFj dGlvbmFsTGF5b3V0VW5pdChhKSA9PSBiOwogfQogCiBpbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNv bnN0IEZyYWN0aW9uYWxMYXlvdXRVbml0JiBhLCBmbG9hdCBiKQpAQCAtMjk3LDcgKzMwMSw3IEBA IGlubGluZSBGcmFjdGlvbmFsTGF5b3V0VW5pdCBvcGVyYXRvciooY28KIHsKICAgICBGcmFjdGlv bmFsTGF5b3V0VW5pdCByZXR1cm5WYWw7CiAgICAgbG9uZyBsb25nIHJhd1ZhbCA9IHN0YXRpY19j YXN0PGxvbmcgbG9uZz4oYS5yYXdWYWx1ZSgpKSAqIGIucmF3VmFsdWUoKSAvIGtGaXhlZFBvaW50 RGVub21pbmF0b3I7Ci0gICAgcmV0dXJuVmFsLnNldFJhd1ZhbHVlKChhLnJhd1ZhbHVlKCkgLyBr Rml4ZWRQb2ludERlbm9taW5hdG9yKSAqIGIucmF3VmFsdWUoKSk7CisgICAgcmV0dXJuVmFsLnNl dFJhd1ZhbHVlKHJhd1ZhbCk7CiAgICAgcmV0dXJuIHJldHVyblZhbDsKIH0gICAgCiAK