78812 2012-02-16 07:40:50 -0800 Removing the last presentation attribute should result in a null attributeStyle(). 2012-02-17 01:21:01 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78798 1 kling kling eric koivisto oldest_to_newest 558182 0 kling 2012-02-16 07:40:50 -0800 Hanging an empty attribute style on a StyledElement is a waste of resources. If updateAttributeStyle() doesn't find any presentation attributes we should set a null attributeStyle. 558185 1 127377 kling 2012-02-16 07:45:48 -0800 Created attachment 127377 Patch 558208 2 127377 kling 2012-02-16 08:18:01 -0800 Comment on attachment 127377 Patch We can avoid the heap allocation altogether if we don't have any presentation attributes.. 558220 3 127377 kling 2012-02-16 08:33:12 -0800 Comment on attachment 127377 Patch Actually, calling the isPresentationAttribute() virtual on every attribute is more expensive than avoiding the temporary StylePropertySet. 558574 4 eric 2012-02-16 15:09:58 -0800 So this is a performance fix? Memory fix? Or is this in any way visible to the web? 559020 5 kling 2012-02-17 01:02:05 -0800 Committed r108049: <http://trac.webkit.org/changeset/108049> 559026 6 kling 2012-02-17 01:21:01 -0800 (In reply to comment #4) > So this is a performance fix? Memory fix? Or is this in any way visible to the web? It's a small performance and memory fix for cases where removing an attribute on an element and causing it to no longer have any presentation attributes is slightly more efficient. 127377 2012-02-16 07:45:48 -0800 2012-02-16 16:58:12 -0800 Patch bug-78812.diff text/plain 2714 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNTE4Y2I3Li4wODZjNmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDItMTYgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgor CisgICAgICAgIFJlbW92aW5nIHRoZSBsYXN0IHByZXNlbnRhdGlvbiBhdHRyaWJ1dGUgc2hvdWxk IHJlc3VsdCBpbiBhIG51bGwgYXR0cmlidXRlU3R5bGUoKS4KKyAgICAgICAgPGh0dHA6Ly93ZWJr aXQub3JnL2IvNzg4MTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSWYgdGhlIGNvbGxlY3RTdHlsZUZvckF0dHJpYnV0ZSgpIHBhc3MgaW4gdXBkYXRl QXR0cmlidXRlU3R5bGUoKSBkb2Vzbid0IGVuY291bnRlciBhbnkKKyAgICAgICAgcmVzcGVjdGVk IHByZXNlbnRhdGlvbiBhdHRyaWJ1dGVzLCBzZXQgYSBudWxsIGF0dHJpYnV0ZVN0eWxlKCkgaW5z dGVhZCBvZiBhbiBlbXB0eSBvbmUuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpjb2xsZWN0TWF0Y2hpbmdS dWxlc0Zvckxpc3QpOgorICAgICAgICAqIGRvbS9TdHlsZWRFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlN0eWxlZEVsZW1lbnQ6OnVwZGF0ZUF0dHJpYnV0ZVN0eWxlKToKKwogMjAxMi0w Mi0xNiAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIFJlZmFjdG9yIENDTGF5ZXJUcmVlSG9zdENvbW1vbjogY3JlYXRlIGhlbHBlciBm dW5jdGlvbiBmb3IgY29tcGxleCBib29sZWFuIGNvbmRpdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IDMxNzEzYWQuLmMwODZhOGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTEwMjYsMTIgKzEwMjYsMTAgQEAgdm9pZCBD U1NTdHlsZVNlbGVjdG9yOjptYXRjaEFsbFJ1bGVzKE1hdGNoUmVzdWx0JiByZXN1bHQpCiAgICAg Ly8gTm93IGNoZWNrIGF1dGhvciBydWxlcywgYmVnaW5uaW5nIGZpcnN0IHdpdGggcHJlc2VudGF0 aW9uYWwgYXR0cmlidXRlcyBtYXBwZWQgZnJvbSBIVE1MLgogICAgIGlmIChtX3N0eWxlZEVsZW1l bnQpIHsKICAgICAgICAgaWYgKFN0eWxlUHJvcGVydHlTZXQqIGF0dHJpYnV0ZVN0eWxlID0gbV9z dHlsZWRFbGVtZW50LT5hdHRyaWJ1dGVTdHlsZSgpKSB7Ci0gICAgICAgICAgICBpZiAoIWF0dHJp YnV0ZVN0eWxlLT5pc0VtcHR5KCkpIHsKLSAgICAgICAgICAgICAgICByZXN1bHQucmFuZ2VzLmxh c3RBdXRob3JSdWxlID0gbV9tYXRjaGVkUnVsZXMuc2l6ZSgpOwotICAgICAgICAgICAgICAgIGlm IChyZXN1bHQucmFuZ2VzLmZpcnN0QXV0aG9yUnVsZSA9PSAtMSkKLSAgICAgICAgICAgICAgICAg ICAgcmVzdWx0LnJhbmdlcy5maXJzdEF1dGhvclJ1bGUgPSByZXN1bHQucmFuZ2VzLmxhc3RBdXRo b3JSdWxlOwotICAgICAgICAgICAgICAgIGFkZE1hdGNoZWRQcm9wZXJ0aWVzKHJlc3VsdCwgYXR0 cmlidXRlU3R5bGUpOwotICAgICAgICAgICAgfQorICAgICAgICAgICAgcmVzdWx0LnJhbmdlcy5s YXN0QXV0aG9yUnVsZSA9IG1fbWF0Y2hlZFJ1bGVzLnNpemUoKTsKKyAgICAgICAgICAgIGlmIChy ZXN1bHQucmFuZ2VzLmZpcnN0QXV0aG9yUnVsZSA9PSAtMSkKKyAgICAgICAgICAgICAgICByZXN1 bHQucmFuZ2VzLmZpcnN0QXV0aG9yUnVsZSA9IHJlc3VsdC5yYW5nZXMubGFzdEF1dGhvclJ1bGU7 CisgICAgICAgICAgICBhZGRNYXRjaGVkUHJvcGVydGllcyhyZXN1bHQsIGF0dHJpYnV0ZVN0eWxl KTsKICAgICAgICAgfQogCiAgICAgICAgIC8vIE5vdyB3ZSBjaGVjayBhZGRpdGlvbmFsIG1hcHBl ZCBkZWNsYXJhdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU3R5bGVkRWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU3R5bGVkRWxlbWVudC5jcHAKaW5kZXggMjc3 NzI1Yi4uMjBlMjkzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcApAQCAtMTgz LDcgKzE4MywxMSBAQCB2b2lkIFN0eWxlZEVsZW1lbnQ6OnVwZGF0ZUF0dHJpYnV0ZVN0eWxlKCkK ICAgICAgICAgY29sbGVjdFN0eWxlRm9yQXR0cmlidXRlKGF0dHJpYnV0ZSwgc3R5bGUuZ2V0KCkp OwogICAgIH0KICAgICBjbGVhckF0dHJpYnV0ZVN0eWxlRGlydHkoKTsKLSAgICBlbnN1cmVBdHRy aWJ1dGVEYXRhKCktPnNldEF0dHJpYnV0ZVN0eWxlKHN0eWxlLnJlbGVhc2UoKSk7CisKKyAgICBp ZiAoc3R5bGUtPmlzRW1wdHkoKSkKKyAgICAgICAgYXR0cmlidXRlRGF0YSgpLT5zZXRBdHRyaWJ1 dGVTdHlsZSgwKTsKKyAgICBlbHNlCisgICAgICAgIGF0dHJpYnV0ZURhdGEoKS0+c2V0QXR0cmli dXRlU3R5bGUoc3R5bGUucmVsZWFzZSgpKTsKIH0KIAogfQo=