78811 2012-02-16 07:14:06 -0800 [Qt] Fix linking in debug builds on Mac OS X 2012-02-16 09:34:01 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf kenneth vestbo webkit.review.bot oldest_to_newest 558167 0 ahf 2012-02-16 07:14:06 -0800 SSIA. 558168 1 127374 ahf 2012-02-16 07:15:54 -0800 Created attachment 127374 Patch 558170 2 ahf 2012-02-16 07:17:00 -0800 Adding Tor Arne for review. 558173 3 ahf 2012-02-16 07:27:48 -0800 Adding Kenneth as he just came by :-) 558199 4 127374 kenneth 2012-02-16 08:10:17 -0800 Comment on attachment 127374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127374&action=review > Source/WebKit2/UIProcess/API/qt/tests/bytearraytestdata.h:36 > + virtual ~ByteArrayTestData(); why not just implement it here? 558233 5 127387 ahf 2012-02-16 08:44:01 -0800 Created attachment 127387 Patch 558266 6 webkit.review.bot 2012-02-16 09:31:52 -0800 The commit-queue encountered the following flaky tests while processing attachment 127387: perf/array-reverse.html bug 78593 (author: ojan@chromium.org) The commit-queue is continuing to process your patch. 558269 7 127387 webkit.review.bot 2012-02-16 09:33:56 -0800 Comment on attachment 127387 Patch Clearing flags on attachment: 127387 Committed r107949: <http://trac.webkit.org/changeset/107949> 558270 8 webkit.review.bot 2012-02-16 09:34:01 -0800 All reviewed patches have been landed. Closing bug. 127374 2012-02-16 07:15:54 -0800 2012-02-16 08:43:53 -0800 Patch bug-78811-20120216161552.patch text/plain 1972 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTY5YmFiYmI4NzMyYTZk OWM4NjhiZTJhYWJhMzQ2ZjI0NTYxYjhlOC4uODBlZTcwYTgxZjAzOWE2MjU0NDJhY2JiNDY3NTM3 YzZiMDE0Y2Y3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTE2ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFoZkAweDkwLmRrPgorCisgICAgICAgIFtRdF0gRml4IGxpbmtpbmcg aW4gZGVidWcgYnVpbGRzIG9uIE1hYyBPUyBYCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03ODgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0 ZGF0YS5jcHA6CisgICAgICAgIChCeXRlQXJyYXlUZXN0RGF0YTo6fkJ5dGVBcnJheVRlc3REYXRh KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL2J5dGVhcnJheXRlc3RkYXRhLmg6 CisKIDIwMTItMDItMTYgIEFkZW5pbHNvbiBDYXZhbGNhbnRpICA8Y2F2YWxjYW50aWlAZ21haWwu Y29tPgogCiAgICAgICAgIFtRdF1bV0syXSBTcGxpdCBRV2ViUGVybWlzc2lvblJlcXVlc3QgaW50 byBRV2ViU2VjdXJpdHlPcmlnaW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvdGVzdHMvYnl0ZWFycmF5dGVzdGRhdGEuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0ZGF0YS5jcHAKaW5kZXggZTBjMmMyNTZj N2IyMTA2YWZjOGYzYTAxODI5ZGUwZTRhYTE1YTgwYS4uYjgxYzA3NjEwZGRiMTJhYTlkOWQxYTlm MTkwYmIyNzMyNDYwODAxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0ZGF0YS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0ZGF0YS5jcHAKQEAgLTMxLDYgKzMxLDEw IEBAIEJ5dGVBcnJheVRlc3REYXRhOjpCeXRlQXJyYXlUZXN0RGF0YShRT2JqZWN0KiBwYXJlbnQp CiAgICAgUV9BU1NFUlQobV9sYXRpbjFEYXRhICE9IG1fdXRmOERhdGEpOwogfQogCitCeXRlQXJy YXlUZXN0RGF0YTo6fkJ5dGVBcnJheVRlc3REYXRhKCkKK3sKK30KKwogUVZhcmlhbnQgQnl0ZUFy cmF5VGVzdERhdGE6OmxhdGluMURhdGEoKSBjb25zdAogewogICAgIHJldHVybiBRVmFyaWFudCht X2xhdGluMURhdGEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC90ZXN0cy9ieXRlYXJyYXl0ZXN0ZGF0YS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0ZGF0YS5oCmluZGV4IDcxNzBmNjU5NDA2NjA1MzQxZmNi ZjFiNjUxOTM0YzcwZWIwMTQxZjYuLjdmODdlNzJkZDRhMzlkMDcwODUzYmQ3OTkxYzJlMTAwODM2 MTk1ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMv Ynl0ZWFycmF5dGVzdGRhdGEuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL2J5dGVhcnJheXRlc3RkYXRhLmgKQEAgLTMzLDYgKzMzLDcgQEAgY2xhc3MgUVdFQktJ VF9FWFBPUlQgQnl0ZUFycmF5VGVzdERhdGEgOiBwdWJsaWMgUU9iamVjdCB7CiAKIHB1YmxpYzoK ICAgICBCeXRlQXJyYXlUZXN0RGF0YShRT2JqZWN0KiBwYXJlbnQgPSAwKTsKKyAgICB2aXJ0dWFs IH5CeXRlQXJyYXlUZXN0RGF0YSgpOwogICAgIFFWYXJpYW50IGxhdGluMURhdGEoKSBjb25zdDsK ICAgICBRVmFyaWFudCB1dGY4RGF0YSgpIGNvbnN0OwogCg== 127387 2012-02-16 08:44:01 -0800 2012-02-16 09:33:56 -0800 Patch bug-78811-20120216174359.patch text/plain 1248 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTY5YmFiYmI4NzMyYTZk OWM4NjhiZTJhYWJhMzQ2ZjI0NTYxYjhlOC4uOGQ5NTg1YzViYTEzOGRmY2YzYmI3MTU1MjFjNzA2 Y2RhYTE1ZGE0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAyLTE2ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFoZkAweDkwLmRrPgorCisgICAgICAgIFtRdF0gRml4IGxpbmtpbmcg aW4gZGVidWcgYnVpbGRzIG9uIE1hYyBPUyBYCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03ODgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0 ZGF0YS5oOgorCiAyMDEyLTAyLTE2ICBBZGVuaWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2FudGlp QGdtYWlsLmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0gU3BsaXQgUVdlYlBlcm1pc3Npb25SZXF1 ZXN0IGludG8gUVdlYlNlY3VyaXR5T3JpZ2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL2J5dGVhcnJheXRlc3RkYXRhLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL2J5dGVhcnJheXRlc3RkYXRhLmgKaW5kZXggNzE3MGY2 NTk0MDY2MDUzNDFmY2JmMWI2NTE5MzRjNzBlYjAxNDFmNi4uZjc4MzhmMDcyNWUzMTNhOGNhMWFm YTI3NDRmMmYzYTQ1NDEzZDU4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC90ZXN0cy9ieXRlYXJyYXl0ZXN0ZGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvYnl0ZWFycmF5dGVzdGRhdGEuaApAQCAtMzMsNiArMzMsNyBA QCBjbGFzcyBRV0VCS0lUX0VYUE9SVCBCeXRlQXJyYXlUZXN0RGF0YSA6IHB1YmxpYyBRT2JqZWN0 IHsKIAogcHVibGljOgogICAgIEJ5dGVBcnJheVRlc3REYXRhKFFPYmplY3QqIHBhcmVudCA9IDAp OworICAgIHZpcnR1YWwgfkJ5dGVBcnJheVRlc3REYXRhKCkgeyB9CiAgICAgUVZhcmlhbnQgbGF0 aW4xRGF0YSgpIGNvbnN0OwogICAgIFFWYXJpYW50IHV0ZjhEYXRhKCkgY29uc3Q7CiAK