78773 2012-02-15 19:27:02 -0800 MediaStream API: enhance the implementaion of MediaStreamTrack::setEnabled 2012-02-21 12:10:40 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 wei.a.lin webkit-unassigned abarth tommyw webkit.review.bot oldest_to_newest 557838 0 wei.a.lin 2012-02-15 19:27:02 -0800 in current implementaion of MediaStreamTrack::setEnabled, whether or no the MediaStream is live, the track enable/disable setting operation will be called via didSetMediaStreamTrackEnabled(). Actually, if MediaStream is finished, above operation can be ignored. please notice, the status of MediaStreamTrack can be set regardless of MediaStream' status. 557849 1 127299 wei.a.lin 2012-02-15 19:44:48 -0800 Created attachment 127299 Patch add a patch for review 560561 2 abarth 2012-02-20 19:44:08 -0800 @tommyw: Thoughts on this patch? Ideally we would test this change as well. Tommy is working on a test framework for this code, which might be helpful. @lin: Please mark your patches "review?" when you'd like them reviewed. That makes the show up in all the appropriate queues. Thanks for the patch. 560726 3 tommyw 2012-02-21 00:44:50 -0800 The patch looks like a reasonable thing to do. And fyi, I'll be sending out two more patches for the test framework later today. 561023 4 127299 abarth 2012-02-21 10:51:45 -0800 Comment on attachment 127299 Patch I'm tempted to say we should hold off on this patch until the testing framework lands, but I don't want to hold your change hostage. Hopefully we'll get Tommy the necessary reviews for the testing framework shortly and we'll have it ready for your future patches. 561115 5 webkit.review.bot 2012-02-21 12:08:29 -0800 The commit-queue encountered the following flaky tests while processing attachment 127299: storage/indexeddb/index-basics.html bug 79138 (authors: dgrogan@chromium.org and jsbell@chromium.org) The commit-queue is continuing to process your patch. 561119 6 127299 webkit.review.bot 2012-02-21 12:10:36 -0800 Comment on attachment 127299 Patch Clearing flags on attachment: 127299 Committed r108383: <http://trac.webkit.org/changeset/108383> 561120 7 webkit.review.bot 2012-02-21 12:10:40 -0800 All reviewed patches have been landed. Closing bug. 127299 2012-02-15 19:44:48 -0800 2012-02-21 12:10:36 -0800 Patch MediaStreamTrack_setEnabled.patch text/plain 1361 wei.a.lin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNzg1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTE2ICBMaW4gV2Vp ICA8d2VpLmEubGluQGludGVsLmNvbT4KKworICAgICAgICBGaXggYnVnIGZyb20gcjEwNzY3Mi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NzczCisK KyAgICAgICAgQmVmb3JlIHNldCBNZWRpYVN0cmVhbVRyYWNrIGRpc2FibGUvZW5hYmxlIG9wZXJh dGlvbiwKKyAgICAgICAgY2hlY2tpbmcgdGhlIHN0YXR1cyBvZiBNZWRpYVN0cmVhbSB0aGF0IGNv bnRhaW5zIHRoaXMgTWVkaWFTdHJlYW1UcmFjay4KKyAgICAgICAgaWYgTWVkaWFTdHJlYW0gaXMg ZmluaXNoZWQsIHRoZW4gc2tpcHBpbmcgb3BlcmF0aW9uIG9mIAorICAgICAgICBkaWRTZXRNZWRp YVN0cmVhbVRyYWNrRW5hYmxlZCgpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorICAgICAgICAqIG1lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2suY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1UcmFjazo6c2V0RW5hYmxlZCk6CisKIDIwMTItMDItMTUg IE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggdGVzdCBy ZWdyZXNzb25zIGZyb20gcjEwNzY3Mi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtVHJhY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL21lZGlh c3RyZWFtL01lZGlhU3RyZWFtVHJhY2suY3BwCShyZXZpc2lvbiAxMDc4NTkpCisrKyBTb3VyY2Uv V2ViQ29yZS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmNwcAkod29ya2luZyBjb3B5KQpA QCAtODEsNiArODEsOSBAQCB2b2lkIE1lZGlhU3RyZWFtVHJhY2s6OnNldEVuYWJsZWQoYm9vbCBl CiAKICAgICBtX2NvbXBvbmVudC0+c2V0RW5hYmxlZChlbmFibGVkKTsKIAorICAgIGlmIChtX3N0 cmVhbURlc2NyaXB0b3ItPmVuZGVkKCkpCisgICAgICAgIHJldHVybjsgICAgCisKICAgICBNZWRp YVN0cmVhbUNlbnRlcjo6aW5zdGFuY2UoKS5kaWRTZXRNZWRpYVN0cmVhbVRyYWNrRW5hYmxlZCht X3N0cmVhbURlc2NyaXB0b3IuZ2V0KCksIG1fY29tcG9uZW50LmdldCgpKTsKIH0KIAo=