78562 2012-02-13 18:43:15 -0800 New flexboxes don't split into columns 2012-02-15 16:47:04 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 62048 1 ojan webkit-unassigned hyatt tony oldest_to_newest 555848 0 ojan 2012-02-13 18:43:15 -0800 RenderBlock* RenderBlock::createAnonymousBlockWithSameTypeAs(RenderBlock* otherAnonymousBlock) const { if (otherAnonymousBlock->isAnonymousColumnsBlock()) return createAnonymousColumnsBlock(); if (otherAnonymousBlock->isAnonymousColumnSpanBlock()) return createAnonymousColumnSpanBlock(); return createAnonymousBlock(otherAnonymousBlock->style()->display() == BOX); } 555850 1 ojan 2012-02-13 18:43:53 -0800 As well as: RenderBlock* RenderBlock::createAnonymousBlock(bool isFlexibleBox) const { RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyle(style()); RenderBlock* newBox = 0; if (isFlexibleBox) { newStyle->setDisplay(BOX); newBox = new (renderArena()) RenderDeprecatedFlexibleBox(document() /* anonymous box */); } else { newStyle->setDisplay(BLOCK); newBox = new (renderArena()) RenderBlock(document() /* anonymous box */); } newBox->setStyle(newStyle.release()); return newBox; } 555851 2 ojan 2012-02-13 18:45:32 -0800 And to round out the trio, RenderObject.h: bool isAnonymousBlock() const { // This function is kept in sync with anonymous block creation conditions in // RenderBlock::createAnonymousBlock(). This includes creating an anonymous // RenderBlock having a BLOCK or BOX display. Other classes such as RenderTextFragment // are not RenderBlocks and will return false. See https://bugs.webkit.org/show_bug.cgi?id=56709. return isAnonymous() && (style()->display() == BLOCK || style()->display() == BOX) && style()->styleType() == NOPSEUDO && isRenderBlock() && !isListMarker() #if ENABLE(FULLSCREEN_API) && !isRenderFullScreen() && !isRenderFullScreenPlaceholder() #endif ; } 557734 3 ojan 2012-02-15 16:47:04 -0800 We need createAnonymousBlock to create a RenderFlexibleBox when splitting flexboxes. This will get new flexboxes to match the old ones. Old flexboxes are all sorts of buggy in multi-column though.