78547 2012-02-13 16:03:47 -0800 Add a themeChromiumAndroid.css file for android-specific default styles 2012-02-16 16:47:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 eric eric abarth macpherson menard satish tkent webkit.review.bot oldest_to_newest 555706 0 eric 2012-02-13 16:03:47 -0800 Add a themeChromiumAndroid.css file for android-specific default styles 555713 1 126856 eric 2012-02-13 16:08:40 -0800 Created attachment 126856 Patch 555716 2 eric 2012-02-13 16:09:58 -0800 Tkent might be curious to see the styling of the datetime inputs, but I think this can just be a rubber-stamp review, it's very simple. 555725 3 126856 satish 2012-02-13 16:15:12 -0800 Comment on attachment 126856 Patch > static const RGBA32 defaultTapHighlightColor = 0x6633b5e5; Should this be under "#if ENABLE(TOUCH_EVENTS)" as well? 555726 4 126856 abarth 2012-02-13 16:15:23 -0800 Comment on attachment 126856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126856&action=review Ok. > Source/WebCore/rendering/RenderThemeChromiumAndroid.h:50 > private: Missing a blank line above this line. 555733 5 126856 peter 2012-02-13 16:24:06 -0800 Comment on attachment 126856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126856&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:825 > '../css/themeChromiumSkia.css', # Chromium only. nit: it seems like someone tried to align them, may be good as a drive-by to remove the extra space here. > Source/WebCore/css/themeChromiumAndroid.css:35 > +select[size][multiple] { Is this last selector necessary? It seems to me that any elements having both @size and @multiple also match one of the earlier two selectors. 555758 6 126856 tkent 2012-02-13 16:46:20 -0800 Comment on attachment 126856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126856&action=review > Source/WebCore/css/themeChromiumAndroid.css:2 > + * Copyright (C) 2009 Google Inc. All rights reserved. 2012? > Source/WebCore/css/themeChromiumAndroid.css:45 > +input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"] { > + -webkit-appearance: menulist-button; > +} I understand how they are implemented in Android and it's ok to commit this as is for now. These types inherit a text field type in WebCore/html/*InputType. We should make a better way to switch form control UI. > Source/WebCore/rendering/RenderThemeChromiumAndroid.h:45 > + virtual String extraDefaultStyleSheet(); > > virtual Color systemColor(int cssValidId) const; > > virtual void adjustInnerSpinButtonStyle(CSSStyleSelector*, RenderStyle*, Element*) const; > > + virtual bool delegatesMenuListRendering() const { return true; } > + > +#if ENABLE(TOUCH_EVENTS) > + virtual Color platformTapHighlightColor() const Should append OVERRIDE. 555761 7 eric 2012-02-13 16:48:02 -0800 Wow! Thanks for all the reviews! Will upload a new patch. 558319 8 eric 2012-02-16 10:45:02 -0800 (In reply to comment #5) > (From update of attachment 126856 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126856&action=review > > > Source/WebCore/WebCore.gyp/WebCore.gyp:825 > > '../css/themeChromiumSkia.css', # Chromium only. > > nit: it seems like someone tried to align them, may be good as a drive-by to remove the extra space here. I don't really see any alignment pattern. I can remove the extra space from the chromiumskia one, but I think I'll just leave it: '../css/themeChromium.css', # Chromium only. '../css/themeChromiumAndroid.css', # Chromium only. '../css/themeChromiumLinux.css', # Chromium only. '../css/themeChromiumSkia.css', # Chromium only. > > Source/WebCore/css/themeChromiumAndroid.css:35 > > +select[size][multiple] { > > Is this last selector necessary? It seems to me that any elements having both @size and @multiple also match one of the earlier two selectors. No clue. 558322 9 127408 eric 2012-02-16 10:47:54 -0800 Created attachment 127408 Patch for landing 558670 10 127408 webkit.review.bot 2012-02-16 16:47:11 -0800 Comment on attachment 127408 Patch for landing Clearing flags on attachment: 127408 Committed r107998: <http://trac.webkit.org/changeset/107998> 558671 11 webkit.review.bot 2012-02-16 16:47:17 -0800 All reviewed patches have been landed. Closing bug. 126856 2012-02-13 16:08:40 -0800 2012-02-16 10:47:48 -0800 Patch bug-78547-20120213160843.patch text/plain 6539 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTMwNzYyYmU4ZjJhYzJm OTYzZjMyYzEyYTZmMWRkMjZkYmQ1NTRhMS4uNWE0NWE3YWZkNDFhOWEwMjA4ODJmMzhlMWFhOWVk Y2VlMjU0YzQ4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAyLTEzICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgYSB0aGVtZUNocm9taXVt QW5kcm9pZC5jc3MgZmlsZSBmb3IgYW5kcm9pZC1zcGVjaWZpYyBkZWZhdWx0IHN0eWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGluY2x1ZGVz IHRoZSB0aGVtZUNocm9taXVtQW5kcm9pZC5jc3MgZmlsZSBmcm9tIHRoZSBDaHJvbWl1bS1BbmRy b2lkIHBvcnQKKyAgICAgICAgYXMgd2VsbCBhcyBzb21lIGFkZGlkdGlvbmFsIGNoYW5nZXMgdGhl eSBoYWQgdG8gaHRtbC5jc3MuICBJIGJlbGlldmUgdGhvc2UKKyAgICAgICAgY2hhbmdlcyB3ZXJl IG1hZGUgYmVmb3JlIHRoZW1lQ2hyb21pdW1BbmRyb2lkIHdhcyBjcmVhdGVkLCBidXQgaXQncyBu b3cgdGhlIGJldHRlciBwbGFjZSBmb3IgdGhpcyBDU1MuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5 cC9XZWJDb3JlLmd5cDoKKyAgICAgICAgKiBjc3MvdGhlbWVDaHJvbWl1bUFuZHJvaWQuY3NzOiBB ZGRlZC4KKyAgICAgICAgKHNlbGVjdFtzaXplXVttdWx0aXBsZV0pOgorICAgICAgICAoaW5wdXRb dHlwZT0iZGF0ZSJdLCBpbnB1dFt0eXBlPSJkYXRldGltZSJdLCBpbnB1dFt0eXBlPSJkYXRldGlt ZS1sb2NhbCJdLCBpbnB1dFt0eXBlPSJ0aW1lIl0sIGlucHV0W3R5cGU9Im1vbnRoIl0pOgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZDo6ZXh0cmFEZWZhdWx0U3R5bGVT aGVldCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhl bWVDaHJvbWl1bUFuZHJvaWQuaDoKKyAgICAgICAgKFJlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lk KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkOjpkZWxlZ2F0 ZXNNZW51TGlzdFJlbmRlcmluZyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9t aXVtQW5kcm9pZDo6cGxhdGZvcm1UYXBIaWdobGlnaHRDb2xvcik6CisKIDIwMTItMDItMDYgIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIENNQ2xvY2sgYXMg YSB0aW1pbmcgc291cmNlIGZvciBQbGF0Zm9ybUNsb2NrIHdoZXJlIGF2YWlsYWJsZS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggZjNkN2QyM2I1NTdkNWM1MjI4Yjc4 ZTQ1NDlhOGI1MDQ4ZjUwMzMwMy4uNWUyYmI5NTUxNzNiOTk1NDRmMmY0NjFjNmE3ODc3MWQ2NWYz NGVlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAK KysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTgyMCw2ICs4 MjAsNyBAQAogICAgICAgICAgICAgICAnLi4vY3NzL3F1aXJrcy5jc3MnLAogICAgICAgICAgICAg ICAnLi4vY3NzL3ZpZXctc291cmNlLmNzcycsCiAgICAgICAgICAgICAgICcuLi9jc3MvdGhlbWVD aHJvbWl1bS5jc3MnLCAjIENocm9taXVtIG9ubHkuCisgICAgICAgICAgICAgICcuLi9jc3MvdGhl bWVDaHJvbWl1bUFuZHJvaWQuY3NzJywgIyBDaHJvbWl1bSBvbmx5LgogICAgICAgICAgICAgICAn Li4vY3NzL3RoZW1lQ2hyb21pdW1MaW51eC5jc3MnLCAjIENocm9taXVtIG9ubHkuCiAgICAgICAg ICAgICAgICcuLi9jc3MvdGhlbWVDaHJvbWl1bVNraWEuY3NzJywgICMgQ2hyb21pdW0gb25seS4K ICAgICAgICAgICAgICAgJy4uL2Nzcy90aGVtZVdpbi5jc3MnLApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL3RoZW1lQ2hyb21pdW1BbmRyb2lkLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy90aGVtZUNocm9taXVtQW5kcm9pZC5jc3MKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzdiOGZjMGUxNTk2NjE1MTY2 YTU5Y2M4NDZkODFlYTMzNjY3MmYwYgotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy90aGVtZUNocm9taXVtQW5kcm9pZC5jc3MKQEAgLTAsMCArMSw0NSBAQAorLyoKKyAqIENv cHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAq IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorICogbWV0OgorICoKKyAqICAgICAqIFJlZGlz dHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0 CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRp c2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCBy ZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisgKiBpbiB0aGUgZG9jdW1lbnRh dGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisgKiBkaXN0cmli dXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUg bmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBw cm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNw ZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElT IFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisgKiAi QVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElT Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorICogT1dORVIgT1IgQ09O VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws CisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVE SU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdP T0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorICogVEhFT1JZ IE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1Ig VE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBB TlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKy8qIFRoZXNlIHN0 eWxlcyBvdmVycmlkZSBvdGhlciB1c2VyLWFnZW50IHN0eWxlcyBmb3IgQ2hyb21pdW0gb24gQW5k cm9pZC4gKi8KKworc2VsZWN0W3NpemVdLAorc2VsZWN0W211bHRpcGxlXSwKK3NlbGVjdFtzaXpl XVttdWx0aXBsZV0geworICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbWVudWxpc3Q7CisgICAgLXdl YmtpdC1ib3gtYWxpZ246IGNlbnRlcjsKKyAgICBib3JkZXI6IDFweCBzb2xpZDsKKyAgICAtd2Vi a2l0LWJvcmRlci1yYWRpdXM6IDVweDsKKyAgICB3aGl0ZS1zcGFjZTogcHJlOworfQorCitpbnB1 dFt0eXBlPSJkYXRlIl0sIGlucHV0W3R5cGU9ImRhdGV0aW1lIl0sIGlucHV0W3R5cGU9ImRhdGV0 aW1lLWxvY2FsIl0sIGlucHV0W3R5cGU9InRpbWUiXSwgaW5wdXRbdHlwZT0ibW9udGgiXSB7Cisg ICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBtZW51bGlzdC1idXR0b247Cit9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcApp bmRleCBjNDVmYzIwODYwMjdjNmFjZTA3YzkzMWQ0YzgwNTI1Nzc4YWIxYjNmLi44OGFjM2E4ZDZj MTk0NmI0ZWNjZjc5MWQ2YzE2ZDU1Mjk2OTZjMzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHAKQEAgLTYzLDYg KzYzLDEyIEBAIENvbG9yIFJlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkOjpzeXN0ZW1Db2xvcihp bnQgY3NzVmFsdWVJZCkgY29uc3QKICAgICByZXR1cm4gUmVuZGVyVGhlbWU6OnN5c3RlbUNvbG9y KGNzc1ZhbHVlSWQpOwogfQogCitTdHJpbmcgUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQ6OmV4 dHJhRGVmYXVsdFN0eWxlU2hlZXQoKQoreworICAgIHJldHVybiBSZW5kZXJUaGVtZUNocm9taXVt TGludXg6OmV4dHJhRGVmYXVsdFN0eWxlU2hlZXQoKSArCisgICAgICAgIFN0cmluZyh0aGVtZUNo cm9taXVtQW5kcm9pZFVzZXJBZ2VudFN0eWxlU2hlZXQsIHNpemVvZih0aGVtZUNocm9taXVtQW5k cm9pZFVzZXJBZ2VudFN0eWxlU2hlZXQpKTsKK30KKwogdm9pZCBSZW5kZXJUaGVtZUNocm9taXVt QW5kcm9pZDo6YWRqdXN0SW5uZXJTcGluQnV0dG9uU3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJl bmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0CiB7CiAgICAgaWYgKFBsYXRmb3JtU3Vw cG9ydDo6bGF5b3V0VGVzdE1vZGUoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQuaAppbmRleCBlN2I5ZDk4ODUxYjg5NmQz MzgwYjEyMWFiMmFhZGNmNWVkMGE0N2ExLi5mNWQ5NWVmYjYxMmM2NzdmMjkyNjU4ZWY1YWJkMzM4 OTE4ZTQ5YzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVDaHJvbWl1bUFuZHJvaWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bUFuZHJvaWQuaApAQCAtMzMsMTQgKzMzLDI0IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIGNsYXNzIFJlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkIDogcHVibGljIFJlbmRlclRo ZW1lQ2hyb21pdW1MaW51eCB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8UmVuZGVy VGhlbWU+IGNyZWF0ZSgpOworICAgIHZpcnR1YWwgU3RyaW5nIGV4dHJhRGVmYXVsdFN0eWxlU2hl ZXQoKTsKIAogICAgIHZpcnR1YWwgQ29sb3Igc3lzdGVtQ29sb3IoaW50IGNzc1ZhbGlkSWQpIGNv bnN0OwogCiAgICAgdmlydHVhbCB2b2lkIGFkanVzdElubmVyU3BpbkJ1dHRvblN0eWxlKENTU1N0 eWxlU2VsZWN0b3IqLCBSZW5kZXJTdHlsZSosIEVsZW1lbnQqKSBjb25zdDsKIAorICAgIHZpcnR1 YWwgYm9vbCBkZWxlZ2F0ZXNNZW51TGlzdFJlbmRlcmluZygpIGNvbnN0IHsgcmV0dXJuIHRydWU7 IH0KKworI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCisgICAgdmlydHVhbCBDb2xvciBwbGF0Zm9y bVRhcEhpZ2hsaWdodENvbG9yKCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiBSZW5kZXJU aGVtZUNocm9taXVtQW5kcm9pZDo6ZGVmYXVsdFRhcEhpZ2hsaWdodENvbG9yOworICAgIH0KKyNl bmRpZgogcHJpdmF0ZToKICAgICB2aXJ0dWFsIH5SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZCgp OwogCisgICAgc3RhdGljIGNvbnN0IFJHQkEzMiBkZWZhdWx0VGFwSGlnaGxpZ2h0Q29sb3IgPSAw eDY2MzNiNWU1OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 127408 2012-02-16 10:47:54 -0800 2012-02-16 16:47:11 -0800 Patch for landing bug-78547-20120216104753.patch text/plain 6731 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTMwNzYyYmU4ZjJhYzJm OTYzZjMyYzEyYTZmMWRkMjZkYmQ1NTRhMS4uZTFhZjcyYTdmOGVmM2RiOTAwMWVkYjJiMzU1NzJj Nzc5ODc1ZTc0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAyLTEzICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgYSB0aGVtZUNocm9taXVt QW5kcm9pZC5jc3MgZmlsZSBmb3IgYW5kcm9pZC1zcGVjaWZpYyBkZWZhdWx0IHN0eWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIFRoaXMgaW5jbHVkZXMgdGhl IHRoZW1lQ2hyb21pdW1BbmRyb2lkLmNzcyBmaWxlIGZyb20gdGhlIENocm9taXVtLUFuZHJvaWQg cG9ydAorICAgICAgICBhcyB3ZWxsIGFzIHNvbWUgYWRkaWR0aW9uYWwgY2hhbmdlcyB0aGV5IGhh ZCB0byBodG1sLmNzcy4gIEkgYmVsaWV2ZSB0aG9zZQorICAgICAgICBjaGFuZ2VzIHdlcmUgbWFk ZSBiZWZvcmUgdGhlbWVDaHJvbWl1bUFuZHJvaWQgd2FzIGNyZWF0ZWQsIGJ1dCBpdCdzIG5vdyB0 aGUgYmV0dGVyIHBsYWNlIGZvciB0aGlzIENTUy4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwL1dl YkNvcmUuZ3lwOgorICAgICAgICAqIGNzcy90aGVtZUNocm9taXVtQW5kcm9pZC5jc3M6IEFkZGVk LgorICAgICAgICAoc2VsZWN0W3NpemVdW211bHRpcGxlXSk6CisgICAgICAgIChpbnB1dFt0eXBl PSJkYXRlIl0sIGlucHV0W3R5cGU9ImRhdGV0aW1lIl0sIGlucHV0W3R5cGU9ImRhdGV0aW1lLWxv Y2FsIl0sIGlucHV0W3R5cGU9InRpbWUiXSwgaW5wdXRbdHlwZT0ibW9udGgiXSk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkOjpleHRyYURlZmF1bHRTdHlsZVNoZWV0 KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNo cm9taXVtQW5kcm9pZC5oOgorICAgICAgICAoUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQpOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQ6OmRlbGVnYXRlc01l bnVMaXN0UmVuZGVyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1B bmRyb2lkOjpwbGF0Zm9ybVRhcEhpZ2hsaWdodENvbG9yKToKKwogMjAxMi0wMi0wNiAgSmVyIE5v YmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgQ01DbG9jayBhcyBhIHRp bWluZyBzb3VyY2UgZm9yIFBsYXRmb3JtQ2xvY2sgd2hlcmUgYXZhaWxhYmxlLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBmM2Q3ZDIzYjU1N2Q1YzUyMjhiNzhlNDU0 OWE4YjUwNDhmNTAzMzAzLi41ZTJiYjk1NTE3M2I5OTU0NGYyZjQ2MWM2YTc4NzcxZDY1ZjM0ZWU3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtODIwLDYgKzgyMCw3 IEBACiAgICAgICAgICAgICAgICcuLi9jc3MvcXVpcmtzLmNzcycsCiAgICAgICAgICAgICAgICcu Li9jc3Mvdmlldy1zb3VyY2UuY3NzJywKICAgICAgICAgICAgICAgJy4uL2Nzcy90aGVtZUNocm9t aXVtLmNzcycsICMgQ2hyb21pdW0gb25seS4KKyAgICAgICAgICAgICAgJy4uL2Nzcy90aGVtZUNo cm9taXVtQW5kcm9pZC5jc3MnLCAjIENocm9taXVtIG9ubHkuCiAgICAgICAgICAgICAgICcuLi9j c3MvdGhlbWVDaHJvbWl1bUxpbnV4LmNzcycsICMgQ2hyb21pdW0gb25seS4KICAgICAgICAgICAg ICAgJy4uL2Nzcy90aGVtZUNocm9taXVtU2tpYS5jc3MnLCAgIyBDaHJvbWl1bSBvbmx5LgogICAg ICAgICAgICAgICAnLi4vY3NzL3RoZW1lV2luLmNzcycsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvdGhlbWVDaHJvbWl1bUFuZHJvaWQuY3NzIGIvU291cmNlL1dlYkNvcmUvY3NzL3Ro ZW1lQ2hyb21pdW1BbmRyb2lkLmNzcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zNDZkODM2YWYyNzBhNzMxNTk0YWYz MGY5OWUzMGFhMjRhYmI3ZmJjCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L3RoZW1lQ2hyb21pdW1BbmRyb2lkLmNzcwpAQCAtMCwwICsxLDQ1IEBACisvKgorICogQ29weXJp Z2h0IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6CisgKgorICogICAgICogUmVkaXN0cmli dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAq IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lci4KKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJv ZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0aW9u IGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlv bi4KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1l cyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21v dGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lm aWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAqICJBUyBJ UyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQg Tk9UCisgKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJ TElUWSBBTkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJ TUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBDT05UUklC VVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyAq IFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcs IEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMg T1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5F U1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVPUlkgT0Yg TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU CisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBX QVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworLyogVGhlc2Ugc3R5bGVz IG92ZXJyaWRlIG90aGVyIHVzZXItYWdlbnQgc3R5bGVzIGZvciBDaHJvbWl1bSBvbiBBbmRyb2lk LiAqLworCitzZWxlY3Rbc2l6ZV0sCitzZWxlY3RbbXVsdGlwbGVdLAorc2VsZWN0W3NpemVdW211 bHRpcGxlXSB7CisgICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBtZW51bGlzdDsKKyAgICAtd2Via2l0 LWJveC1hbGlnbjogY2VudGVyOworICAgIGJvcmRlcjogMXB4IHNvbGlkOworICAgIC13ZWJraXQt Ym9yZGVyLXJhZGl1czogNXB4OworICAgIHdoaXRlLXNwYWNlOiBwcmU7Cit9CisKK2lucHV0W3R5 cGU9ImRhdGUiXSwgaW5wdXRbdHlwZT0iZGF0ZXRpbWUiXSwgaW5wdXRbdHlwZT0iZGF0ZXRpbWUt bG9jYWwiXSwgaW5wdXRbdHlwZT0idGltZSJdLCBpbnB1dFt0eXBlPSJtb250aCJdIHsKKyAgICAt d2Via2l0LWFwcGVhcmFuY2U6IG1lbnVsaXN0LWJ1dHRvbjsKK30KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQuY3BwCmluZGV4 IGM0NWZjMjA4NjAyN2M2YWNlMDdjOTMxZDRjODA1MjU3NzhhYjFiM2YuLjg4YWMzYThkNmMxOTQ2 YjRlY2NmNzkxZDZjMTZkNTUyOTY5NmMzOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcApAQCAtNjMsNiArNjMs MTIgQEAgQ29sb3IgUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQ6OnN5c3RlbUNvbG9yKGludCBj c3NWYWx1ZUlkKSBjb25zdAogICAgIHJldHVybiBSZW5kZXJUaGVtZTo6c3lzdGVtQ29sb3IoY3Nz VmFsdWVJZCk7CiB9CiAKK1N0cmluZyBSZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZDo6ZXh0cmFE ZWZhdWx0U3R5bGVTaGVldCgpCit7CisgICAgcmV0dXJuIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51 eDo6ZXh0cmFEZWZhdWx0U3R5bGVTaGVldCgpICsKKyAgICAgICAgU3RyaW5nKHRoZW1lQ2hyb21p dW1BbmRyb2lkVXNlckFnZW50U3R5bGVTaGVldCwgc2l6ZW9mKHRoZW1lQ2hyb21pdW1BbmRyb2lk VXNlckFnZW50U3R5bGVTaGVldCkpOworfQorCiB2b2lkIFJlbmRlclRoZW1lQ2hyb21pdW1BbmRy b2lkOjphZGp1c3RJbm5lclNwaW5CdXR0b25TdHlsZShDU1NTdHlsZVNlbGVjdG9yKiwgUmVuZGVy U3R5bGUqIHN0eWxlLCBFbGVtZW50KikgY29uc3QKIHsKICAgICBpZiAoUGxhdGZvcm1TdXBwb3J0 OjpsYXlvdXRUZXN0TW9kZSgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5oCmluZGV4IGU3YjlkOTg4NTFiODk2ZDMzODBi MTIxYWIyYWFkY2Y1ZWQwYTQ3YTEuLjVmYjEyYmMwMmU2M2MxNmE0MTg0MTYxM2U5MDBjMmUyODJh OGZlNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNo cm9taXVtQW5kcm9pZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZUNocm9taXVtQW5kcm9pZC5oCkBAIC0zMywxNCArMzMsMjUgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogY2xhc3MgUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQgOiBwdWJsaWMgUmVuZGVyVGhlbWVD aHJvbWl1bUxpbnV4IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxSZW5kZXJUaGVt ZT4gY3JlYXRlKCk7CisgICAgdmlydHVhbCBTdHJpbmcgZXh0cmFEZWZhdWx0U3R5bGVTaGVldCgp IE9WRVJSSURFOwogCi0gICAgdmlydHVhbCBDb2xvciBzeXN0ZW1Db2xvcihpbnQgY3NzVmFsaWRJ ZCkgY29uc3Q7CisgICAgdmlydHVhbCBDb2xvciBzeXN0ZW1Db2xvcihpbnQgY3NzVmFsaWRJZCkg Y29uc3QgT1ZFUlJJREU7CiAKLSAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0SW5uZXJTcGluQnV0dG9u U3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJlbmRlclN0eWxlKiwgRWxlbWVudCopIGNvbnN0Owor ICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RJbm5lclNwaW5CdXR0b25TdHlsZShDU1NTdHlsZVNlbGVj dG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50KikgY29uc3QgT1ZFUlJJREU7CisKKyAgICB2aXJ0 dWFsIGJvb2wgZGVsZWdhdGVzTWVudUxpc3RSZW5kZXJpbmcoKSBjb25zdCBPVkVSUklERSB7IHJl dHVybiB0cnVlOyB9CisKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQorICAgIHZpcnR1YWwgQ29s b3IgcGxhdGZvcm1UYXBIaWdobGlnaHRDb2xvcigpIGNvbnN0IE9WRVJSSURFCisgICAgeworICAg ICAgICByZXR1cm4gUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQ6OmRlZmF1bHRUYXBIaWdobGln aHRDb2xvcjsKKyAgICB9CisjZW5kaWYKIAogcHJpdmF0ZToKICAgICB2aXJ0dWFsIH5SZW5kZXJU aGVtZUNocm9taXVtQW5kcm9pZCgpOwogCisgICAgc3RhdGljIGNvbnN0IFJHQkEzMiBkZWZhdWx0 VGFwSGlnaGxpZ2h0Q29sb3IgPSAweDY2MzNiNWU1OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQo=