78499 2012-02-13 08:13:06 -0800 FKA: The auto-generated label in a <details> element without a <summary> is not keyboard accessible 2023-09-12 06:06:14 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED http://mathiasbynens.be/demo/html5-details-jquery InRadar P2 Normal --- 252223 1 mathias rniwa arko faulkner.steve jcraig jonlee mathias mike morrita shinyak webkit-bug-importer oldest_to_newest 555269 0 mathias 2012-02-13 08:13:06 -0800 Minimal test case: data:text/html;charset=utf-8,<!DOCTYPE html><title>Test</title><details>foo</details> (Note that this is invalid markup: http://bugzilla.validator.nu/show_bug.cgi?id=896) The spec is here: http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#the-details-element > The first `summary` element child of the element, if any, represents the summary or legend of the details. If there is no child `summary` element, the user agent should provide its own legend (e.g. "Details"). It seems to me that this legend should be keyboard accessible, just like a <summary>. 555277 1 mathias 2012-02-13 08:25:02 -0800 When clicking the label once, it will get a focus outline, and from then on Space or Enter can be used to toggle the <details> element’s contents. So the only thing that doesn’t work (it seems) is tabbing to the label. 555290 2 faulkner.steve 2012-02-13 08:38:14 -0800 seems like a summary element is added to the shadow dom even when not added by an author. 555324 3 webkit-bug-importer 2012-02-13 09:24:27 -0800 <rdar://problem/10853057> 556049 4 mathias 2012-02-14 00:24:36 -0800 FWIW, I recently proposed changing the behavior so that instead of a text label, an actual <summary> element would automatically be inserted. This would make it easier to polyfill this behavior, and possibly to implement the whole thing in a browser. Hixie said the following: https://www.w3.org/Bugs/Public/show_bug.cgi?id=15455#c3 > You're not allowed to omit the <summary>, so IMHO it doesn't really matter what > happens when you omit it so long as it's the same everywhere. Sounds like he could be convinced to change this if it would make things easier for browser makers. (I may be wrong, but it seems like the proposed behavior would’ve avoided this bug. Feel free to ignore this comment if it’s irrelevant.) 580470 5 arko 2012-03-16 06:47:40 -0700 If user forgot to add <summary> element as a child of <details> element, in such case a <summary> element is added to the shadow dom of <details>. All descendant elements in a shadow root are skipped if the host node of the shadow root is not focusable. Here <details> is non-focusable. So pressing tab does not transfer the focus to the focusable <summary> element in the shadow root. We need to override the supportsFocus() and focus() method in HTMLDetailsElement. So that it can transfer the focus to the focusable <summary> element in the shadow root on pressing tab to <details> element. 580472 6 132273 arko 2012-03-16 06:48:26 -0700 Created attachment 132273 Proposed patch 581726 7 132273 morrita 2012-03-19 03:38:55 -0700 Comment on attachment 132273 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132273&action=review This doesn't looks like right direction. We shouldn't take the auto-generate summary as a special case if possible. > Source/WebCore/html/HTMLDetailsElement.h:45 > + virtual void focus(bool restorePreviousSelection = true) OVERRIDE; Please don't give the default value on derived class. It can cause hard-to-find error. 581728 8 morrita 2012-03-19 03:40:26 -0700 HI Shinya, Could you explain how auto-generated summary work? I think there is some trick in its implementation. It would be great if you have a Wiki page entry for that. 1976817 9 rniwa 2023-09-11 07:15:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/17651 1977044 10 ews-feeder 2023-09-12 06:06:11 -0700 Committed 267899@main (2115ac47e427): <https://commits.webkit.org/267899@main> Reviewed commits have been landed. Closing PR #17651 and removing active labels. 132273 2012-03-16 06:48:26 -0700 2012-03-19 03:38:55 -0700 Proposed patch patch_78499.diff text/plain 4971 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTAwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTE2ICBBcmtvIFNh aGEgIDxhcmtvQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBUaGUgYXV0by1nZW5lcmF0ZWQgbGFi ZWwgaW4gYSA8ZGV0YWlscz4gZWxlbWVudCB3aXRob3V0IGEgPHN1bW1hcnk+IGlzIG5vdCBrZXli b2FyZCBhY2Nlc3NpYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Nzg0OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUZXN0OiBmYXN0L2h0bWwvZGV0YWlscy1uby1zdW1tYXJ5LWtleWJvYXJkLXNob3ct aGlkZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxEZXRhaWxzRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRGV0YWlsc0VsZW1lbnQ6OnN1cHBvcnRzRm9jdXMpOgorICAgICAg ICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRGV0YWlsc0VsZW1lbnQ6OmZvY3Vz KToKKyAgICAgICAgKiBodG1sL0hUTUxEZXRhaWxzRWxlbWVudC5oOgorICAgICAgICAoSFRNTERl dGFpbHNFbGVtZW50KToKKwogMjAxMi0wMy0xNiAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBBZGQgYXNzZXJ0cyBhbmQgaW1wcm92ZSBsb2dnaW5nIGluIFBh Z2VDYWNoZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERldGFpbHNFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEZXRhaWxzRWxlbWVudC5j cHAJKHJldmlzaW9uIDExMTAwMCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERldGFpbHNF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU3LDYgKzE1NywxNyBAQCB2b2lkIEhUTUxE ZXRhaWxzRWxlbWVudDo6dG9nZ2xlT3BlbigpCiAgICAgc2V0QXR0cmlidXRlKG9wZW5BdHRyLCBt X2lzT3BlbiA/IG51bGxBdG9tIDogZW1wdHlBdG9tKTsKIH0KIAorYm9vbCBIVE1MRGV0YWlsc0Vs ZW1lbnQ6OnN1cHBvcnRzRm9jdXMoKSBjb25zdAoreworICAgIHJldHVybiB0cnVlOworfQorCit2 b2lkIEhUTUxEZXRhaWxzRWxlbWVudDo6Zm9jdXMoYm9vbCkKK3sKKyAgICBpZiAoRWxlbWVudCog c3VtbWFyeSA9IGZpbmRNYWluU3VtbWFyeSgpKQorICAgICAgICBzdW1tYXJ5LT5mb2N1cygpOwor fQorCiB9CiAKICNlbmRpZgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGV0YWlsc0Vs ZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEZXRhaWxzRWxl bWVudC5oCShyZXZpc2lvbiAxMTEwMDApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEZXRh aWxzRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0MSw5IEBAIHByaXZhdGU6CiAK ICAgICB2b2lkIGNyZWF0ZVNoYWRvd1N1YnRyZWUoKTsKIAorICAgIHZpcnR1YWwgYm9vbCBzdXBw b3J0c0ZvY3VzKCkgY29uc3QgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGZvY3VzKGJvb2wg cmVzdG9yZVByZXZpb3VzU2VsZWN0aW9uID0gdHJ1ZSkgT1ZFUlJJREU7CisKICAgICBib29sIG1f aXNPcGVuOwogCiB9OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTExMDAxKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDMtMTYgIEFy a28gU2FoYSAgPGFya29AbW90b3JvbGEuY29tPgorCisgICAgICAgIFRoZSBhdXRvLWdlbmVyYXRl ZCBsYWJlbCBpbiBhIDxkZXRhaWxzPiBlbGVtZW50IHdpdGhvdXQgYSA8c3VtbWFyeT4gaXMgbm90 IGtleWJvYXJkIGFjY2Vzc2libGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03ODQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZmFzdC9odG1sL2RldGFpbHMtbm8tc3VtbWFyeS1rZXlib2FyZC1zaG93 LWhpZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2h0bWwvZGV0YWlscy1u by1zdW1tYXJ5LWtleWJvYXJkLXNob3ctaGlkZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wMy0xNiAg WW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10g bGFiZWwuZm9ybSBhdHRyaWJ1dGUgZG9lc24ndCB3b3JrCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2h0bWwvZGV0YWlscy1uby1zdW1tYXJ5LWtleWJvYXJkLXNob3ctaGlkZS1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9odG1sL2RldGFpbHMtbm8tc3VtbWFyeS1r ZXlib2FyZC1zaG93LWhpZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9odG1sL2RldGFpbHMtbm8tc3VtbWFyeS1rZXlib2FyZC1zaG93LWhpZGUtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE2IEBACitUaGlzIHRlc3QgdmVyaWZpZXMg dGhhdCBhdXRvLWdlbmVyYXRlZCA8c3VtbWFyeT4gaW4gYSA8ZGV0YWlscz4gZWxlbWVudCBpcyBr ZXlib2FyZCBhY2Nlc3NpYmxlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFT UyBvcGVuQXR0cmlidXRlKCJkZXRhaWxzIikgaXMgZmFsc2UKK1RvZ2dsZSA8ZGlzcGxheT4gdXNp bmcgRW50ZXIga2V5OgorUEFTUyBvcGVuQXR0cmlidXRlKCJkZXRhaWxzIikgaXMgdHJ1ZQorUEFT UyBvcGVuQXR0cmlidXRlKCJkZXRhaWxzIikgaXMgZmFsc2UKK1RvZ2dsZSA8ZGlzcGxheT4gdXNp bmcgU3BhY2ViYXIga2V5OgorUEFTUyBvcGVuQXR0cmlidXRlKCJkZXRhaWxzIikgaXMgdHJ1ZQor UEFTUyBvcGVuQXR0cmlidXRlKCJkZXRhaWxzIikgaXMgZmFsc2UKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2h0bWwvZGV0YWlscy1uby1zdW1tYXJ5LWtleWJvYXJkLXNob3ctaGlkZS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaHRtbC9kZXRhaWxzLW5vLXN1bW1hcnkta2V5Ym9hcmQt c2hvdy1oaWRlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2h0bWwvZGV0 YWlscy1uby1zdW1tYXJ5LWtleWJvYXJkLXNob3ctaGlkZS5odG1sCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDM4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4u L2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKwor PGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2 PgorPGRldGFpbHMgaWQ9ImRldGFpbHMiPjxpbnB1dD48L2RldGFpbHM+Cis8c2NyaXB0PgorICAg IGZ1bmN0aW9uIG9wZW5BdHRyaWJ1dGUoaWQpIHsKKyAgICAgICAgcmV0dXJuIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKGlkKS5vcGVuOworICAgIH0KKworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRl c3QgdmVyaWZpZXMgdGhhdCBhdXRvLWdlbmVyYXRlZCAmbHQ7c3VtbWFyeSZndDsgaW4gYSAmbHQ7 ZGV0YWlscyZndDsgZWxlbWVudCBpcyBrZXlib2FyZCBhY2Nlc3NpYmxlLiIpOworCisgICAgaWYg KHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJcdCIp OworCisgICAgICAgIHNob3VsZEJlRmFsc2UoJ29wZW5BdHRyaWJ1dGUoImRldGFpbHMiKScpOwor ICAgICAgICBkZWJ1ZygiVG9nZ2xlICZsdDtkaXNwbGF5Jmd0OyB1c2luZyBFbnRlciBrZXk6Iik7 CisgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIlxyIik7CisgICAgICAgIHNob3VsZEJlVHJ1 ZSgnb3BlbkF0dHJpYnV0ZSgiZGV0YWlscyIpJyk7CisgICAgICAgIGV2ZW50U2VuZGVyLmtleURv d24oIlxyIik7CisgICAgICAgIHNob3VsZEJlRmFsc2UoJ29wZW5BdHRyaWJ1dGUoImRldGFpbHMi KScpOworCisgICAgICAgIGRlYnVnKCJUb2dnbGUgJmx0O2Rpc3BsYXkmZ3Q7IHVzaW5nIFNwYWNl YmFyIGtleToiKTsKKyAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bigiICIpOworICAgICAgICBz aG91bGRCZVRydWUoJ29wZW5BdHRyaWJ1dGUoImRldGFpbHMiKScpOworICAgICAgICBldmVudFNl bmRlci5rZXlEb3duKCIgIik7CisgICAgICAgIHNob3VsZEJlRmFsc2UoJ29wZW5BdHRyaWJ1dGUo ImRldGFpbHMiKScpOworICAgIH0gZWxzZSB7CisgICAgICAgIGRlYnVnKCdUaGVyZSBhcmUgdGVz dHMgdXNpbmcgZXZlbnRTZW5kZXIuJyk7CisgICAgfQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K