78358 2012-02-10 06:57:07 -0800 REGRESSION (Safari 5.0.5 - 5.1): Link is not colored as visited if default port number is present 2017-03-16 12:45:51 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All NEW http://spe.mobilephone.net/wit/xhtmlv2/linkanchor.xhtml InRadar, Regression P3 Major --- 1 webkitlearner webkit-unassigned ap beidson eric janten ojan.autocc webkitlearner webkit.review.bot oldest_to_newest 554062 0 webkitlearner 2012-02-10 06:57:07 -0800 Hi, 1.go to this URL: http://spe.mobilephone.net/wit/xhtmlv2/linkanchor.xhtml 2.click on the http, port 80, https, port 443 links. 3.After the clicking the link another page will be opened. 4.click back button and check the particular link now. 5.link color(before clicking the link it is blue) is not changed to visited color(after clicking the link and come back and see.Link color will be changed to another color as per the default css defined.It will not be blue in color). Thanks, webkitlearner. 554166 1 ap 2012-02-10 10:23:50 -0800 Eric, this sounds like fallout from the change in bug 54090. Could you take a look? <a href="http://www.slowpokeproductions.com:80/wit/%77ittarget1b.xhtml">http, port 80</a><br/> <a href="https://www.slowpokeproductions.com:443/wit/%77ittarget1b.xhtml">https, port 443</a><br/> 554192 2 eric 2012-02-10 10:40:15 -0800 I would not be surprised were this the case. I don't understand the reproduction. I assume I need to use Safari to test? 554230 3 ap 2012-02-10 11:14:38 -0800 Yes, this works in Chrome. To reproduce, 1. Open http://spe.mobilephone.net/wit/xhtmlv2/linkanchor.xhtml 2. Click on "http, port 80" link in the middle of the page. 3. Go back. Expected: it's highlighted as visited. Actual: it's not. 554336 4 eric 2012-02-10 13:16:45 -0800 I can verify that this is borked in Safari 5.1. Chrome, as noted, works fine. 554344 5 eric 2012-02-10 13:26:44 -0800 It's unclear to me why clicking on the :80 link would not mark the non :80 one as visited. It seems the visited subsystem should use canonical urls. From a user's perspective, the links are identical. 554347 6 eric 2012-02-10 13:31:37 -0800 I'm happy to advise someone in fixing this, but I don't plan on working on this any time soon. We can also just roll out bug 54090. 575512 7 131171 webkitlearner 2012-03-10 06:34:53 -0800 Created attachment 131171 It has the modified and original files , if you check the difference between this two files you can get the patch of 78358 bug Hi, When you click on the link <a xmlns="http://www.w3.org/1999/xhtml" href="http://www.slowpokeproductions.com:80/wit/%77ittarget1b.xhtml">http, port 80</a> The KURL object is created for the above link and the url is being parsed and the default port numbers is being removed and the link is loaded and the same link is being stored in the Hashtable. When you press the back button in the HTMLAnchorElement.h the following api inline LinkHash HTMLAnchorElement::visitedLinkHash() const is being called which inturn calls WebCore::visitedLinkHash; to which we are passing the base URL and the AtomicString of fastGetAttribute(HTMLNames::hrefAttr). So the url has the default ports and this url is being checked in the hashmap , as it is not stored we are getting the link unvisted and showing blue color. So we need to send the same type of URL(without ports) for the LinkHash to check for the url visted or not. So i have the proposed patch where you create the KURL object from the fastGetAttribute(HTMLNames::hrefAttr) and convert it in to AtomicString from the KURL object and send it which solves the issue. 575672 8 webkit.review.bot 2012-03-11 01:46:36 -0800 Attachment 131171 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 575796 9 131171 ap 2012-03-11 10:58:56 -0700 Comment on attachment 131171 It has the modified and original files , if you check the difference between this two files you can get the patch of 78358 bug The attachment is a RAR archive. Would you be willing to contribute a patch, as described in <http://www.webkit.org/coding/contributing.html>? 577499 10 webkitlearner 2012-03-13 10:27:14 -0700 Hi, Original API inline LinkHash HTMLAnchorElement::visitedLinkHash() const { if (!m_cachedVisitedLinkHash) m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), fastGetAttribute(HTMLNames::hrefAttr)); return m_cachedVisitedLinkHash; } Modified API inline LinkHash HTMLAnchorElement::visitedLinkHash() const { if (!m_cachedVisitedLinkHash) m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), AtomicString(document()->completeURL(fastGetAttribute(HTMLNames::hrefAttr).string()).string().utf8().data())); return m_cachedVisitedLinkHash; } Not able to download the webkit code as the server is slow , to submit the patch currently im working on nightly build code. Kindly let me know any other way to submit the patch. ~Webkit Learner 588852 11 134054 webkitlearner 2012-03-27 07:07:48 -0700 Created attachment 134054 Proposed patch 588853 12 webkitlearner 2012-03-27 07:09:46 -0700 Hi, I have attached the proposed patch kindly review it and let me know the reviews on the proposed patch. ~Webkit Learner 589031 13 eric 2012-03-27 10:40:36 -0700 The patch may be correct, but won't apply since it wasn' created from teh root of the repository (as our patch tools will automatically do for you). See http://www.webkit.org/coding/contributing.html Create the patch The easiest way to create a patch is to run Tools/Scripts/webkit-patch upload. This will upload your current Subversion diff (or Git diff if you use git) to the issue tracking system and mark it as ready for review. 603327 14 137375 webkitlearner 2012-04-16 12:21:37 -0700 Created attachment 137375 proposed patch kindly check the patch and give your feedback on it 603333 15 ap 2012-04-16 12:31:38 -0700 Please do follow guidelines at <http://www.webkit.org/coding/contributing.html>. Patches need to come with regression tests, ChangeLogs, and should be marked r? to properly appear in review queue. 603363 16 137385 webkitlearner 2012-04-16 12:59:07 -0700 Created attachment 137385 Patch 603366 17 webkit.review.bot 2012-04-16 13:02:38 -0700 Attachment 137385 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/html/HTMLAnchorElement.h:152: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 603767 18 137473 webkitlearner 2012-04-16 21:13:52 -0700 Created attachment 137473 Patch 603768 19 137473 eric 2012-04-16 21:18:01 -0700 Comment on attachment 137473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137473&action=review > Source/WebCore/html/HTMLAnchorElement.h:152 > + KURL vistedURL = document()->completeURL(fastGetAttribute(HTMLNames::hrefAttr).string()); > + m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), AtomicString(vistedURL.string().utf8().data())); All these conversions make no sense. :) You're converting from an AtomicString, to a STring, to a KURL, then to a STring, CSTring, and char* only to go back to an AtomicSTring! :p 603812 20 webkitlearner 2012-04-16 22:47:46 -0700 Dear Eric, The conversion of AtomicString, To a STring , to a KURL is the key which solved this issue else you need to remove the defaultportscheme api and calling this api in the KURL.cpp When you click the URL you get "http://www.slowpokeproductions.com:80/wit/%77ittarget1b.xhtml" and this URL is sent to check the VistedLinkHash. In the VistedLinkHash link is stored as http://www.slowpokeproductions.com/wit/%77ittarget1b.xhtml,because after parsing the URL, which is done in the KURL.cpp :80 is removed and this URL is stored in the VistedLinkHash .When you click back you are checking "http://www.slowpokeproductions.com:80/wit/%77ittarget1b.xhtml" is present in the VistedLinkHash or not.So for that reason you need to parse the AtomicString.If you start parsing the AtomicString you end up writing another KURL.cpp file. For this purpose i have given the url to document->completeURL() which returns me the parsed URL.to give the url to document->completeURL() i strin String.Thats why i converted AtomicString to STring. I got the parsed KURL object.but i need to send the AtomicString to visitedLinkHash api. There is no constructor in AtomicString which accepts the KURL object.As i found constructor which accepts char* in AtomicString, So i converted KURL to STring,CString and char* and created AtomicString which is parsed and doesnot have :80 in the URL. Kindly check this solution once again or suggest me better way to achieve this. ~webkitlearner (In reply to comment #19) > (From update of attachment 137473 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137473&action=review > > > Source/WebCore/html/HTMLAnchorElement.h:152 > > + KURL vistedURL = document()->completeURL(fastGetAttribute(HTMLNames::hrefAttr).string()); > > + m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), AtomicString(vistedURL.string().utf8().data())); > > All these conversions make no sense. :) You're converting from an AtomicString, to a STring, to a KURL, then to a STring, CSTring, and char* only to go back to an AtomicSTring! :p 615916 21 beidson 2012-05-03 20:04:57 -0700 <rdar://problem/11368052> 795452 22 180344 webkitlearner 2012-12-20 08:10:28 -0800 Created attachment 180344 Patch 795473 23 180344 beidson 2012-12-20 08:54:29 -0800 Comment on attachment 180344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180344&action=review > Source/WebCore/ChangeLog:8 > + Link is not colored as visited if default port number is present > + https://bugs.webkit.org/show_bug.cgi?id=78358 > + > + > + Not reviewed. > + Weird extra white space. Also, we normally leave the "Reviewed by NOBODY (OOPS!)" in patches until they are reviewed. > Source/WebCore/ChangeLog:11 > + Trying to get the KURL of the url which we got from fastGetAttribute and getting the AtmoicString of the KURL by adding AtomicString API in KURL class. > + The URL we are getting from fastGetAttribute returns the url with port number, as we have added an api in the KURL class which deletes the port number > + when parsed, in the same way we have to give the parsed URL to vistedlinkHased so that the URL will be marked as visted. This description is verbose and confusing. This fix is small; A sentence would suffice. > Source/WebCore/ChangeLog:14 > + > + No new tests (OOPS!). > + This is a deal breaker... a change like this needs tests. This has already been mentioned before. Please stop submitting patches without tests. > Source/WebCore/html/HTMLAnchorElement.h:155 > + if (!m_cachedVisitedLinkHash) { > + KURL vistedURL = document()->completeURL(fastGetAttribute(HTMLNames::hrefAttr).string()); > + m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), vistedURL.getAtomicString()); > + } All you are doing here is jumping through a lot of hoops with various string classes to try and preserve the :80 on this one link so in case the :80 form is visited it would show as purple. Many Webkit-embedding user agents strip default ports in their requests. e.g. clicking a link to "http://webkit.org:80/" takes you to "http://webkit.org/" So "visiting" webkit.org:80 doesn't enter webkit.org:80 into the visited link hashes, it just adds webkit.org. Did you bother to try in, say, Safari? As originally reported, I assumed this bug was about the equivalence of http://webkit.org/ and http://webkit.org:80/ and how if you visit one, the other should also appear visited. This is what Firefox does, for example, and what I think we should do. Instead of jumping through these hopes to preserve :80 in the hash, what we should be doing is realizing that :80 is the default port and drop it. > Source/WebCore/platform/KURL.cpp:594 > +AtomicString KURL::getAtomicString() const > +{ > + return AtomicString(string()); > +} > + We are not going to add this. I think you misunderstand how all the string classes relate. 1288677 24 ap 2017-03-16 12:45:51 -0700 *** Bug 169738 has been marked as a duplicate of this bug. *** 131171 2012-03-10 06:34:53 -0800 2012-03-11 10:58:56 -0700 It has the modified and original files , if you check the difference between this two files you can get the patch of 78358 bug 78358.rar application/binary 4032 webkitlearner UmFyIRoHAM+QcwAADQAAAAAAAADah3QgkEkATgcAAG4UAAACYBATXFiaakAdMyQAIAAAAGNoYW5n ZXNcbW9kaWZpZWRcSFRNTEFuY2hvckVsZW1lbnQuaADwaudfEB2QzI0RfJnZftw6KXNyqlBKMIBk 5WzYZuVpDAkKwhDQJM2fKUxiBuoxoptOeipU53tta2SDbTdpNs9TDcz75WUCFfl3aV+pXOmL/hKt K7Xiur8/NPoHi4ZguEVYmXzYVxqFFNrThUv29wVpJhkX2XIss8fef6/jvwjoEYxzjmHtZztVcpVX 4kV8FWSkA0j07w3p0fcFeVyEXF0JNM5El3R81Pbnsvpt8gc1+s8/zyNz+ze6RiauXKsMVldOg6g5 sgfCGwNkbHgPDQBDnRV9SBUSyuBiGDzEGrE+B+jJMRfF4B1BeZGhJm+A2whz0weBor3Km3eLDxQG nQEFz04vM+203BmhFUfA+NjIYowiPxz2+sVqNQc413qSgMuNYDZpnPnpTeOBIyD78p9xl+OEWDzQ c2D8LvN8dpAUCRVSLwLDVAuhfQlMMhtCpyK6NIT3fAXNfcfoLoJlObzg5sZlZ5Bsey3LBtPbYDVV 25UMIHWVEin7X4qg1LA72jU4mlp50EAwX3s3+jq674qtvtddW7dz9/tqZtP2IBUZtIkUrkymrBMh 1c2C5fMOdnQPTXu1ugDKrzWbRiM0B0Gxn7de9e/zqumUFcMlfs1uu1nnV13bnVer0BCvDHI2c6El 21Zu4gSmT33RhGVKERmRgHaD6GQ5KtArDFBOD8H3qhBOJISYQ2/7vMkUJ0Y8hF8aO7CLqNYqGhj5 XiNznK3Vc7bNvnoQ18wdGsmgXIWe/Vh+wBCHQ+9gEnojazv/qQAkl+80a75igMBB2FcQLqxALDQh zXMRkpzHpqio06VKj8aXyo0nd13qsffuKZM+D8wi/gE6L/TaqmZUf1XgjyQol7lHrAgZ4eYwOHhW afCL9DloyFBT9G820nnZ19606e/oSZUPuzFzl8qSbz/ceCsd0Po8nFxCOEBxqyO6CwKlyPxeDwSM ECOOAsWf66a/LCYZUmQ66PKUdnD4mH4tHb5qIB3JMRQ/o5MegPnmsgvQ6JP/rsYiqsEksCYOK9z9 xUfKi3VKftCGE1AgoZE5im2DQSCsC9pzX4235iQkQS9+ZuRt6/kjkazmKVFt7CrDJRbK6puB0Z/K Jx+NsLIQV+Tj8jYWktC5ctBE4MUnzmKbY2zcbaR48xEsEWJ46wfkb3rhHTiGwwNjWSFKi2Nx8vhs rmnKiLw0ggVcxxtmrhHgS111yOFfSx+ycVKi2XXlE21NuvWpMmJvkZZ25xhcsVnxMWpOEEicW5yo ZgyVIoALgIAGY3CsfPaQ30EmxDyUc36kTaPscM6p+cdphNIbv+Wkjc4gsRnobcE8WqkUJLwVYKAM X/9pEzZAX267toShlcTwicmLhngRXCFYgvQcjErapSZIHwqeqr4+CQ+lCQj0pNKNQG9qCxoypuFO ci5WwoZDoKzrnyci5/a/E9k+QV3qCypFUb8XHE56ykY3HQLhyO+OmCFI+BbcH0hXeoJlEtkugL0R Pen0EKuPPy71ChRqm7A+BCLRsGOAkEweTi0Fgo9rGVKhBEE0s1p7i/Kn3F0Wk5bnJxOzzY5dHxJc 4CQVkPBbhk/cowR6QuVZ8JWaySYelvs2jH0Fk7k5Umeh/UF6wgndINMCMVAnblx/MmzRxjKGCiOq WP0yzdGl9oursr3btn616h10rB+8nLrH6GmstZTw7s2AUrOx3jVDwp9IeAUaAyWBYe+FfYfm6YGM OkbJs1/BHSZU7R04PJCk0sVAboDAdf0xNjM5QaD4KqZQgrmoXCSNYNvKw0Hu5Rt5Qw+D7Rlls/Ko N+iY2T8xOiYFXKfUbpHb0LtmdLdlCovLt43LGAxAbxUngvDhWiVksLkkhfTjGWXBB7YnQAHAjwgb xxeFhLHj13X6sj7/bgKpmOHk9engBwTqeREqQfudqmCiHI1gtmd+lyqCyPP6jav+eU/pzkueaWi/ eLC+vKB7VQbdP3ALbL24CM1ot711riGlbjk068GiGFFPcYPMpVRResBLvrjT6dLJQ95BmLdXmtV5 vTZrXer61b9WdKunCevJ2H9o99FOaJAakvkrFrZ1jPWpQTza+SY0ZNFYmEfBqzj/AHYQLRNxjoac ImIXC13mKd8se4HW9EMfVEzz6k8V5eu5d/HP5FnO1ECm8aTH5CDnatcvJ3Hrm/jHgeWClU1T3xbi SC85eWFaLFD7j4YcnnhZAD8qMQLI0heabCG4rlVEef12Ah9QZtVyOXl3FlCZ6TP+BCtN/7uE/O0R 57uyXHjrbajwx2JzWfH6YHgGE3jqn63l51gaZD43xUB8QYL3OMummdoyajTn8/RyE6gzHex06aD6 8XIH0FxhIN+OBd+BWmF900QUz1RlJWGl04nE5oDJOwyZ9IxED4YEkhqYhxNUfLNVoDDOpvdnObAw EdYSuGT6wD/g/8LniuicjTP5GE6VcIUt0QN80GJSbgMfkOxTc1Ke2yV1LzM8WtOEKH1bZ2oq5sdp RQMK/RiX6bTcz1Fm1tZ4MyOfc5SV/gdf2nyqdCCQSQAvBwAAKhQAAAIXTdovmp5qQB0zJAAgAAAA Y2hhbmdlc1xvcmlnaW5hbFxIVE1MQW5jaG9yRWxlbWVudC5oAPCVv20MHVEMjRPNnVe88KvdxKII jCAZmrZkM3FrhgSCwhDQJM2dUTGWDajHYm7cmCxTfdtWtkg27ZV22z5MNzO/VqmMuuVVXdfTxmv4 Rcu6q6ulXPz+HgHJxzBcYqpMmVlbEqUU2rOFS+HqCspstC+jBF13z8D/5/PhgHQIzinHMPSzvUmC lWgiRbxWaKQDSP54BvTo+oK6tjIwLpTbaxpsPD4q+nPSvlu9gd1+88/95XI+Dm6RiUsmRcYrDClB 5B3ZA/QGyNobPiPBQBDnRV5WFUS619nRBlEH1hgBBRomEvk+A6gspGxKG+A2wB30wd9sr/LG3fLB yQmnQENz84cp+NtxGaEVWAEA2cZijCI/HRa7BWY1B0DYfpOEy23fNmoc+flR84UjIQPyH5GoI4BX 8qDmufpd1zj1ICgTKsRiFYawF0L7QUy0HEKnIro0hPe8Jc2Bx/AvAmQ5vODuxmV30Gz6VvWDavWw mrMOQqYQPMqplP6vyWBqV97tmpwtrzzoIBgvrYvdPX2XhJWu55pXLmfvd1TNqCxAKjNpEilseQ1Y JkPLmwYLlDvZ0D1VrlXpAyS57FkxGZB4Gvn7Va7d/7ruGUFbMlesVeyznnl2XLfXdrUBCujHI2c6 El21Zu4QSmP13hgGVPQI1IwDuB9DQdlXhV0RQzg/CB6wQTiTEoENv/7zJFCdGPoRjEj2wi6zWKho Y+14Tc5yr12+6xa6KGivnDw1g0DBCz4KswWAIQ6H4MAk9EbWd/akAJNjwNGxAYoDAQddbCC6rwi6 KEOa5yNFOY9SQqNOlSo+2l7qNJ7dl1KP33JMmeyCYRfwidN7qspGZVg1Whjx6ES96r9gQM8PMYHD 4rtwBF+py0ZCgr+rmbSb7tbPNZePh0ptKn5ZjBy+RNR9/qO/VO6H7vpycgjhAcauj2gr6xccEXw8 UzBAjjgK9j++qtzaDDKkxnXR5Sjs4gEzBFs7fNZAPZNmKH9HZj0B883jF9zok//XIxCS4SSwpg4r 1P4FR+1FyaU/cEMqKhBQ0J3FNwGwkFZF6Rmv73H5yaCIZfDM3K49b7I7Gu7ilRceusy0UW2uqbod OfyCdf3uBYCCv7OvyuBZT0rl20MToxSfO4puDaNxupH35iJXIuTy2A/K5vZCPHCNlkbOwkKVFwbc BfHbXNOVEXRphAq7j3uGtgHfT2V1yuleTxelO1SouF2ZBONTcnzqTJikBGmt2cYXNFZ8UFrThBIn FycyGYNFTKAC2CABmNsrPx3EN8hKM6OSjm/MijZ+DjnVPzjtQJpDd/02mbnCFiM9Dbini10ihJeK zJQBi/zcRM2QF9Oy5ZEqZXC+InYi6Z4kWwBWIL0nIxK1IpMcL4VPVmMXFIfShIR6UmpGoDekhY0a V3inORdnaUMh0FZ13xORd+tnqe2fIK8FBZEyquelt1Ku/gjO88BbOR4R0yQpIAL7w+kK8FBNIlsl 0BdiJ8E+hhWxZ+XeoUKNU3aHwoRfG0Y3yQzBicWQsFHtYypUIIgmlmtv8X3U+8um0nLd5OJ2+7HL o/klzgJBWgwLcEn7lGCPyFyrPhKzVTUDJb7dwx+4sfepKkz0P6gvPQCd0g1AIxUCd2XH8ybNHWMg aKI0ix5Ms3T8wNF19ta5csfOtUOulof305tg/Q01pvIeHdquCla2vca4fQn1BgCjQGTvrj4Qr6Dy vGFjBqGycNbxR4mVO0eODEhTbXKgN0hoOwaZmxmcoNB8CShQgrmoXCaPsG3lZbDO5Rx5A0+D8Rll 8/KoOCig2j9xOiYVXZgUbpHr0LtqdLelCovLt43rGA1AbpU3wuj0LRKyWFySQwJxDLLggzYngAG+ jBA4Di8DKeLFsuv15H4O2wVTUcPJ69PEDgnk+iJUg/c7XMFUORqhbM8NTlUFkY/qOK9lyHyc5Lnm pov1i0vrqoZqoNun7wFul7UJGa0XN57FxDUtxyfOzBohhRT3GDzKJIovVwl32Rp/nUyUM8gzFpLn s1pvVYq3Ov5pXkp0q6cJ68fafNHvIpzRIDWl8lYtbGwZ7FKCebX7KDRs0VSYB8WvOP7AdhCtE3GO hpxiZ0OFrPsU75Y+QPN6YY+uJnnzJ5MS9dy5+OfyLOdrIFR802fyEHO165ePvPXN/GPAxYKVTXPf JxSQXnLywrTYogcfTDkx4WgA+6jECxtoXmqwhvK5VRGP69AQ+sM3K5HNzbyyhMikXCFmb+m8UU7T Htv7J0euzuqbBHYqNf7flffAYTfvKeFPs3XQMuqlZp2SDBHx2DkJ0b03sVtljfMAFM80bJ1dthSJ ouZBsFYJN6UYiB/GRJoYeIcTEICzVqAw3Zbvb0TqBgI6oFYNjlkHdB/8PPkwiYTVNxGE6lsAUc0P X54eyk3gY/YdqkxrUstsrrXVZ4tiX4Wj1fb4oqxMdlBUNGvTp16rK8zzFm1ubvsyObM5SV39v9TR VnTgkDUAAAAAAAAAAAACAAAAAGWeakAUMBAAEAAAAGNoYW5nZXNcbW9kaWZpZWQAsETLjyySdOCQ NQAAAAAAAAAAAAIAAAAAkp5qQBQwEAAQAAAAY2hhbmdlc1xvcmlnaW5hbACwjUY3BOJ04JAsAAAA AAAAAAAAAgAAAACWnmpAFDAHABAAAABjaGFuZ2VzALAJRwfEPXsAQAcA 134054 2012-03-27 07:07:48 -0700 2012-04-16 12:58:31 -0700 Proposed patch Bug 78358.patch text/plain 658 webkitlearner SW5kZXg6IEhUTUxBbmNob3JFbGVtZW50LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBIVE1MQW5jaG9yRWxl bWVudC5oCShyZXZpc2lvbiAxMTIyNTkpDQorKysgSFRNTEFuY2hvckVsZW1lbnQuaAkod29ya2lu ZyBjb3B5KQ0KQEAgLTE0OCw3ICsxNDgsNyBAQA0KIGlubGluZSBMaW5rSGFzaCBIVE1MQW5jaG9y RWxlbWVudDo6dmlzaXRlZExpbmtIYXNoKCkgY29uc3QKIHsKICAgICBpZiAoIW1fY2FjaGVkVmlz aXRlZExpbmtIYXNoKQotICAgICAgICBtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaCA9IFdlYkNvcmU6 OnZpc2l0ZWRMaW5rSGFzaChkb2N1bWVudCgpLT5iYXNlVVJMKCksIGZhc3RHZXRBdHRyaWJ1dGUo SFRNTE5hbWVzOjpocmVmQXR0cikpOworICAgICAgICBtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaCA9 IFdlYkNvcmU6OnZpc2l0ZWRMaW5rSGFzaChkb2N1bWVudCgpLT5iYXNlVVJMKCksQXRvbWljU3Ry aW5nKGRvY3VtZW50KCktPmNvbXBsZXRlVVJMKGZhc3RHZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpo cmVmQXR0cikuc3RyaW5nKCkpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCkpKTsKICAgICByZXR1cm4g bV9jYWNoZWRWaXNpdGVkTGlua0hhc2g7IAogfQogCg== 137375 2012-04-16 12:21:37 -0700 2012-04-16 12:58:44 -0700 proposed patch 78358.patch text/plain 723 webkitlearner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmgJKHJldmlzaW9uIDEx NDIwOSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTQ4LDcgKzE0OCw3IEBAIHByaXZhdGU6CiBpbmxpbmUgTGlua0hhc2ggSFRN TEFuY2hvckVsZW1lbnQ6OnZpc2l0ZWRMaW5rSGFzaCgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX2Nh Y2hlZFZpc2l0ZWRMaW5rSGFzaCkKLSAgICAgICAgbV9jYWNoZWRWaXNpdGVkTGlua0hhc2ggPSBX ZWJDb3JlOjp2aXNpdGVkTGlua0hhc2goZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCBmYXN0R2V0QXR0 cmlidXRlKEhUTUxOYW1lczo6aHJlZkF0dHIpKTsKKyAgICAgICAgbV9jYWNoZWRWaXNpdGVkTGlu a0hhc2ggPSBXZWJDb3JlOjp2aXNpdGVkTGlua0hhc2goZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCBB dG9taWNTdHJpbmcoZG9jdW1lbnQoKS0+Y29tcGxldGVVUkwoZmFzdEdldEF0dHJpYnV0ZShIVE1M TmFtZXM6OmhyZWZBdHRyKS5zdHJpbmcoKSkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSkpOwogICAg IHJldHVybiBtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaDsgCiB9CiAK 137385 2012-04-16 12:59:07 -0700 2012-04-16 21:13:39 -0700 Patch bug-78358-20120417012905.patch text/plain 1468 webkitlearner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDI4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTE2ICBXZWJraXQg TGVhcm5lciAgPHdlYmtpdGxlYXJuZXJAZ21haWwuY29tPgorCisgICAgICAgIExpbmsgaXMgbm90 IGNvbG9yZWQgYXMgdmlzaXRlZCBpZiBkZWZhdWx0IHBvcnQgbnVtYmVyIGlzIHByZXNlbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzU4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdGVzdGNhc2UgOiBo dHRwOi8vc3BlLm1vYmlsZXBob25lLm5ldC93aXQveGh0bWx2Mi9saW5rYW5jaG9yLnhodG1sCisK KyAgICAgICAgKiBodG1sL0hUTUxBbmNob3JFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpI VE1MQW5jaG9yRWxlbWVudDo6dmlzaXRlZExpbmtIYXNoKToKKwogMjAxMi0wNC0xNiAgTHVpeiBB Z29zdGluaSAgPGx1aXouYWdvc3RpbmlAcGFsbS5jb20+CiAKICAgICAgICAgbWF0Y2hNZWRpYSgp IE1lZGlhUXVlcnlMaXN0IG5vdCB1cGRhdGluZwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQW5jaG9yRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEFuY2hvckVsZW1lbnQuaAkocmV2aXNpb24gMTE0MjA5KQorKysgU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MQW5jaG9yRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsNyArMTQ4LDggQEAg cHJpdmF0ZToKIGlubGluZSBMaW5rSGFzaCBIVE1MQW5jaG9yRWxlbWVudDo6dmlzaXRlZExpbmtI YXNoKCkgY29uc3QKIHsKICAgICBpZiAoIW1fY2FjaGVkVmlzaXRlZExpbmtIYXNoKQotICAgICAg ICBtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaCA9IFdlYkNvcmU6OnZpc2l0ZWRMaW5rSGFzaChkb2N1 bWVudCgpLT5iYXNlVVJMKCksIGZhc3RHZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0cikp OworICAgICAgICBtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaCA9IFdlYkNvcmU6OnZpc2l0ZWRMaW5r SGFzaChkb2N1bWVudCgpLT5iYXNlVVJMKCksIAorCQkgICAgICAgICAgICAgICAgICAgICAgICAg ICAgQXRvbWljU3RyaW5nKGRvY3VtZW50KCktPmNvbXBsZXRlVVJMKGZhc3RHZXRBdHRyaWJ1dGUo SFRNTE5hbWVzOjpocmVmQXR0cikuc3RyaW5nKCkpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCkpKTsK ICAgICByZXR1cm4gbV9jYWNoZWRWaXNpdGVkTGlua0hhc2g7IAogfQogCg== 137473 2012-04-16 21:13:52 -0700 2012-12-20 08:10:17 -0800 Patch bug-78358-20120417094349.patch text/plain 1520 webkitlearner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDI4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTE2ICBXZWJraXQg TGVhcm5lciAgPHdlYmtpdGxlYXJuZXJAZ21haWwuY29tPgorCisgICAgICAgIExpbmsgaXMgbm90 IGNvbG9yZWQgYXMgdmlzaXRlZCBpZiBkZWZhdWx0IHBvcnQgbnVtYmVyIGlzIHByZXNlbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzU4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdGVzdGNhc2UgOiBo dHRwOi8vc3BlLm1vYmlsZXBob25lLm5ldC93aXQveGh0bWx2Mi9saW5rYW5jaG9yLnhodG1sCisK KyAgICAgICAgKiBodG1sL0hUTUxBbmNob3JFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpI VE1MQW5jaG9yRWxlbWVudDo6dmlzaXRlZExpbmtIYXNoKToKKwogMjAxMi0wNC0xNiAgTHVpeiBB Z29zdGluaSAgPGx1aXouYWdvc3RpbmlAcGFsbS5jb20+CiAKICAgICAgICAgbWF0Y2hNZWRpYSgp IE1lZGlhUXVlcnlMaXN0IG5vdCB1cGRhdGluZwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQW5jaG9yRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEFuY2hvckVsZW1lbnQuaAkocmV2aXNpb24gMTE0MjA5KQorKysgU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MQW5jaG9yRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcsOCArMTQ3LDEwIEBA IHByaXZhdGU6CiAKIGlubGluZSBMaW5rSGFzaCBIVE1MQW5jaG9yRWxlbWVudDo6dmlzaXRlZExp bmtIYXNoKCkgY29uc3QKIHsKLSAgICBpZiAoIW1fY2FjaGVkVmlzaXRlZExpbmtIYXNoKQotICAg ICAgICBtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaCA9IFdlYkNvcmU6OnZpc2l0ZWRMaW5rSGFzaChk b2N1bWVudCgpLT5iYXNlVVJMKCksIGZhc3RHZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0 cikpOworICAgIGlmICghbV9jYWNoZWRWaXNpdGVkTGlua0hhc2gpIHsKKyAgICAgICAgS1VSTCB2 aXN0ZWRVUkwgPSBkb2N1bWVudCgpLT5jb21wbGV0ZVVSTChmYXN0R2V0QXR0cmlidXRlKEhUTUxO YW1lczo6aHJlZkF0dHIpLnN0cmluZygpKTsKKyAgICAgICAgbV9jYWNoZWRWaXNpdGVkTGlua0hh c2ggPSBXZWJDb3JlOjp2aXNpdGVkTGlua0hhc2goZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCBBdG9t aWNTdHJpbmcodmlzdGVkVVJMLnN0cmluZygpLnV0ZjgoKS5kYXRhKCkpKTsKKyAgICB9CiAgICAg cmV0dXJuIG1fY2FjaGVkVmlzaXRlZExpbmtIYXNoOyAKIH0KIAo= 180344 2012-12-20 08:10:28 -0800 2012-12-20 08:54:28 -0800 Patch bug-78358-20121220213745.patch text/plain 3114 webkitlearner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzc5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTE1ICBXZWJraXQg TGVhcm5lciAgPHdlYmtpdGxlYXJuZXJAZ21haWwuY29tPgorCisgICAgICAgIExpbmsgaXMgbm90 IGNvbG9yZWQgYXMgdmlzaXRlZCBpZiBkZWZhdWx0IHBvcnQgbnVtYmVyIGlzIHByZXNlbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzU4CisgICAg ICAgIAorCisgICAgICAgIE5vdCByZXZpZXdlZC4KKworICAgICAgICBUcnlpbmcgdG8gZ2V0IHRo ZSBLVVJMIG9mIHRoZSB1cmwgd2hpY2ggd2UgZ290IGZyb20gZmFzdEdldEF0dHJpYnV0ZSBhbmQg Z2V0dGluZyB0aGUgQXRtb2ljU3RyaW5nIG9mIHRoZSBLVVJMIGJ5IGFkZGluZyBBdG9taWNTdHJp bmcgQVBJIGluIEtVUkwgY2xhc3MuCisgICAgICAgIFRoZSBVUkwgd2UgYXJlIGdldHRpbmcgZnJv bSBmYXN0R2V0QXR0cmlidXRlIHJldHVybnMgdGhlIHVybCB3aXRoIHBvcnQgbnVtYmVyLCBhcyB3 ZSBoYXZlIGFkZGVkIGFuIGFwaSBpbiB0aGUgS1VSTCBjbGFzcyB3aGljaCBkZWxldGVzIHRoZSBw b3J0IG51bWJlcgorICAgICAgICB3aGVuIHBhcnNlZCwgaW4gdGhlIHNhbWUgd2F5IHdlIGhhdmUg dG8gZ2l2ZSB0aGUgcGFyc2VkIFVSTCB0byB2aXN0ZWRsaW5rSGFzZWQgc28gdGhhdCB0aGUgVVJM IHdpbGwgYmUgbWFya2VkIGFzIHZpc3RlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMh KS4KKworICAgICAgICAqIGh0bWwvSFRNTEFuY2hvckVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxBbmNob3JFbGVtZW50Ojp2aXNpdGVkTGlua0hhc2gpOgorICAgICAgICAqIHBsYXRm b3JtL0tVUkwuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL0tVUkwuaDoKKwogMjAxMi0xMi0xNSAg TWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmUtbGFuZGluZyBwYXRj aCBmb3IgIkludHJvZHVjaW5nIHRoZSBEYXRhYmFzZVN0cmF0ZWd5IGFuZCBkYXRhYmFzZSBzZXJ2 ZXJzIi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmgJKHJldmlz aW9uIDEzNzc5NikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaAko d29ya2luZyBjb3B5KQpAQCAtMTQ5LDggKzE0OSwxMCBAQCBwcml2YXRlOgogCiBpbmxpbmUgTGlu a0hhc2ggSFRNTEFuY2hvckVsZW1lbnQ6OnZpc2l0ZWRMaW5rSGFzaCgpIGNvbnN0CiB7Ci0gICAg aWYgKCFtX2NhY2hlZFZpc2l0ZWRMaW5rSGFzaCkKLSAgICAgICAgbV9jYWNoZWRWaXNpdGVkTGlu a0hhc2ggPSBXZWJDb3JlOjp2aXNpdGVkTGlua0hhc2goZG9jdW1lbnQoKS0+YmFzZVVSTCgpLCBm YXN0R2V0QXR0cmlidXRlKEhUTUxOYW1lczo6aHJlZkF0dHIpKTsKKyAgICBpZiAoIW1fY2FjaGVk VmlzaXRlZExpbmtIYXNoKSB7CisgICAgICAgIEtVUkwgdmlzdGVkVVJMID0gZG9jdW1lbnQoKS0+ Y29tcGxldGVVUkwoZmFzdEdldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmhyZWZBdHRyKS5zdHJpbmco KSk7CisgICAgICAgIG1fY2FjaGVkVmlzaXRlZExpbmtIYXNoID0gV2ViQ29yZTo6dmlzaXRlZExp bmtIYXNoKGRvY3VtZW50KCktPmJhc2VVUkwoKSwgdmlzdGVkVVJMLmdldEF0b21pY1N0cmluZygp KTsKKyAgICB9CiAgICAgcmV0dXJuIG1fY2FjaGVkVmlzaXRlZExpbmtIYXNoOyAKIH0KIApJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAJKHJldmlzaW9uIDEzNzc5NikKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01ODcsNiArNTg3LDEx IEBAIFN0cmluZyBLVVJMOjpsYXN0UGF0aENvbXBvbmVudCgpIGNvbnN0CiAgICAgcmV0dXJuIG1f c3RyaW5nLnN1YnN0cmluZyhzdGFydCwgZW5kIC0gc3RhcnQgKyAxKTsKIH0KIAorQXRvbWljU3Ry aW5nIEtVUkw6OmdldEF0b21pY1N0cmluZygpIGNvbnN0Cit7CisgICAgcmV0dXJuIEF0b21pY1N0 cmluZyhzdHJpbmcoKSk7Cit9CisKIFN0cmluZyBLVVJMOjpwcm90b2NvbCgpIGNvbnN0CiB7CiAg ICAgcmV0dXJuIG1fc3RyaW5nLmxlZnQobV9zY2hlbWVFbmQpOwpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vS1VSTC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L0tVUkwuaAkocmV2aXNpb24gMTM3Nzk2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VS TC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiS1VSTFdURlVS TEltcGwuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFw Lmg+CisjaW5jbHVkZSA8d3RmL3RleHQvQXRvbWljU3RyaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3Rl eHQvV1RGU3RyaW5nLmg+CiAKICNpZiBVU0UoQ0YpCkBAIC0xMjksNyArMTMwLDcgQEAgcHVibGlj OgogI2Vsc2UKICAgICBjb25zdCBTdHJpbmcmIHN0cmluZygpIGNvbnN0IHsgcmV0dXJuIG1fc3Ry aW5nOyB9CiAjZW5kaWYKLQorICAgIEF0b21pY1N0cmluZyBnZXRBdG9taWNTdHJpbmcoKSBjb25z dDsKICAgICBTdHJpbmcgcHJvdG9jb2woKSBjb25zdDsKICAgICBTdHJpbmcgaG9zdCgpIGNvbnN0 OwogICAgIHVuc2lnbmVkIHNob3J0IHBvcnQoKSBjb25zdDsK