78325 2012-02-09 21:30:48 -0800 CSS3 calc: update font-size test to use pre/post js 2012-02-10 12:08:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 16662 1 mikelawther mikelawther webkit.review.bot oldest_to_newest 553802 0 mikelawther 2012-02-09 21:30:48 -0800 CSS3 calc: update font-size test to use pre/post js 553803 1 126448 mikelawther 2012-02-09 21:31:27 -0800 Created attachment 126448 Patch 554178 2 126448 ojan 2012-02-10 10:30:34 -0800 Comment on attachment 126448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126448&action=review > LayoutTests/css3/calc/font-size.html:22 > + shouldBeEqualToString('getComputedStyle(document.getElementById("' + spans[i].id + '"), null).fontSize', getComputedStyle(document.getElementById("control"), null).fontSize); In future tests, you could make this more readable by creating a helper function: function fontSize(id) { return getComputedStyle(document.getElementById("' + id + '"), null).fontSize; } 554273 3 126448 webkit.review.bot 2012-02-10 12:08:13 -0800 Comment on attachment 126448 Patch Clearing flags on attachment: 126448 Committed r107425: <http://trac.webkit.org/changeset/107425> 554274 4 webkit.review.bot 2012-02-10 12:08:17 -0800 All reviewed patches have been landed. Closing bug. 126448 2012-02-09 21:31:27 -0800 2012-02-10 12:08:13 -0800 Patch bug-78325-20120210163125.patch text/plain 3940 mikelawther U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MzQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjk1OWU1ZWJiMmJhNjJjMjkzZTQ0 ODY3MGVhYThiNDY3NmVmYjkyNS4uYmI3ODQ5MWZhY2I0ZTdjMzkzZDIyNmJlMWYzZGRjNmEwNTE1 MzRlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTA5ICBNaWtlIExhd3RoZXIgIDxt aWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ1NTMyBjYWxjOiB1cGRhdGUgZm9u dC1zaXplIHRlc3QgdG8gdXNlIHByZS9wb3N0IGpzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODMyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogY3NzMy9jYWxjL2ZvbnQtc2l6ZS1leHBlY3RlZC50eHQ6 CisgICAgICAgICogY3NzMy9jYWxjL2ZvbnQtc2l6ZS5odG1sOgorCiAyMDEyLTAyLTA5ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBV bnJldmlld2VkIGV4cGVjdGF0aW9uIGZvbGxvd3VwIGZvciByMTA3MzI5CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9jc3MzL2NhbGMvZm9udC1zaXplLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2NzczMvY2FsYy9mb250LXNpemUtZXhwZWN0ZWQudHh0CmluZGV4IDI1MzUxODA2YWY2YzBhZmMy NmY3OWNlMjk2YmIzNzAyYmRiYjMwZWUuLjU5NWJkMDZlYmUwOGFiYzUxNWM3Yzc0YzliOGI2YmUw ZTVlMzc0M2EgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NzczMvY2FsYy9mb250LXNpemUtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2NzczMvY2FsYy9mb250LXNpemUtZXhwZWN0ZWQu dHh0CkBAIC0xLDUgKzEsMTEgQEAKLVRoZSBmb250IHNpemUgb2YgdGhlc2UgbGluZXMgc2hvdWxk IGJlIGlkZW50aWNhbCAKLVRoZSBmb250IHNpemUgb2YgdGhlc2UgbGluZXMgc2hvdWxkIGJlIGlk ZW50aWNhbCAKLVRoZSBmb250IHNpemUgb2YgdGhlc2UgbGluZXMgc2hvdWxkIGJlIGlkZW50aWNh bAotRkFJTAotQ29tcHV0ZWQgZm9udCBzaXplcyBkbyBub3QgbWF0Y2gKK1Rlc3RzIHRoYXQgQ1NT MyBjYWxjKCkgY2FuIGJlIHVzZWQgd2l0aCB0aGUgZm9udC1zaXplIHByb3BlcnR5CisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitGQUlMIGdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImNhbGMtcGVyY2VudCIpLCBudWxsKS5mb250U2l6ZSBzaG91bGQgYmUg NDBweC4gV2FzIDIwcHguCitGQUlMIGdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImNhbGMtcGVyY2VudC1waXhlbHMiKSwgbnVsbCkuZm9udFNpemUgc2hvdWxkIGJlIDQw cHguIFdhcyAyMHB4LgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvY2FsYy9mb250LXNpemUuaHRt bCBiL0xheW91dFRlc3RzL2NzczMvY2FsYy9mb250LXNpemUuaHRtbAppbmRleCA5MjhmZmY0YThk ZWY3MTE5MzM5ZDk2NGM5NWE1MDdiZGNmZDEwZjFhLi41ZmExNWIxNjQwZGM2NzUwMGFkZWU0MjNh Y2ZhMDE5Y2M4NDZhNzU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2NhbGMvZm9udC1z aXplLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9jYWxjL2ZvbnQtc2l6ZS5odG1sCkBAIC0x LDQwICsxLDI4IEBACis8IURPQ1RZUEUgSFRNTD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiA8c3R5bGU+IAogI2NvbnRyb2wg e2ZvbnQtc2l6ZTogMjAwJTt9CiAjY2FsYy1wZXJjZW50IHtmb250LXNpemU6IC13ZWJraXQtY2Fs YygyMDAlKTt9CiAjY2FsYy1wZXJjZW50LXBpeGVscyB7Zm9udC1zaXplOiAtd2Via2l0LWNhbGMo MTUwJSArIDEwcHgpO30KIDwvc3R5bGU+CiAKLTxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogMjBweDsi PgorPGRpdiBpZD0idGVzdC1jb250YWluZXIiIHN0eWxlPSJmb250LXNpemU6IDIwcHg7Ij4KIDxz cGFuIGlkPSJjb250cm9sIj5UaGUgZm9udCBzaXplIG9mIHRoZXNlIGxpbmVzIHNob3VsZCBiZSBp ZGVudGljYWw8L3NwYW4+CiA8YnIvPgotPHNwYW4gaWQ9ImNhbGMtcGVyY2VudCI+VGhlIGZvbnQg c2l6ZSBvZiB0aGVzZSBsaW5lcyBzaG91bGQgYmUgaWRlbnRpY2FsPC9zcGFuPgorPHNwYW4gY2xh c3M9ImZvbnR0ZXN0IiBpZD0iY2FsYy1wZXJjZW50Ij5UaGUgZm9udCBzaXplIG9mIHRoZXNlIGxp bmVzIHNob3VsZCBiZSBpZGVudGljYWw8L3NwYW4+CiA8YnIvPgotPHNwYW4gaWQ9ImNhbGMtcGVy Y2VudC1waXhlbHMiPlRoZSBmb250IHNpemUgb2YgdGhlc2UgbGluZXMgc2hvdWxkIGJlIGlkZW50 aWNhbDwvc3Bhbj4KLTxoci8+Cis8c3BhbiBjbGFzcz0iZm9udHRlc3QiIGlkPSJjYWxjLXBlcmNl bnQtcGl4ZWxzIj5UaGUgZm9udCBzaXplIG9mIHRoZXNlIGxpbmVzIHNob3VsZCBiZSBpZGVudGlj YWw8L3NwYW4+CiA8L2Rpdj4KLTxkaXYgaWQ9InJlc3VsdHMiPjwvZGl2PgogCiA8c2NyaXB0Pgot aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7Ci12YXIgY29udHJvbFNpemUgPSAgZ2V0Q29tcHV0ZWRTdHlsZShkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiY29udHJvbCIpLCBudWxsKS5mb250U2l6ZQorZGVzY3JpcHRp b24oIlRlc3RzIHRoYXQgQ1NTMyBjYWxjKCkgY2FuIGJlIHVzZWQgd2l0aCB0aGUgZm9udC1zaXpl IHByb3BlcnR5Iik7CiAKLXZhciBzcGFucyA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1l KCJzcGFuIik7Ci12YXIgc2FtZVNpemUgPSB0cnVlOwordmFyIHNwYW5zID0gZG9jdW1lbnQuZ2V0 RWxlbWVudHNCeUNsYXNzTmFtZSgiZm9udHRlc3QiKTsKIGZvciAodmFyIGkgPSAwOyBpIDwgc3Bh bnMubGVuZ3RoOyArK2kpIHsKLSAgICB2YXIgY3VycmVudCA9IHNwYW5zW2ldOwotICAgIGlmIChz YW1lU2l6ZSkKLSAgICAgICAgc2FtZVNpemUgPSBnZXRDb21wdXRlZFN0eWxlKGN1cnJlbnQsIG51 bGwpLmZvbnRTaXplID09IGNvbnRyb2xTaXplOwotfQotCi12YXIgcmVzdWx0cyA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJyZXN1bHRzIik7Ci1pZiAoc2FtZVNpemUpIHsKLSAgICByZXN1bHRz LnN0eWxlLmNvbG9yID0gImdyZWVuIjsKLSAgICByZXN1bHRzLmlubmVySFRNTCA9ICJQQVNTIjsK LX0gZWxzZSB7Ci0gICAgcmVzdWx0cy5zdHlsZS5jb2xvciA9ICJyZWQiOwotICAgIHJlc3VsdHMu aW5uZXJIVE1MID0gIkZBSUwiOyAgICAKLSAgICByZXN1bHRzLmlubmVySFRNTCArPSAiPHA+Q29t cHV0ZWQgZm9udCBzaXplcyBkbyBub3QgbWF0Y2g8L3A+IjsKKyAgICBzaG91bGRCZUVxdWFsVG9T dHJpbmcoJ2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIicgKyBzcGFu c1tpXS5pZCArICciKSwgbnVsbCkuZm9udFNpemUnLCBnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb250cm9sIiksIG51bGwpLmZvbnRTaXplKTsKIH0KIAoraWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBkb2N1bWVudC5ib2R5LnJlbW92ZUNoaWxk KGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0LWNvbnRhaW5lciIpKTsKIDwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9z Y3JpcHQ+Cg==