78311 2012-02-09 18:25:03 -0800 Convert Frame/FrameView to LayoutUnits in preparation for turning on subpixel layout 2012-02-09 23:07:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63567 1 eae eae darin eric leviw webkit.review.bot oldest_to_newest 553699 0 eae 2012-02-09 18:25:03 -0800 Convert Frame/FrameView and related classes to use LayoutUnits and pixelSnappedIntRect where needed. 553705 1 126426 eae 2012-02-09 18:36:58 -0800 Created attachment 126426 Patch 553728 2 126426 eric 2012-02-09 19:06:13 -0800 Comment on attachment 126426 Patch OK. 553863 3 126426 webkit.review.bot 2012-02-09 23:07:38 -0800 Comment on attachment 126426 Patch Clearing flags on attachment: 126426 Committed r107366: <http://trac.webkit.org/changeset/107366> 553864 4 webkit.review.bot 2012-02-09 23:07:43 -0800 All reviewed patches have been landed. Closing bug. 126426 2012-02-09 18:36:58 -0800 2012-02-09 23:07:38 -0800 Patch bug-78311-20120209183657.patch text/plain 7566 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNzMzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ0IEBACisyMDEyLTAyLTA5ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb252ZXJ0IEZyYW1lL0ZyYW1l VmlldyB0byBMYXlvdXRVbml0cyBpbiBwcmVwYXJhdGlvbiBmb3IgdHVybmluZyBvbiBzdWJwaXhl bCBsYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc4MzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBhZ2UvRnJh bWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6Om5vZGVJbWFnZSk6CisgICAgICAgIFBp eGVsIHNuYXAgcGFpbnRpbmcgcmVjdCBmb3IgaW1hZ2UgdG8gZW5zdXJlIHRoYXQgaXQgaXMgcGFp bnRlZCBhbGlnbmVkCisgICAgICAgIHRvIGRldmljZSBwaXhlbHMuIFRoaXMgYXZvaWRzIGF2b2lk IHVud2FudGVkIGFudGktYWxpYXNpbmcuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OndpbmRvd0NsaXBSZWN0Rm9yTGF5ZXIpOgor ICAgICAgICBQaXhlbCBzbmFwIGNsaXAgcmVjdHMgYXMgYWxsIHdpbmRvdyBjb29yZGluYXRlcyBh bmQgc2l6ZXMgYXJlIGV4cG9zZWQgYXMKKyAgICAgICAgaW50ZWdlcnMuCisKKyAgICAgICAgKiBw YWdlL0dlc3R1cmVUYXBIaWdobGlnaHRlci5jcHA6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OmFkZFJlbGV2YW50UmVwYWludGVkT2JqZWN0KToKKyAg ICAgICAgQXMgdGhlIHBhaW50aW5nIGlzIGRvbmUgYWxpZ25lZCBvbiBwaXhlbCBib3VuZGFyaWVz IHdlIG5lZWQgdG8gcGl4ZWwgc25hcAorICAgICAgICB0aGUgdmlldyByZWN0IHdoZW4gY2hlY2tp bmcgaWYgaXQgaW50ZXJzZWN0cyB0aGUgb2JqZWN0cyBwYWludCByZWN0LgorCisgICAgICAgICog cGFnZS9tYWMvRnJhbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6c25hcHNob3RE cmFnSW1hZ2UpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6Om5vZGVJbWFnZSk6CisgICAgICAg IFBpeGVsIHNuYXAgcGFpbnRpbmcgcmVjdCBmb3IgaW1hZ2UgdG8gZW5zdXJlIHRoYXQgaXQgaXMg cGFpbnRlZCBhbGlnbmVkCisgICAgICAgIHRvIGRldmljZSBwaXhlbHMuIFRoaXMgYXZvaWRzIGF2 b2lkIHVud2FudGVkIGFudGktYWxpYXNpbmcuCisKKyAgICAgICAgKiBwYWdlL3dpbi9GcmFtZUNH V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpub2RlSW1hZ2UpOgorICAgICAgICBQ aXhlbCBzbmFwIHBhaW50aW5nIHJlY3QgZm9yIGltYWdlIHRvIGVuc3VyZSB0aGF0IGl0IGlzIHBh aW50ZWQgYWxpZ25lZAorICAgICAgICB0byBkZXZpY2UgcGl4ZWxzLiBUaGlzIGF2b2lkcyBhdm9p ZCB1bndhbnRlZCBhbnRpLWFsaWFzaW5nLgorCisgICAgICAgICogcmVuZGVyaW5nL0xheW91dFR5 cGVzLmg6CisgICAgICAgIChXZWJDb3JlOjpwaXhlbFNuYXBwZWRJbnRSZWN0KToKKyAgICAgICAg KFdlYkNvcmUpOgorICAgICAgICBOby1vcCBpbXBsZW1lbnRhdGlvbiBvZiBwaXhlbFNuYXBwZWRJ bnRSZWN0IGZvciBub3cuCisKIDIwMTItMDItMDkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdGhlIHNjcm9sbCBsYXllciBwb3NpdGlvbiBv biB0aGUgbWFpbiB0aHJlYWQgd2hlbiB3ZSBoYXZlIHNsb3cgcmVwYWludCBvYmplY3RzCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lLmNwcAkocmV2aXNpb24gMTA3MTI0KQorKysgU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNzIsNyArMTA3Miw3IEBAIERyYWdJ bWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5vZGUKICAgICBtX3ZpZXctPnNldE5vZGVU b0RyYXcobm9kZSk7IC8vIEVuYWJsZSBzcGVjaWFsIHN1Yi10cmVlIGRyYXdpbmcgbW9kZS4KIAog ICAgIExheW91dFJlY3QgdG9wTGV2ZWxSZWN0OwotICAgIEludFJlY3QgcGFpbnRpbmdSZWN0ID0g cmVuZGVyZXItPnBhaW50aW5nUm9vdFJlY3QodG9wTGV2ZWxSZWN0KTsKKyAgICBJbnRSZWN0IHBh aW50aW5nUmVjdCA9IHBpeGVsU25hcHBlZEludFJlY3QocmVuZGVyZXItPnBhaW50aW5nUm9vdFJl Y3QodG9wTGV2ZWxSZWN0KSk7CiAKICAgICBPd25QdHI8SW1hZ2VCdWZmZXI+IGJ1ZmZlcihJbWFn ZUJ1ZmZlcjo6Y3JlYXRlKHBhaW50aW5nUmVjdC5zaXplKCkpKTsKICAgICBpZiAoIWJ1ZmZlcikK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDEwNzEyNCkKKysrIFNv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ3OSw5 ICsyNDc5LDkgQEAgSW50UmVjdCBGcmFtZVZpZXc6OndpbmRvd0NsaXBSZWN0Rm9yTGF5ZQogICAg IC8vIEFwcGx5IHRoZSBjbGlwIGZyb20gdGhlIGxheWVyLgogICAgIEludFJlY3QgY2xpcFJlY3Q7 CiAgICAgaWYgKGNsaXBUb0xheWVyQ29udGVudHMpCi0gICAgICAgIGNsaXBSZWN0ID0gbGF5ZXIt PmNoaWxkcmVuQ2xpcFJlY3QoKTsKKyAgICAgICAgY2xpcFJlY3QgPSBwaXhlbFNuYXBwZWRJbnRS ZWN0KGxheWVyLT5jaGlsZHJlbkNsaXBSZWN0KCkpOwogICAgIGVsc2UKLSAgICAgICAgY2xpcFJl Y3QgPSBsYXllci0+c2VsZkNsaXBSZWN0KCk7CisgICAgICAgIGNsaXBSZWN0ID0gcGl4ZWxTbmFw cGVkSW50UmVjdChsYXllci0+c2VsZkNsaXBSZWN0KCkpOwogICAgIGNsaXBSZWN0ID0gY29udGVu dHNUb1dpbmRvdyhjbGlwUmVjdCk7IAogICAgIHJldHVybiBpbnRlcnNlY3Rpb24oY2xpcFJlY3Qs IHdpbmRvd0NsaXBSZWN0KCkpOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9HZXN0dXJl VGFwSGlnaGxpZ2h0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvR2Vz dHVyZVRhcEhpZ2hsaWdodGVyLmNwcAkocmV2aXNpb24gMTA3MTI0KQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9HZXN0dXJlVGFwSGlnaGxpZ2h0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NSw3 ICs1NSw3IEBAIGlubGluZSBMYXlvdXRQb2ludCBvd25lckZyYW1lVG9NYWluRnJhbWUKIAogICAg IEZyYW1lKiBtYWluRnJhbWUgPSBjb250YWluaW5nRnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCk7 CiAKLSAgICBMYXlvdXRQb2ludCBtYWluRnJhbWVQb2ludCA9IG1haW5GcmFtZS0+dmlldygpLT5y b290Vmlld1RvQ29udGVudHMoY29udGFpbmluZ0ZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9Sb290 VmlldyhMYXlvdXRQb2ludCgpKSk7CisgICAgTGF5b3V0UG9pbnQgbWFpbkZyYW1lUG9pbnQgPSBt YWluRnJhbWUtPnZpZXcoKS0+cm9vdFZpZXdUb0NvbnRlbnRzKGNvbnRhaW5pbmdGcmFtZS0+dmll dygpLT5jb250ZW50c1RvUm9vdFZpZXcoSW50UG9pbnQoKSkpOwogICAgIHJldHVybiBtYWluRnJh bWVQb2ludDsKIH0KIApAQCAtOTUsOCArOTUsOCBAQCBpbmxpbmUgYm9vbCBzdHJpa2VzKGNvbnN0 IExheW91dFJlY3QmIGEsCiAKIGlubGluZSB2b2lkIHNoaWZ0WEVkZ2VzVG9Db250YWluSWZTdHJp a2VzKExheW91dFJlY3QmIHJlY3QsIGNvbnN0IExheW91dFJlY3QmIG90aGVyKQogewotICAgIGlu dCBsZWZ0U2lkZSA9IHJlY3QueCgpOwotICAgIGludCByaWdodFNpZGUgPSByZWN0Lm1heFgoKTsK KyAgICBMYXlvdXRVbml0IGxlZnRTaWRlID0gcmVjdC54KCk7CisgICAgTGF5b3V0VW5pdCByaWdo dFNpZGUgPSByZWN0Lm1heFgoKTsKIAogICAgIGlmICghb3RoZXIuaXNFbXB0eSgpICYmIHN0cmlr ZXMocmVjdCwgb3RoZXIpKSB7CiAgICAgICAgIGxlZnRTaWRlID0gc3RkOjptaW4obGVmdFNpZGUs IG90aGVyLngoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAJKHJldmlzaW9uIDEwNzEyNCkKKysr IFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNzYsNyAr MTA3Niw3IEBAIHZvaWQgUGFnZTo6YWRkUmVsZXZhbnRSZXBhaW50ZWRPYmplY3QoUmUKIAogICAg IC8vIFRoZSBvYmplY3RzIGFyZSBvbmx5IHJlbGV2YW50IGlmIHRoZXkgYXJlIGJlaW5nIHBhaW50 ZWQgd2l0aGluIHRoZSB2aWV3UmVjdCgpLgogICAgIGlmIChSZW5kZXJWaWV3KiB2aWV3ID0gb2Jq ZWN0LT52aWV3KCkpIHsKLSAgICAgICAgaWYgKCFvYmplY3RQYWludFJlY3QuaW50ZXJzZWN0cyh2 aWV3LT52aWV3UmVjdCgpKSkKKyAgICAgICAgaWYgKCFvYmplY3RQYWludFJlY3QuaW50ZXJzZWN0 cyhwaXhlbFNuYXBwZWRJbnRSZWN0KHZpZXctPnZpZXdSZWN0KCkpKSkKICAgICAgICAgICAgIHJl dHVybjsKICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0ZyYW1lTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0ZyYW1lTWFjLm1tCShyZXZp c2lvbiAxMDcxMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9GcmFtZU1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtMTU4LDcgKzE1OCw3IEBAIE5TSW1hZ2UqIEZyYW1lOjpzbmFwc2hvdERy YWdJbWFnZShOb2RlKiAKICAgICBtX2RvYy0+dXBkYXRlTGF5b3V0KCk7ICAgICAgICAvLyBmb3Jj ZXMgc3R5bGUgcmVjYWxjIC0gbmVlZGVkIHNpbmNlIGNoYW5naW5nIHRoZSBkcmFnIHN0YXRlIG1p Z2h0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gaW1wbHkgbmV3 IHN0eWxlcywgcGx1cyBKUyBjb3VsZCBoYXZlIGNoYW5nZWQgb3RoZXIgdGhpbmdzCiAgICAgTGF5 b3V0UmVjdCB0b3BMZXZlbFJlY3Q7Ci0gICAgTlNSZWN0IHBhaW50aW5nUmVjdCA9IHJlbmRlcmVy LT5wYWludGluZ1Jvb3RSZWN0KHRvcExldmVsUmVjdCk7CisgICAgTlNSZWN0IHBhaW50aW5nUmVj dCA9IHBpeGVsU25hcHBlZEludFJlY3QocmVuZGVyZXItPnBhaW50aW5nUm9vdFJlY3QodG9wTGV2 ZWxSZWN0KSk7CiAKICAgICBtX3ZpZXctPnNldE5vZGVUb0RyYXcobm9kZSk7ICAgICAgICAgICAg ICAvLyBpbnZva2Ugc3BlY2lhbCBzdWItdHJlZSBkcmF3aW5nIG1vZGUKICAgICBOU0ltYWdlKiBy ZXN1bHQgPSBpbWFnZUZyb21SZWN0KHBhaW50aW5nUmVjdCk7CkBAIC0xNjcsNyArMTY3LDcgQEAg TlNJbWFnZSogRnJhbWU6OnNuYXBzaG90RHJhZ0ltYWdlKE5vZGUqIAogICAgIG1fdmlldy0+c2V0 Tm9kZVRvRHJhdygwKTsKIAogICAgIGlmIChlbGVtZW50UmVjdCkKLSAgICAgICAgKmVsZW1lbnRS ZWN0ID0gdG9wTGV2ZWxSZWN0OworICAgICAgICAqZWxlbWVudFJlY3QgPSBwaXhlbFNuYXBwZWRJ bnRSZWN0KHRvcExldmVsUmVjdCk7CiAgICAgaWYgKGltYWdlUmVjdCkKICAgICAgICAgKmltYWdl UmVjdCA9IHBhaW50aW5nUmVjdDsKICAgICByZXR1cm4gcmVzdWx0OwpAQCAtMTgyLDcgKzE4Miw3 IEBAIERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5vZGUKICAgICBtX2RvYy0+ dXBkYXRlTGF5b3V0KCk7IC8vIGZvcmNlcyBzdHlsZSByZWNhbGMKIAogICAgIExheW91dFJlY3Qg dG9wTGV2ZWxSZWN0OwotICAgIE5TUmVjdCBwYWludGluZ1JlY3QgPSByZW5kZXJlci0+cGFpbnRp bmdSb290UmVjdCh0b3BMZXZlbFJlY3QpOworICAgIE5TUmVjdCBwYWludGluZ1JlY3QgPSBwaXhl bFNuYXBwZWRJbnRSZWN0KHJlbmRlcmVyLT5wYWludGluZ1Jvb3RSZWN0KHRvcExldmVsUmVjdCkp OwogCiAgICAgbV92aWV3LT5zZXROb2RlVG9EcmF3KG5vZGUpOyAvLyBpbnZva2Ugc3BlY2lhbCBz dWItdHJlZSBkcmF3aW5nIG1vZGUKICAgICBOU0ltYWdlKiByZXN1bHQgPSBpbWFnZUZyb21SZWN0 KHBhaW50aW5nUmVjdCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL3dpbi9GcmFtZUNHV2lu LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3dpbi9GcmFtZUNHV2luLmNw cAkocmV2aXNpb24gMTA3MTI0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS93aW4vRnJhbWVDR1dp bi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDcgKzk4LDcgQEAgRHJhZ0ltYWdlUmVmIEZyYW1l Ojpub2RlSW1hZ2UoTm9kZSogbm9kZQogICAgICAgICByZXR1cm4gMDsKIAogICAgIExheW91dFJl Y3QgdG9wTGV2ZWxSZWN0OwotICAgIEludFJlY3QgcGFpbnRpbmdSZWN0ID0gcmVuZGVyZXItPnBh aW50aW5nUm9vdFJlY3QodG9wTGV2ZWxSZWN0KTsKKyAgICBJbnRSZWN0IHBhaW50aW5nUmVjdCA9 IHBpeGVsU25hcHBlZEludFJlY3QocmVuZGVyZXItPnBhaW50aW5nUm9vdFJlY3QodG9wTGV2ZWxS ZWN0KSk7CiAKICAgICBkb2N1bWVudCgpLT51cGRhdGVMYXlvdXQoKTsKIApJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0xheW91dFR5cGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0xheW91dFR5cGVzLmgJKHJldmlzaW9uIDEwNzEyNCkKKysrIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRUeXBlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw2 ICs1MSwxMSBAQCBpbmxpbmUgTGF5b3V0UmVjdCBlbmNsb3NpbmdMYXlvdXRSZWN0KGNvCiAgICAg cmV0dXJuIGVuY2xvc2luZ0ludFJlY3QocmVjdCk7CiB9CiAKK2lubGluZSBJbnRSZWN0IHBpeGVs U25hcHBlZEludFJlY3QoY29uc3QgTGF5b3V0UmVjdCYgcmVjdCkKK3sKKyAgICByZXR1cm4gcmVj dDsKK30KKwogaW5saW5lIExheW91dFNpemUgcm91bmRlZExheW91dFNpemUoY29uc3QgRmxvYXRT aXplJiBzKQogewogICAgIHJldHVybiByb3VuZGVkSW50U2l6ZShzKTsK