78173 2012-02-08 16:07:07 -0800 Don't re-implement ZipFile.extractall 2012-02-20 19:54:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER P2 Normal --- 71593 1 abarth abarth dpranke webkit.review.bot oldest_to_newest 552582 0 abarth 2012-02-08 16:07:07 -0800 Don't re-implement ZipFile.extractall 552586 1 126177 abarth 2012-02-08 16:08:41 -0800 Created attachment 126177 Patch 552590 2 abarth 2012-02-08 16:10:10 -0800 Committed r107147: <http://trac.webkit.org/changeset/107147> 559485 3 dpranke 2012-02-17 13:36:49 -0800 This appears to break the autoinstaller using Python 2.6.1 on the Mac :( See bug 78866. 559492 4 126177 webkit.review.bot 2012-02-17 13:42:16 -0800 Comment on attachment 126177 Patch Rejecting attachment 126177 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/ Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/common/system/autoinstall.py Hunk #1 FAILED at 259. Hunk #2 FAILED at 313. 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/system/autoinstall.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11543261 560571 5 abarth 2012-02-20 19:54:56 -0800 Looks like we need to keep this until we remove support for Python 2.6. 126177 2012-02-08 16:08:41 -0800 2012-02-17 13:42:16 -0800 Patch bug-78173-20120208160840.patch text/plain 2980 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNzE0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTAyLTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgRG9uJ3QgcmUtaW1wbGVtZW50IFppcEZpbGUuZXh0cmFjdGFsbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgxNzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjYW4gdXNlIFppcEZpbGUu ZXh0cmFjdGFsbCBub3cgdGhhdCB3ZSBkb24ndCBzdXBwb3J0IFB5dGhvbiAyLjUuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHk6CisgICAg ICAgIChBdXRvSW5zdGFsbGVyLl9leHRyYWN0X3Rhcmd6KToKKyAgICAgICAgKEF1dG9JbnN0YWxs ZXIuX3VuemlwKToKKwogMjAxMi0wMi0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJlbW92ZSB0aGUgb3NwYXRoIGNvbXBhdCBzaGltIGZyb20gd2Via2l0cHkK SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0 b2luc3RhbGwucHkJKHJldmlzaW9uIDEwNzE0NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weQkod29ya2luZyBjb3B5KQpAQCAtMjU5LDQzICsy NTksNiBAQCBjbGFzcyBBdXRvSW5zdGFsbGVyKG9iamVjdCk6CiAKICAgICAgICAgcmV0dXJuIHRh cmdldF9wYXRoCiAKLSAgICAjIFRoaXMgaXMgYSByZXBsYWNlbWVudCBmb3IgWmlwRmlsZS5leHRy YWN0YWxsKCksIHdoaWNoIGlzCi0gICAgIyBhdmFpbGFibGUgaW4gUHl0aG9uIDIuNiBidXQgbm90 IGluIGVhcmxpZXIgdmVyc2lvbnMuCi0gICAgZGVmIF9leHRyYWN0X2FsbChzZWxmLCB6aXBfZmls ZSwgdGFyZ2V0X2Rpcik6Ci0gICAgICAgIHNlbGYuX2xvZ190cmFuc2ZlcigiRXh0cmFjdGluZyB6 aXAgZmlsZS4uLiIsIHppcF9maWxlLCB0YXJnZXRfZGlyKQotCi0gICAgICAgICMgVGhpcyBpcyBo ZWxwZnVsIGZvciBkZWJ1Z2dpbmcgcHVycG9zZXMuCi0gICAgICAgIF9sb2cuZGVidWcoIkxpc3Rp bmcgemlwIGZpbGUgY29udGVudHMuLi4iKQotICAgICAgICBmb3IgbmFtZSBpbiB6aXBfZmlsZS5u YW1lbGlzdCgpOgotICAgICAgICAgICAgX2xvZy5kZWJ1ZygnICAgICogIiVzIicgJSBuYW1lKQot Ci0gICAgICAgIGZvciBuYW1lIGluIHppcF9maWxlLm5hbWVsaXN0KCk6Ci0gICAgICAgICAgICBw YXRoID0gb3MucGF0aC5qb2luKHRhcmdldF9kaXIsIG5hbWUpCi0gICAgICAgICAgICBzZWxmLl9s b2dfdHJhbnNmZXIoIkV4dHJhY3RpbmcuLi4iLCBuYW1lLCBwYXRoKQotCi0gICAgICAgICAgICBp ZiBub3Qgb3MucGF0aC5iYXNlbmFtZShwYXRoKToKLSAgICAgICAgICAgICAgICAjIFRoZW4gdGhl IHBhdGggZW5kcyBpbiBhIHNsYXNoLCBzbyBpdCBpcyBhIGRpcmVjdG9yeS4KLSAgICAgICAgICAg ICAgICBzZWxmLl9jcmVhdGVfZGlyZWN0b3J5KHBhdGgpCi0gICAgICAgICAgICAgICAgY29udGlu dWUKLSAgICAgICAgICAgICMgT3RoZXJ3aXNlLCBpdCBpcyBhIGZpbGUuCi0KLSAgICAgICAgICAg IHRyeToKLSAgICAgICAgICAgICAgICAjIFdlIG9wZW4gdGhpcyBmaWxlIHcvbyBlbmNvZGluZywg YXMgd2UncmUgcmVhZGluZy93cml0aW5nCi0gICAgICAgICAgICAgICAgIyB0aGUgcmF3IGJ5dGUt c3RyZWFtIGZyb20gdGhlIHppcCBmaWxlLgotICAgICAgICAgICAgICAgIG91dGZpbGUgPSBvcGVu KHBhdGgsICd3YicpCi0gICAgICAgICAgICBleGNlcHQgSU9FcnJvciwgZXJyOgotICAgICAgICAg ICAgICAgICMgTm90IGFsbCB6aXAgZmlsZXMgc2VlbSB0byBsaXN0IHRoZSBkaXJlY3RvcmllcyBl eHBsaWNpdGx5LAotICAgICAgICAgICAgICAgICMgc28gdHJ5IGFnYWluIGFmdGVyIGNyZWF0aW5n IHRoZSBjb250YWluaW5nIGRpcmVjdG9yeS4KLSAgICAgICAgICAgICAgICBfbG9nLmRlYnVnKCJH b3QgSU9FcnJvcjogcmV0cnlpbmcgYWZ0ZXIgY3JlYXRpbmcgZGlyZWN0b3J5Li4uIikKLSAgICAg ICAgICAgICAgICBkaXIgPSBvcy5wYXRoLmRpcm5hbWUocGF0aCkKLSAgICAgICAgICAgICAgICBz ZWxmLl9jcmVhdGVfZGlyZWN0b3J5KGRpcikKLSAgICAgICAgICAgICAgICBvdXRmaWxlID0gb3Bl bihwYXRoLCAnd2InKQotCi0gICAgICAgICAgICB0cnk6Ci0gICAgICAgICAgICAgICAgb3V0Zmls ZS53cml0ZSh6aXBfZmlsZS5yZWFkKG5hbWUpKQotICAgICAgICAgICAgZmluYWxseToKLSAgICAg ICAgICAgICAgICBvdXRmaWxlLmNsb3NlKCkKLQogICAgIGRlZiBfdW56aXAoc2VsZiwgcGF0aCwg c2NyYXRjaF9kaXIpOgogICAgICAgICAjIHppcGZpbGUuZXh0cmFjdGFsbCgpIGV4dHJhY3RzIHRv IGEgcGF0aCB3aXRob3V0IHRoZQogICAgICAgICAjIHRyYWlsaW5nICIuemlwIi4KQEAgLTMxMyw3 ICsyNzYsNyBAQCBjbGFzcyBBdXRvSW5zdGFsbGVyKG9iamVjdCk6CiAgICAgICAgICAgICByYWlz ZSBFeGNlcHRpb24obWVzc2FnZSkKIAogICAgICAgICB0cnk6Ci0gICAgICAgICAgICBzZWxmLl9l eHRyYWN0X2FsbCh6aXBfZmlsZSwgc2NyYXRjaF9kaXIpCisgICAgICAgICAgICB6aXBfZmlsZS5l eHRyYWN0YWxsKHNjcmF0Y2hfZGlyKQogICAgICAgICBmaW5hbGx5OgogICAgICAgICAgICAgemlw X2ZpbGUuY2xvc2UoKQogCg==