77973 2012-02-07 05:20:06 -0800 Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute 2012-02-07 16:00:37 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 550885 0 haraken 2012-02-07 05:20:06 -0800 We can rename [v8OnProto] to [V8OnProto], since V8 specific IDL attributes should be prefixed by "V8". For now, [V8OnProto] is just used in CodeGeneratorV8.pm internally, we are planning to use it in normal IDL files in the near future. 550886 1 125823 haraken 2012-02-07 05:22:01 -0800 Created attachment 125823 Patch 551509 2 125823 webkit.review.bot 2012-02-07 16:00:33 -0800 Comment on attachment 125823 Patch Clearing flags on attachment: 125823 Committed r107004: <http://trac.webkit.org/changeset/107004> 551510 3 webkit.review.bot 2012-02-07 16:00:37 -0800 All reviewed patches have been landed. Closing bug. 125823 2012-02-07 05:22:01 -0800 2012-02-07 16:00:33 -0800 Patch bug-77973-20120207222155.patch text/plain 2683 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZkYjJmNGQ1ZGIwYmZh MjZlNDA3NTA1OGIzMzY1N2U3NGIxOTBmZS4uYzBiNzc1ODJmNWE4NzBhMzgxYjc2OGRlZjYwZTk5 OTE4NmZiYjJkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTA3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgW3Y4T25Q cm90b10gSURMIGF0dHJpYnV0ZSB0byBbVjhPblByb3RvXSBJREwgYXR0cmlidXRlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzk3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVuYW1l cyBbdjhPblByb3RvXSB0byBbVjhPblByb3RvXSwgc2luY2UgVjggc3BlY2lmaWMgSURMCisgICAg ICAgIGF0dHJpYnV0ZXMgc2hvdWxkIGJlIHByZWZpeGVkIGJ5ICJWOCIuCisKKyAgICAgICAgTm8g dGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVOb3JtYWxBdHRyR2V0dGVy KToKKyAgICAgICAgKEdlbmVyYXRlTm9ybWFsQXR0clNldHRlcik6CisgICAgICAgIChHZW5lcmF0 ZVNpbmdsZUJhdGNoZWRBdHRyaWJ1dGUpOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlv bik6CisKIDIwMTItMDItMDcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDY5MTIuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4 IGFlMjZhNzQxY2JmYzJhMzRkZDIzMzE3YmZkM2MwOGFhN2RhNTVmOTAuLjlkZDMzMWYxOTNkMWM3 M2RjZTExZWNiMWZhMzBiMDcwYjU1MTY4YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC04MDksNyArODA5LDcgQEAgRU5E CiBFTkQKICAgICAgICAgICAgIH0KICAgICAgICAgfQotICAgIH0gZWxzaWYgKCRhdHRyRXh0LT57 InY4T25Qcm90byJ9IHx8ICRhdHRyRXh0LT57IlY4VW5mb3JnZWFibGUifSkgeworICAgIH0gZWxz aWYgKCRhdHRyRXh0LT57IlY4T25Qcm90byJ9IHx8ICRhdHRyRXh0LT57IlY4VW5mb3JnZWFibGUi fSkgewogICAgICAgICBpZiAoJGludGVyZmFjZU5hbWUgZXEgIkRPTVdpbmRvdyIpIHsKICAgICAg ICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsIDw8RU5EKTsKICAgICB2ODo6SGFuZGxlPHY4 OjpPYmplY3Q+IGhvbGRlciA9IGluZm8uSG9sZGVyKCk7CkBAIC0xMDUzLDcgKzEwNTMsNyBAQCBF TkQKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgJHN2Z1dyYXBwZWRO YXRpdmVUeXBlJiBpbXBJbnN0YW5jZSA9IHdyYXBwZXItPnByb3BlcnR5UmVmZXJlbmNlKCk7XG4i KTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgJHN2Z1dyYXBwZWRO YXRpdmVUeXBlKiBpbXAgPSAmaW1wSW5zdGFuY2U7XG4iKTsKICAgICAgICAgfQotICAgIH0gZWxz aWYgKCRhdHRyRXh0LT57InY4T25Qcm90byJ9KSB7CisgICAgfSBlbHNpZiAoJGF0dHJFeHQtPnsi VjhPblByb3RvIn0pIHsKICAgICAgIGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93Iikg ewogICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCA8PEVORCk7CiAgICAgdjg6OkhhbmRs ZTx2ODo6T2JqZWN0PiBob2xkZXIgPSBpbmZvLkhvbGRlcigpOwpAQCAtMjAyOSw3ICsyMDI5LDcg QEAgc3ViIEdlbmVyYXRlU2luZ2xlQmF0Y2hlZEF0dHJpYnV0ZQogICAgIH0KIAogICAgICMgQW4g YWNjZXNzb3IgY2FuIGJlIGluc3RhbGxlZCBvbiB0aGUgcHJvdG8KLSAgICBpZiAoJGF0dHJFeHQt PnsidjhPblByb3RvIn0pIHsKKyAgICBpZiAoJGF0dHJFeHQtPnsiVjhPblByb3RvIn0pIHsKICAg ICAgICAgJG9uX3Byb3RvID0gIjEgLyogb24gcHJvdG8gKi8iOwogICAgIH0KIApAQCAtMjI4MCw3 ICsyMjgwLDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgfQogCiAgICAg ICAgIGlmICgkYXR0clR5cGUgZXEgIkV2ZW50TGlzdGVuZXIiICYmICRpbnRlcmZhY2VOYW1lIGVx ICJET01XaW5kb3ciKSB7Ci0gICAgICAgICAgICAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJ2OE9uUHJvdG8ifSA9IDE7CisgICAgICAgICAgICAkYXR0cmlidXRl LT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOE9uUHJvdG8ifSA9IDE7CiAgICAg ICAgIH0KIAogICAgICAgICBpZiAoJGF0dHJUeXBlIGVxICJTZXJpYWxpemVkU2NyaXB0VmFsdWUi KSB7Cg==