7797 2006-03-16 00:21:12 -0800 Can't set background color on new text fields 2006-03-17 05:04:55 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 6986 1 adele adele oldest_to_newest 36524 0 adele 2006-03-16 00:21:12 -0800 Can't set background color on new text fields 36525 1 7107 adele 2006-03-16 00:24:04 -0800 Created attachment 7107 patch Not sure if this is the right approach in the long run, since there could be other non-inhertied CSS properties that we should pass on to the div style. 36526 2 7108 adele 2006-03-16 00:25:58 -0800 Created attachment 7108 layout test 36528 3 7107 hyatt 2006-03-16 00:38:54 -0800 Comment on attachment 7107 patch The <input> has to be the one to draw the background, since backgrounds draw in the border box of an element. The reason this isn't drawing is that the native theme is stopping it. 36695 4 adele 2006-03-17 01:08:56 -0800 I had hyatt review a new patch. It turns out that the NSTextFieldCell was drawing a background - even with setDrawsBackground:NO. So we added a new function just to draw the text field border. 36715 5 mitz 2006-03-17 05:04:55 -0800 I think after the fix all new text fields have a transparent background by default instead of white (probably fixable in html4.css). 7107 2006-03-16 00:24:04 -0800 2006-03-16 00:38:54 -0800 patch bk.txt text/plain 2564 adele SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRGaWVsZC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dEZpZWxkLmNwcAkocmV2aXNpb24gMTMzMTgp CisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0RmllbGQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01MywxNCArNTMsOCBAQAogdm9pZCBSZW5kZXJUZXh0RmllbGQ6OnNldFN0eWxlKFJlbmRl clN0eWxlKiBzdHlsZSkKIHsKICAgICBSZW5kZXJCbG9jazo6c2V0U3R5bGUoc3R5bGUpOwotICAg IGlmIChtX2RpdikgewotICAgICAgICBSZW5kZXJCbG9jayogZGl2UmVuZGVyZXIgPSBzdGF0aWNf Y2FzdDxSZW5kZXJCbG9jayo+KG1fZGl2LT5yZW5kZXJlcigpKTsKLSAgICAgICAgUmVuZGVyU3R5 bGUqIGRpdlN0eWxlID0gY3JlYXRlRGl2U3R5bGUoc3R5bGUpOwotICAgICAgICBkaXZSZW5kZXJl ci0+c2V0U3R5bGUoZGl2U3R5bGUpOwotICAgICAgICBmb3IgKE5vZGVJbXBsICpuID0gbV9kaXYt PmZpcnN0Q2hpbGQoKTsgbjsgbiA9IG4tPnRyYXZlcnNlTmV4dE5vZGUobV9kaXYuZ2V0KCkpKQot ICAgICAgICAgICAgaWYgKG4tPnJlbmRlcmVyKCkpCi0gICAgICAgICAgICAgICAgbi0+cmVuZGVy ZXIoKS0+c2V0U3R5bGUoZGl2U3R5bGUpOwotICAgIH0KKyAgICBpZiAobV9kaXYpCisgICAgICAg IHNldERpdlN0eWxlKHN0eWxlKTsKICAgICBzZXRSZXBsYWNlZChpc0lubGluZSgpKTsKIH0KIApA QCAtNzIsOSArNjYsMjAgQEAKICAgICBkaXZTdHlsZS0+c2V0T3ZlcmZsb3coT0hJRERFTik7CiAg ICAgZGl2U3R5bGUtPnNldFdoaXRlU3BhY2UoTk9XUkFQKTsKICAgICBkaXZTdHlsZS0+c2V0VXNl ck1vZGlmeShSRUFEX1dSSVRFKTsKKyAgICBkaXZTdHlsZS0+c2V0QmFja2dyb3VuZENvbG9yKHN0 YXJ0U3R5bGUtPmJhY2tncm91bmRDb2xvcigpKTsKICAgICByZXR1cm4gZGl2U3R5bGU7CiB9CiAK K3ZvaWQgUmVuZGVyVGV4dEZpZWxkOjpzZXREaXZTdHlsZShSZW5kZXJTdHlsZSogc3R5bGUpCit7 CisgICAgUmVuZGVyQmxvY2sqIGRpdlJlbmRlcmVyID0gc3RhdGljX2Nhc3Q8UmVuZGVyQmxvY2sq PihtX2Rpdi0+cmVuZGVyZXIoKSk7CisgICAgUmVuZGVyU3R5bGUqIGRpdlN0eWxlID0gY3JlYXRl RGl2U3R5bGUoc3R5bGUpOworICAgIGRpdlJlbmRlcmVyLT5zZXRTdHlsZShkaXZTdHlsZSk7Cisg ICAgZm9yIChOb2RlSW1wbCAqbiA9IG1fZGl2LT5maXJzdENoaWxkKCk7IG47IG4gPSBuLT50cmF2 ZXJzZU5leHROb2RlKG1fZGl2LmdldCgpKSkKKyAgICAgICAgaWYgKG4tPnJlbmRlcmVyKCkpCisg ICAgICAgICAgICBuLT5yZW5kZXJlcigpLT5zZXRTdHlsZShkaXZTdHlsZSk7Cit9CisKIHZvaWQg UmVuZGVyVGV4dEZpZWxkOjp1cGRhdGVGcm9tRWxlbWVudCgpCiB7CiAgICAgaWYgKGVsZW1lbnQo KS0+aGFzVGFnTmFtZShpbnB1dFRhZykpIHsKQEAgLTk5LDggKzEwNCw3IEBACiAgICAgICAgICAg ICAvLyBGSVhNRTogIEFkZHJlc3MgZm9jdXMgYW5kIGV2ZW50IHByb2JsZW1zIHdpdGggdGhpcyBz aGFkb3cgRE9NLgogICAgICAgICAgICAgLy8gRm9yIGV4YW1wbGUsIGV2ZW50cyBzaG91bGQgYXBw ZWFyIHRvIG9jY3VyIG9uIHRoZSBpbnB1dCBlbGVtZW50LCBidXQgbXVzdCB0YWtlIGFmZmVjdCBv biB0aGlzIGRpdi4KICAgICAgICAgICAgIAotICAgICAgICAgICAgUmVuZGVyU3R5bGUqIGRpdlN0 eWxlID0gY3JlYXRlRGl2U3R5bGUoc3R5bGUoKSk7Ci0gICAgICAgICAgICBkaXZSZW5kZXJlci0+ c2V0U3R5bGUoZGl2U3R5bGUpOyAKKyAgICAgICAgICAgIHNldERpdlN0eWxlKHN0eWxlKCkpOwog ICAgICAgICAgICAgCiAgICAgICAgICAgICAvLyBBZGQgZGl2IHRvIFJlbmRlciB0cmVlCiAgICAg ICAgICAgICBSZW5kZXJCbG9jazo6YWRkQ2hpbGQoZGl2UmVuZGVyZXIpOwpJbmRleDogV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGV4dEZpZWxkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dEZpZWxkLmgJKHJldmlzaW9uIDEzMzE4KQorKysgV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dEZpZWxkLmgJKHdvcmtpbmcgY29weSkKQEAgLTM4LDcgKzM4LDggQEAK ICAgICB2aXJ0dWFsIHZvaWQgc2V0U3R5bGUoUmVuZGVyU3R5bGUqKTsKICAgICB2aXJ0dWFsIHZv aWQgdXBkYXRlRnJvbUVsZW1lbnQoKTsKICAgICAKLSAgICBSZW5kZXJTdHlsZSogY3JlYXRlRGl2 U3R5bGUoUmVuZGVyU3R5bGUqIHN0YXJ0U3R5bGUpOworICAgIFJlbmRlclN0eWxlKiBjcmVhdGVE aXZTdHlsZShSZW5kZXJTdHlsZSopOworICAgIHZvaWQgc2V0RGl2U3R5bGUoUmVuZGVyU3R5bGUq KTsKIAogICAgIGJvb2wgaXNFZGl0ZWQoKSBjb25zdCB7IHJldHVybiBtX2RpcnR5OyB9OwogICAg IHZvaWQgc2V0RWRpdGVkKGJvb2wgaXNFZGl0ZWQpIHsgbV9kaXJ0eSA9IGlzRWRpdGVkOyB9Owo= 7108 2006-03-16 00:25:58 -0800 2006-03-16 00:25:58 -0800 layout test input-appearance-bkcolor.html text/html 235 adele PGh0bWw+CjxzdHlsZT4KLm5ldyB7CiAgICAta2h0bWwtYXBwZWFyYW5jZTogdGV4dGZpZWxkOwog ICAgYmFja2dyb3VuZC1jb2xvcjogcGluazsKfQo8L3N0eWxlPgpUaGlzIHRlc3RzIHRoYXQgYmFj a2dyb3VuZCBjb2xvciBjYW4gYmUgc2V0IG9uIHRoZSBuZXcgdGV4dCBmaWVsZHMuCjxicj48aW5w dXQgY2xhc3M9Im5ldyIgdHlwZT0idGV4dCIgdmFsdWU9IlRoaXMgc2hvdWxkIGJlIHBpbmsuIj4K PC9odG1sPg==