77938 2012-02-06 22:38:09 -0800 SVGTRefElement shouldn't dynamically create a shadow root. 2012-05-30 09:41:27 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77503 0 shinyak webkit-unassigned dglazkov shinyak webkit.review.bot zimmermann oldest_to_newest 550638 0 shinyak 2012-02-06 22:38:09 -0800 It's difficult to support multiple shadow subtrees if a shadow root is recreated. We should change this. 551805 1 126005 shinyak 2012-02-07 22:33:36 -0800 Created attachment 126005 Patch 551814 2 shinyak 2012-02-07 22:45:35 -0800 Zimmermann, I'm now implementing "multiple shadow subtrees", which is described in https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html When "multiple shadow subtrees" is supported, a user can append a shadow root into any elements. SVG elements are not exceptional. So if a user adds a new shadow root into 'tref' element before tref adds shadow root by itself, a problem may happen. So I would like to ensure that a shadow root is created before user can add a new shadow root into this element. Do you think a problem happens if a shadow root is added in a construction phase? If not, I would like to proceed this change. If it does, we have to think another solution. 551893 3 126005 zimmermann 2012-02-08 01:46:46 -0800 Comment on attachment 126005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126005&action=review r- for the missing tests for now. Patch looks good in general. > Source/WebCore/ChangeLog:9 > + SVGTRefElement creates a shadow root dynamically. This will cause a problem to support > + multiple shadow subtrees. So it should be created in a constructor phase. > + > + Reviewed by NOBODY (OOPS!). These blocks should be swapped. Can you include a testcase that shows this problem? Otherwise this will break again in future. > Source/WebCore/svg/SVGTRefElement.cpp:61 > - return adoptRef(new SVGTRefElement(tagName, document)); > + RefPtr<SVGTRefElement> elem = adoptRef(new SVGTRefElement(tagName, document)); > + elem->createShadowSubtree(); > + return elem.release(); s/elem/element/ - no abbreviations please. 552907 4 shinyak 2012-02-08 23:57:49 -0800 I'll resubmit this after Bug 77935 is landed. I'm now using it... 553672 5 126417 shinyak 2012-02-09 18:04:15 -0800 Created attachment 126417 Patch 554901 6 126417 webkit.review.bot 2012-02-12 17:35:51 -0800 Comment on attachment 126417 Patch Rejecting attachment 126417 from commit-queue. shinyak@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 554954 7 126417 webkit.review.bot 2012-02-12 19:35:35 -0800 Comment on attachment 126417 Patch Clearing flags on attachment: 126417 Committed r107523: <http://trac.webkit.org/changeset/107523> 554955 8 webkit.review.bot 2012-02-12 19:35:40 -0800 All reviewed patches have been landed. Closing bug. 637318 9 dglazkov 2012-05-30 09:41:27 -0700 This bug is still mentioned in http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/dom/ShadowRoot.cpp&exact_package=chromium&q=allowsAuthorShadowRoot&type=cs&l=75. Should we remove the check now? 126005 2012-02-07 22:33:36 -0800 2012-02-09 18:04:08 -0800 Patch bug-77938-20120208153335.patch text/plain 3534 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ4NzgzZmM0NTAwMmM4 ZmEzMjQzY2FkZTE1NTI2Yjc3YTg1YWI3Ny4uZDNjOGE5ZmUwZWRlNDk1MjUyNDEyZjA4NTNhNGJi YTU3MGJjZGY5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTA3ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgU1ZHVFJlZkVsZW1l bnQgc2hvdWxkbid0IGNyZWF0ZSBhIHNoYWRvdyByb290IGR5bmFtaWNhbGx5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MzgKKworICAgICAgICBT VkdUUmVmRWxlbWVudCBjcmVhdGVzIGEgc2hhZG93IHJvb3QgZHluYW1pY2FsbHkuIFRoaXMgd2ls bCBjYXVzZSBhIHByb2JsZW0gdG8gc3VwcG9ydAorICAgICAgICBtdWx0aXBsZSBzaGFkb3cgc3Vi dHJlZXMuIFNvIGl0IHNob3VsZCBiZSBjcmVhdGVkIGluIGEgY29uc3RydWN0b3IgcGhhc2UuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBzdmcvU1ZHVFJlZkVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVFJlZkVsZW1lbnQ6OmNyZWF0ZSk6CisgICAg ICAgIChXZWJDb3JlOjpTVkdUUmVmRWxlbWVudDo6Y3JlYXRlU2hhZG93U3VidHJlZSk6CisgICAg ICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlNWR1RSZWZFbGVtZW50Ojp1cGRhdGVS ZWZlcmVuY2VkVGV4dCk6CisgICAgICAgICogc3ZnL1NWR1RSZWZFbGVtZW50Lmg6CisgICAgICAg IChTVkdUUmVmRWxlbWVudCk6CisKIDIwMTItMDItMDcgIERhdmlkIFJldmVtYW4gIDxyZXZlbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJFR1JFU1NJT04ocjEwMTg1NCk6 IENhdXNpbmcgbGFyZ2UgYW1vdW50cyBvZiB1bm5lY2Vzc2FyeSByZXBhaW50aW5nLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RSZWZFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3N2Zy9TVkdUUmVmRWxlbWVudC5jcHAKaW5kZXggMzAwYjhjOWZiNmQ1ZGI3ZDdmZTAzMWJl NWExY2IyNjAzN2I5NmIyMS4uZjNhZjBmZWFlMTZiMGM2Y2MyYmM3ZmMzMzAzMDRlMGI1NzRlMjJi MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RSZWZFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVFJlZkVsZW1lbnQuY3BwCkBAIC01Niw3ICs1Niw5IEBA IGlubGluZSBTVkdUUmVmRWxlbWVudDo6U1ZHVFJlZkVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFt ZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRvCiAKIFBhc3NSZWZQdHI8U1ZHVFJlZkVsZW1lbnQ+IFNW R1RSZWZFbGVtZW50OjpjcmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1l bnQqIGRvY3VtZW50KQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcgU1ZHVFJlZkVsZW1lbnQo dGFnTmFtZSwgZG9jdW1lbnQpKTsKKyAgICBSZWZQdHI8U1ZHVFJlZkVsZW1lbnQ+IGVsZW0gPSBh ZG9wdFJlZihuZXcgU1ZHVFJlZkVsZW1lbnQodGFnTmFtZSwgZG9jdW1lbnQpKTsKKyAgICBlbGVt LT5jcmVhdGVTaGFkb3dTdWJ0cmVlKCk7CisgICAgcmV0dXJuIGVsZW0ucmVsZWFzZSgpOwogfQog CiBjbGFzcyBTdWJ0cmVlTW9kaWZpY2F0aW9uRXZlbnRMaXN0ZW5lciA6IHB1YmxpYyBFdmVudExp c3RlbmVyIHsKQEAgLTE0NCw2ICsxNDYsMTEgQEAgU1ZHVFJlZkVsZW1lbnQ6On5TVkdUUmVmRWxl bWVudCgpCiAgICAgY2xlYXJFdmVudExpc3RlbmVyKCk7CiB9CiAKK3ZvaWQgU1ZHVFJlZkVsZW1l bnQ6OmNyZWF0ZVNoYWRvd1N1YnRyZWUoKQoreworICAgIFNoYWRvd1Jvb3Q6OmNyZWF0ZSh0aGlz LCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKK30KKwogdm9pZCBTVkdUUmVmRWxlbWVudDo6dXBkYXRl UmVmZXJlbmNlZFRleHQoKQogewogICAgIEVsZW1lbnQqIHRhcmdldCA9IFNWR1VSSVJlZmVyZW5j ZTo6dGFyZ2V0RWxlbWVudEZyb21JUklTdHJpbmcoaHJlZigpLCBkb2N1bWVudCgpKTsKQEAgLTE1 MSwxMSArMTU4LDExIEBAIHZvaWQgU1ZHVFJlZkVsZW1lbnQ6OnVwZGF0ZVJlZmVyZW5jZWRUZXh0 KCkKICAgICBTdHJpbmcgdGV4dENvbnRlbnQ7CiAgICAgaWYgKHRhcmdldC0+cGFyZW50Tm9kZSgp KQogICAgICAgICB0ZXh0Q29udGVudCA9IHRhcmdldC0+dGV4dENvbnRlbnQoKTsKLSAgICBFeGNl cHRpb25Db2RlIGlnbm9yZSA9IDA7Ci0gICAgaWYgKCFlbnN1cmVTaGFkb3dSb290KCktPmZpcnN0 Q2hpbGQoKSkKLSAgICAgICAgc2hhZG93Um9vdCgpLT5hcHBlbmRDaGlsZChTVkdTaGFkb3dUZXh0 OjpjcmVhdGUoZG9jdW1lbnQoKSwgdGV4dENvbnRlbnQpLCBpZ25vcmUpOworCisgICAgaWYgKCFz aGFkb3dSb290KCktPmZpcnN0Q2hpbGQoKSkKKyAgICAgICAgc2hhZG93Um9vdCgpLT5hcHBlbmRD aGlsZChTVkdTaGFkb3dUZXh0OjpjcmVhdGUoZG9jdW1lbnQoKSwgdGV4dENvbnRlbnQpLCBBU1NF UlRfTk9fRVhDRVBUSU9OKTsKICAgICBlbHNlCi0gICAgICAgIHNoYWRvd1Jvb3QoKS0+Zmlyc3RD aGlsZCgpLT5zZXRUZXh0Q29udGVudCh0ZXh0Q29udGVudCwgaWdub3JlKTsKKyAgICAgICAgc2hh ZG93Um9vdCgpLT5maXJzdENoaWxkKCktPnNldFRleHRDb250ZW50KHRleHRDb250ZW50LCBBU1NF UlRfTk9fRVhDRVBUSU9OKTsKIH0KIAogYm9vbCBTVkdUUmVmRWxlbWVudDo6aXNTdXBwb3J0ZWRB dHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgYXR0ck5hbWUpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHVFJlZkVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdU UmVmRWxlbWVudC5oCmluZGV4IDE3YThhY2Q1OWIyNTYzNzM5MmQ3MDhmMDM2YzFjYmFlOWY0M2M5 ODguLmJiNjEyZGE0NGQyMjE2YWY3MmY2ODNhNGM5OTk2M2NlZDMzYTg1YmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUUmVmRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9TVkdUUmVmRWxlbWVudC5oCkBAIC00MCw2ICs0MCw4IEBAIHByaXZhdGU6CiAgICAgU1ZH VFJlZkVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50Kik7CiAgICAgdmlydHVh bCB+U1ZHVFJlZkVsZW1lbnQoKTsKIAorICAgIHZvaWQgY3JlYXRlU2hhZG93U3VidHJlZSgpOwor CiAgICAgYm9vbCBpc1N1cHBvcnRlZEF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJik7CiAg ICAgdmlydHVhbCB2b2lkIHBhcnNlQXR0cmlidXRlKEF0dHJpYnV0ZSopIE9WRVJSSURFOwogICAg IHZpcnR1YWwgdm9pZCBzdmdBdHRyaWJ1dGVDaGFuZ2VkKGNvbnN0IFF1YWxpZmllZE5hbWUmKTsK 126417 2012-02-09 18:04:15 -0800 2012-02-12 19:35:35 -0800 Patch bug-77938-20120210110413.patch text/plain 6485 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE5MzI0OWZkMzA2OTQ1 ODFmNjY1YTIwOWFkZDcyNTI3MTk5NTIyMi4uM2M4YTVmYzhjZmYzNzc4NTE5OTliOGI3NWUxM2Zk ZWY1NTU2NjJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTA5ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgU1ZHVFJlZkVsZW1l bnQgc2hvdWxkbid0IGNyZWF0ZSBhIHNoYWRvdyByb290IGR5bmFtaWNhbGx5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkdUUmVmRWxlbWVudCBjcmVh dGVzIGEgc2hhZG93IHJvb3QgZHluYW1pY2FsbHkuIFRoaXMgd2lsbCBjYXVzZSBhIHByb2JsZW0g dG8gc3VwcG9ydAorICAgICAgICBtdWx0aXBsZSBzaGFkb3cgc3VidHJlZXMuIFNvIGl0IHNob3Vs ZCBiZSBjcmVhdGVkIGluIGEgY29uc3RydWN0b3IgcGhhc2UuCisKKyAgICAgICAgVGVzdDogc3Zn L2N1c3RvbS90cmVmLXNoYWRvd2RvbS5odG1sCisKKyAgICAgICAgKiBzdmcvU1ZHVFJlZkVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVFJlZkVsZW1lbnQ6OmNyZWF0ZSk6CisgICAg ICAgIChXZWJDb3JlOjpTVkdUUmVmRWxlbWVudDo6Y3JlYXRlU2hhZG93U3VidHJlZSk6CisgICAg ICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlNWR1RSZWZFbGVtZW50Ojp1cGRhdGVS ZWZlcmVuY2VkVGV4dCk6CisgICAgICAgICogc3ZnL1NWR1RSZWZFbGVtZW50Lmg6CisgICAgICAg IChTVkdUUmVmRWxlbWVudCk6CisKIDIwMTItMDItMDkgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgVHJlZU9yZGVySXRlcmF0b3IgYW5kIGl0ZXJhdGUg b3ZlciB0aGUgY2hpbGQgYm94ZXMgZGlyZWN0bHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHVFJlZkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RSZWZFbGVt ZW50LmNwcAppbmRleCAzMDBiOGM5ZmI2ZDVkYjdkN2ZlMDMxYmU1YTFjYjI2MDM3Yjk2YjIxLi45 OGI4ZjkxM2ZhMTYzMmI3MTczOTY0MjBlZDNlZTZkODBkYzJjOWM0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHVFJlZkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdUUmVmRWxlbWVudC5jcHAKQEAgLTU2LDcgKzU2LDkgQEAgaW5saW5lIFNWR1RSZWZFbGVt ZW50OjpTVkdUUmVmRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVu dCogZG8KIAogUGFzc1JlZlB0cjxTVkdUUmVmRWxlbWVudD4gU1ZHVFJlZkVsZW1lbnQ6OmNyZWF0 ZShjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCogZG9jdW1lbnQpCiB7Ci0g ICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTVkdUUmVmRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCkp OworICAgIFJlZlB0cjxTVkdUUmVmRWxlbWVudD4gZWxlbWVudCA9IGFkb3B0UmVmKG5ldyBTVkdU UmVmRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCkpOworICAgIGVsZW1lbnQtPmNyZWF0ZVNoYWRv d1N1YnRyZWUoKTsKKyAgICByZXR1cm4gZWxlbWVudC5yZWxlYXNlKCk7CiB9CiAKIGNsYXNzIFN1 YnRyZWVNb2RpZmljYXRpb25FdmVudExpc3RlbmVyIDogcHVibGljIEV2ZW50TGlzdGVuZXIgewpA QCAtMTQ0LDYgKzE0NiwxMSBAQCBTVkdUUmVmRWxlbWVudDo6flNWR1RSZWZFbGVtZW50KCkKICAg ICBjbGVhckV2ZW50TGlzdGVuZXIoKTsKIH0KIAordm9pZCBTVkdUUmVmRWxlbWVudDo6Y3JlYXRl U2hhZG93U3VidHJlZSgpCit7CisgICAgU2hhZG93Um9vdDo6Y3JlYXRlKHRoaXMsIFNoYWRvd1Jv b3Q6OkNyZWF0aW5nVXNlckFnZW50U2hhZG93Um9vdCwgQVNTRVJUX05PX0VYQ0VQVElPTik7Cit9 CisKIHZvaWQgU1ZHVFJlZkVsZW1lbnQ6OnVwZGF0ZVJlZmVyZW5jZWRUZXh0KCkKIHsKICAgICBF bGVtZW50KiB0YXJnZXQgPSBTVkdVUklSZWZlcmVuY2U6OnRhcmdldEVsZW1lbnRGcm9tSVJJU3Ry aW5nKGhyZWYoKSwgZG9jdW1lbnQoKSk7CkBAIC0xNTEsMTEgKzE1OCwxMSBAQCB2b2lkIFNWR1RS ZWZFbGVtZW50Ojp1cGRhdGVSZWZlcmVuY2VkVGV4dCgpCiAgICAgU3RyaW5nIHRleHRDb250ZW50 OwogICAgIGlmICh0YXJnZXQtPnBhcmVudE5vZGUoKSkKICAgICAgICAgdGV4dENvbnRlbnQgPSB0 YXJnZXQtPnRleHRDb250ZW50KCk7Ci0gICAgRXhjZXB0aW9uQ29kZSBpZ25vcmUgPSAwOwotICAg IGlmICghZW5zdXJlU2hhZG93Um9vdCgpLT5maXJzdENoaWxkKCkpCi0gICAgICAgIHNoYWRvd1Jv b3QoKS0+YXBwZW5kQ2hpbGQoU1ZHU2hhZG93VGV4dDo6Y3JlYXRlKGRvY3VtZW50KCksIHRleHRD b250ZW50KSwgaWdub3JlKTsKKworICAgIGlmICghc2hhZG93Um9vdCgpLT5maXJzdENoaWxkKCkp CisgICAgICAgIHNoYWRvd1Jvb3QoKS0+YXBwZW5kQ2hpbGQoU1ZHU2hhZG93VGV4dDo6Y3JlYXRl KGRvY3VtZW50KCksIHRleHRDb250ZW50KSwgQVNTRVJUX05PX0VYQ0VQVElPTik7CiAgICAgZWxz ZQotICAgICAgICBzaGFkb3dSb290KCktPmZpcnN0Q2hpbGQoKS0+c2V0VGV4dENvbnRlbnQodGV4 dENvbnRlbnQsIGlnbm9yZSk7CisgICAgICAgIHNoYWRvd1Jvb3QoKS0+Zmlyc3RDaGlsZCgpLT5z ZXRUZXh0Q29udGVudCh0ZXh0Q29udGVudCwgQVNTRVJUX05PX0VYQ0VQVElPTik7CiB9CiAKIGJv b2wgU1ZHVFJlZkVsZW1lbnQ6OmlzU3VwcG9ydGVkQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5h bWUmIGF0dHJOYW1lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RSZWZFbGVt ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVFJlZkVsZW1lbnQuaAppbmRleCAxN2E4YWNk NTliMjU2MzczOTJkNzA4ZjAzNmMxY2JhZTlmNDNjOTg4Li5iYjYxMmRhNDRkMjIxNmFmNzJmNjgz YTRjOTk5NjNjZWQzM2E4NWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVFJl ZkVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVFJlZkVsZW1lbnQuaApAQCAt NDAsNiArNDAsOCBAQCBwcml2YXRlOgogICAgIFNWR1RSZWZFbGVtZW50KGNvbnN0IFF1YWxpZmll ZE5hbWUmLCBEb2N1bWVudCopOwogICAgIHZpcnR1YWwgflNWR1RSZWZFbGVtZW50KCk7CiAKKyAg ICB2b2lkIGNyZWF0ZVNoYWRvd1N1YnRyZWUoKTsKKwogICAgIGJvb2wgaXNTdXBwb3J0ZWRBdHRy aWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYpOwogICAgIHZpcnR1YWwgdm9pZCBwYXJzZUF0dHJp YnV0ZShBdHRyaWJ1dGUqKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgc3ZnQXR0cmlidXRl Q2hhbmdlZChjb25zdCBRdWFsaWZpZWROYW1lJik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWZhNzg4YmQ2ZjNlNzk4NzE2 ZmM2MDFiNGNjZTAwYmNiODRjMzE3Ni4uNTU2NjdhYjlmNTlkY2QzZTUzMzEyN2Y0ZjZkNjAwOGVh YTJjNmY0YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA5ICBTaGlueWEgS2F3YW5h a2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgU1ZHVFJlZkVsZW1lbnQgc2hvdWxk bid0IGNyZWF0ZSBhIHNoYWRvdyByb290IGR5bmFtaWNhbGx5LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MzgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVja3MgYSBzaGFkb3cgcm9vdCBleGlzdHMg b2YgdHJlZiBlbGVtZW50IGluIGNhc2VzIHhsaW5rOmhyZWYgaXMgc2V0IGFuZCBpcyBub3Qgc2V0 LgorCisgICAgICAgICogc3ZnL2N1c3RvbS90cmVmLXNoYWRvd2RvbS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vdHJlZi1zaGFkb3dkb20uaHRtbDogQWRkZWQuCisK IDIwMTItMDItMDkgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgQW5vdGhlciB1bnJldmlld2VkIG1hc3NpdmUgU1ZHIHJlYmFzZWxpbmUgKGFsbCBv dXIgd2luZG93cyBib3RzIHRoYXQgSSBtaXNzZWQpLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv c3ZnL2N1c3RvbS90cmVmLXNoYWRvd2RvbS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdmcv Y3VzdG9tL3RyZWYtc2hhZG93ZG9tLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45YzgxYzQ2ZTY2 MTA1MWVkMGRkNTJjYTA1NmE1YTk0ZWExOTAzMzI5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvc3ZnL2N1c3RvbS90cmVmLXNoYWRvd2RvbS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwy IEBACitXb29ob28hCitTVUNDRVNTIQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3Rv bS90cmVmLXNoYWRvd2RvbS5odG1sIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS90cmVmLXNoYWRv d2RvbS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJjOThkN2I4NGQyMDE1MDJhZGE5YmU5MDgwMjlkOTY3MWJl MmFkNzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3RyZWYtc2hh ZG93ZG9tLmh0bWwKQEAgLTAsMCArMSw1NyBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgor PGhlYWQ+CisKKzwvaGVhZD4KKzxib2R5PgorCis8c3ZnIHZlcnNpb249IjEuMSIgYmFzZVByb2Zp bGU9ImJhc2ljIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciCisgICAgIHhtbG5z OnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB2aWV3Qm94PSIwIDAgMTYwIDEy MCI+CisgICAgPGRlZnM+PHRleHQgaWQ9InRleHQiPldvb2hvbyE8L3RleHQ+PC9kZWZzPgorICAg IDx0ZXh0Pjx0cmVmIGlkPSJ0ZXh0LXdpdGgtaHJlZiIgeGxpbms6aHJlZj0iI3RleHQiIC8+PC90 ZXh0PgorICAgIDx0ZXh0Pjx0cmVmIGlkPSJ0ZXh0LXdpdGhvdXQtaHJlZiIgLz48L3RleHQ+Cis8 L3N2Zz4KKworPHAgaWQ9InJlc3VsdCI+VGhpcyB0ZXN0IGNhbiBvbmx5IGJlIHJ1biBpbiBEdW1w UmVuZGVyVHJlZS48L3A+CisKKzxzY3JpcHQ+CitmdW5jdGlvbiBsb2coc3RyaW5nKSB7CisgICAg dmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKTsKKworICAgIHZh ciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKKyAgICBkaXYuYXBwZW5kQ2hp bGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoc3RyaW5nKSk7CisgICAgcmVzdWx0LmFwcGVuZENo aWxkKGRpdik7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYgKCF3aW5kb3cuaW50 ZXJuYWxzIHx8ICF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICByZXR1cm47 CisKKyAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIHZh ciByZXN1bHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0Jyk7CisgICAgd2hpbGUg KHJlc3VsdC5maXJzdENoaWxkKQorICAgICAgICByZXN1bHQucmVtb3ZlQ2hpbGQocmVzdWx0LmZp cnN0Q2hpbGQpOworCisgICAgdmFyIHRleHRXaXRoSHJlZiA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd0ZXh0LXdpdGgtaHJlZicpOworICAgIHZhciB0ZXh0V2l0aG91dEhyZWYgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgndGV4dC13aXRob3V0LWhyZWYnKTsKKworICAgIHZhciBzcjEgPSBp bnRlcm5hbHMuc2hhZG93Um9vdCh0ZXh0V2l0aEhyZWYpOworICAgIGlmIChzcjEgPT0gbnVsbCkg eworICAgICAgICBsb2coIkZBSUw6IHRleHRXaXRoSHJlZiBzaG91bGQgaGF2ZSBhIHNoYWRvdyBy b290LiIpOworICAgICAgICByZXR1cm47CisgICAgfQorICAgIHZhciBzcjIgPSBpbnRlcm5hbHMu c2hhZG93Um9vdCh0ZXh0V2l0aG91dEhyZWYpOworICAgIGlmIChzcjIgPT0gbnVsbCkgeworICAg ICAgICBsb2coIkZBSUw6IHRleHRXaXRob3V0SHJlZiBzaG91bGQgaGF2ZSBhIHNoYWRvdyByb290 LiIpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgbG9nKCJTVUNDRVNTISIpOworfQor CitydW5UZXN0KCk7Cis8L3NjcmlwdD4KKworPC9ib2R5PgorPC9odG1sPgo=