77770 2012-02-03 13:17:09 -0800 [chromium] Use explicit casts for WebRect/WebSize to IntRect/IntSize conversions 2012-02-08 13:32:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 71143 1 eae eae aroben eric fishd leviw oldest_to_newest 549002 0 eae 2012-02-03 13:17:09 -0800 With the introduction of FixedRect/Size/Point the implicit conversion path from WebRect to IntRect is no longer unambiguous. 549017 1 125399 eae 2012-02-03 13:33:56 -0800 Created attachment 125399 Patch 549052 2 125399 eric 2012-02-03 14:03:08 -0800 Comment on attachment 125399 Patch I'm not sure what this buys us. It's nice that these implicitly convert. What benifit of removed ambiguity is there? Or was this just helpful to you while writing your layout patch (as I assume you may have removed the implicit constructors to find all the callsites and check them?) 549054 3 eae 2012-02-03 14:04:59 -0800 It avoids "ambiguous conversion" compiler errors when building with the sub pixel units on certain platforms, most notably windows. 549056 4 eric 2012-02-03 14:08:44 -0800 I see. Could you tell me which conversions it thinks are ambigious? As in could you paste either an example warning (or a made up one?) Just so I understand what I'd be approving here. :) 549058 5 eric 2012-02-03 14:09:25 -0800 Given that thsi is chromium only, I probably should remove the various apple folks I CC'd. Sorry for the bug spam. 549089 6 eae 2012-02-03 14:32:36 -0800 > I see. Could you tell me which conversions it thinks are ambigious? As in could you paste either an example warning (or a made up one?) Of course, I'll kick off a build without these changes right away and report back. 552445 7 eae 2012-02-08 13:32:33 -0800 As we no longer have implicit conversion between FixedRect/Point/Size and platform specific types this patch is now obsolete. 125399 2012-02-03 13:33:56 -0800 2012-02-08 13:32:45 -0800 Patch bug-77770-20120203133355.patch text/plain 4419 eae SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDY2ODcpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIy IEBACisyMDEyLTAyLTAzICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIFVzZSBleHBsaWNpdCBjYXN0cyBmb3IgV2ViUmVjdC9XZWJTaXplIHRv IEludFJlY3QvSW50U2l6ZSBjb252ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc3NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgZXhwbGljaXQgaW5zdGVhZCBvZiBpbXBsaWNpdCBjb252 ZXJzaW9uIGZyb20gV2ViUmVjdCBhbmQgV2ViU2l6ZSB0bworICAgICAgICBJbnRSZWN0IGFuZCBJ bnRTaXplIHJlc3Blc3RpdmllbHkgdG8gYXZvaWQgYW1iaWd1aXR5LgorCisgICAgICAgICogc3Jj L1dlYlBvcHVwTWVudUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVJbXBs OjpwYWludCk6CisgICAgICAgICogc3JjL1dlYlNjcm9sbGJhckltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJTY3JvbGxiYXJJbXBsOjpnZXRUaWNrbWFya3MpOgorICAgICAgICAoV2ViS2l0 OjpXZWJTY3JvbGxiYXJJbXBsOjpzZXRMb2NhdGlvbik6CisgICAgICAgIChXZWJLaXQ6OldlYlNj cm9sbGJhckltcGw6OnBhaW50KToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0Rml4ZWRMYXlvdXRTaXplKToKKwogMjAxMi0w Mi0wMyAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NjkxCkluZGV4OiBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAkocmV2aXNpb24gMTA2Njgz KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUG9wdXBNZW51SW1wbC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTIwOCw3ICsyMDgsNyBAQCB2b2lkIFdlYlBvcHVwTWVudUltcGw6OnBh aW50KFdlYkNhbnZhcyogCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmICghcmVjdC5pc0VtcHR5 KCkpCi0gICAgICAgIG1fd2lkZ2V0LT5wYWludCgmR3JhcGhpY3NDb250ZXh0QnVpbGRlcihjYW52 YXMpLmNvbnRleHQoKSwgcmVjdCk7CisgICAgICAgIG1fd2lkZ2V0LT5wYWludCgmR3JhcGhpY3ND b250ZXh0QnVpbGRlcihjYW52YXMpLmNvbnRleHQoKSwgc3RhdGljX2Nhc3Q8Y29uc3QgSW50UmVj dD4ocmVjdCkpOwogfQogCiB2b2lkIFdlYlBvcHVwTWVudUltcGw6OnRoZW1lQ2hhbmdlZCgpCklu ZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTY3JvbGxiYXJJbXBsLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTY3JvbGxiYXJJbXBsLmNw cAkocmV2aXNpb24gMTA2NjgzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2Ny b2xsYmFySW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNSw3ICsxMDUsNyBAQCB2b2lkIFdl YlNjcm9sbGJhckltcGw6OmdldFRpY2ttYXJrcyhWZWN0CiAgICAgbV9jbGllbnQtPmdldFRpY2tt YXJrcyhjb25zdF9jYXN0PFdlYlNjcm9sbGJhckltcGwqPih0aGlzKSwgJnRpY2tzKTsKICAgICB0 aWNrbWFya3MucmVzaXplKHRpY2tzLnNpemUoKSk7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkg PCB0aWNrcy5zaXplKCk7ICsraSkKLSAgICAgICAgdGlja21hcmtzW2ldID0gdGlja3NbaV07Cisg ICAgICAgIHRpY2ttYXJrc1tpXSA9IHN0YXRpY19jYXN0PEludFJlY3Q+KHRpY2tzW2ldKTsKIH0K IAogSW50UG9pbnQgV2ViU2Nyb2xsYmFySW1wbDo6Y29udmVydEZyb21Db250YWluaW5nVmlld1Rv U2Nyb2xsYmFyKGNvbnN0IEludFBvaW50JiBwYXJlbnRQb2ludCkgY29uc3QKQEAgLTEyNCwxNSAr MTI0LDE2IEBAIGJvb2wgV2ViU2Nyb2xsYmFySW1wbDo6aXNPdmVybGF5KCkgY29uc3QKICAgICBy ZXR1cm4gbV9zY3JvbGxiYXItPmlzT3ZlcmxheVNjcm9sbGJhcigpOwogfQogCi12b2lkIFdlYlNj cm9sbGJhckltcGw6OnNldExvY2F0aW9uKGNvbnN0IFdlYlJlY3QmIHJlY3QpCit2b2lkIFdlYlNj cm9sbGJhckltcGw6OnNldExvY2F0aW9uKGNvbnN0IFdlYlJlY3QmIHdlYlJlY3QpCiB7CiAgICAg SW50UmVjdCBvbGRSZWN0ID0gbV9zY3JvbGxiYXItPmZyYW1lUmVjdCgpOworICAgIEludFJlY3Qg cmVjdCA9IHN0YXRpY19jYXN0PEludFJlY3Q+KHdlYlJlY3QpOwogICAgIG1fc2Nyb2xsYmFyLT5z ZXRGcmFtZVJlY3QocmVjdCk7Ci0gICAgaWYgKFdlYlJlY3Qob2xkUmVjdCkgIT0gcmVjdCkKKyAg ICBpZiAob2xkUmVjdCAhPSByZWN0KQogICAgICAgbV9zY3JvbGxiYXItPmludmFsaWRhdGUoKTsK IAogICAgIGludCBsZW5ndGggPSBtX3Njcm9sbGJhci0+b3JpZW50YXRpb24oKSA9PSBIb3Jpem9u dGFsU2Nyb2xsYmFyID8gbV9zY3JvbGxiYXItPndpZHRoKCkgOiBtX3Njcm9sbGJhci0+aGVpZ2h0 KCk7Ci0gICAgaW50IHBhZ2VTdGVwID0gbWF4KG1heChzdGF0aWNfY2FzdDxpbnQ+KHN0YXRpY19j YXN0PGZsb2F0PihsZW5ndGgpICogU2Nyb2xsYmFyOjptaW5GcmFjdGlvblRvU3RlcFdoZW5QYWdp bmcoKSksIGxlbmd0aCAtIFNjcm9sbGJhcjo6bWF4T3ZlcmxhcEJldHdlZW5QYWdlcygpKSwgMSk7 CisgICAgaW50IHBhZ2VTdGVwID0gbWF4KG1heDxpbnQ+KHN0YXRpY19jYXN0PGludD4oc3RhdGlj X2Nhc3Q8ZmxvYXQ+KGxlbmd0aCkgKiBTY3JvbGxiYXI6Om1pbkZyYWN0aW9uVG9TdGVwV2hlblBh Z2luZygpKSwgbGVuZ3RoIC0gU2Nyb2xsYmFyOjptYXhPdmVybGFwQmV0d2VlblBhZ2VzKCkpLCAx KTsKICAgICBtX3Njcm9sbGJhci0+c2V0U3RlcHMoU2Nyb2xsYmFyOjpwaXhlbHNQZXJMaW5lU3Rl cCgpLCBwYWdlU3RlcCk7CiAgICAgbV9zY3JvbGxiYXItPnNldEVuYWJsZWQobV9zY3JvbGxiYXIt PnRvdGFsU2l6ZSgpID4gbGVuZ3RoKTsKICAgICBtX3Njcm9sbGJhci0+c2V0UHJvcG9ydGlvbihs ZW5ndGgsIG1fc2Nyb2xsYmFyLT50b3RhbFNpemUoKSk7CkBAIC0xNjksNyArMTcwLDcgQEAgdm9p ZCBXZWJTY3JvbGxiYXJJbXBsOjpzY3JvbGwoU2Nyb2xsRGlyZQogCiB2b2lkIFdlYlNjcm9sbGJh ckltcGw6OnBhaW50KFdlYkNhbnZhcyogY2FudmFzLCBjb25zdCBXZWJSZWN0JiByZWN0KQogewot ICAgIG1fc2Nyb2xsYmFyLT5wYWludCgmR3JhcGhpY3NDb250ZXh0QnVpbGRlcihjYW52YXMpLmNv bnRleHQoKSwgcmVjdCk7CisgICAgbV9zY3JvbGxiYXItPnBhaW50KCZHcmFwaGljc0NvbnRleHRC dWlsZGVyKGNhbnZhcykuY29udGV4dCgpLCBzdGF0aWNfY2FzdDxjb25zdCBJbnRSZWN0PihyZWN0 KSk7CiB9CiAKIGJvb2wgV2ViU2Nyb2xsYmFySW1wbDo6aGFuZGxlSW5wdXRFdmVudChjb25zdCBX ZWJJbnB1dEV2ZW50JiBldmVudCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDEwNjY4MykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE5MCw3ICsyMTkwLDcg QEAgdm9pZCBXZWJWaWV3SW1wbDo6c2V0Rml4ZWRMYXlvdXRTaXplKGNvbgogICAgIGlmICghZnJh bWUgfHwgIWZyYW1lLT52aWV3KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGZyYW1lLT52aWV3 KCktPnNldEZpeGVkTGF5b3V0U2l6ZShsYXlvdXRTaXplKTsKKyAgICBmcmFtZS0+dmlldygpLT5z ZXRGaXhlZExheW91dFNpemUoc3RhdGljX2Nhc3Q8Y29uc3QgSW50U2l6ZT4obGF5b3V0U2l6ZSkp OwogfQogCiB2b2lkIFdlYlZpZXdJbXBsOjpwZXJmb3JtTWVkaWFQbGF5ZXJBY3Rpb24oY29uc3Qg V2ViTWVkaWFQbGF5ZXJBY3Rpb24mIGFjdGlvbiwK