77699 2012-02-02 18:22:05 -0800 ColorInputType needs to use ensureInlineStyleDecl 2012-02-02 21:44:54 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 548318 0 keishi 2012-02-02 18:22:05 -0800 Change ColorInputType to use ensureInlineStyleDecl. 548351 1 125234 keishi 2012-02-02 19:07:57 -0800 Created attachment 125234 Patch 548363 2 125234 tkent 2012-02-02 19:20:31 -0800 Comment on attachment 125234 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125234&action=review > Source/WebCore/ChangeLog:7 > + ColorInputType needs to use ensureInlineStyleDecl > + https://bugs.webkit.org/show_bug.cgi?id=77699 > + > + Reviewed by NOBODY (OOPS!). > + You had better add a reason that we need ensureInlineStyleDecl. 548368 3 125241 keishi 2012-02-02 19:30:20 -0800 Created attachment 125241 Patch 548369 4 125241 keishi 2012-02-02 19:31:59 -0800 Comment on attachment 125241 Patch Added comment. Because WebCore internally should use the more specific CSSMutableStyleDeclaration http://trac.webkit.org/changeset/105739 548440 5 125241 webkit.review.bot 2012-02-02 21:44:50 -0800 Comment on attachment 125241 Patch Clearing flags on attachment: 125241 Committed r106628: <http://trac.webkit.org/changeset/106628> 548441 6 webkit.review.bot 2012-02-02 21:44:54 -0800 All reviewed patches have been landed. Closing bug. 125234 2012-02-02 19:07:57 -0800 2012-02-02 19:29:54 -0800 Patch bug-77699-20120203120755.patch text/plain 1323 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjczYjA5ZDU4ZGU1MGRl ZDU3ZDBjNzA3OTliNjIwYmJmMmUxMTVmZi4uOTNjMGRlNzk1YTQ2ZGUzZGJiOWRiNzQ0ODdkZjA2 OTNiOTJkNWE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTAyICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbG9ySW5wdXRUeXBl IG5lZWRzIHRvIHVzZSBlbnN1cmVJbmxpbmVTdHlsZURlY2wKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3Njk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNvbG9ySW5wdXRUeXBlOjp1cGRhdGVDb2xvclN3YXRjaCk6CisKIDIw MTItMDItMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgU2Nyb2xsaW5nVHJlZSBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9Db2xvcklucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBl LmNwcAppbmRleCBkN2JkODFmNGNmNDlhZThlMzcyYTg4MGY0OTkyOTIzZTU0ODhiMjdhLi4wNzFj YzM0MTZjMTY2ZjNjY2QyMDQ1Zjc5MTA5N2IwZjg3ZTRhNDA3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0NvbG9ySW5wdXRUeXBlLmNwcApAQCAtMTc4LDcgKzE3OCw3IEBAIHZvaWQgQ29sb3JJbnB1dFR5 cGU6OnVwZGF0ZUNvbG9yU3dhdGNoKCkKICAgICBpZiAoIWNvbG9yU3dhdGNoKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBjb2xvclN3YXRjaC0+c3R5bGUoKS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVy dHlCYWNrZ3JvdW5kQ29sb3IsIGVsZW1lbnQoKS0+dmFsdWUoKSwgZmFsc2UsIEFTU0VSVF9OT19F WENFUFRJT04pOworICAgIGNvbG9yU3dhdGNoLT5lbnN1cmVJbmxpbmVTdHlsZURlY2woKS0+c2V0 UHJvcGVydHkoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IsIGVsZW1lbnQoKS0+dmFsdWUoKSwg ZmFsc2UpOwogfQogCiBIVE1MRWxlbWVudCogQ29sb3JJbnB1dFR5cGU6OnNoYWRvd0NvbG9yU3dh dGNoKCkgY29uc3QK 125241 2012-02-02 19:30:20 -0800 2012-02-02 21:44:50 -0800 Patch bug-77699-20120203123018.patch text/plain 1463 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjczYjA5ZDU4ZGU1MGRl ZDU3ZDBjNzA3OTliNjIwYmJmMmUxMTVmZi4uNzk0MWVkZTNmNGI3NjQyZjkwMDBmNzNlMzYyM2Nj YzA3ZmE1YWQzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTAyICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbG9ySW5wdXRUeXBl IG5lZWRzIHRvIHVzZSBlbnN1cmVJbmxpbmVTdHlsZURlY2wKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3Njk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg S2VudCBUYW11cmEuCisKKyAgICAgICAgQmVjYXVzZSBXZWJDb3JlIGludGVybmFsbHkgc2hvdWxk IHVzZSB0aGUgbW9yZSBzcGVjaWZpYyBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbgorICAgICAg ICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMDU3MzkKKworICAgICAgICAqIGh0 bWwvQ29sb3JJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3JJbnB1dFR5cGU6 OnVwZGF0ZUNvbG9yU3dhdGNoKToKKwogMjAxMi0wMi0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBTY3JvbGxpbmdUcmVlIGNsYXNzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCmluZGV4IGQ3YmQ4MWY0Y2Y0OWFlOGUzNzJh ODgwZjQ5OTI5MjNlNTQ4OGIyN2EuLjA3MWNjMzQxNmMxNjZmM2NjZDIwNDVmNzkxMDk3YjBmODdl NGE0MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCkBAIC0xNzgsNyAr MTc4LDcgQEAgdm9pZCBDb2xvcklucHV0VHlwZTo6dXBkYXRlQ29sb3JTd2F0Y2goKQogICAgIGlm ICghY29sb3JTd2F0Y2gpCiAgICAgICAgIHJldHVybjsKIAotICAgIGNvbG9yU3dhdGNoLT5zdHls ZSgpLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xvciwgZWxlbWVudCgpLT52 YWx1ZSgpLCBmYWxzZSwgQVNTRVJUX05PX0VYQ0VQVElPTik7CisgICAgY29sb3JTd2F0Y2gtPmVu c3VyZUlubGluZVN0eWxlRGVjbCgpLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eUJhY2tncm91bmRD b2xvciwgZWxlbWVudCgpLT52YWx1ZSgpLCBmYWxzZSk7CiB9CiAKIEhUTUxFbGVtZW50KiBDb2xv cklucHV0VHlwZTo6c2hhZG93Q29sb3JTd2F0Y2goKSBjb25zdAo=