77608 2012-02-01 23:21:10 -0800 Remove Element::ensureShadowRoot 2012-08-08 01:13:31 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75930 77612 77929 77930 77932 77936 90938 77603 85263 0 shinyak shinyak cmarcelo webkit.review.bot oldest_to_newest 547674 0 shinyak 2012-02-01 23:21:10 -0800 We often use ensureShadowRoot, but most of them are not necessary, because a shadow root is created in Something::create method. If we can remove it, the code can be much clearer when supporting multiple shadow trees. 550550 1 shinyak 2012-02-06 19:44:06 -0800 ensureShadowRoot makes the life cycle of shadow root confusing. Most of shadow roots are created near the constructor, so let's remove it to make the life cycle of shadow root understanding. 550557 2 shinyak 2012-02-06 19:52:00 -0800 Let me mention that INPUT and MEDIA may create their shadow root in the non-constructor phase. So when adding shadow root to these elements, we should be careful. 550564 3 shinyak 2012-02-06 20:03:57 -0800 SVG and ValidationMessage also create shadow root in non-constructor phase... 666309 4 shinyak 2012-07-10 21:22:33 -0700 To support Shadow DOM for all the elements, this should be fixed immediately... 689831 5 157101 shinyak 2012-08-07 21:01:39 -0700 Created attachment 157101 Patch 689947 6 157101 rniwa 2012-08-07 23:05:20 -0700 Comment on attachment 157101 Patch Yay! Less code. 690035 7 157101 webkit.review.bot 2012-08-08 01:13:27 -0700 Comment on attachment 157101 Patch Clearing flags on attachment: 157101 Committed r125007: <http://trac.webkit.org/changeset/125007> 690036 8 webkit.review.bot 2012-08-08 01:13:31 -0700 All reviewed patches have been landed. Closing bug. 157101 2012-08-07 21:01:39 -0700 2012-08-08 01:13:27 -0700 Patch bug-77608-20120808130113.patch text/plain 2749 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDUxMGM1NDVhN2Y1Mzkw ZDZmMTU1NjZkOTNkMzc2ZDQ2ZDA1MTE1Yi4uNzExZDkzNTEwODAyYTU5ZGU1ZTQ1YTg4YTdlMGY0 MTZjYTczMDA0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA3ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgRWxl bWVudDo6ZW5zdXJlU2hhZG93Um9vdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Nzc2MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSBFbGVtZW50OjplbnN1cmVTaGFkb3dSb290IGlzIG5vdCB1c2Vk IGFueW1vcmUsIHdlIGNhbiByZW1vdmUgdGhpcyBzYWZlbHkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBXZWJDb3JlLm9yZGVyOgor ICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAg ICAgICAoRWxlbWVudCk6CisKIDIwMTItMDgtMDcgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVwbGFjZSB0aHJvd0Vycm9yKEV4Y2VwdGlvbkNv ZGUsIElzb2xhdGUqKSB3aXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLm9y ZGVyIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5vcmRlcgppbmRleCA3MzU1YTMyMDFkZmRlZDZh OWNjYTQ3N2NkMzhmMmM0ZDVjYmQzNDk1Li45ZDkwMjJjYTVhMzMxZjdhMzY4N2I3NGJhMGYyZmM3 NjIzN2IwM2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLm9yZGVyCisrKyBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUub3JkZXIKQEAgLTY5MzMsNyArNjkzMyw2IEBAIF9fWk43 V2ViQ29yZTE0UmFuZ2VJbnB1dFR5cGU2Y3JlYXRlRVBOU18xNkhUTUxJbnB1dEVsZW1lbnRFCiBf X1pOSzdXZWJDb3JlMTRSYW5nZUlucHV0VHlwZTE1Zm9ybUNvbnRyb2xUeXBlRXYKIF9fWk43V2Vi Q29yZTE0SW5wdXRUeXBlTmFtZXM1cmFuZ2VFdgogX19aTjdXZWJDb3JlMTRSYW5nZUlucHV0VHlw ZTE5Y3JlYXRlU2hhZG93U3VidHJlZUV2Ci1fX1pON1dlYkNvcmU3RWxlbWVudDE2ZW5zdXJlU2hh ZG93Um9vdEV2CiBfX1pON1dlYkNvcmUxMFNoYWRvd1Jvb3RDMUVQTlNfOERvY3VtZW50RQogX19a TjdXZWJDb3JlOVRyZWVTY29wZTE4c2V0UGFyZW50VHJlZVNjb3BlRVBTMF8KIF9fWk5LN1dlYkNv cmUxMFNoYWRvd1Jvb3Q4bm9kZVR5cGVFdgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDdiZTY0 MGViMTI1MDFiMjViMmZlZGVjYTE1ZWI1NDczNzlkOGJmN2QuLjkwODliYzhjMDhiYjIzY2VkYzk3 NzdlZDBiMWMwZTVkNzhlZmFmYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTEyMDUsMTQg KzEyMDUsNiBAQCBTaGFkb3dSb290KiBFbGVtZW50Ojp1c2VyQWdlbnRTaGFkb3dSb290KCkgY29u c3QKICAgICByZXR1cm4gMDsKIH0KIAotU2hhZG93Um9vdCogRWxlbWVudDo6ZW5zdXJlU2hhZG93 Um9vdCgpCi17Ci0gICAgaWYgKEVsZW1lbnRTaGFkb3cqIHNoYWRvdyA9IHRoaXMtPnNoYWRvdygp KQotICAgICAgICByZXR1cm4gc2hhZG93LT5vbGRlc3RTaGFkb3dSb290KCk7Ci0KLSAgICByZXR1 cm4gU2hhZG93Um9vdDo6Y3JlYXRlKHRoaXMsIFNoYWRvd1Jvb3Q6OlVzZXJBZ2VudFNoYWRvd1Jv b3QpLmdldCgpOwotfQotCiBjb25zdCBBdG9taWNTdHJpbmcmIEVsZW1lbnQ6OnNoYWRvd1BzZXVk b0lkKCkgY29uc3QKIHsKICAgICByZXR1cm4gaGFzUmFyZURhdGEoKSA/IGVsZW1lbnRSYXJlRGF0 YSgpLT5tX3NoYWRvd1BzZXVkb0lkIDogbnVsbEF0b207CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCA1 OTkxZmVmNGUzMjczYTA0MzM0YTBjOWVlNjFhYTQxZTExYzIwODU4Li4wMTM2ZDZjY2M1YTFlMmQz NjMxY2ZmNzM4NDhlMGE3MDgzOGI5OGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTI3NywxMCAr Mjc3LDYgQEAgcHVibGljOgogCiAgICAgU2hhZG93Um9vdCogdXNlckFnZW50U2hhZG93Um9vdCgp IGNvbnN0OwogCi0gICAgLy8gRklYTUU6IFJlbW92ZSBFbGVtZW50OjplbnN1cmVTaGFkb3dSb290 Ci0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NjA4Ci0g ICAgU2hhZG93Um9vdCogZW5zdXJlU2hhZG93Um9vdCgpOwotCiAgICAgdmlydHVhbCBjb25zdCBB dG9taWNTdHJpbmcmIHNoYWRvd1BzZXVkb0lkKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRTaGFkb3dQ c2V1ZG9JZChjb25zdCBBdG9taWNTdHJpbmcmLCBFeGNlcHRpb25Db2RlJiA9IEFTU0VSVF9OT19F WENFUFRJT04pOwogCg==